Remove JQuery UI from OFBiz website

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Remove JQuery UI from OFBiz website

adityasharma
Hi team,

While upgrading JQuery for the Apache OFBiz website I noticed jQuery UI is
no longer used. I propose to remove it with the following PR:

https://github.com/apache/ofbiz-site/pull/6/files

I haven't found any code reference related to it and the site works well
without any console errors. Do let me know if anyone having any idea why it
was used or if there is something missed at my end.

Thanks and regards,
Aditya Sharma
Reply | Threaded
Open this post in threaded view
|

Re: Remove JQuery UI from OFBiz website

Deepak Dixit-5
Hi Aditya,

I don't see any issue in removing jquery ui, It was added at initial
commit.
If everything works fine we can remove this.


Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org


On Mon, Jan 4, 2021 at 8:02 PM Aditya Sharma <[hidden email]>
wrote:

> Hi team,
>
> While upgrading JQuery for the Apache OFBiz website I noticed jQuery UI is
> no longer used. I propose to remove it with the following PR:
>
> https://github.com/apache/ofbiz-site/pull/6/files
>
> I haven't found any code reference related to it and the site works well
> without any console errors. Do let me know if anyone having any idea why it
> was used or if there is something missed at my end.
>
> Thanks and regards,
> Aditya Sharma
>
Reply | Threaded
Open this post in threaded view
|

Re: Remove JQuery UI from OFBiz website

Michael Brohl-3
+1

Thanks,

Michael Brohl

ecomify GmbH - www.ecomify.de


Am 04.01.21 um 16:02 schrieb Deepak Dixit:

> Hi Aditya,
>
> I don't see any issue in removing jquery ui, It was added at initial
> commit.
> If everything works fine we can remove this.
>
>
> Thanks & Regards
> --
> Deepak Dixit
> ofbiz.apache.org
>
>
> On Mon, Jan 4, 2021 at 8:02 PM Aditya Sharma <[hidden email]>
> wrote:
>
>> Hi team,
>>
>> While upgrading JQuery for the Apache OFBiz website I noticed jQuery UI is
>> no longer used. I propose to remove it with the following PR:
>>
>> https://github.com/apache/ofbiz-site/pull/6/files
>>
>> I haven't found any code reference related to it and the site works well
>> without any console errors. Do let me know if anyone having any idea why it
>> was used or if there is something missed at my end.
>>
>> Thanks and regards,
>> Aditya Sharma
>>
Reply | Threaded
Open this post in threaded view
|

Re: Remove JQuery UI from OFBiz website

Jacopo Cappellato-3
In reply to this post by adityasharma
+1

Thanks,

Jacopo


On Mon, Jan 4, 2021 at 3:32 PM Aditya Sharma <[hidden email]>
wrote:

> Hi team,
>
> While upgrading JQuery for the Apache OFBiz website I noticed jQuery UI is
> no longer used. I propose to remove it with the following PR:
>
> https://github.com/apache/ofbiz-site/pull/6/files
>
> I haven't found any code reference related to it and the site works well
> without any console errors. Do let me know if anyone having any idea why it
> was used or if there is something missed at my end.
>
> Thanks and regards,
> Aditya Sharma
>
Reply | Threaded
Open this post in threaded view
|

Re: Remove JQuery UI from OFBiz website

adityasharma
Thanks, everyone! I have merged the changes.

Let me know if someone faces any issues related to it.

Thanks and Regards,
Aditya Sharma


On Mon, Jan 4, 2021 at 10:23 PM Jacopo Cappellato <
[hidden email]> wrote:

> +1
>
> Thanks,
>
> Jacopo
>
>
> On Mon, Jan 4, 2021 at 3:32 PM Aditya Sharma <[hidden email]>
> wrote:
>
> > Hi team,
> >
> > While upgrading JQuery for the Apache OFBiz website I noticed jQuery UI
> is
> > no longer used. I propose to remove it with the following PR:
> >
> > https://github.com/apache/ofbiz-site/pull/6/files
> >
> > I haven't found any code reference related to it and the site works well
> > without any console errors. Do let me know if anyone having any idea why
> it
> > was used or if there is something missed at my end.
> >
> > Thanks and regards,
> > Aditya Sharma
> >
>