Hi all,
what about removing the author information from source files (like I did in rev. 453960)? Keeping this information in the source files is discouraged by the ASF (clearer information about the contributors of a file can be derived from the commit logs) and we have already mostly abandoned this practice for new files... what about cleaning the old ones? Jacopo |
The ideas was so someone could contact who did that code and ask questions.
I believe this is now in the SVN history so that is unnecessary in code. Jacopo Cappellato sent the following on 10/7/2006 9:48 AM: > Hi all, > > what about removing the author information from source files (like I did > in rev. 453960)? > > Keeping this information in the source files is discouraged by the ASF > (clearer information about the contributors of a file can be derived > from the commit logs) and we have already mostly abandoned this practice > for new files... what about cleaning the old ones? > > Jacopo > |
Administrator
|
In reply to this post by Jacopo Cappellato
Yes, I agree. If we share the task by components it may be done pretty quickly (maybe even quasi-automatically).
Jacques From: "Jacopo Cappellato" <[hidden email]> > Hi all, > > what about removing the author information from source files (like I did > in rev. 453960)? > > Keeping this information in the source files is discouraged by the ASF > (clearer information about the contributors of a file can be derived > from the commit logs) and we have already mostly abandoned this practice > for new files... what about cleaning the old ones? > > Jacopo |
In reply to this post by Jacopo Cappellato
Yes, I think it would be good to toss these. There are various problems with them too. I've noticed a lot of author listings that are incorrect because a header was just copied from another file and the author list never changed and such. -David On Oct 7, 2006, at 5:48 PM, Jacopo Cappellato wrote: > Hi all, > > what about removing the author information from source files (like > I did in rev. 453960)? > > Keeping this information in the source files is discouraged by the > ASF (clearer information about the contributors of a file can be > derived from the commit logs) and we have already mostly abandoned > this practice for new files... what about cleaning the old ones? > > Jacopo |
Hi,
Most projects at the ASF decided a year or two ago to discard @author tags, either to just stop using them, or even to go into the files and remove the existing ones. You've covered some of the reasons why this is a decent idea, and there's another good reason which is legal coverage. I don't have time to go into details, but anyways @author tags are not essential to remove: OFBiz can keep them in, take them out, whatever you want: it's up to the project, there's no ASF mandate. Yoav On 10/7/06, David E Jones <[hidden email]> wrote: > > Yes, I think it would be good to toss these. > > There are various problems with them too. I've noticed a lot of > author listings that are incorrect because a header was just copied > from another file and the author list never changed and such. > > -David > > > On Oct 7, 2006, at 5:48 PM, Jacopo Cappellato wrote: > > > Hi all, > > > > what about removing the author information from source files (like > > I did in rev. 453960)? > > > > Keeping this information in the source files is discouraged by the > > ASF (clearer information about the contributors of a file can be > > derived from the commit logs) and we have already mostly abandoned > > this practice for new files... what about cleaning the old ones? > > > > Jacopo > > > |
In reply to this post by Jacques Le Roux
Jacques,
that's a good idea: I'm going to clean the "content" component (the manufacturing one is already done). Jacopo PS: while we are doing this task it is a good idea to also remove the @version, @since, $Rev tags Jacques Le Roux wrote: > Yes, I agree. If we share the task by components it may be done pretty quickly (maybe even quasi-automatically). > > Jacques > > From: "Jacopo Cappellato" <[hidden email]> >> Hi all, >> >> what about removing the author information from source files (like I did >> in rev. 453960)? >> >> Keeping this information in the source files is discouraged by the ASF >> (clearer information about the contributors of a file can be derived >> from the commit logs) and we have already mostly abandoned this practice >> for new files... what about cleaning the old ones? >> >> Jacopo |
Administrator
|
After correcting my mistake about DemoProductCategoriesI18nData.xml (thanks again David) I will go for POS module.
Jacques ----- Original Message ----- From: "Jacopo Cappellato" <[hidden email]> To: <[hidden email]> Sent: Sunday, October 08, 2006 7:59 AM Subject: Re: Removing author information from source files > Jacques, > > that's a good idea: I'm going to clean the "content" component (the > manufacturing one is already done). > > Jacopo > > PS: while we are doing this task it is a good idea to also remove the > @version, @since, $Rev tags > > > Jacques Le Roux wrote: > > Yes, I agree. If we share the task by components it may be done pretty quickly (maybe even quasi-automatically). > > > > Jacques > > > > From: "Jacopo Cappellato" <[hidden email]> > >> Hi all, > >> > >> what about removing the author information from source files (like I did > >> in rev. 453960)? > >> > >> Keeping this information in the source files is discouraged by the ASF > >> (clearer information about the contributors of a file can be derived > >> from the commit logs) and we have already mostly abandoned this practice > >> for new files... what about cleaning the old ones? > >> > >> Jacopo |
That's great! In the mentime I've completed all the other application
components. I'll start my attack to the framework ones starting from the components in the end (workflow, widget, webtools etc...) Jacopo Jacques Le Roux wrote: > After correcting my mistake about DemoProductCategoriesI18nData.xml (thanks again David) I will go for POS module. > > Jacques > > ----- Original Message ----- > From: "Jacopo Cappellato" <[hidden email]> > To: <[hidden email]> > Sent: Sunday, October 08, 2006 7:59 AM > Subject: Re: Removing author information from source files > > >> Jacques, >> >> that's a good idea: I'm going to clean the "content" component (the >> manufacturing one is already done). >> >> Jacopo >> >> PS: while we are doing this task it is a good idea to also remove the >> @version, @since, $Rev tags >> >> >> Jacques Le Roux wrote: >>> Yes, I agree. If we share the task by components it may be done pretty quickly (maybe even quasi-automatically). >>> >>> Jacques >>> >>> From: "Jacopo Cappellato" <[hidden email]> >>>> Hi all, >>>> >>>> what about removing the author information from source files (like I did >>>> in rev. 453960)? >>>> >>>> Keeping this information in the source files is discouraged by the ASF >>>> (clearer information about the contributors of a file can be derived >>>> from the commit logs) and we have already mostly abandoned this practice >>>> for new files... what about cleaning the old ones? >>>> >>>> Jacopo |
Jacques, all,
ok, I've removed the author information from all the files of the framework and application folders (including pos). One more little step forward for Apache graduation is done. Jacopo Jacopo Cappellato wrote: > That's great! In the mentime I've completed all the other application > components. > I'll start my attack to the framework ones starting from the components > in the end (workflow, widget, webtools etc...) > > Jacopo > > Jacques Le Roux wrote: >> After correcting my mistake about DemoProductCategoriesI18nData.xml >> (thanks again David) I will go for POS module. >> >> Jacques >> >> ----- Original Message ----- From: "Jacopo Cappellato" <[hidden email]> >> To: <[hidden email]> >> Sent: Sunday, October 08, 2006 7:59 AM >> Subject: Re: Removing author information from source files >> >> >>> Jacques, >>> >>> that's a good idea: I'm going to clean the "content" component (the >>> manufacturing one is already done). >>> >>> Jacopo >>> >>> PS: while we are doing this task it is a good idea to also remove the >>> @version, @since, $Rev tags >>> >>> >>> Jacques Le Roux wrote: >>>> Yes, I agree. If we share the task by components it may be done >>>> pretty quickly (maybe even quasi-automatically). >>>> >>>> Jacques >>>> >>>> From: "Jacopo Cappellato" <[hidden email]> >>>>> Hi all, >>>>> >>>>> what about removing the author information from source files (like >>>>> I did in rev. 453960)? >>>>> >>>>> Keeping this information in the source files is discouraged by the >>>>> ASF (clearer information about the contributors of a file can be >>>>> derived from the commit logs) and we have already mostly abandoned >>>>> this practice for new files... what about cleaning the old ones? >>>>> >>>>> Jacopo |
Administrator
|
Woow, I did not have even the time to look at it.
I did some gardening, bad for my back but good for my head, don't know for ASF (Do we like gardening ? ;o) I may help on the copyright date problem. Thanks Jacopo ! ----- Original Message ----- From: "Jacopo Cappellato" <[hidden email]> To: <[hidden email]> Sent: Sunday, October 08, 2006 6:04 PM Subject: Re: Removing author information from source files > Jacques, all, > > ok, I've removed the author information from all the files of the > framework and application folders (including pos). > > One more little step forward for Apache graduation is done. > > Jacopo > > > Jacopo Cappellato wrote: > > That's great! In the mentime I've completed all the other application > > components. > > I'll start my attack to the framework ones starting from the components > > in the end (workflow, widget, webtools etc...) > > > > Jacopo > > > > Jacques Le Roux wrote: > >> After correcting my mistake about DemoProductCategoriesI18nData.xml > >> (thanks again David) I will go for POS module. > >> > >> Jacques > >> > >> ----- Original Message ----- From: "Jacopo Cappellato" <[hidden email]> > >> To: <[hidden email]> > >> Sent: Sunday, October 08, 2006 7:59 AM > >> Subject: Re: Removing author information from source files > >> > >> > >>> Jacques, > >>> > >>> that's a good idea: I'm going to clean the "content" component (the > >>> manufacturing one is already done). > >>> > >>> Jacopo > >>> > >>> PS: while we are doing this task it is a good idea to also remove the > >>> @version, @since, $Rev tags > >>> > >>> > >>> Jacques Le Roux wrote: > >>>> Yes, I agree. If we share the task by components it may be done > >>>> pretty quickly (maybe even quasi-automatically). > >>>> > >>>> Jacques > >>>> > >>>> From: "Jacopo Cappellato" <[hidden email]> > >>>>> Hi all, > >>>>> > >>>>> what about removing the author information from source files (like > >>>>> I did in rev. 453960)? > >>>>> > >>>>> Keeping this information in the source files is discouraged by the > >>>>> ASF (clearer information about the contributors of a file can be > >>>>> derived from the commit logs) and we have already mostly abandoned > >>>>> this practice for new files... what about cleaning the old ones? > >>>>> > >>>>> Jacopo |
Free forum by Nabble | Edit this page |