Removing failing tests from framework
Locked
 
|
Hello Everyone,
I've been doing a lot of work lately in [1] to be able to build ofbiz-framework and run all tests successfully without pulling any plugins in. After lots and lots of test runs, trial-and-error, and deep code debugging I was able to bring down the total failing tests from hundreds to only two. I believe the two remaining tests are fundamentally incorrect because they assume the existence of data, scripts and widgets in ecommerce and I explained this issue more thoroughly in [2] Therefore, I made a patch [3] which simply removes the tests / portions of tests which are causing the failures. This is a quick solution to get the ofbiz-framework to build and test successfully without plugins. The real solution, however, requires a very deep look into the order component and to remove all dependencies on ecommerce. This is a lot of work, and should be done gradually over time. So my recommendation is to apply the patch, and create a JIRA to gradually remove remaining entanglements from order to ecommerce. WDYT? [1] https://issues.apache.org/jira/browse/OFBIZ-9322 [2] https://s.apache.org/DlGE [3] https://issues.apache.org/jira/secure/attachment/12865667/OFBIZ-9322.patch Cheers, Taher Alkhateeb |
|
|
Hey folks. I see no one replied so far on this. I'm not a big fan of lazy
consensus, but I will proceed in this case because the patch is very small and two minor tests will be removed/modified for the sake of building ofbiz-framework independently. On Sat, Apr 29, 2017 at 10:32 AM, Taher Alkhateeb < [hidden email]> wrote: > Hello Everyone, > > I've been doing a lot of work lately in [1] to be able to build > ofbiz-framework and run all tests successfully without pulling any plugins > in. > > After lots and lots of test runs, trial-and-error, and deep code debugging > I was able to bring down the total failing tests from hundreds to only two. > I believe the two remaining tests are fundamentally incorrect because they > assume the existence of data, scripts and widgets in ecommerce and I > explained this issue more thoroughly in [2] > > Therefore, I made a patch [3] which simply removes the tests / portions of > tests which are causing the failures. This is a quick solution to get the > ofbiz-framework to build and test successfully without plugins. > > The real solution, however, requires a very deep look into the order > component and to remove all dependencies on ecommerce. This is a lot of > work, and should be done gradually over time. > > So my recommendation is to apply the patch, and create a JIRA to gradually > remove remaining entanglements from order to ecommerce. > > WDYT? > > [1] https://issues.apache.org/jira/browse/OFBIZ-9322 > [2] https://s.apache.org/DlGE > [3] https://issues.apache.org/jira/secure/attachment/ > 12865667/OFBIZ-9322.patch > > Cheers, > > Taher Alkhateeb > |
Re: Removing failing tests from framework
|
+1 Taher
Am 02.05.17 um 11:11 schrieb Taher Alkhateeb: > Hey folks. I see no one replied so far on this. I'm not a big fan of lazy > consensus, but I will proceed in this case because the patch is very small > and two minor tests will be removed/modified for the sake of building > ofbiz-framework independently. > > On Sat, Apr 29, 2017 at 10:32 AM, Taher Alkhateeb < > [hidden email]> wrote: > >> Hello Everyone, >> >> I've been doing a lot of work lately in [1] to be able to build >> ofbiz-framework and run all tests successfully without pulling any plugins >> in. >> >> After lots and lots of test runs, trial-and-error, and deep code debugging >> I was able to bring down the total failing tests from hundreds to only two. >> I believe the two remaining tests are fundamentally incorrect because they >> assume the existence of data, scripts and widgets in ecommerce and I >> explained this issue more thoroughly in [2] >> >> Therefore, I made a patch [3] which simply removes the tests / portions of >> tests which are causing the failures. This is a quick solution to get the >> ofbiz-framework to build and test successfully without plugins. >> >> The real solution, however, requires a very deep look into the order >> component and to remove all dependencies on ecommerce. This is a lot of >> work, and should be done gradually over time. >> >> So my recommendation is to apply the patch, and create a JIRA to gradually >> remove remaining entanglements from order to ecommerce. >> >> WDYT? >> >> [1] https://issues.apache.org/jira/browse/OFBIZ-9322 >> [2] https://s.apache.org/DlGE >> [3] https://issues.apache.org/jira/secure/attachment/ >> 12865667/OFBIZ-9322.patch >> >> Cheers, >> >> Taher Alkhateeb >> |
smime.p7s (5K)
Re: Removing failing tests from framework
Administrator
|
In reply to this post by taher
Hi Taher,
Please give me an hour to review, I did not look at it yet Thanks Jacques Le 02/05/2017 à 11:11, Taher Alkhateeb a écrit : > Hey folks. I see no one replied so far on this. I'm not a big fan of lazy > consensus, but I will proceed in this case because the patch is very small > and two minor tests will be removed/modified for the sake of building > ofbiz-framework independently. > > On Sat, Apr 29, 2017 at 10:32 AM, Taher Alkhateeb < > [hidden email]> wrote: > >> Hello Everyone, >> >> I've been doing a lot of work lately in [1] to be able to build >> ofbiz-framework and run all tests successfully without pulling any plugins >> in. >> >> After lots and lots of test runs, trial-and-error, and deep code debugging >> I was able to bring down the total failing tests from hundreds to only two. >> I believe the two remaining tests are fundamentally incorrect because they >> assume the existence of data, scripts and widgets in ecommerce and I >> explained this issue more thoroughly in [2] >> >> Therefore, I made a patch [3] which simply removes the tests / portions of >> tests which are causing the failures. This is a quick solution to get the >> ofbiz-framework to build and test successfully without plugins. >> >> The real solution, however, requires a very deep look into the order >> component and to remove all dependencies on ecommerce. This is a lot of >> work, and should be done gradually over time. >> >> So my recommendation is to apply the patch, and create a JIRA to gradually >> remove remaining entanglements from order to ecommerce. >> >> WDYT? >> >> [1] https://issues.apache.org/jira/browse/OFBIZ-9322 >> [2] https://s.apache.org/DlGE >> [3] https://issues.apache.org/jira/secure/attachment/ >> 12865667/OFBIZ-9322.patch >> >> Cheers, >> >> Taher Alkhateeb >> |
Re: Removing failing tests from framework
|
Administrator
|
In reply to this post by Michael Brohl-3
Hi Michael,
So today you don't apply the seven days rule? ;) Cheers Jacques Le 02/05/2017 à 11:18, Michael Brohl a écrit : > +1 Taher > > Am 02.05.17 um 11:11 schrieb Taher Alkhateeb: >> Hey folks. I see no one replied so far on this. I'm not a big fan of lazy >> consensus, but I will proceed in this case because the patch is very small >> and two minor tests will be removed/modified for the sake of building >> ofbiz-framework independently. >> >> On Sat, Apr 29, 2017 at 10:32 AM, Taher Alkhateeb < >> [hidden email]> wrote: >> >>> Hello Everyone, >>> >>> I've been doing a lot of work lately in [1] to be able to build >>> ofbiz-framework and run all tests successfully without pulling any plugins >>> in. >>> >>> After lots and lots of test runs, trial-and-error, and deep code debugging >>> I was able to bring down the total failing tests from hundreds to only two. >>> I believe the two remaining tests are fundamentally incorrect because they >>> assume the existence of data, scripts and widgets in ecommerce and I >>> explained this issue more thoroughly in [2] >>> >>> Therefore, I made a patch [3] which simply removes the tests / portions of >>> tests which are causing the failures. This is a quick solution to get the >>> ofbiz-framework to build and test successfully without plugins. >>> >>> The real solution, however, requires a very deep look into the order >>> component and to remove all dependencies on ecommerce. This is a lot of >>> work, and should be done gradually over time. >>> >>> So my recommendation is to apply the patch, and create a JIRA to gradually >>> remove remaining entanglements from order to ecommerce. >>> >>> WDYT? >>> >>> [1] https://issues.apache.org/jira/browse/OFBIZ-9322 >>> [2] https://s.apache.org/DlGE >>> [3] https://issues.apache.org/jira/secure/attachment/ >>> 12865667/OFBIZ-9322.patch >>> >>> Cheers, >>> >>> Taher Alkhateeb >>> > > |
Re: Removing failing tests from framework
|
Administrator
|
In reply to this post by Jacques Le Roux
It's OK with me if we later reintroduce this test and create a Jira for that
Jacques Le 02/05/2017 à 11:24, Jacques Le Roux a écrit : > Hi Taher, > > Please give me an hour to review, I did not look at it yet > > Thanks > > Jacques > > > Le 02/05/2017 à 11:11, Taher Alkhateeb a écrit : >> Hey folks. I see no one replied so far on this. I'm not a big fan of lazy >> consensus, but I will proceed in this case because the patch is very small >> and two minor tests will be removed/modified for the sake of building >> ofbiz-framework independently. >> >> On Sat, Apr 29, 2017 at 10:32 AM, Taher Alkhateeb < >> [hidden email]> wrote: >> >>> Hello Everyone, >>> >>> I've been doing a lot of work lately in [1] to be able to build >>> ofbiz-framework and run all tests successfully without pulling any plugins >>> in. >>> >>> After lots and lots of test runs, trial-and-error, and deep code debugging >>> I was able to bring down the total failing tests from hundreds to only two. >>> I believe the two remaining tests are fundamentally incorrect because they >>> assume the existence of data, scripts and widgets in ecommerce and I >>> explained this issue more thoroughly in [2] >>> >>> Therefore, I made a patch [3] which simply removes the tests / portions of >>> tests which are causing the failures. This is a quick solution to get the >>> ofbiz-framework to build and test successfully without plugins. >>> >>> The real solution, however, requires a very deep look into the order >>> component and to remove all dependencies on ecommerce. This is a lot of >>> work, and should be done gradually over time. >>> >>> So my recommendation is to apply the patch, and create a JIRA to gradually >>> remove remaining entanglements from order to ecommerce. >>> >>> WDYT? >>> >>> [1] https://issues.apache.org/jira/browse/OFBIZ-9322 >>> [2] https://s.apache.org/DlGE >>> [3] https://issues.apache.org/jira/secure/attachment/ >>> 12865667/OFBIZ-9322.patch >>> >>> Cheers, >>> >>> Taher Alkhateeb >>> > > |
Re: Removing failing tests from framework
|
Administrator
|
BTW Taher,
Will you take care of updating the Buildbot Script? I think it's a good occasion Jacques Le 02/05/2017 à 11:27, Jacques Le Roux a écrit : > It's OK with me if we later reintroduce this test and create a Jira for that > > Jacques > > > Le 02/05/2017 à 11:24, Jacques Le Roux a écrit : >> Hi Taher, >> >> Please give me an hour to review, I did not look at it yet >> >> Thanks >> >> Jacques >> >> >> Le 02/05/2017 à 11:11, Taher Alkhateeb a écrit : >>> Hey folks. I see no one replied so far on this. I'm not a big fan of lazy >>> consensus, but I will proceed in this case because the patch is very small >>> and two minor tests will be removed/modified for the sake of building >>> ofbiz-framework independently. >>> >>> On Sat, Apr 29, 2017 at 10:32 AM, Taher Alkhateeb < >>> [hidden email]> wrote: >>> >>>> Hello Everyone, >>>> >>>> I've been doing a lot of work lately in [1] to be able to build >>>> ofbiz-framework and run all tests successfully without pulling any plugins >>>> in. >>>> >>>> After lots and lots of test runs, trial-and-error, and deep code debugging >>>> I was able to bring down the total failing tests from hundreds to only two. >>>> I believe the two remaining tests are fundamentally incorrect because they >>>> assume the existence of data, scripts and widgets in ecommerce and I >>>> explained this issue more thoroughly in [2] >>>> >>>> Therefore, I made a patch [3] which simply removes the tests / portions of >>>> tests which are causing the failures. This is a quick solution to get the >>>> ofbiz-framework to build and test successfully without plugins. >>>> >>>> The real solution, however, requires a very deep look into the order >>>> component and to remove all dependencies on ecommerce. This is a lot of >>>> work, and should be done gradually over time. >>>> >>>> So my recommendation is to apply the patch, and create a JIRA to gradually >>>> remove remaining entanglements from order to ecommerce. >>>> >>>> WDYT? >>>> >>>> [1] https://issues.apache.org/jira/browse/OFBIZ-9322 >>>> [2] https://s.apache.org/DlGE >>>> [3] https://issues.apache.org/jira/secure/attachment/ >>>> 12865667/OFBIZ-9322.patch >>>> >>>> Cheers, >>>> >>>> Taher Alkhateeb >>>> >> >> > > |
Re: Removing failing tests from framework
|
|
In reply to this post by taher
+1
thanks for the effort and kudos for the progress made so far. Jacopo On Sat, Apr 29, 2017 at 9:32 AM, Taher Alkhateeb <[hidden email] > wrote: > Hello Everyone, > > I've been doing a lot of work lately in [1] to be able to build > ofbiz-framework and run all tests successfully without pulling any plugins > in. > > After lots and lots of test runs, trial-and-error, and deep code debugging > I was able to bring down the total failing tests from hundreds to only two. > I believe the two remaining tests are fundamentally incorrect because they > assume the existence of data, scripts and widgets in ecommerce and I > explained this issue more thoroughly in [2] > > Therefore, I made a patch [3] which simply removes the tests / portions of > tests which are causing the failures. This is a quick solution to get the > ofbiz-framework to build and test successfully without plugins. > > The real solution, however, requires a very deep look into the order > component and to remove all dependencies on ecommerce. This is a lot of > work, and should be done gradually over time. > > So my recommendation is to apply the patch, and create a JIRA to gradually > remove remaining entanglements from order to ecommerce. > > WDYT? > > [1] https://issues.apache.org/jira/browse/OFBIZ-9322 > [2] https://s.apache.org/DlGE > [3] > https://issues.apache.org/jira/secure/attachment/12865667/OFBIZ-9322.patch > > Cheers, > > Taher Alkhateeb > |
Re: Removing failing tests from framework
|
Administrator
|
Indeed thanks Taher,
After a review I agree with these changes. I found only trivial things to now take care of. Jacques Le 02/05/2017 à 12:04, Jacopo Cappellato a écrit : > +1 > > thanks for the effort and kudos for the progress made so far. > > Jacopo > > On Sat, Apr 29, 2017 at 9:32 AM, Taher Alkhateeb <[hidden email] >> wrote: >> Hello Everyone, >> >> I've been doing a lot of work lately in [1] to be able to build >> ofbiz-framework and run all tests successfully without pulling any plugins >> in. >> >> After lots and lots of test runs, trial-and-error, and deep code debugging >> I was able to bring down the total failing tests from hundreds to only two. >> I believe the two remaining tests are fundamentally incorrect because they >> assume the existence of data, scripts and widgets in ecommerce and I >> explained this issue more thoroughly in [2] >> >> Therefore, I made a patch [3] which simply removes the tests / portions of >> tests which are causing the failures. This is a quick solution to get the >> ofbiz-framework to build and test successfully without plugins. >> >> The real solution, however, requires a very deep look into the order >> component and to remove all dependencies on ecommerce. This is a lot of >> work, and should be done gradually over time. >> >> So my recommendation is to apply the patch, and create a JIRA to gradually >> remove remaining entanglements from order to ecommerce. >> >> WDYT? >> >> [1] https://issues.apache.org/jira/browse/OFBIZ-9322 >> [2] https://s.apache.org/DlGE >> [3] >> https://issues.apache.org/jira/secure/attachment/12865667/OFBIZ-9322.patch >> >> Cheers, >> >> Taher Alkhateeb >> |
|
|
Hello everyone,
Okay final commit in r1793633 is applied. ofbiz-framework now runs all tests successfully without plugins, finally! The next step is to split buildbot builds in two for the two products: ofbiz-framework and ofbiz-plugins. On Tue, May 2, 2017 at 2:26 PM, Jacques Le Roux < [hidden email]> wrote: > Indeed thanks Taher, > > After a review I agree with these changes. I found only trivial things to > now take care of. > > Jacques > > > > Le 02/05/2017 à 12:04, Jacopo Cappellato a écrit : > >> +1 >> >> thanks for the effort and kudos for the progress made so far. >> >> Jacopo >> >> On Sat, Apr 29, 2017 at 9:32 AM, Taher Alkhateeb < >> [hidden email] >> >>> wrote: >>> Hello Everyone, >>> >>> I've been doing a lot of work lately in [1] to be able to build >>> ofbiz-framework and run all tests successfully without pulling any >>> plugins >>> in. >>> >>> After lots and lots of test runs, trial-and-error, and deep code >>> debugging >>> I was able to bring down the total failing tests from hundreds to only >>> two. >>> I believe the two remaining tests are fundamentally incorrect because >>> they >>> assume the existence of data, scripts and widgets in ecommerce and I >>> explained this issue more thoroughly in [2] >>> >>> Therefore, I made a patch [3] which simply removes the tests / portions >>> of >>> tests which are causing the failures. This is a quick solution to get the >>> ofbiz-framework to build and test successfully without plugins. >>> >>> The real solution, however, requires a very deep look into the order >>> component and to remove all dependencies on ecommerce. This is a lot of >>> work, and should be done gradually over time. >>> >>> So my recommendation is to apply the patch, and create a JIRA to >>> gradually >>> remove remaining entanglements from order to ecommerce. >>> >>> WDYT? >>> >>> [1] https://issues.apache.org/jira/browse/OFBIZ-9322 >>> [2] https://s.apache.org/DlGE >>> [3] >>> https://issues.apache.org/jira/secure/attachment/12865667/OF >>> BIZ-9322.patch >>> >>> Cheers, >>> >>> Taher Alkhateeb >>> >>> > |
Re: Removing failing tests from framework
|
Administrator
|
In reply to this post by Jacques Le Roux
Hi Taher,
The test have been removed, please create a Jira to not forget to put the test again later. Thanks Jacques Le 02/05/2017 à 11:27, Jacques Le Roux a écrit : > It's OK with me if we later reintroduce this test and create a Jira for that > > Jacques > > > Le 02/05/2017 à 11:24, Jacques Le Roux a écrit : >> Hi Taher, >> >> Please give me an hour to review, I did not look at it yet >> >> Thanks >> >> Jacques >> >> >> Le 02/05/2017 à 11:11, Taher Alkhateeb a écrit : >>> Hey folks. I see no one replied so far on this. I'm not a big fan of lazy >>> consensus, but I will proceed in this case because the patch is very small >>> and two minor tests will be removed/modified for the sake of building >>> ofbiz-framework independently. >>> >>> On Sat, Apr 29, 2017 at 10:32 AM, Taher Alkhateeb < >>> [hidden email]> wrote: >>> >>>> Hello Everyone, >>>> >>>> I've been doing a lot of work lately in [1] to be able to build >>>> ofbiz-framework and run all tests successfully without pulling any plugins >>>> in. >>>> >>>> After lots and lots of test runs, trial-and-error, and deep code debugging >>>> I was able to bring down the total failing tests from hundreds to only two. >>>> I believe the two remaining tests are fundamentally incorrect because they >>>> assume the existence of data, scripts and widgets in ecommerce and I >>>> explained this issue more thoroughly in [2] >>>> >>>> Therefore, I made a patch [3] which simply removes the tests / portions of >>>> tests which are causing the failures. This is a quick solution to get the >>>> ofbiz-framework to build and test successfully without plugins. >>>> >>>> The real solution, however, requires a very deep look into the order >>>> component and to remove all dependencies on ecommerce. This is a lot of >>>> work, and should be done gradually over time. >>>> >>>> So my recommendation is to apply the patch, and create a JIRA to gradually >>>> remove remaining entanglements from order to ecommerce. >>>> >>>> WDYT? >>>> >>>> [1] https://issues.apache.org/jira/browse/OFBIZ-9322 >>>> [2] https://s.apache.org/DlGE >>>> [3] https://issues.apache.org/jira/secure/attachment/ >>>> 12865667/OFBIZ-9322.patch >>>> >>>> Cheers, >>>> >>>> Taher Alkhateeb >>>> >> >> > |
|
|
Hi Jacques, why do you want to reintroduce the tests?
On Wed, May 10, 2017 at 12:52 PM, Jacques Le Roux < [hidden email]> wrote: > Hi Taher, > > The test have been removed, please create a Jira to not forget to put the > test again later. > > Thanks > > Jacques > > > > Le 02/05/2017 à 11:27, Jacques Le Roux a écrit : > >> It's OK with me if we later reintroduce this test and create a Jira for >> that >> >> Jacques >> >> >> Le 02/05/2017 à 11:24, Jacques Le Roux a écrit : >> >>> Hi Taher, >>> >>> Please give me an hour to review, I did not look at it yet >>> >>> Thanks >>> >>> Jacques >>> >>> >>> Le 02/05/2017 à 11:11, Taher Alkhateeb a écrit : >>> >>>> Hey folks. I see no one replied so far on this. I'm not a big fan of >>>> lazy >>>> consensus, but I will proceed in this case because the patch is very >>>> small >>>> and two minor tests will be removed/modified for the sake of building >>>> ofbiz-framework independently. >>>> >>>> On Sat, Apr 29, 2017 at 10:32 AM, Taher Alkhateeb < >>>> [hidden email]> wrote: >>>> >>>> Hello Everyone, >>>>> >>>>> I've been doing a lot of work lately in [1] to be able to build >>>>> ofbiz-framework and run all tests successfully without pulling any >>>>> plugins >>>>> in. >>>>> >>>>> After lots and lots of test runs, trial-and-error, and deep code >>>>> debugging >>>>> I was able to bring down the total failing tests from hundreds to only >>>>> two. >>>>> I believe the two remaining tests are fundamentally incorrect because >>>>> they >>>>> assume the existence of data, scripts and widgets in ecommerce and I >>>>> explained this issue more thoroughly in [2] >>>>> >>>>> Therefore, I made a patch [3] which simply removes the tests / >>>>> portions of >>>>> tests which are causing the failures. This is a quick solution to get >>>>> the >>>>> ofbiz-framework to build and test successfully without plugins. >>>>> >>>>> The real solution, however, requires a very deep look into the order >>>>> component and to remove all dependencies on ecommerce. This is a lot of >>>>> work, and should be done gradually over time. >>>>> >>>>> So my recommendation is to apply the patch, and create a JIRA to >>>>> gradually >>>>> remove remaining entanglements from order to ecommerce. >>>>> >>>>> WDYT? >>>>> >>>>> [1] https://issues.apache.org/jira/browse/OFBIZ-9322 >>>>> [2] https://s.apache.org/DlGE >>>>> [3] https://issues.apache.org/jira/secure/attachment/ >>>>> 12865667/OFBIZ-9322.patch >>>>> >>>>> Cheers, >>>>> >>>>> Taher Alkhateeb >>>>> >>>>> >>> >>> >> > |
Re: Removing failing tests from framework
|
Administrator
|
Hi Taher,
I thought we temporarily removed these tests and would put them back later in another correct place with also data at correct plac. Is that not the case? Do we really want to remove them definitely? Jacques Le 10/05/2017 à 12:18, Taher Alkhateeb a écrit : > Hi Jacques, why do you want to reintroduce the tests? > > On Wed, May 10, 2017 at 12:52 PM, Jacques Le Roux < > [hidden email]> wrote: > >> Hi Taher, >> >> The test have been removed, please create a Jira to not forget to put the >> test again later. >> >> Thanks >> >> Jacques >> >> >> >> Le 02/05/2017 à 11:27, Jacques Le Roux a écrit : >> >>> It's OK with me if we later reintroduce this test and create a Jira for >>> that >>> >>> Jacques >>> >>> >>> Le 02/05/2017 à 11:24, Jacques Le Roux a écrit : >>> >>>> Hi Taher, >>>> >>>> Please give me an hour to review, I did not look at it yet >>>> >>>> Thanks >>>> >>>> Jacques >>>> >>>> >>>> Le 02/05/2017 à 11:11, Taher Alkhateeb a écrit : >>>> >>>>> Hey folks. I see no one replied so far on this. I'm not a big fan of >>>>> lazy >>>>> consensus, but I will proceed in this case because the patch is very >>>>> small >>>>> and two minor tests will be removed/modified for the sake of building >>>>> ofbiz-framework independently. >>>>> >>>>> On Sat, Apr 29, 2017 at 10:32 AM, Taher Alkhateeb < >>>>> [hidden email]> wrote: >>>>> >>>>> Hello Everyone, >>>>>> I've been doing a lot of work lately in [1] to be able to build >>>>>> ofbiz-framework and run all tests successfully without pulling any >>>>>> plugins >>>>>> in. >>>>>> >>>>>> After lots and lots of test runs, trial-and-error, and deep code >>>>>> debugging >>>>>> I was able to bring down the total failing tests from hundreds to only >>>>>> two. >>>>>> I believe the two remaining tests are fundamentally incorrect because >>>>>> they >>>>>> assume the existence of data, scripts and widgets in ecommerce and I >>>>>> explained this issue more thoroughly in [2] >>>>>> >>>>>> Therefore, I made a patch [3] which simply removes the tests / >>>>>> portions of >>>>>> tests which are causing the failures. This is a quick solution to get >>>>>> the >>>>>> ofbiz-framework to build and test successfully without plugins. >>>>>> >>>>>> The real solution, however, requires a very deep look into the order >>>>>> component and to remove all dependencies on ecommerce. This is a lot of >>>>>> work, and should be done gradually over time. >>>>>> >>>>>> So my recommendation is to apply the patch, and create a JIRA to >>>>>> gradually >>>>>> remove remaining entanglements from order to ecommerce. >>>>>> >>>>>> WDYT? >>>>>> >>>>>> [1] https://issues.apache.org/jira/browse/OFBIZ-9322 >>>>>> [2] https://s.apache.org/DlGE >>>>>> [3] https://issues.apache.org/jira/secure/attachment/ >>>>>> 12865667/OFBIZ-9322.patch >>>>>> >>>>>> Cheers, >>>>>> >>>>>> Taher Alkhateeb >>>>>> >>>>>> >>>> |
|
|
Yes, I thought the explanation is clear in my email?
On May 11, 2017 5:35 PM, "Jacques Le Roux" <[hidden email]> wrote: > Hi Taher, > > I thought we temporarily removed these tests and would put them back later > in another correct place with also data at correct plac. > > Is that not the case? Do we really want to remove them definitely? > > Jacques > > > Le 10/05/2017 à 12:18, Taher Alkhateeb a écrit : > >> Hi Jacques, why do you want to reintroduce the tests? >> >> On Wed, May 10, 2017 at 12:52 PM, Jacques Le Roux < >> [hidden email]> wrote: >> >> Hi Taher, >>> >>> The test have been removed, please create a Jira to not forget to put the >>> test again later. >>> >>> Thanks >>> >>> Jacques >>> >>> >>> >>> Le 02/05/2017 à 11:27, Jacques Le Roux a écrit : >>> >>> It's OK with me if we later reintroduce this test and create a Jira for >>>> that >>>> >>>> Jacques >>>> >>>> >>>> Le 02/05/2017 à 11:24, Jacques Le Roux a écrit : >>>> >>>> Hi Taher, >>>>> >>>>> Please give me an hour to review, I did not look at it yet >>>>> >>>>> Thanks >>>>> >>>>> Jacques >>>>> >>>>> >>>>> Le 02/05/2017 à 11:11, Taher Alkhateeb a écrit : >>>>> >>>>> Hey folks. I see no one replied so far on this. I'm not a big fan of >>>>>> lazy >>>>>> consensus, but I will proceed in this case because the patch is very >>>>>> small >>>>>> and two minor tests will be removed/modified for the sake of building >>>>>> ofbiz-framework independently. >>>>>> >>>>>> On Sat, Apr 29, 2017 at 10:32 AM, Taher Alkhateeb < >>>>>> [hidden email]> wrote: >>>>>> >>>>>> Hello Everyone, >>>>>> >>>>>>> I've been doing a lot of work lately in [1] to be able to build >>>>>>> ofbiz-framework and run all tests successfully without pulling any >>>>>>> plugins >>>>>>> in. >>>>>>> >>>>>>> After lots and lots of test runs, trial-and-error, and deep code >>>>>>> debugging >>>>>>> I was able to bring down the total failing tests from hundreds to >>>>>>> only >>>>>>> two. >>>>>>> I believe the two remaining tests are fundamentally incorrect because >>>>>>> they >>>>>>> assume the existence of data, scripts and widgets in ecommerce and I >>>>>>> explained this issue more thoroughly in [2] >>>>>>> >>>>>>> Therefore, I made a patch [3] which simply removes the tests / >>>>>>> portions of >>>>>>> tests which are causing the failures. This is a quick solution to get >>>>>>> the >>>>>>> ofbiz-framework to build and test successfully without plugins. >>>>>>> >>>>>>> The real solution, however, requires a very deep look into the order >>>>>>> component and to remove all dependencies on ecommerce. This is a lot >>>>>>> of >>>>>>> work, and should be done gradually over time. >>>>>>> >>>>>>> So my recommendation is to apply the patch, and create a JIRA to >>>>>>> gradually >>>>>>> remove remaining entanglements from order to ecommerce. >>>>>>> >>>>>>> WDYT? >>>>>>> >>>>>>> [1] https://issues.apache.org/jira/browse/OFBIZ-9322 >>>>>>> [2] https://s.apache.org/DlGE >>>>>>> [3] https://issues.apache.org/jira/secure/attachment/ >>>>>>> 12865667/OFBIZ-9322.patch >>>>>>> >>>>>>> Cheers, >>>>>>> >>>>>>> Taher Alkhateeb >>>>>>> >>>>>>> >>>>>>> >>>>> > |
Re: Removing failing tests from framework
|
Administrator
|
OK, if nobody cares about these tests then let it be
To be quite clear: http://svn.apache.org/viewvc?view=revision&revision=1793633 Jacques Le 11/05/2017 à 16:50, Taher Alkhateeb a écrit : > Yes, I thought the explanation is clear in my email? > > On May 11, 2017 5:35 PM, "Jacques Le Roux" <[hidden email]> > wrote: > >> Hi Taher, >> >> I thought we temporarily removed these tests and would put them back later >> in another correct place with also data at correct plac. >> >> Is that not the case? Do we really want to remove them definitely? >> >> Jacques >> >> >> Le 10/05/2017 à 12:18, Taher Alkhateeb a écrit : >> >>> Hi Jacques, why do you want to reintroduce the tests? >>> >>> On Wed, May 10, 2017 at 12:52 PM, Jacques Le Roux < >>> [hidden email]> wrote: >>> >>> Hi Taher, >>>> The test have been removed, please create a Jira to not forget to put the >>>> test again later. >>>> >>>> Thanks >>>> >>>> Jacques >>>> >>>> >>>> >>>> Le 02/05/2017 à 11:27, Jacques Le Roux a écrit : >>>> >>>> It's OK with me if we later reintroduce this test and create a Jira for >>>>> that >>>>> >>>>> Jacques >>>>> >>>>> >>>>> Le 02/05/2017 à 11:24, Jacques Le Roux a écrit : >>>>> >>>>> Hi Taher, >>>>>> Please give me an hour to review, I did not look at it yet >>>>>> >>>>>> Thanks >>>>>> >>>>>> Jacques >>>>>> >>>>>> >>>>>> Le 02/05/2017 à 11:11, Taher Alkhateeb a écrit : >>>>>> >>>>>> Hey folks. I see no one replied so far on this. I'm not a big fan of >>>>>>> lazy >>>>>>> consensus, but I will proceed in this case because the patch is very >>>>>>> small >>>>>>> and two minor tests will be removed/modified for the sake of building >>>>>>> ofbiz-framework independently. >>>>>>> >>>>>>> On Sat, Apr 29, 2017 at 10:32 AM, Taher Alkhateeb < >>>>>>> [hidden email]> wrote: >>>>>>> >>>>>>> Hello Everyone, >>>>>>> >>>>>>>> I've been doing a lot of work lately in [1] to be able to build >>>>>>>> ofbiz-framework and run all tests successfully without pulling any >>>>>>>> plugins >>>>>>>> in. >>>>>>>> >>>>>>>> After lots and lots of test runs, trial-and-error, and deep code >>>>>>>> debugging >>>>>>>> I was able to bring down the total failing tests from hundreds to >>>>>>>> only >>>>>>>> two. >>>>>>>> I believe the two remaining tests are fundamentally incorrect because >>>>>>>> they >>>>>>>> assume the existence of data, scripts and widgets in ecommerce and I >>>>>>>> explained this issue more thoroughly in [2] >>>>>>>> >>>>>>>> Therefore, I made a patch [3] which simply removes the tests / >>>>>>>> portions of >>>>>>>> tests which are causing the failures. This is a quick solution to get >>>>>>>> the >>>>>>>> ofbiz-framework to build and test successfully without plugins. >>>>>>>> >>>>>>>> The real solution, however, requires a very deep look into the order >>>>>>>> component and to remove all dependencies on ecommerce. This is a lot >>>>>>>> of >>>>>>>> work, and should be done gradually over time. >>>>>>>> >>>>>>>> So my recommendation is to apply the patch, and create a JIRA to >>>>>>>> gradually >>>>>>>> remove remaining entanglements from order to ecommerce. >>>>>>>> >>>>>>>> WDYT? >>>>>>>> >>>>>>>> [1] https://issues.apache.org/jira/browse/OFBIZ-9322 >>>>>>>> [2] https://s.apache.org/DlGE >>>>>>>> [3] https://issues.apache.org/jira/secure/attachment/ >>>>>>>> 12865667/OFBIZ-9322.patch >>>>>>>> >>>>>>>> Cheers, >>>>>>>> >>>>>>>> Taher Alkhateeb >>>>>>>> >>>>>>>> >>>>>>>> |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |