OFBiz › OFBiz - Dev

Removing the dependency on "build" from all the "run-test*" ant targets

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

13 messages Options

Jacopo Cappellato-4

Removing the dependency on "build" from all the "run-test*" ant targets

What do you think? In order to run most of the tests successfully you need to run load-data that already depends on "build"...

Here is the code change I would like to commit:

Index: build.xml
===================================================================
--- build.xml (revision 1328357)
+++ build.xml (working copy)
@@ -868,7 +868,7 @@
<antcall target="load-admin-user-login"/>
</target>

- <target name="run-tests" depends="build"
+ <target name="run-tests"
description="Run OFBiz default tests; you have to manually execute 'ant load-demo' before and see results in runtime/logs/test-results/html/all-tests.html.">
<java jar="ofbiz.jar" fork="true" resultproperty="test.result">
<jvmarg value="${memory.initial.param}"/>
@@ -910,7 +910,7 @@
<env key="LC_ALL" value="C"/>
</java>
</target>
- <target name="run-test" depends="build"
+ <target name="run-test"
description="Run a single test, syntax eg: ant run-test -Dtest.component=service -Dtest.case=service-soap-tests">
<fail unless="test.component">test.component is a required parameter: -Dtest.component=componentname</fail>
<fail unless="test.case">test.case is a required parameter: -Dtest.case=testcasename</fail>
@@ -936,7 +936,7 @@
</condition>
</fail>
</target>
- <target name="run-test-suite" depends="build"
+ <target name="run-test-suite"
description="Run a single test suite, syntax eg: ant run-test-suite -Dtest.component=mycomponent -Dtest.suiteName=mytests">
<fail unless="test.component">test.component is a required parameter: -Dtest.component=componentname</fail>
<fail unless="test.suiteName">test.suiteName is a required parameter: -Dtest.suiteName=testsuitename</fail>

Jacopo

Pierre Smits

Re: Removing the dependency on "build" from all the "run-test*" ant targets

+1

In my CI setup for automated OFBiz testing the system, after having checked
out the latest from trunk automatically, each individual test suite
triggered has to rebuild. Which only takes a minute or so. But for all
executed test runs together it adds up to about 15 mins.

So, each minute saved is a minute gained.

Regards,

Pierre

Op 23 april 2012 15:21 schreef Jacopo Cappellato <
[hidden email]> het volgende:

> What do you think? In order to run most of the tests successfully you need
> to run load-data that already depends on "build"...
>
> Here is the code change I would like to commit:
>
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1328357)
> +++ build.xml (working copy)
> @@ -868,7 +868,7 @@
> <antcall target="load-admin-user-login"/>
> </target>
>
> - <target name="run-tests" depends="build"
> + <target name="run-tests"
> description="Run OFBiz default tests; you have to manually
> execute 'ant load-demo' before and see results in
> runtime/logs/test-results/html/all-tests.html.">
> <java jar="ofbiz.jar" fork="true" resultproperty="test.result">
> <jvmarg value="${memory.initial.param}"/>
> @@ -910,7 +910,7 @@
> <env key="LC_ALL" value="C"/>
> </java>
> </target>
> - <target name="run-test" depends="build"
> + <target name="run-test"
> description="Run a single test, syntax eg: ant run-test
> -Dtest.component=service -Dtest.case=service-soap-tests">
> <fail unless="test.component">test.component is a required
> parameter: -Dtest.component=componentname</fail>
> <fail unless="test.case">test.case is a required parameter:
> -Dtest.case=testcasename</fail>
> @@ -936,7 +936,7 @@
> </condition>
> </fail>
> </target>
> - <target name="run-test-suite" depends="build"
> + <target name="run-test-suite"
> description="Run a single test suite, syntax eg: ant
> run-test-suite -Dtest.component=mycomponent -Dtest.suiteName=mytests">
> <fail unless="test.component">test.component is a required
> parameter: -Dtest.component=componentname</fail>
> <fail unless="test.suiteName">test.suiteName is a required
> parameter: -Dtest.suiteName=testsuitename</fail>
>
> Jacopo
>
>

Jacques Le Roux

Re: Removing the dependency on "build" from all the "run-test*" ant targets

Administrator

+1

Jacques

From: "Pierre Smits" <[hidden email]>

> +1
>
> In my CI setup for automated OFBiz testing the system, after having checked
> out the latest from trunk automatically, each individual test suite
> triggered has to rebuild. Which only takes a minute or so. But for all
> executed test runs together it adds up to about 15 mins.
>
> So, each minute saved is a minute gained.
>
> Regards,
>
> Pierre
>
> Op 23 april 2012 15:21 schreef Jacopo Cappellato <
> [hidden email]> het volgende:
>
>> What do you think? In order to run most of the tests successfully you need
>> to run load-data that already depends on "build"...
>>
>> Here is the code change I would like to commit:
>>
>> Index: build.xml
>> ===================================================================
>> --- build.xml (revision 1328357)
>> +++ build.xml (working copy)
>> @@ -868,7 +868,7 @@
>> <antcall target="load-admin-user-login"/>
>> </target>
>>
>> - <target name="run-tests" depends="build"
>> + <target name="run-tests"
>> description="Run OFBiz default tests; you have to manually
>> execute 'ant load-demo' before and see results in
>> runtime/logs/test-results/html/all-tests.html.">
>> <java jar="ofbiz.jar" fork="true" resultproperty="test.result">
>> <jvmarg value="${memory.initial.param}"/>
>> @@ -910,7 +910,7 @@
>> <env key="LC_ALL" value="C"/>
>> </java>
>> </target>
>> - <target name="run-test" depends="build"
>> + <target name="run-test"
>> description="Run a single test, syntax eg: ant run-test
>> -Dtest.component=service -Dtest.case=service-soap-tests">
>> <fail unless="test.component">test.component is a required
>> parameter: -Dtest.component=componentname</fail>
>> <fail unless="test.case">test.case is a required parameter:
>> -Dtest.case=testcasename</fail>
>> @@ -936,7 +936,7 @@
>> </condition>
>> </fail>
>> </target>
>> - <target name="run-test-suite" depends="build"
>> + <target name="run-test-suite"
>> description="Run a single test suite, syntax eg: ant
>> run-test-suite -Dtest.component=mycomponent -Dtest.suiteName=mytests">
>> <fail unless="test.component">test.component is a required
>> parameter: -Dtest.component=componentname</fail>
>> <fail unless="test.suiteName">test.suiteName is a required
>> parameter: -Dtest.suiteName=testsuitename</fail>
>>
>> Jacopo
>>
>>
>

Sascha Rodekamp-3

Re: Removing the dependency on "build" from all the "run-test*" ant targets

+1

Sascha

Am 23.04.2012 um 17:56 schrieb "Jacques Le Roux" <[hidden email]>:

> +1
>
> Jacques
>
> From: "Pierre Smits" <[hidden email]>
>> +1
>> In my CI setup for automated OFBiz testing the system, after having checked
>> out the latest from trunk automatically, each individual test suite
>> triggered has to rebuild. Which only takes a minute or so. But for all
>> executed test runs together it adds up to about 15 mins.
>> So, each minute saved is a minute gained.
>> Regards,
>> Pierre
>> Op 23 april 2012 15:21 schreef Jacopo Cappellato <
>> [hidden email]> het volgende:
>>> What do you think? In order to run most of the tests successfully you need
>>> to run load-data that already depends on "build"...
>>>
>>> Here is the code change I would like to commit:
>>>
>>> Index: build.xml
>>> ===================================================================
>>> --- build.xml (revision 1328357)
>>> +++ build.xml (working copy)
>>> @@ -868,7 +868,7 @@
>>> <antcall target="load-admin-user-login"/>
>>> </target>
>>>
>>> - <target name="run-tests" depends="build"
>>> + <target name="run-tests"
>>> description="Run OFBiz default tests; you have to manually
>>> execute 'ant load-demo' before and see results in
>>> runtime/logs/test-results/html/all-tests.html.">
>>> <java jar="ofbiz.jar" fork="true" resultproperty="test.result">
>>> <jvmarg value="${memory.initial.param}"/>
>>> @@ -910,7 +910,7 @@
>>> <env key="LC_ALL" value="C"/>
>>> </java>
>>> </target>
>>> - <target name="run-test" depends="build"
>>> + <target name="run-test"
>>> description="Run a single test, syntax eg: ant run-test
>>> -Dtest.component=service -Dtest.case=service-soap-tests">
>>> <fail unless="test.component">test.component is a required
>>> parameter: -Dtest.component=componentname</fail>
>>> <fail unless="test.case">test.case is a required parameter:
>>> -Dtest.case=testcasename</fail>
>>> @@ -936,7 +936,7 @@
>>> </condition>
>>> </fail>
>>> </target>
>>> - <target name="run-test-suite" depends="build"
>>> + <target name="run-test-suite"
>>> description="Run a single test suite, syntax eg: ant
>>> run-test-suite -Dtest.component=mycomponent -Dtest.suiteName=mytests">
>>> <fail unless="test.component">test.component is a required
>>> parameter: -Dtest.component=componentname</fail>
>>> <fail unless="test.suiteName">test.suiteName is a required
>>> parameter: -Dtest.suiteName=testsuitename</fail>
>>>
>>> Jacopo
>>>
>>>
>>

Erwan de FERRIERES-2

Re: Removing the dependency on "build" from all the "run-test*" ant targets

In reply to this post by Jacopo Cappellato-4

+1
On Apr 23, 2012 3:22 PM, "Jacopo Cappellato" <
[hidden email]> wrote:

Vikas Mayur-2

Re: Removing the dependency on "build" from all the "run-test*" ant targets

In reply to this post by Jacopo Cappellato-4

+1

Regards
Vikas

On Apr 23, 2012, at 6:51 PM, Jacopo Cappellato wrote:

> What do you think? In order to run most of the tests successfully you need to run load-data that already depends on "build"...
>
> Here is the code change I would like to commit:
>
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1328357)
> +++ build.xml (working copy)
> @@ -868,7 +868,7 @@
> <antcall target="load-admin-user-login"/>
> </target>
>
> - <target name="run-tests" depends="build"
> + <target name="run-tests"
> description="Run OFBiz default tests; you have to manually execute 'ant load-demo' before and see results in runtime/logs/test-results/html/all-tests.html.">
> <java jar="ofbiz.jar" fork="true" resultproperty="test.result">
> <jvmarg value="${memory.initial.param}"/>
> @@ -910,7 +910,7 @@
> <env key="LC_ALL" value="C"/>
> </java>
> </target>
> - <target name="run-test" depends="build"
> + <target name="run-test"
> description="Run a single test, syntax eg: ant run-test -Dtest.component=service -Dtest.case=service-soap-tests">
> <fail unless="test.component">test.component is a required parameter: -Dtest.component=componentname</fail>
> <fail unless="test.case">test.case is a required parameter: -Dtest.case=testcasename</fail>
> @@ -936,7 +936,7 @@
> </condition>
> </fail>
> </target>
> - <target name="run-test-suite" depends="build"
> + <target name="run-test-suite"
> description="Run a single test suite, syntax eg: ant run-test-suite -Dtest.component=mycomponent -Dtest.suiteName=mytests">
> <fail unless="test.component">test.component is a required parameter: -Dtest.component=componentname</fail>
> <fail unless="test.suiteName">test.suiteName is a required parameter: -Dtest.suiteName=testsuitename</fail>
>
> Jacopo
>

Adrian Crum-3

Re: Removing the dependency on "build" from all the "run-test*" ant targets

In reply to this post by Jacopo Cappellato-4

-1

If you are running tests, then most likely you are developing new code.
So, if the tests fail, I should be able to make corrections to my source
code and then run the tests again without having to insert a build step.

-Adrian

On 4/23/2012 2:21 PM, Jacopo Cappellato wrote:

> What do you think? In order to run most of the tests successfully you need to run load-data that already depends on "build"...
>
> Here is the code change I would like to commit:
>
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1328357)
> +++ build.xml (working copy)
> @@ -868,7 +868,7 @@
> <antcall target="load-admin-user-login"/>
> </target>
>
> -<target name="run-tests" depends="build"
> +<target name="run-tests"
> description="Run OFBiz default tests; you have to manually execute 'ant load-demo' before and see results in runtime/logs/test-results/html/all-tests.html.">
> <java jar="ofbiz.jar" fork="true" resultproperty="test.result">
> <jvmarg value="${memory.initial.param}"/>
> @@ -910,7 +910,7 @@
> <env key="LC_ALL" value="C"/>
> </java>
> </target>
> -<target name="run-test" depends="build"
> +<target name="run-test"
> description="Run a single test, syntax eg: ant run-test -Dtest.component=service -Dtest.case=service-soap-tests">
> <fail unless="test.component">test.component is a required parameter: -Dtest.component=componentname</fail>
> <fail unless="test.case">test.case is a required parameter: -Dtest.case=testcasename</fail>
> @@ -936,7 +936,7 @@
> </condition>
> </fail>
> </target>
> -<target name="run-test-suite" depends="build"
> +<target name="run-test-suite"
> description="Run a single test suite, syntax eg: ant run-test-suite -Dtest.component=mycomponent -Dtest.suiteName=mytests">
> <fail unless="test.component">test.component is a required parameter: -Dtest.component=componentname</fail>
> <fail unless="test.suiteName">test.suiteName is a required parameter: -Dtest.suiteName=testsuitename</fail>
>
> Jacopo
>

Scott Gray-2

Re: Removing the dependency on "build" from all the "run-test*" ant targets

The same argument could run in the opposite direction as well though, if I just changed a script/simple-method why should I have to build again? Although to be honest I don't really mind either way, running a build when nothing has changed takes virtually no time at all.

Regards
Scott

On 24/04/2012, at 10:57 PM, Adrian Crum wrote:

> -1
>
> If you are running tests, then most likely you are developing new code. So, if the tests fail, I should be able to make corrections to my source code and then run the tests again without having to insert a build step.
>
> -Adrian
>
> On 4/23/2012 2:21 PM, Jacopo Cappellato wrote:
>> What do you think? In order to run most of the tests successfully you need to run load-data that already depends on "build"...
>>
>> Here is the code change I would like to commit:
>>
>> Index: build.xml
>> ===================================================================
>> --- build.xml (revision 1328357)
>> +++ build.xml (working copy)
>> @@ -868,7 +868,7 @@
>> <antcall target="load-admin-user-login"/>
>> </target>
>>
>> -<target name="run-tests" depends="build"
>> +<target name="run-tests"
>> description="Run OFBiz default tests; you have to manually execute 'ant load-demo' before and see results in runtime/logs/test-results/html/all-tests.html.">
>> <java jar="ofbiz.jar" fork="true" resultproperty="test.result">
>> <jvmarg value="${memory.initial.param}"/>
>> @@ -910,7 +910,7 @@
>> <env key="LC_ALL" value="C"/>
>> </java>
>> </target>
>> -<target name="run-test" depends="build"
>> +<target name="run-test"
>> description="Run a single test, syntax eg: ant run-test -Dtest.component=service -Dtest.case=service-soap-tests">
>> <fail unless="test.component">test.component is a required parameter: -Dtest.component=componentname</fail>
>> <fail unless="test.case">test.case is a required parameter: -Dtest.case=testcasename</fail>
>> @@ -936,7 +936,7 @@
>> </condition>
>> </fail>
>> </target>
>> -<target name="run-test-suite" depends="build"
>> +<target name="run-test-suite"
>> description="Run a single test suite, syntax eg: ant run-test-suite -Dtest.component=mycomponent -Dtest.suiteName=mytests">
>> <fail unless="test.component">test.component is a required parameter: -Dtest.component=componentname</fail>
>> <fail unless="test.suiteName">test.suiteName is a required parameter: -Dtest.suiteName=testsuitename</fail>
>>
>> Jacopo
>>

Jacopo Cappellato-4

Re: Removing the dependency on "build" from all the "run-test*" ant targets

there are actually use cases (and good motivations) for both options and this is why I proposed the most granular one. If you are building new *java* code then you could run:

ant build run-tests

Jacopo

On Apr 24, 2012, at 2:02 PM, Scott Gray wrote:

> The same argument could run in the opposite direction as well though, if I just changed a script/simple-method why should I have to build again? Although to be honest I don't really mind either way, running a build when nothing has changed takes virtually no time at all.
>
> Regards
> Scott
>
> On 24/04/2012, at 10:57 PM, Adrian Crum wrote:
>
>> -1
>>
>> If you are running tests, then most likely you are developing new code. So, if the tests fail, I should be able to make corrections to my source code and then run the tests again without having to insert a build step.
>>
>> -Adrian
>>
>> On 4/23/2012 2:21 PM, Jacopo Cappellato wrote:
>>> What do you think? In order to run most of the tests successfully you need to run load-data that already depends on "build"...
>>>
>>> Here is the code change I would like to commit:
>>>
>>> Index: build.xml
>>> ===================================================================
>>> --- build.xml (revision 1328357)
>>> +++ build.xml (working copy)
>>> @@ -868,7 +868,7 @@
>>> <antcall target="load-admin-user-login"/>
>>> </target>
>>>
>>> -<target name="run-tests" depends="build"
>>> +<target name="run-tests"
>>> description="Run OFBiz default tests; you have to manually execute 'ant load-demo' before and see results in runtime/logs/test-results/html/all-tests.html.">
>>> <java jar="ofbiz.jar" fork="true" resultproperty="test.result">
>>> <jvmarg value="${memory.initial.param}"/>
>>> @@ -910,7 +910,7 @@
>>> <env key="LC_ALL" value="C"/>
>>> </java>
>>> </target>
>>> -<target name="run-test" depends="build"
>>> +<target name="run-test"
>>> description="Run a single test, syntax eg: ant run-test -Dtest.component=service -Dtest.case=service-soap-tests">
>>> <fail unless="test.component">test.component is a required parameter: -Dtest.component=componentname</fail>
>>> <fail unless="test.case">test.case is a required parameter: -Dtest.case=testcasename</fail>
>>> @@ -936,7 +936,7 @@
>>> </condition>
>>> </fail>
>>> </target>
>>> -<target name="run-test-suite" depends="build"
>>> +<target name="run-test-suite"
>>> description="Run a single test suite, syntax eg: ant run-test-suite -Dtest.component=mycomponent -Dtest.suiteName=mytests">
>>> <fail unless="test.component">test.component is a required parameter: -Dtest.component=componentname</fail>
>>> <fail unless="test.suiteName">test.suiteName is a required parameter: -Dtest.suiteName=testsuitename</fail>
>>>
>>> Jacopo
>>>
>

Adrian Crum-3

Re: Removing the dependency on "build" from all the "run-test*" ant targets

I hadn't thought of that. Thanks for the tip!

-Adrian

On 4/24/2012 1:10 PM, Jacopo Cappellato wrote:

> there are actually use cases (and good motivations) for both options and this is why I proposed the most granular one. If you are building new *java* code then you could run:
>
> ant build run-tests
>
> Jacopo
>
> On Apr 24, 2012, at 2:02 PM, Scott Gray wrote:
>
>> The same argument could run in the opposite direction as well though, if I just changed a script/simple-method why should I have to build again? Although to be honest I don't really mind either way, running a build when nothing has changed takes virtually no time at all.
>>
>> Regards
>> Scott
>>
>> On 24/04/2012, at 10:57 PM, Adrian Crum wrote:
>>
>>> -1
>>>
>>> If you are running tests, then most likely you are developing new code. So, if the tests fail, I should be able to make corrections to my source code and then run the tests again without having to insert a build step.
>>>
>>> -Adrian
>>>
>>> On 4/23/2012 2:21 PM, Jacopo Cappellato wrote:
>>>> What do you think? In order to run most of the tests successfully you need to run load-data that already depends on "build"...
>>>>
>>>> Here is the code change I would like to commit:
>>>>
>>>> Index: build.xml
>>>> ===================================================================
>>>> --- build.xml (revision 1328357)
>>>> +++ build.xml (working copy)
>>>> @@ -868,7 +868,7 @@
>>>> <antcall target="load-admin-user-login"/>
>>>> </target>
>>>>
>>>> -<target name="run-tests" depends="build"
>>>> +<target name="run-tests"
>>>> description="Run OFBiz default tests; you have to manually execute 'ant load-demo' before and see results in runtime/logs/test-results/html/all-tests.html.">
>>>> <java jar="ofbiz.jar" fork="true" resultproperty="test.result">
>>>> <jvmarg value="${memory.initial.param}"/>
>>>> @@ -910,7 +910,7 @@
>>>> <env key="LC_ALL" value="C"/>
>>>> </java>
>>>> </target>
>>>> -<target name="run-test" depends="build"
>>>> +<target name="run-test"
>>>> description="Run a single test, syntax eg: ant run-test -Dtest.component=service -Dtest.case=service-soap-tests">
>>>> <fail unless="test.component">test.component is a required parameter: -Dtest.component=componentname</fail>
>>>> <fail unless="test.case">test.case is a required parameter: -Dtest.case=testcasename</fail>
>>>> @@ -936,7 +936,7 @@
>>>> </condition>
>>>> </fail>
>>>> </target>
>>>> -<target name="run-test-suite" depends="build"
>>>> +<target name="run-test-suite"
>>>> description="Run a single test suite, syntax eg: ant run-test-suite -Dtest.component=mycomponent -Dtest.suiteName=mytests">
>>>> <fail unless="test.component">test.component is a required parameter: -Dtest.component=componentname</fail>
>>>> <fail unless="test.suiteName">test.suiteName is a required parameter: -Dtest.suiteName=testsuitename</fail>
>>>>
>>>> Jacopo
>>>>

Jacopo Cappellato-4

Re: Removing the dependency on "build" from all the "run-test*" ant targets

Adrian, can I proceed with the proposed change then?

Thanks,

Jacopo

On Apr 24, 2012, at 2:36 PM, Adrian Crum wrote:

> I hadn't thought of that. Thanks for the tip!
>
> -Adrian
>
> On 4/24/2012 1:10 PM, Jacopo Cappellato wrote:
>> there are actually use cases (and good motivations) for both options and this is why I proposed the most granular one. If you are building new *java* code then you could run:
>>
>> ant build run-tests
>>
>> Jacopo
>>
>> On Apr 24, 2012, at 2:02 PM, Scott Gray wrote:
>>
>>> The same argument could run in the opposite direction as well though, if I just changed a script/simple-method why should I have to build again? Although to be honest I don't really mind either way, running a build when nothing has changed takes virtually no time at all.
>>>
>>> Regards
>>> Scott
>>>
>>> On 24/04/2012, at 10:57 PM, Adrian Crum wrote:
>>>
>>>> -1
>>>>
>>>> If you are running tests, then most likely you are developing new code. So, if the tests fail, I should be able to make corrections to my source code and then run the tests again without having to insert a build step.
>>>>
>>>> -Adrian
>>>>
>>>> On 4/23/2012 2:21 PM, Jacopo Cappellato wrote:
>>>>> What do you think? In order to run most of the tests successfully you need to run load-data that already depends on "build"...
>>>>>
>>>>> Here is the code change I would like to commit:
>>>>>
>>>>> Index: build.xml
>>>>> ===================================================================
>>>>> --- build.xml (revision 1328357)
>>>>> +++ build.xml (working copy)
>>>>> @@ -868,7 +868,7 @@
>>>>> <antcall target="load-admin-user-login"/>
>>>>> </target>
>>>>>
>>>>> -<target name="run-tests" depends="build"
>>>>> +<target name="run-tests"
>>>>> description="Run OFBiz default tests; you have to manually execute 'ant load-demo' before and see results in runtime/logs/test-results/html/all-tests.html.">
>>>>> <java jar="ofbiz.jar" fork="true" resultproperty="test.result">
>>>>> <jvmarg value="${memory.initial.param}"/>
>>>>> @@ -910,7 +910,7 @@
>>>>> <env key="LC_ALL" value="C"/>
>>>>> </java>
>>>>> </target>
>>>>> -<target name="run-test" depends="build"
>>>>> +<target name="run-test"
>>>>> description="Run a single test, syntax eg: ant run-test -Dtest.component=service -Dtest.case=service-soap-tests">
>>>>> <fail unless="test.component">test.component is a required parameter: -Dtest.component=componentname</fail>
>>>>> <fail unless="test.case">test.case is a required parameter: -Dtest.case=testcasename</fail>
>>>>> @@ -936,7 +936,7 @@
>>>>> </condition>
>>>>> </fail>
>>>>> </target>
>>>>> -<target name="run-test-suite" depends="build"
>>>>> +<target name="run-test-suite"
>>>>> description="Run a single test suite, syntax eg: ant run-test-suite -Dtest.component=mycomponent -Dtest.suiteName=mytests">
>>>>> <fail unless="test.component">test.component is a required parameter: -Dtest.component=componentname</fail>
>>>>> <fail unless="test.suiteName">test.suiteName is a required parameter: -Dtest.suiteName=testsuitename</fail>
>>>>>
>>>>> Jacopo
>>>>>

Adrian Crum-3

Re: Removing the dependency on "build" from all the "run-test*" ant targets

That's fine.

+1

-Adrian

On 5/11/2012 1:56 PM, Jacopo Cappellato wrote:

> Adrian, can I proceed with the proposed change then?
>
> Thanks,
>
> Jacopo
>
> On Apr 24, 2012, at 2:36 PM, Adrian Crum wrote:
>
>> I hadn't thought of that. Thanks for the tip!
>>
>> -Adrian
>>
>> On 4/24/2012 1:10 PM, Jacopo Cappellato wrote:
>>> there are actually use cases (and good motivations) for both options and this is why I proposed the most granular one. If you are building new *java* code then you could run:
>>>
>>> ant build run-tests
>>>
>>> Jacopo
>>>
>>> On Apr 24, 2012, at 2:02 PM, Scott Gray wrote:
>>>
>>>> The same argument could run in the opposite direction as well though, if I just changed a script/simple-method why should I have to build again? Although to be honest I don't really mind either way, running a build when nothing has changed takes virtually no time at all.
>>>>
>>>> Regards
>>>> Scott
>>>>
>>>> On 24/04/2012, at 10:57 PM, Adrian Crum wrote:
>>>>
>>>>> -1
>>>>>
>>>>> If you are running tests, then most likely you are developing new code. So, if the tests fail, I should be able to make corrections to my source code and then run the tests again without having to insert a build step.
>>>>>
>>>>> -Adrian
>>>>>
>>>>> On 4/23/2012 2:21 PM, Jacopo Cappellato wrote:
>>>>>> What do you think? In order to run most of the tests successfully you need to run load-data that already depends on "build"...
>>>>>>
>>>>>> Here is the code change I would like to commit:
>>>>>>
>>>>>> Index: build.xml
>>>>>> ===================================================================
>>>>>> --- build.xml (revision 1328357)
>>>>>> +++ build.xml (working copy)
>>>>>> @@ -868,7 +868,7 @@
>>>>>> <antcall target="load-admin-user-login"/>
>>>>>> </target>
>>>>>>
>>>>>> -<target name="run-tests" depends="build"
>>>>>> +<target name="run-tests"
>>>>>> description="Run OFBiz default tests; you have to manually execute 'ant load-demo' before and see results in runtime/logs/test-results/html/all-tests.html.">
>>>>>> <java jar="ofbiz.jar" fork="true" resultproperty="test.result">
>>>>>> <jvmarg value="${memory.initial.param}"/>
>>>>>> @@ -910,7 +910,7 @@
>>>>>> <env key="LC_ALL" value="C"/>
>>>>>> </java>
>>>>>> </target>
>>>>>> -<target name="run-test" depends="build"
>>>>>> +<target name="run-test"
>>>>>> description="Run a single test, syntax eg: ant run-test -Dtest.component=service -Dtest.case=service-soap-tests">
>>>>>> <fail unless="test.component">test.component is a required parameter: -Dtest.component=componentname</fail>
>>>>>> <fail unless="test.case">test.case is a required parameter: -Dtest.case=testcasename</fail>
>>>>>> @@ -936,7 +936,7 @@
>>>>>> </condition>
>>>>>> </fail>
>>>>>> </target>
>>>>>> -<target name="run-test-suite" depends="build"
>>>>>> +<target name="run-test-suite"
>>>>>> description="Run a single test suite, syntax eg: ant run-test-suite -Dtest.component=mycomponent -Dtest.suiteName=mytests">
>>>>>> <fail unless="test.component">test.component is a required parameter: -Dtest.component=componentname</fail>
>>>>>> <fail unless="test.suiteName">test.suiteName is a required parameter: -Dtest.suiteName=testsuitename</fail>
>>>>>>
>>>>>> Jacopo
>>>>>>

Jacopo Cappellato-4

Re: Removing the dependency on "build" from all the "run-test*" ant targets

Thanks; committed in rev. 1337484

Jacopo

On May 12, 2012, at 8:54 AM, Adrian Crum wrote:

> That's fine.
>
> +1
>
> -Adrian
>
> On 5/11/2012 1:56 PM, Jacopo Cappellato wrote:
>> Adrian, can I proceed with the proposed change then?
>>
>> Thanks,
>>
>> Jacopo
>>
>> On Apr 24, 2012, at 2:36 PM, Adrian Crum wrote:
>>
>>> I hadn't thought of that. Thanks for the tip!
>>>
>>> -Adrian
>>>
>>> On 4/24/2012 1:10 PM, Jacopo Cappellato wrote:
>>>> there are actually use cases (and good motivations) for both options and this is why I proposed the most granular one. If you are building new *java* code then you could run:
>>>>
>>>> ant build run-tests
>>>>
>>>> Jacopo
>>>>
>>>> On Apr 24, 2012, at 2:02 PM, Scott Gray wrote:
>>>>
>>>>> The same argument could run in the opposite direction as well though, if I just changed a script/simple-method why should I have to build again? Although to be honest I don't really mind either way, running a build when nothing has changed takes virtually no time at all.
>>>>>
>>>>> Regards
>>>>> Scott
>>>>>
>>>>> On 24/04/2012, at 10:57 PM, Adrian Crum wrote:
>>>>>
>>>>>> -1
>>>>>>
>>>>>> If you are running tests, then most likely you are developing new code. So, if the tests fail, I should be able to make corrections to my source code and then run the tests again without having to insert a build step.
>>>>>>
>>>>>> -Adrian
>>>>>>
>>>>>> On 4/23/2012 2:21 PM, Jacopo Cappellato wrote:
>>>>>>> What do you think? In order to run most of the tests successfully you need to run load-data that already depends on "build"...
>>>>>>>
>>>>>>> Here is the code change I would like to commit:
>>>>>>>
>>>>>>> Index: build.xml
>>>>>>> ===================================================================
>>>>>>> --- build.xml (revision 1328357)
>>>>>>> +++ build.xml (working copy)
>>>>>>> @@ -868,7 +868,7 @@
>>>>>>> <antcall target="load-admin-user-login"/>
>>>>>>> </target>
>>>>>>>
>>>>>>> -<target name="run-tests" depends="build"
>>>>>>> +<target name="run-tests"
>>>>>>> description="Run OFBiz default tests; you have to manually execute 'ant load-demo' before and see results in runtime/logs/test-results/html/all-tests.html.">
>>>>>>> <java jar="ofbiz.jar" fork="true" resultproperty="test.result">
>>>>>>> <jvmarg value="${memory.initial.param}"/>
>>>>>>> @@ -910,7 +910,7 @@
>>>>>>> <env key="LC_ALL" value="C"/>
>>>>>>> </java>
>>>>>>> </target>
>>>>>>> -<target name="run-test" depends="build"
>>>>>>> +<target name="run-test"
>>>>>>> description="Run a single test, syntax eg: ant run-test -Dtest.component=service -Dtest.case=service-soap-tests">
>>>>>>> <fail unless="test.component">test.component is a required parameter: -Dtest.component=componentname</fail>
>>>>>>> <fail unless="test.case">test.case is a required parameter: -Dtest.case=testcasename</fail>
>>>>>>> @@ -936,7 +936,7 @@
>>>>>>> </condition>
>>>>>>> </fail>
>>>>>>> </target>
>>>>>>> -<target name="run-test-suite" depends="build"
>>>>>>> +<target name="run-test-suite"
>>>>>>> description="Run a single test suite, syntax eg: ant run-test-suite -Dtest.component=mycomponent -Dtest.suiteName=mytests">
>>>>>>> <fail unless="test.component">test.component is a required parameter: -Dtest.component=componentname</fail>
>>>>>>> <fail unless="test.suiteName">test.suiteName is a required parameter: -Dtest.suiteName=testsuitename</fail>
>>>>>>>
>>>>>>> Jacopo
>>>>>>>