Repurpose AddressMatchMap

[Scott Gray-2]

Hi All,

I need to do some company name matching where something like AddressMatchMap would come in handy so that I can replace things like "Co." with "Company", "Inc." with "Incorporated" etc. while performing the matching.

Does anyone mind if I add the Type pattern to AddressMatchMap so I can reuse the same entity for a different purpose?  Ideally I would also rename the entity to something more generic, but probably won't have enough time in the first pass.

Please let me know if there are any objections or questions.

Many thanks
Scott

[BJ Freeman]

I used it to match incoming Categories from supplier to ofbiz categories.
also added regex to it for doing address look up
seems to be a good catchall no one is expanding in the trunk.

Scott Gray sent the following on 8/3/2010 2:54 AM:

> Hi All,
>
> I need to do some company name matching where something like AddressMatchMap would come in handy so that I can replace things like "Co." with "Company", "Inc." with "Incorporated" etc. while performing the matching.
>
> Does anyone mind if I add the Type pattern to AddressMatchMap so I can reuse the same entity for a different purpose?  Ideally I would also rename the entity to something more generic, but probably won't have enough time in the first pass.
>
> Please let me know if there are any objections or questions.
>
> Many thanks
> Scott
>

[Scott Gray-2]

How did you reuse it for multiple purposes without having a type entity?  For example I don't want address specific key/values operating on groupName strings, that's why I'm proposing to add the type pattern to the entity.

And I think you'll find it is actively used for its intended purpose, for example both google checkout and the first ebay component make use of the methods in PartyWorker that in turn use AddressMatchMap and those components are fairly recent additions.  I do plan on adding javadocs to the worker methods though, I'm guessing a lot of people simply aren't aware of them and what they do.

Regards
Scott

On 3/08/2010, at 10:40 PM, BJ Freeman wrote:

> I used it to match incoming Categories from supplier to ofbiz categories.
> also added regex to it for doing address look up
> seems to be a good catchall no one is expanding in the trunk.
>
> Scott Gray sent the following on 8/3/2010 2:54 AM:
>> Hi All,
>>
>> I need to do some company name matching where something like AddressMatchMap would come in handy so that I can replace things like "Co." with "Company", "Inc." with "Incorporated" etc. while performing the matching.
>>
>> Does anyone mind if I add the Type pattern to AddressMatchMap so I can reuse the same entity for a different purpose?  Ideally I would also rename the entity to something more generic, but probably won't have enough time in the first pass.
>>
>> Please let me know if there are any objections or questions.
>>
>> Many thanks
>> Scott
>>

[BJ Freeman]

I overload the entity in my own components, i wrote some time ago.
thanks for the heads up will have to stop being lazy and create entities
for my purposes.

Scott Gray sent the following on 8/3/2010 4:04 AM:

> How did you reuse it for multiple purposes without having a type entity?  For example I don't want address specific key/values operating on groupName strings, that's why I'm proposing to add the type pattern to the entity.
>
> And I think you'll find it is actively used for its intended purpose, for example both google checkout and the first ebay component make use of the methods in PartyWorker that in turn use AddressMatchMap and those components are fairly recent additions.  I do plan on adding javadocs to the worker methods though, I'm guessing a lot of people simply aren't aware of them and what they do.
>
> Regards
> Scott
>
> On 3/08/2010, at 10:40 PM, BJ Freeman wrote:
>
>> I used it to match incoming Categories from supplier to ofbiz categories.
>> also added regex to it for doing address look up
>> seems to be a good catchall no one is expanding in the trunk.
>>
>> Scott Gray sent the following on 8/3/2010 2:54 AM:
>>> Hi All,
>>>
>>> I need to do some company name matching where something like AddressMatchMap would come in handy so that I can replace things like "Co." with "Company", "Inc." with "Incorporated" etc. while performing the matching.
>>>
>>> Does anyone mind if I add the Type pattern to AddressMatchMap so I can reuse the same entity for a different purpose?  Ideally I would also rename the entity to something more generic, but probably won't have enough time in the first pass.
>>>
>>> Please let me know if there are any objections or questions.
>>>
>>> Many thanks
>>> Scott
>>>
>

[Scott Gray-2]

After having a look at it here is my updated proposition:
1. Add new ValueMatchMap and ValueMatchMapType entities as follows
ValueMatchMap
- mapKey *
- mapValue *
- valueMatchMapTypeId *
- sequenceNum

ValueMatchMapType
- valueMatchMapTypeId *
- description

2.  Add seed data types ADDRESS_LINE and GROUP_NAME

3. Write a migration service for AddressMatchMap to ValueMatchMap

4. Change the existing AddressMapMatch services to the new entity

5. Rename AddressMatchMap to OldAddressMatchMap

Thoughts are welcome.

Thanks
Scott

On 3/08/2010, at 9:54 PM, Scott Gray wrote:

> Hi All,
>
> I need to do some company name matching where something like AddressMatchMap would come in handy so that I can replace things like "Co." with "Company", "Inc." with "Incorporated" etc. while performing the matching.
>
> Does anyone mind if I add the Type pattern to AddressMatchMap so I can reuse the same entity for a different purpose?  Ideally I would also rename the entity to something more generic, but probably won't have enough time in the first pass.
>
> Please let me know if there are any objections or questions.
>
> Many thanks
> Scott
>