Shippable Weight - r1720900 - OFBIZ-6777

[Vikas Mayur-2]

Hi,

I see this commit was done to fix the inconsistencies with the weight
column on the product. The product_weight is now used instead so if I am
not wrong migrating to OFBiz 16 from OFBiz 12 would require me to copy the
weight column to product_weight column and everything should magically
happen. Of-course I need to change the custom code to adapt to this change.

When I looked closer, the service 'recalcShippingTotal' make use of the
column shipping_weight (OrderReadHelper.getItemWeight()) instead.

So, my question is why would we use product_weight on order entry and
shipping_weight when an item is canceled to recalculate the order total?

Secondly, if product_weight is used in first place, what is the
significance of shipping_weight and which one should be used to calculate
the shipping options (shipping methods and shipping cost) in general?

Please let me know if I misunderstood the change.

Thanks in advance.

Regards
Vikas

[Paul Foxworthy]

Hi Vikas,

Does shipping_weight factor in typical packaging for shipping? So you'd use
shipping weight to calculate shipping costs, but product_weight for product
specification. You might order quantity twelve 420g cans of soup. 420g is
the net weight of the product, but for shipping you need to factor in the
weight of the cans and the box as well.

Cheers

Paul Foxworthy


On 7 March 2018 at 13:11, Vikas Mayur <[hidden email]> wrote:

> Hi,
>
> I see this commit was done to fix the inconsistencies with the weight
> column on the product. The product_weight is now used instead so if I am
> not wrong migrating to OFBiz 16 from OFBiz 12 would require me to copy the
> weight column to product_weight column and everything should magically
> happen. Of-course I need to change the custom code to adapt to this change.
>
> When I looked closer, the service 'recalcShippingTotal' make use of the
> column shipping_weight (OrderReadHelper.getItemWeight()) instead.
>
> So, my question is why would we use product_weight on order entry and
> shipping_weight when an item is canceled to recalculate the order total?
>
> Secondly, if product_weight is used in first place, what is the
> significance of shipping_weight and which one should be used to calculate
> the shipping options (shipping methods and shipping cost) in general?
>
> Please let me know if I misunderstood the change.
>
> Thanks in advance.
>
> Regards
> Vikas
>

--
Coherent Software Australia Pty Ltd
PO Box 2773
Cheltenham Vic 3192
Australia

Phone: [phone]
Web: http://www.coherentsoftware.com.au/
Email: [hidden email]

[Vikas Mayur-2]

Hi Paul,

Thanks for you reply.

At least in the r1720900 (and overall OFBiz) appears to be using the
product_weight other than the recalculate shipping total service where it
use shipping_weight. I would be interested to know why we use
product_weight in one place and shipping_weight in other. Is it a bug or I
completely overlooking something?

Ok, understood the shipping weight and how it may be typically factored in
the calculate shipping cost but my question is in general is about the
shipping_weight on the product. In your scenario of 12, 420g cans of soup,
how would you know the shipping_weight on the product? Well, do you mean if
the package weight for 12 cans is 1200g, you would use 420g+100g to define
the shipping_weight on the product? An order quantity of 6 cans may be
using lets say 500g of package weight (and not 600g), how could we enter
this on the product as it may always be variable? There is this logic to
split the number of units into different packages based on the max weight
etc. So in general, I am not sure what is the purpose of shipping_weight on
the product.

Regards
Vikas





On Tue, Mar 6, 2018 at 8:53 PM, Paul Foxworthy <[hidden email]> wrote:

> Hi Vikas,
>
> Does shipping_weight factor in typical packaging for shipping? So you'd use
> shipping weight to calculate shipping costs, but product_weight for product
> specification. You might order quantity twelve 420g cans of soup. 420g is
> the net weight of the product, but for shipping you need to factor in the
> weight of the cans and the box as well.
>
> Cheers
>
> Paul Foxworthy
>
>
> On 7 March 2018 at 13:11, Vikas Mayur <[hidden email]> wrote:
>
> > Hi,
> >
> > I see this commit was done to fix the inconsistencies with the weight
> > column on the product. The product_weight is now used instead so if I am
> > not wrong migrating to OFBiz 16 from OFBiz 12 would require me to copy
> the
> > weight column to product_weight column and everything should magically
> > happen. Of-course I need to change the custom code to adapt to this
> change.
> >
> > When I looked closer, the service 'recalcShippingTotal' make use of the
> > column shipping_weight (OrderReadHelper.getItemWeight()) instead.
> >
> > So, my question is why would we use product_weight on order entry and
> > shipping_weight when an item is canceled to recalculate the order total?
> >
> > Secondly, if product_weight is used in first place, what is the
> > significance of shipping_weight and which one should be used to calculate
> > the shipping options (shipping methods and shipping cost) in general?
> >
> > Please let me know if I misunderstood the change.
> >
> > Thanks in advance.
> >
> > Regards
> > Vikas
> >
>
>
>
> --
> Coherent Software Australia Pty Ltd
> PO Box 2773
> Cheltenham Vic 3192
> Australia
>
> Phone: [phone]
> Web: http://www.coherentsoftware.com.au/
> Email: [hidden email]
>

[Vikas Mayur-2]

Is there anyone who could please confirm if this is bug and a ticket need
to be opened? Sorry for any oversight on my side.

Regards
Vikas

On Tue, Mar 6, 2018 at 8:11 PM, Vikas Mayur <[hidden email]> wrote:

> Hi,
>
> I see this commit was done to fix the inconsistencies with the weight
> column on the product. The product_weight is now used instead so if I am
> not wrong migrating to OFBiz 16 from OFBiz 12 would require me to copy the
> weight column to product_weight column and everything should magically
> happen. Of-course I need to change the custom code to adapt to this change.
>
> When I looked closer, the service 'recalcShippingTotal' make use of the
> column shipping_weight (OrderReadHelper.getItemWeight()) instead.
>
> So, my question is why would we use product_weight on order entry and
> shipping_weight when an item is canceled to recalculate the order total?
>
> Secondly, if product_weight is used in first place, what is the
> significance of shipping_weight and which one should be used to calculate
> the shipping options (shipping methods and shipping cost) in general?
>
> Please let me know if I misunderstood the change.
>
> Thanks in advance.
>
> Regards
> Vikas
>
>
>
>

[Jacques Le Roux]

Hi Jacopo, Suraj, Ashish  and Paul,

Because there is no answer, I suppose it's a Vika's oversight? Else (even w/o answers) I'll digg it...

Thanks

Jacques

Le 09/03/2018 à 01:56, Vikas Mayur a écrit :

> Is there anyone who could please confirm if this is bug and a ticket need
> to be opened? Sorry for any oversight on my side.
>
> Regards
> Vikas
>
> On Tue, Mar 6, 2018 at 8:11 PM, Vikas Mayur <[hidden email]> wrote:
>
>> Hi,
>>
>> I see this commit was done to fix the inconsistencies with the weight
>> column on the product. The product_weight is now used instead so if I am
>> not wrong migrating to OFBiz 16 from OFBiz 12 would require me to copy the
>> weight column to product_weight column and everything should magically
>> happen. Of-course I need to change the custom code to adapt to this change.
>>
>> When I looked closer, the service 'recalcShippingTotal' make use of the
>> column shipping_weight (OrderReadHelper.getItemWeight()) instead.
>>
>> So, my question is why would we use product_weight on order entry and
>> shipping_weight when an item is canceled to recalculate the order total?
>>
>> Secondly, if product_weight is used in first place, what is the
>> significance of shipping_weight and which one should be used to calculate
>> the shipping options (shipping methods and shipping cost) in general?
>>
>> Please let me know if I misunderstood the change.
>>
>> Thanks in advance.
>>
>> Regards
>> Vikas
>>
>>
>>
>>