Start refactoring

[chris snow]

Hi Adrian,

I see from some commits that you are doing some work on tidying up the
Start / Config classes.  Great work!

Do you have a longer term goal you are working towards, or are you
just doing some spring cleaning?

Cheers,

Chris

[Adrian Crum-3]

That work was a continuation of the work I did to have hot-deploy
components load their own containers. The project I'm working on MUST
start up and shut down properly, and the existing startup/shutdown code
did not accomplish that, so I fixed it.

For now, I'm done working on those classes. They could certainly use
more work.

-Adrian

On 3/28/2011 2:02 PM, chris snow wrote:

> Hi Adrian,
>
> I see from some commits that you are doing some work on tidying up the
> Start / Config classes.  Great work!
>
> Do you have a longer term goal you are working towards, or are you
> just doing some spring cleaning?
>
> Cheers,
>
> Chris

[chris snow]

Tiny improvement - would it make sense to move the args from the
Config class?  I'll raise a JIRA  with a patch to explain ...

On Mon, Mar 28, 2011 at 10:43 PM, Adrian Crum
<[hidden email]> wrote:

> That work was a continuation of the work I did to have hot-deploy components
> load their own containers. The project I'm working on MUST start up and shut
> down properly, and the existing startup/shutdown code did not accomplish
> that, so I fixed it.
>
> For now, I'm done working on those classes. They could certainly use more
> work.
>
> -Adrian
>
> On 3/28/2011 2:02 PM, chris snow wrote:
>>
>> Hi Adrian,
>>
>> I see from some commits that you are doing some work on tidying up the
>> Start / Config classes.  Great work!
>>
>> Do you have a longer term goal you are working towards, or are you
>> just doing some spring cleaning?
>>
>> Cheers,
>>
>> Chris
>

[Adrian Crum-3]

Config uses the arguments to determine which properties file to load.
Where else would you put it?

-Adrian

On 3/28/2011 2:56 PM, chris snow wrote:

> Tiny improvement - would it make sense to move the args from the
> Config class?  I'll raise a JIRA  with a patch to explain ...
>
> On Mon, Mar 28, 2011 at 10:43 PM, Adrian Crum
> <[hidden email]>  wrote:
>> That work was a continuation of the work I did to have hot-deploy components
>> load their own containers. The project I'm working on MUST start up and shut
>> down properly, and the existing startup/shutdown code did not accomplish
>> that, so I fixed it.
>>
>> For now, I'm done working on those classes. They could certainly use more
>> work.
>>
>> -Adrian
>>
>> On 3/28/2011 2:02 PM, chris snow wrote:
>>> Hi Adrian,
>>>
>>> I see from some commits that you are doing some work on tidying up the
>>> Start / Config classes.  Great work!
>>>
>>> Do you have a longer term goal you are working towards, or are you
>>> just doing some spring cleaning?
>>>
>>> Cheers,
>>>
>>> Chris

[chris snow]

Hi Adrian,  I've created OFBIZ-4234.

On Mon, Mar 28, 2011 at 10:57 PM, Adrian Crum
<[hidden email]> wrote:

> Config uses the arguments to determine which properties file to load. Where
> else would you put it?
>
> -Adrian
>
> On 3/28/2011 2:56 PM, chris snow wrote:
>>
>> Tiny improvement - would it make sense to move the args from the
>> Config class?  I'll raise a JIRA  with a patch to explain ...
>>
>> On Mon, Mar 28, 2011 at 10:43 PM, Adrian Crum
>> <[hidden email]>  wrote:
>>>
>>> That work was a continuation of the work I did to have hot-deploy
>>> components
>>> load their own containers. The project I'm working on MUST start up and
>>> shut
>>> down properly, and the existing startup/shutdown code did not accomplish
>>> that, so I fixed it.
>>>
>>> For now, I'm done working on those classes. They could certainly use more
>>> work.
>>>
>>> -Adrian
>>>
>>> On 3/28/2011 2:02 PM, chris snow wrote:
>>>>
>>>> Hi Adrian,
>>>>
>>>> I see from some commits that you are doing some work on tidying up the
>>>> Start / Config classes.  Great work!
>>>>
>>>> Do you have a longer term goal you are working towards, or are you
>>>> just doing some spring cleaning?
>>>>
>>>> Cheers,
>>>>
>>>> Chris
>