[jira] [Created] (OFBIZ-4234) remove main program args[] from Config

[Nicolas Malin (Jira)]

remove main program args[] from Config
--------------------------------------

                 Key: OFBIZ-4234
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4234
             Project: OFBiz
          Issue Type: Improvement
          Components: framework
    Affects Versions: SVN trunk
            Reporter: chris snow
            Priority: Trivial


would it make sense to remove the program main args[] from Config?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

chris snow updated OFBIZ-4234:
------------------------------

    Attachment: moveArgsFromConfig.patch

> remove main program args[] from Config
> --------------------------------------
>
>                 Key: OFBIZ-4234
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4234
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: chris snow
>            Priority: Trivial
>         Attachments: moveArgsFromConfig.patch
>
>
> would it make sense to remove the program main args[] from Config?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012296#comment-13012296 ]

Adrian Crum commented on OFBIZ-4234:
------------------------------------

This change breaks the encapsulation of the Config class. The Start class has to know that the Config class uses the first command-line argument, and it shouldn't have to know that.

> remove main program args[] from Config
> --------------------------------------
>
>                 Key: OFBIZ-4234
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4234
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: chris snow
>            Priority: Trivial
>         Attachments: moveArgsFromConfig.patch
>
>
> would it make sense to remove the program main args[] from Config?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

chris snow closed OFBIZ-4234.
-----------------------------

    Resolution: Not A Problem

> remove main program args[] from Config
> --------------------------------------
>
>                 Key: OFBIZ-4234
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4234
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: chris snow
>            Priority: Trivial
>         Attachments: moveArgsFromConfig.patch
>
>
> would it make sense to remove the program main args[] from Config?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012332#comment-13012332 ]

chris snow commented on OFBIZ-4234:
-----------------------------------

ok.  I'll close this issue.

> remove main program args[] from Config
> --------------------------------------
>
>                 Key: OFBIZ-4234
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4234
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: chris snow
>            Priority: Trivial
>         Attachments: moveArgsFromConfig.patch
>
>
> would it make sense to remove the program main args[] from Config?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012333#comment-13012333 ]

Adrian Crum commented on OFBIZ-4234:
------------------------------------

Chris,

If you're interested in continuing the work on the Start class, there are some other things that could be done:

1. Have the Start class implement a state machine.
2. Have the loaders implement state machines.
3. Have the Config class do more to hide its implementation.
4. Have the admin port monitoring thread class contain a Start instance so it doesn't rely on being a nested class.
5. JavaDocs.

> remove main program args[] from Config
> --------------------------------------
>
>                 Key: OFBIZ-4234
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4234
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: chris snow
>            Priority: Trivial
>         Attachments: moveArgsFromConfig.patch
>
>
> would it make sense to remove the program main args[] from Config?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira