UI Refactoring progress

[Adrian Crum]

My requests for help with the new maincss.css file
(https://issues.apache.org/jira/browse/OFBIZ-666) on the dev and user mailing
lists have gone unanswered, so the UI Refactoring effort has come to a
screeching halt. Jacques was able to test the new maincss.css file on one more
browser - Opera - while evaluating the experimental_3.patch file
(https://issues.apache.org/jira/browse/OFBIZ-633).

In the meantime...

Instead of creating a new umbrella Jira issue for this effort, I decided to use
an existing issue that was already in that role -
https://issues.apache.org/jira/browse/OFBIZ-241. I linked OFBIZ-241 to some of
the "free floating" UI issues.

Here are the tasks I would like to accomplish before the developers conference
in March:

1. Get OFBIZ-666 committed to the project.
2. Submit a newer version of maincss.css to Jira - which can be used for the
rest of this effort.
3. Post some refactoring guidelines and tips on OFBIZ-241.

March is less than a month away. If the UI Refactoring effort is addressed at
the developers conference, then it would be nice to have this groundwork
completed beforehand.

-Adrian

[Christian Geisert]

Adrian Crum schrieb:
> My requests for help with the new maincss.css file
> (https://issues.apache.org/jira/browse/OFBIZ-666) on the dev and user
> mailing lists have gone unanswered, so the UI Refactoring effort has
> come to a screeching halt. Jacques was able to test the new maincss.css

I started doing some testing with Iceweasel ..er.. Firefox and Konqueror
under Linux but ran out of time - I hadn't noticed any problems so far
(well some small differences in font sizes)

Christian

[Adrian Crum]

Thanks Christian!

Yeah, the font sizes will change slightly. That's because the new css file
converts the mixed pt and px sizes into ems. If you change your browser's
default font size, the UI should scale properly.


Christian Geisert wrote:

> Adrian Crum schrieb:
>
>> My requests for help with the new maincss.css file
>> (https://issues.apache.org/jira/browse/OFBIZ-666) on the dev and user
>> mailing lists have gone unanswered, so the UI Refactoring effort has
>> come to a screeching halt. Jacques was able to test the new maincss.css
>
>
> I started doing some testing with Iceweasel ..er.. Firefox and Konqueror
> under Linux but ran out of time - I hadn't noticed any problems so far
> (well some small differences in font sizes)
>
> Christian
>

[David E Jones]

On Feb 5, 2007, at 10:49 AM, Adrian Crum wrote:

> My requests for help with the new maincss.css file (https://
> issues.apache.org/jira/browse/OFBIZ-666) on the dev and user  
> mailing lists have gone unanswered, so the UI Refactoring effort  
> has come to a screeching halt.

Welcome to the dark side of the... (community-driven open source world).

-David

[Adrian Crum]

David E. Jones wrote:
> Welcome to the dark side of the... (community-driven open source world).
>
> -David

lol - thanks!

I thoroughly understand that everyone is busy and I'm trying to be sensitive to
that. And that sentence wasn't meant as a complaint btw. I was just stating that
is where things are right now.

[cjhowe]

--- Adrian Crum <[hidden email]> wrote:

> David E. Jones wrote:
> > Welcome to the dark side of the... (community-driven open source
> world).
> >
> > -David
>
> lol - thanks!
>
> I thoroughly understand that everyone is busy and I'm trying to be
> sensitive to
> that. And that sentence wasn't meant as a complaint btw. I was just
> stating that
> is where things are right now.
>
>

Hey Adrian,
I have been intending to take a good look at your many improvements on
the whole, but have been recovering from foot-in-mouth disease with
regards to Asterisk PBX and Google Checkout integrations.  I think I'm
on the tail end of what my company will need for the Google Checkout
stuff so hopefully I'll be able to take that look at the UI refactoring
more seriously this week.  However Jacques endorsement of Andrew's
Selenium stuff may delay that look slightly :-) .  Lots of good stuff
becoming available to OFBiz this year!!  Speaking of which, when are
those additional new committers going to be added?
Regards,
Chris

[jonwimp]

Adrian,

Are your changes only in the maincss.css? If so, I'll test it quickly myself.

Last I recall, your changes involve merging tabstyles.css into maincss.css. Is this correct? If
so, there'd be many changes to many files that used to use tabstyles.css. Suggestion on how I can
test maincss.css if this is the case?

Sorry for lack of response, Adrian. Your issue with cleaning up the css files is close to my
heart. I hate having to grep through css files only to find a suitable style named "right-section"
that I'm forced to use for a footer --- ie I hate having to call for a "spanner" in order to get a
scalpel.

I understand it's not easy to create "container styles" for all of OFBiz; we might end up with
styles like "right-section", "right-section-with-a-diff", "right-section-with-more-diff". I
suggest we create very basic styles like "right-section", and then have UIs extend that style. Not
sure if I'm clear here, but that should be about as concise as I can manage to express my idea.

I'll look at the maincss.css file right away. Please advise further to aid my testing? Thanks.

Jonathon

PS: Beginning of March is also my deadline for my project!

Adrian Crum wrote:

> My requests for help with the new maincss.css file
> (https://issues.apache.org/jira/browse/OFBIZ-666) on the dev and user
> mailing lists have gone unanswered, so the UI Refactoring effort has
> come to a screeching halt. Jacques was able to test the new maincss.css
> file on one more browser - Opera - while evaluating the
> experimental_3.patch file
> (https://issues.apache.org/jira/browse/OFBIZ-633).
>
> In the meantime...
>
> Instead of creating a new umbrella Jira issue for this effort, I decided
> to use an existing issue that was already in that role -
> https://issues.apache.org/jira/browse/OFBIZ-241. I linked OFBIZ-241 to
> some of the "free floating" UI issues.
>
> Here are the tasks I would like to accomplish before the developers
> conference in March:
>
> 1. Get OFBIZ-666 committed to the project.
> 2. Submit a newer version of maincss.css to Jira - which can be used for
> the rest of this effort.
> 3. Post some refactoring guidelines and tips on OFBIZ-241.
>
> March is less than a month away. If the UI Refactoring effort is
> addressed at the developers conference, then it would be nice to have
> this groundwork completed beforehand.
>
> -Adrian
>
>

[jonwimp]

Hehe. Haha. I also have problems trying to explain the pitfalls of open source WITHIN the context
of my drive to adopt it.

Jonathon

David E. Jones wrote:

>
> On Feb 5, 2007, at 10:49 AM, Adrian Crum wrote:
>
>> My requests for help with the new maincss.css file
>> (https://issues.apache.org/jira/browse/OFBIZ-666) on the dev and user
>> mailing lists have gone unanswered, so the UI Refactoring effort has
>> come to a screeching halt.
>
> Welcome to the dark side of the... (community-driven open source world).
>
> -David
>
>
>

[Andrew Sykes]

Adrian,

I'm not sure if this is one for you or not, but here goes...

The entity reference page now has a large grey ("gray" for US guys) gap
between each of the related entities.

This seems like a really bad thing as the page is already massive, so
making it even bigger is a bit of a pain. Was this intentional?

I'm using FC3 and FF 1.5 in case that helps.
--
Kind Regards
Andrew Sykes <[hidden email]>
Sykes Development Ltd
http://www.sykesdevelopment.com

[Adrian Crum]

Chris Howe wrote:
> I have been intending to take a good look at your many improvements on
> the whole, but have been recovering from foot-in-mouth disease with
> regards to Asterisk PBX and Google Checkout integrations.  I think I'm
> on the tail end of what my company will need for the Google Checkout
> stuff so hopefully I'll be able to take that look at the UI refactoring
> more seriously this week.

That would be cool. I'm excited about the work you've done with PBX integration
- it is something we can use here. I'll take a closer look at your PBX work on
the other side of March.

[Adrian Crum]

Jonathon,

The OFBIZ-666 changes only affect maincss.css - the issue describes what it
does. The css file merge was accomplished a week or so ago.

Right now the holdup is testing on a Mac - I need someone with a Mac to try it out.

Thank you very much for your help!


Jonathon -- Improov wrote:

> Adrian,
>
> Are your changes only in the maincss.css? If so, I'll test it quickly
> myself.
>
> Last I recall, your changes involve merging tabstyles.css into
> maincss.css. Is this correct? If so, there'd be many changes to many
> files that used to use tabstyles.css. Suggestion on how I can test
> maincss.css if this is the case?
>
> Sorry for lack of response, Adrian. Your issue with cleaning up the css
> files is close to my heart. I hate having to grep through css files only
> to find a suitable style named "right-section" that I'm forced to use
> for a footer --- ie I hate having to call for a "spanner" in order to
> get a scalpel.
>
> I understand it's not easy to create "container styles" for all of
> OFBiz; we might end up with styles like "right-section",
> "right-section-with-a-diff", "right-section-with-more-diff". I suggest
> we create very basic styles like "right-section", and then have UIs
> extend that style. Not sure if I'm clear here, but that should be about
> as concise as I can manage to express my idea.
>
> I'll look at the maincss.css file right away. Please advise further to
> aid my testing? Thanks.
>
> Jonathon
>
> PS: Beginning of March is also my deadline for my project!
>
> Adrian Crum wrote:
>
>> My requests for help with the new maincss.css file
>> (https://issues.apache.org/jira/browse/OFBIZ-666) on the dev and user
>> mailing lists have gone unanswered, so the UI Refactoring effort has
>> come to a screeching halt. Jacques was able to test the new
>> maincss.css file on one more browser - Opera - while evaluating the
>> experimental_3.patch file
>> (https://issues.apache.org/jira/browse/OFBIZ-633).
>>
>> In the meantime...
>>
>> Instead of creating a new umbrella Jira issue for this effort, I
>> decided to use an existing issue that was already in that role -
>> https://issues.apache.org/jira/browse/OFBIZ-241. I linked OFBIZ-241 to
>> some of the "free floating" UI issues.
>>
>> Here are the tasks I would like to accomplish before the developers
>> conference in March:
>>
>> 1. Get OFBIZ-666 committed to the project.
>> 2. Submit a newer version of maincss.css to Jira - which can be used
>> for the rest of this effort.
>> 3. Post some refactoring guidelines and tips on OFBIZ-241.
>>
>> March is less than a month away. If the UI Refactoring effort is
>> addressed at the developers conference, then it would be nice to have
>> this groundwork completed beforehand.
>>
>> -Adrian
>>
>>
>
>

[Adrian Crum]

Thanks Andrew! I'll take a look at that.


Andrew Sykes wrote:

> Adrian,
>
> I'm not sure if this is one for you or not, but here goes...
>
> The entity reference page now has a large grey ("gray" for US guys) gap
> between each of the related entities.
>
> This seems like a really bad thing as the page is already massive, so
> making it even bigger is a bit of a pain. Was this intentional?
>
> I'm using FC3 and FF 1.5 in case that helps.

[Andrew Sykes]

Thanks Adrian,

Do you want an JIRA issue for it?

It's one of those things that I wasn't sure if it was a feature or a
bug ;-)

- Andrew

On Tue, 2007-02-06 at 08:03 -0800, Adrian Crum wrote:

> Thanks Andrew! I'll take a look at that.
>
>
> Andrew Sykes wrote:
>
> > Adrian,
> >
> > I'm not sure if this is one for you or not, but here goes...
> >
> > The entity reference page now has a large grey ("gray" for US guys) gap
> > between each of the related entities.
> >
> > This seems like a really bad thing as the page is already massive, so
> > making it even bigger is a bit of a pain. Was this intentional?
> >
> > I'm using FC3 and FF 1.5 in case that helps.

--
Kind Regards
Andrew Sykes <[hidden email]>
Sykes Development Ltd
http://www.sykesdevelopment.com

[Adrian Crum]

If there are no objections from the community, I'll just incorporate whatever
fix I come up with in the OFBIZ-666 patch. It already contains one UI fix-up.


Andrew Sykes wrote:

> Thanks Adrian,
>
> Do you want an JIRA issue for it?
>
> It's one of those things that I wasn't sure if it was a feature or a
> bug ;-)
>
> - Andrew
>
> On Tue, 2007-02-06 at 08:03 -0800, Adrian Crum wrote:
>
>>Thanks Andrew! I'll take a look at that.
>>
>>
>>Andrew Sykes wrote:
>>
>>
>>>Adrian,
>>>
>>>I'm not sure if this is one for you or not, but here goes...
>>>
>>>The entity reference page now has a large grey ("gray" for US guys) gap
>>>between each of the related entities.
>>>
>>>This seems like a really bad thing as the page is already massive, so
>>>making it even bigger is a bit of a pain. Was this intentional?
>>>
>>>I'm using FC3 and FF 1.5 in case that helps.

[Adrian Crum]

That gray gap is not the result of the new style sheet. The gray row is
intentional and it can be found in the EntityRefMain.ftl file, around line 120.

In this case, a Jira issue would be a good idea.


Adrian Crum wrote:

> If there are no objections from the community, I'll just incorporate
> whatever fix I come up with in the OFBIZ-666 patch. It already contains
> one UI fix-up.
>
>
> Andrew Sykes wrote:
>
>> Thanks Adrian,
>>
>> Do you want an JIRA issue for it?
>>
>> It's one of those things that I wasn't sure if it was a feature or a
>> bug ;-)
>>
>> - Andrew
>>
>> On Tue, 2007-02-06 at 08:03 -0800, Adrian Crum wrote:
>>
>>> Thanks Andrew! I'll take a look at that.
>>>
>>>
>>> Andrew Sykes wrote:
>>>
>>>
>>>> Adrian,
>>>>
>>>> I'm not sure if this is one for you or not, but here goes...
>>>>
>>>> The entity reference page now has a large grey ("gray" for US guys) gap
>>>> between each of the related entities.
>>>>
>>>> This seems like a really bad thing as the page is already massive, so
>>>> making it even bigger is a bit of a pain. Was this intentional?
>>>>
>>>> I'm using FC3 and FF 1.5 in case that helps.
>
>