Update: Screen Widget Refactor

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Update: Screen Widget Refactor

Adrian Crum-3
My volunteer time will be extremely limited starting next week, so I
have put the remaining widget refactoring work on the shelf.

I accomplished most of what I set out to do, but I wasn't able to do any
work on widget XML validation.

My hope is that this effort provides a springboard for others to
innovate in this area of the project.

I would like to backport the screen widget refactor to the R14 branch.
The refactor fixed innumerable bugs and flaws in the previous code. If
there are no strong objections, I will do the backport in a few days.

Thank you everyone for your patience while I worked on the problems
caused by the refactor.

--
Adrian Crum
Sandglass Software
www.sandglass-software.com
Reply | Threaded
Open this post in threaded view
|

Re: Update: Screen Widget Refactor

Jacques Le Roux
Administrator
Hi Adrian,

Sorry but I'm against this, or rather I have another suggestion to do. I will make it brief.

We decided to create a R14.12 freezed branch. Since then you worked on the screen widget refactor, I committed the SEO webapp in ecommerce:
https://cwiki.apache.org/confluence/display/OFBIZ/Search+Engine+Optimisation%2C+SEO+in+ecommerce and I'd like to also backport it to the R14 branch. I
guess others would want to backport their own work, etc.

My suggestion is to rename R14.12 to R15.02 and to tag it again and freeze it before the end of Feburary. Nothing forces us to have a release by year,
R15.02 is fine!

Jacques

Le 24/02/2015 22:32, Adrian Crum a écrit :

> My volunteer time will be extremely limited starting next week, so I have put the remaining widget refactoring work on the shelf.
>
> I accomplished most of what I set out to do, but I wasn't able to do any work on widget XML validation.
>
> My hope is that this effort provides a springboard for others to innovate in this area of the project.
>
> I would like to backport the screen widget refactor to the R14 branch. The refactor fixed innumerable bugs and flaws in the previous code. If there
> are no strong objections, I will do the backport in a few days.
>
> Thank you everyone for your patience while I worked on the problems caused by the refactor.
>
Reply | Threaded
Open this post in threaded view
|

Re: Update: Screen Widget Refactor

Jacques Le Roux
Administrator
Adrian,

You said
 >If there are no strong objections, I will do the backport in a few days.
But you didn't even care to reply to my suggestion. Nobody did and I find this very disappointing. Nobody care about what get backported to releases?

Why are you so eager to backport these changes? I know there were some issues you fixed, but it was working like that for years and there was no hurry.
Moreover, you have already fixed few bugs you introduced with the refactoring. So chances are they are some others waiting...

Yesterday evening, I though about it and I must say was a bit upset. At a point that I thought about vetoing this backport. Finally I will not because
I'm sure you will do diligence to fix the bug once reported.

But I feel very alone today

Jacques

Le 25/02/2015 11:01, Jacques Le Roux a écrit :

> Hi Adrian,
>
> Sorry but I'm against this, or rather I have another suggestion to do. I will make it brief.
>
> We decided to create a R14.12 freezed branch. Since then you worked on the screen widget refactor, I committed the SEO webapp in ecommerce:
> https://cwiki.apache.org/confluence/display/OFBIZ/Search+Engine+Optimisation%2C+SEO+in+ecommerce and I'd like to also backport it to the R14 branch.
> I guess others would want to backport their own work, etc.
>
> My suggestion is to rename R14.12 to R15.02 and to tag it again and freeze it before the end of Feburary. Nothing forces us to have a release by
> year, R15.02 is fine!
>
> Jacques
>
> Le 24/02/2015 22:32, Adrian Crum a écrit :
>> My volunteer time will be extremely limited starting next week, so I have put the remaining widget refactoring work on the shelf.
>>
>> I accomplished most of what I set out to do, but I wasn't able to do any work on widget XML validation.
>>
>> My hope is that this effort provides a springboard for others to innovate in this area of the project.
>>
>> I would like to backport the screen widget refactor to the R14 branch. The refactor fixed innumerable bugs and flaws in the previous code. If there
>> are no strong objections, I will do the backport in a few days.
>>
>> Thank you everyone for your patience while I worked on the problems caused by the refactor.
>>
>
Reply | Threaded
Open this post in threaded view
|

Re: Update: Screen Widget Refactor

Pierre Smits
Jacques,

You seem to forget that I have expressed my viewpoint on the subject of
what goes into release branches and subsequent releases at various
occasions. So have others.

We seem to avoid the opportunity to combine efforts to come up with a new
strategy that would help the project in this area.

Best regards,

Pierre Smits

*ORRTIZ.COM <http://www.orrtiz.com>*
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com

On Fri, Feb 27, 2015 at 10:24 AM, Jacques Le Roux <
[hidden email]> wrote:

> Adrian,
>
> You said
> >If there are no strong objections, I will do the backport in a few days.
> But you didn't even care to reply to my suggestion. Nobody did and I find
> this very disappointing. Nobody care about what get backported to releases?
>
> Why are you so eager to backport these changes? I know there were some
> issues you fixed, but it was working like that for years and there was no
> hurry.
> Moreover, you have already fixed few bugs you introduced with the
> refactoring. So chances are they are some others waiting...
>
> Yesterday evening, I though about it and I must say was a bit upset. At a
> point that I thought about vetoing this backport. Finally I will not
> because I'm sure you will do diligence to fix the bug once reported.
>
> But I feel very alone today
>
> Jacques
>
> Le 25/02/2015 11:01, Jacques Le Roux a écrit :
>
>  Hi Adrian,
>>
>> Sorry but I'm against this, or rather I have another suggestion to do. I
>> will make it brief.
>>
>> We decided to create a R14.12 freezed branch. Since then you worked on
>> the screen widget refactor, I committed the SEO webapp in ecommerce:
>> https://cwiki.apache.org/confluence/display/OFBIZ/
>> Search+Engine+Optimisation%2C+SEO+in+ecommerce and I'd like to also
>> backport it to the R14 branch. I guess others would want to backport their
>> own work, etc.
>>
>> My suggestion is to rename R14.12 to R15.02 and to tag it again and
>> freeze it before the end of Feburary. Nothing forces us to have a release
>> by year, R15.02 is fine!
>>
>> Jacques
>>
>> Le 24/02/2015 22:32, Adrian Crum a écrit :
>>
>>> My volunteer time will be extremely limited starting next week, so I
>>> have put the remaining widget refactoring work on the shelf.
>>>
>>> I accomplished most of what I set out to do, but I wasn't able to do any
>>> work on widget XML validation.
>>>
>>> My hope is that this effort provides a springboard for others to
>>> innovate in this area of the project.
>>>
>>> I would like to backport the screen widget refactor to the R14 branch.
>>> The refactor fixed innumerable bugs and flaws in the previous code. If
>>> there are no strong objections, I will do the backport in a few days.
>>>
>>> Thank you everyone for your patience while I worked on the problems
>>> caused by the refactor.
>>>
>>>
>>
Reply | Threaded
Open this post in threaded view
|

Re: Update: Screen Widget Refactor

Jacques Le Roux
Administrator
I will write something in the wiki, as I suggested in my last email of the recent "Release policy" thread

Jacques

Le 27/02/2015 10:34, Pierre Smits a écrit :

> Jacques,
>
> You seem to forget that I have expressed my viewpoint on the subject of
> what goes into release branches and subsequent releases at various
> occasions. So have others.
>
> We seem to avoid the opportunity to combine efforts to come up with a new
> strategy that would help the project in this area.
>
> Best regards,
>
> Pierre Smits
>
> *ORRTIZ.COM <http://www.orrtiz.com>*
> Services & Solutions for Cloud-
> Based Manufacturing, Professional
> Services and Retail & Trade
> http://www.orrtiz.com
>
> On Fri, Feb 27, 2015 at 10:24 AM, Jacques Le Roux <
> [hidden email]> wrote:
>
>> Adrian,
>>
>> You said
>>> If there are no strong objections, I will do the backport in a few days.
>> But you didn't even care to reply to my suggestion. Nobody did and I find
>> this very disappointing. Nobody care about what get backported to releases?
>>
>> Why are you so eager to backport these changes? I know there were some
>> issues you fixed, but it was working like that for years and there was no
>> hurry.
>> Moreover, you have already fixed few bugs you introduced with the
>> refactoring. So chances are they are some others waiting...
>>
>> Yesterday evening, I though about it and I must say was a bit upset. At a
>> point that I thought about vetoing this backport. Finally I will not
>> because I'm sure you will do diligence to fix the bug once reported.
>>
>> But I feel very alone today
>>
>> Jacques
>>
>> Le 25/02/2015 11:01, Jacques Le Roux a écrit :
>>
>>   Hi Adrian,
>>> Sorry but I'm against this, or rather I have another suggestion to do. I
>>> will make it brief.
>>>
>>> We decided to create a R14.12 freezed branch. Since then you worked on
>>> the screen widget refactor, I committed the SEO webapp in ecommerce:
>>> https://cwiki.apache.org/confluence/display/OFBIZ/
>>> Search+Engine+Optimisation%2C+SEO+in+ecommerce and I'd like to also
>>> backport it to the R14 branch. I guess others would want to backport their
>>> own work, etc.
>>>
>>> My suggestion is to rename R14.12 to R15.02 and to tag it again and
>>> freeze it before the end of Feburary. Nothing forces us to have a release
>>> by year, R15.02 is fine!
>>>
>>> Jacques
>>>
>>> Le 24/02/2015 22:32, Adrian Crum a écrit :
>>>
>>>> My volunteer time will be extremely limited starting next week, so I
>>>> have put the remaining widget refactoring work on the shelf.
>>>>
>>>> I accomplished most of what I set out to do, but I wasn't able to do any
>>>> work on widget XML validation.
>>>>
>>>> My hope is that this effort provides a springboard for others to
>>>> innovate in this area of the project.
>>>>
>>>> I would like to backport the screen widget refactor to the R14 branch.
>>>> The refactor fixed innumerable bugs and flaws in the previous code. If
>>>> there are no strong objections, I will do the backport in a few days.
>>>>
>>>> Thank you everyone for your patience while I worked on the problems
>>>> caused by the refactor.
>>>>
>>>>
Reply | Threaded
Open this post in threaded view
|

Re: Update: Screen Widget Refactor

Adrian Crum-3
In reply to this post by Pierre Smits
Jacques,

For some reason, your reply did not make it to my inbox.

I suggested backporting the widget refactor months ago, and at that time
there were some +1s and no objections.

I don't agree that bug fixes should not be backported if no one is
complaining about the bugs.

I didn't respond to your first reply because there was nothing to reply
to. You seemed to be opposed to the backport, but you did not state why.
You seem to suggest that if I do a backport, then everyone will want to
do a backport. I don't agree with that view.

If you want to veto the commit, then go ahead. I will revert it.

Adrian Crum
Sandglass Software
www.sandglass-software.com

On 2/27/2015 1:34 AM, Pierre Smits wrote:

> Jacques,
>
> You seem to forget that I have expressed my viewpoint on the subject of
> what goes into release branches and subsequent releases at various
> occasions. So have others.
>
> We seem to avoid the opportunity to combine efforts to come up with a new
> strategy that would help the project in this area.
>
> Best regards,
>
> Pierre Smits
>
> *ORRTIZ.COM <http://www.orrtiz.com>*
> Services & Solutions for Cloud-
> Based Manufacturing, Professional
> Services and Retail & Trade
> http://www.orrtiz.com
>
> On Fri, Feb 27, 2015 at 10:24 AM, Jacques Le Roux <
> [hidden email]> wrote:
>
>> Adrian,
>>
>> You said
>>> If there are no strong objections, I will do the backport in a few days.
>> But you didn't even care to reply to my suggestion. Nobody did and I find
>> this very disappointing. Nobody care about what get backported to releases?
>>
>> Why are you so eager to backport these changes? I know there were some
>> issues you fixed, but it was working like that for years and there was no
>> hurry.
>> Moreover, you have already fixed few bugs you introduced with the
>> refactoring. So chances are they are some others waiting...
>>
>> Yesterday evening, I though about it and I must say was a bit upset. At a
>> point that I thought about vetoing this backport. Finally I will not
>> because I'm sure you will do diligence to fix the bug once reported.
>>
>> But I feel very alone today
>>
>> Jacques
>>
>> Le 25/02/2015 11:01, Jacques Le Roux a écrit :
>>
>>   Hi Adrian,
>>>
>>> Sorry but I'm against this, or rather I have another suggestion to do. I
>>> will make it brief.
>>>
>>> We decided to create a R14.12 freezed branch. Since then you worked on
>>> the screen widget refactor, I committed the SEO webapp in ecommerce:
>>> https://cwiki.apache.org/confluence/display/OFBIZ/
>>> Search+Engine+Optimisation%2C+SEO+in+ecommerce and I'd like to also
>>> backport it to the R14 branch. I guess others would want to backport their
>>> own work, etc.
>>>
>>> My suggestion is to rename R14.12 to R15.02 and to tag it again and
>>> freeze it before the end of Feburary. Nothing forces us to have a release
>>> by year, R15.02 is fine!
>>>
>>> Jacques
>>>
>>> Le 24/02/2015 22:32, Adrian Crum a écrit :
>>>
>>>> My volunteer time will be extremely limited starting next week, so I
>>>> have put the remaining widget refactoring work on the shelf.
>>>>
>>>> I accomplished most of what I set out to do, but I wasn't able to do any
>>>> work on widget XML validation.
>>>>
>>>> My hope is that this effort provides a springboard for others to
>>>> innovate in this area of the project.
>>>>
>>>> I would like to backport the screen widget refactor to the R14 branch.
>>>> The refactor fixed innumerable bugs and flaws in the previous code. If
>>>> there are no strong objections, I will do the backport in a few days.
>>>>
>>>> Thank you everyone for your patience while I worked on the problems
>>>> caused by the refactor.
>>>>
>>>>
>>>
>
Reply | Threaded
Open this post in threaded view
|

Re: Update: Screen Widget Refactor

Jacques Le Roux
Administrator

Le 27/02/2015 17:19, Adrian Crum a écrit :
> Jacques,
>
> For some reason, your reply did not make it to my inbox.
>
> I suggested backporting the widget refactor months ago, and at that time there were some +1s and no objections.
>
> I don't agree that bug fixes should not be backported if no one is complaining about the bugs.

Who said that?

>
> I didn't respond to your first reply because there was nothing to reply to. You seemed to be opposed to the backport, but you did not state why. You
> seem to suggest that if I do a backport, then everyone will want to do a backport. I don't agree with that view.
>
> If you want to veto the commit, then go ahead. I will revert it.

Nope it's OK, I trust you.

Jacques

>
> Adrian Crum
> Sandglass Software
> www.sandglass-software.com
>
> On 2/27/2015 1:34 AM, Pierre Smits wrote:
>> Jacques,
>>
>> You seem to forget that I have expressed my viewpoint on the subject of
>> what goes into release branches and subsequent releases at various
>> occasions. So have others.
>>
>> We seem to avoid the opportunity to combine efforts to come up with a new
>> strategy that would help the project in this area.
>>
>> Best regards,
>>
>> Pierre Smits
>>
>> *ORRTIZ.COM <http://www.orrtiz.com>*
>> Services & Solutions for Cloud-
>> Based Manufacturing, Professional
>> Services and Retail & Trade
>> http://www.orrtiz.com
>>
>> On Fri, Feb 27, 2015 at 10:24 AM, Jacques Le Roux <
>> [hidden email]> wrote:
>>
>>> Adrian,
>>>
>>> You said
>>>> If there are no strong objections, I will do the backport in a few days.
>>> But you didn't even care to reply to my suggestion. Nobody did and I find
>>> this very disappointing. Nobody care about what get backported to releases?
>>>
>>> Why are you so eager to backport these changes? I know there were some
>>> issues you fixed, but it was working like that for years and there was no
>>> hurry.
>>> Moreover, you have already fixed few bugs you introduced with the
>>> refactoring. So chances are they are some others waiting...
>>>
>>> Yesterday evening, I though about it and I must say was a bit upset. At a
>>> point that I thought about vetoing this backport. Finally I will not
>>> because I'm sure you will do diligence to fix the bug once reported.
>>>
>>> But I feel very alone today
>>>
>>> Jacques
>>>
>>> Le 25/02/2015 11:01, Jacques Le Roux a écrit :
>>>
>>>   Hi Adrian,
>>>>
>>>> Sorry but I'm against this, or rather I have another suggestion to do. I
>>>> will make it brief.
>>>>
>>>> We decided to create a R14.12 freezed branch. Since then you worked on
>>>> the screen widget refactor, I committed the SEO webapp in ecommerce:
>>>> https://cwiki.apache.org/confluence/display/OFBIZ/
>>>> Search+Engine+Optimisation%2C+SEO+in+ecommerce and I'd like to also
>>>> backport it to the R14 branch. I guess others would want to backport their
>>>> own work, etc.
>>>>
>>>> My suggestion is to rename R14.12 to R15.02 and to tag it again and
>>>> freeze it before the end of Feburary. Nothing forces us to have a release
>>>> by year, R15.02 is fine!
>>>>
>>>> Jacques
>>>>
>>>> Le 24/02/2015 22:32, Adrian Crum a écrit :
>>>>
>>>>> My volunteer time will be extremely limited starting next week, so I
>>>>> have put the remaining widget refactoring work on the shelf.
>>>>>
>>>>> I accomplished most of what I set out to do, but I wasn't able to do any
>>>>> work on widget XML validation.
>>>>>
>>>>> My hope is that this effort provides a springboard for others to
>>>>> innovate in this area of the project.
>>>>>
>>>>> I would like to backport the screen widget refactor to the R14 branch.
>>>>> The refactor fixed innumerable bugs and flaws in the previous code. If
>>>>> there are no strong objections, I will do the backport in a few days.
>>>>>
>>>>> Thank you everyone for your patience while I worked on the problems
>>>>> caused by the refactor.
>>>>>
>>>>>
>>>>
>>
>