[VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
13 messages Options
Reply | Threaded
Open this post in threaded view
|

[VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version)

Jacopo Cappellato-3
This is the vote thread to release "Apache OFBiz 17.12.01": this is the
first release, containing the framework, applications and all the plugins
from the 17.12 release branches.

The release files can be downloaded from here:
https://dist.apache.org/repos/dist/dev/ofbiz/

and are:
* apache-ofbiz-17.12.01.zip
* KEYS: text file with keys
* apache-ofbiz-17.12.01.zip.asc: the detached signature file
* apache-ofbiz-17.12.01.zip.sha512: checksum file

Please download and test the zip file and verify the signature and checksum
(for instructions on testing the signatures see
http://www.apache.org/info/verification.html).

Vote:

[ +1] release as Apache OFBiz 17.12.01
[ -1] do not release

This vote will be open for 4 days.
For more details about this process please read
http://www.apache.org/foundation/voting.html
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version)

Michael Brohl-3
Hi Jacopo,

how do we handle the open issues in
https://issues.apache.org/jira/projects/OFBIZ/versions/12338772 ?

Will they be moved to 17.12.02 then?

Best regards,

Michael Brohl

ecomify GmbH - www.ecomify.de


Am 20.02.20 um 11:51 schrieb Jacopo Cappellato:

> This is the vote thread to release "Apache OFBiz 17.12.01": this is the
> first release, containing the framework, applications and all the plugins
> from the 17.12 release branches.
>
> The release files can be downloaded from here:
> https://dist.apache.org/repos/dist/dev/ofbiz/
>
> and are:
> * apache-ofbiz-17.12.01.zip
> * KEYS: text file with keys
> * apache-ofbiz-17.12.01.zip.asc: the detached signature file
> * apache-ofbiz-17.12.01.zip.sha512: checksum file
>
> Please download and test the zip file and verify the signature and checksum
> (for instructions on testing the signatures see
> http://www.apache.org/info/verification.html).
>
> Vote:
>
> [ +1] release as Apache OFBiz 17.12.01
> [ -1] do not release
>
> This vote will be open for 4 days.
> For more details about this process please read
> http://www.apache.org/foundation/voting.html
>


smime.p7s (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version)

Jacopo Cappellato-3
Yes, I was thinking to move them to 17.12.02 before creating the release
notes for 17.12.01

Jacopo

On Thu, Feb 20, 2020 at 12:04 PM Michael Brohl <[hidden email]>
wrote:

> Hi Jacopo,
>
> how do we handle the open issues in
> https://issues.apache.org/jira/projects/OFBIZ/versions/12338772 ?
>
> Will they be moved to 17.12.02 then?
>
> Best regards,
>
> Michael Brohl
>
> ecomify GmbH - www.ecomify.de
>
>
> Am 20.02.20 um 11:51 schrieb Jacopo Cappellato:
> > This is the vote thread to release "Apache OFBiz 17.12.01": this is the
> > first release, containing the framework, applications and all the plugins
> > from the 17.12 release branches.
> >
> > The release files can be downloaded from here:
> > https://dist.apache.org/repos/dist/dev/ofbiz/
> >
> > and are:
> > * apache-ofbiz-17.12.01.zip
> > * KEYS: text file with keys
> > * apache-ofbiz-17.12.01.zip.asc: the detached signature file
> > * apache-ofbiz-17.12.01.zip.sha512: checksum file
> >
> > Please download and test the zip file and verify the signature and
> checksum
> > (for instructions on testing the signatures see
> > http://www.apache.org/info/verification.html).
> >
> > Vote:
> >
> > [ +1] release as Apache OFBiz 17.12.01
> > [ -1] do not release
> >
> > This vote will be open for 4 days.
> > For more details about this process please read
> > http://www.apache.org/foundation/voting.html
> >
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version)

Michael Brohl-3
In reply to this post by Jacopo Cappellato-3
-1

~/Projects/apache-ofbiz/dist-apache-ofbiz-17.12.01 
../ofbiz-tools/verify-ofbiz-release.sh apache-ofbiz-17.12.01.zip
sha check of file: apache-ofbiz-17.12.01.zip
Using sha file: apache-ofbiz-17.12.01.zip.sha512
apache-ofbiz-17.12.01.zip: 663B1F39 B657E6FB 2D7097BC 657AC103 375ECA26
326DD3A1 73CEF112 ED4BD61E 05CB5679 88921E1F A2A26A88 7F88B7B1 B560566E
BCA57265 2BB57778 2B1B5AF1
apache-ofbiz-17.12.01.zip: 663B1F39 B657E6FB 2D7097BC 657AC103 375ECA26
326DD3A1 73CEF112 ED4BD61E 05CB5679 88921E1F A2A26A88 7F88B7B1 B560566E
BCA57265 2BB57778 2B1B5AF1
sha checksum OK

GPG verification output
gpg: Signature made Thu Feb 20 10:12:01 2020 CET using RSA key ID 847AF9E0
gpg: Good signature from "Jacopo Cappellato (CODE SIGNING KEY)
<[hidden email]>" [ultimate]


~/Projects/apache-ofbiz/dist-apache-ofbiz-17.12.01/apache-ofbiz-17.12.01
 ./gradlew loadAll testIntegration

...
:ofbiz --test FAILED
:createTestReports
Trying to override old definition of datatype junitreport

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':ofbiz --test'.
 > Process 'command
'/Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home/bin/java''
finished with non-zero exit value 1

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or
--debug option to get more log output.

BUILD FAILED


The following tests failed:


Class    Name    Status    Type    Time(s)
groupordertests    limitreached-test    Failure    ERROR: Could not
complete the Test GroupOrder the limit is reached
[file:/Users/mbrohl/Projects/apache-ofbiz/dist-apache-ofbiz-17.12.01/apache-ofbiz-17.12.01/applications/product/minilang/product/test/GroupOrderTest.xml#testGroupOrderLimitReached]
process [problem invoking the [createProductGroupOrder] service with the
map named [createProductGroupOrderMap] containing
[{userLogin=[GenericEntity:UserLogin][createdStamp,2020-02-20
15:18:47.661(java.sql.Timestamp)][createdTxStamp,2020-02-20
15:18:47.57(java.sql.Timestamp)][currentPassword,null()][disabledBy,null()][disabledDateTime,null()][enabled,N(java.lang.String)][externalAuthId,null()][hasLoggedOut,null()][isSystem,Y(java.lang.String)][lastCurrencyUom,null()][lastLocale,null()][lastTimeZone,null()][lastUpdatedStamp,2020-02-20
15:18:49.705(java.sql.Timestamp)][lastUpdatedTxStamp,2020-02-20
15:18:49.675(java.sql.Timestamp)][partyId,system(java.lang.String)][passwordHint,null()][requirePasswordChange,null()][successiveFailedLogins,null()][userLdapDn,null()][userLoginId,system(java.lang.String)],
fromDate=2020-02-20 15:21:22.25, productId=GZ-1000, statusId=GO_CREATED,
reqOrderQty=1, soldOrderQty=0, locale=en, thruDate=2020-02-21
15:21:22.25}]: Service [createProductGroupOrder] Failed (null)]

junit.framework.AssertionFailedError: ERROR: Could not complete the Test
GroupOrder the limit is reached
[file:/Users/mbrohl/Projects/apache-ofbiz/dist-apache-ofbiz-17.12.01/apache-ofbiz-17.12.01/applications/product/minilang/product/test/GroupOrderTest.xml#testGroupOrderLimitReached]
process [problem invoking the [createProductGroupOrder] service with the
map named [createProductGroupOrderMap] containing
[{userLogin=[GenericEntity:UserLogin][createdStamp,2020-02-20
15:18:47.661(java.sql.Timestamp)][createdTxStamp,2020-02-20
15:18:47.57(java.sql.Timestamp)][currentPassword,null()][disabledBy,null()][disabledDateTime,null()][enabled,N(java.lang.String)][externalAuthId,null()][hasLoggedOut,null()][isSystem,Y(java.lang.String)][lastCurrencyUom,null()][lastLocale,null()][lastTimeZone,null()][lastUpdatedStamp,2020-02-20
15:18:49.705(java.sql.Timestamp)][lastUpdatedTxStamp,2020-02-20
15:18:49.675(java.sql.Timestamp)][partyId,system(jaava.lang.String)][passwordHint,null()][requirePasswordChange,null()][successiveFailedLogins,null()][userLdapDn,null()][userLoginId,system(java.lang.String)],
fromDate=2020-02-20 15:21:22.25, productId=GZ-1000, statusId=GO_CREATED,
reqOrderQty=1, soldOrderQty=0, locale=en, thruDate=2020-02-21
15:21:22.25}]: Service [createProductGroupOrder] Failed (null)]
at org.apache.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:91)
at
org.apache.ofbiz.testtools.TestRunContainer.staart(TestRunContainer.java:89)
at
org.apacche.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:148)
at
org.apache.ofbiz.base.containerr.ContainerLoader.load(ContainerLoader.java:73)
at
org.apache.ofbiz.base.start.StartupControlPanel.loadStartupLoaders(StartupControlPanel.javva:218)
at
org.apache.ofbiz.bbase.start.StartupControlPanel.start(StartupControlPanel.java:71)
at org.apache.ofbiz.base.staart.Start.main(Start.java:85)
     0.018
groupordertests    limitnotreached-test    Failure    ERROR: Could not
complete the Test GroupOrder the limit is not reached
[file:/Users/mbrohl/Projects/apache-ofbiz/dist-apache-ofbiz-17.12.01/apache-ofbiz-17.12.01/applications/product/minilang/product/test/GroupOrderTest.xml#testGroupOrderLimitNotReached]
process [problem invoking the [createProductGroupOrder] service with the
map named [createProductGroupOrderMap] containing
[{userLogin=[GenericEntity:UserLogin][createdStamp,2020-02-20
15:18:47.661(java.sql.Timestamp)][createdTxStamp,2020-02-20
15:18:47.57(java.sql.Timestamp)][currentPassword,null()][disabledBy,null()][disabledDateTime,null()][enabled,N(java.lang.String)][externalAuthId,null()][hasLoggedOut,null()][isSystem,Y(java.lang.String)][lastCurrencyUom,null()][lastLocale,null()][lastTimeZone,null()][lastUpdatedStamp,2020-02-20
15:18:49.705(java.sql.Timestamp)][lastUpdatedTxStamp,2020-02-20
15:18:49.675(java.sql.Timestamp)][partyId,system(java.lang.String)][passwordHint,null()][requirePasswordChange,null()][successiveFailedLogins,null()][userLdapDn,null()][userLoginId,system(java.lang.String)],
fromDate=2020-02-20 15:21:22.261, productId=GZ-1001,
statusId=GO_CREATED, reqOrderQty=2, soldOrderQty=0, locale=en,
thruDate=2020-02-21 15:21:22.261}]: Service [createProductGroupOrder]
Failed (null)]

junit.framework.AssertionFailedError: ERROR: Could not complete the Test
GroupOrder the limit is not reached
[file:/Users/mbrohl/Projects/apache-ofbiz/dist-apache-ofbiz-17.12.01/apache-ofbiz-17.12.01/applications/product/minilang/product/test/GroupOrderTest.xml#testGroupOrderLimitNotReached]
process [problem invoking the [createProductGroupOrder] service with the
map named [createProductGroupOrderMap] containing
[{userLogin=[GenericEntity:UserLogin][createdStamp,2020-02-20
15:18:47.661(java.sql.Timestamp)][createdTxStamp,2020-02-20
15:18:47.57(java.sql.Timestamp)][currentPassword,null()][disabledBy,null()][disabledDateTime,null()][enabled,N(java.lang.String)][externalAuthId,null()][hasLoggedOut,null()][isSystem,Y(java.lang.String)][lastCurrencyUom,null()][lastLocale,null()][lastTimeZone,null()][lastUpdatedStamp,2020-02-20
15:18:49.705(java.sql.Timestamp)][lastUpdatedTxStamp,2020-02-20
15:18:49.675(java.sql.Timestamp)][partyId,system(java.lang.String)][passwordHint,null()][requirePasswordChange,null()][successiveFailedLogins,null()][userLdapDn,null()][userLoginId,system(java.lang.String)],
fromDate=2020-02-20 15:21:22.261, productId=GZ-1001,
statusId=GO_CREATED, reqOrderQty=2, soldOrderQty=0, locale=en,
thruDate=2020-02-21 15:21:22.261}]: Service [createProductGroupOrder]
Failed (null)]
at org.apache.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:91)
at
org.apache.ofbiz.testtools.TestRunContainer.staart(TestRunContainer.java:89)
at
org.apacche.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:148)
at
org.apache.ofbiz.base.containerr.ContainerLoader.load(ContainerLoader.java:73)
at
org.apache.ofbiz.base.start.StartupControlPanel.loadStartupLoaders(StartupControlPanel.javva:218)
at
org.apache.ofbiz.bbase.start.StartupControlPanel.start(StartupControlPanel.java:71)
at org.apache.ofbiz.base.staart.Start.main(Start.java:85)


Can someone confirm that this is not depending on my environment somehow?

Thanks,

Michael



Am 20.02.20 um 11:51 schrieb Jacopo Cappellato:

> This is the vote thread to release "Apache OFBiz 17.12.01": this is the
> first release, containing the framework, applications and all the plugins
> from the 17.12 release branches.
>
> The release files can be downloaded from here:
> https://dist.apache.org/repos/dist/dev/ofbiz/
>
> and are:
> * apache-ofbiz-17.12.01.zip
> * KEYS: text file with keys
> * apache-ofbiz-17.12.01.zip.asc: the detached signature file
> * apache-ofbiz-17.12.01.zip.sha512: checksum file
>
> Please download and test the zip file and verify the signature and checksum
> (for instructions on testing the signatures see
> http://www.apache.org/info/verification.html).
>
> Vote:
>
> [ +1] release as Apache OFBiz 17.12.01
> [ -1] do not release
>
> This vote will be open for 4 days.
> For more details about this process please read
> http://www.apache.org/foundation/voting.html
>


smime.p7s (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version)

Jacopo Cappellato-3
On Thu, Feb 20, 2020 at 3:36 PM Michael Brohl <[hidden email]>
wrote:

> [...]
> Can someone confirm that this is not depending on my environment somehow?
>

Weird, tests all passed in my environment. I have just re-run them now and
it worked again. I am curious to get the feedback from others.

Jacopo
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version)

Michael Brohl-3
My environment ist MacOS 10.14.6 Mojave, Adopt OpenJDK 1.8.0_232

I just unzipped the archive, cd'd into the folder and ran ./gradlew
loadAll testIntegration

Michael


Am 20.02.20 um 16:05 schrieb Jacopo Cappellato:

> On Thu, Feb 20, 2020 at 3:36 PM Michael Brohl <[hidden email]>
> wrote:
>
>> [...]
>> Can someone confirm that this is not depending on my environment somehow?
>>
> Weird, tests all passed in my environment. I have just re-run them now and
> it worked again. I am curious to get the feedback from others.
>
> Jacopo
>


smime.p7s (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version)

Nicolas Malin-2
In reply to this post by Jacopo Cappellato-3
On 20/02/2020 16:05, Jacopo Cappellato wrote:

> On Thu, Feb 20, 2020 at 3:36 PM Michael Brohl <[hidden email]>
> wrote:
>
>> [...]
>> Can someone confirm that this is not depending on my environment somehow?
>>
> Weird, tests all passed in my environment. I have just re-run them now and
> it worked again. I am curious to get the feedback from others.
>
> Jacopo
>
Same here,

Tests finished with successful from my environment (openjdk 1.8.0_242)

Nicolas


pEpkey.asc (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version)

Nicolas Malin-2
In reply to this post by Jacopo Cappellato-3
Jacopo,

During my check I saw that this archive contains the gradle wrapper.
It's a forget or just me that not understand the finality of
https://issues.apache.org/jira/browse/OFBIZ-10145

Nicolas

On 20/02/2020 11:51, Jacopo Cappellato wrote:

> This is the vote thread to release "Apache OFBiz 17.12.01": this is the
> first release, containing the framework, applications and all the plugins
> from the 17.12 release branches.
>
> The release files can be downloaded from here:
> https://dist.apache.org/repos/dist/dev/ofbiz/
>
> and are:
> * apache-ofbiz-17.12.01.zip
> * KEYS: text file with keys
> * apache-ofbiz-17.12.01.zip.asc: the detached signature file
> * apache-ofbiz-17.12.01.zip.sha512: checksum file
>
> Please download and test the zip file and verify the signature and checksum
> (for instructions on testing the signatures see
> http://www.apache.org/info/verification.html).
>
> Vote:
>
> [ +1] release as Apache OFBiz 17.12.01
> [ -1] do not release
>
> This vote will be open for 4 days.
> For more details about this process please read
> http://www.apache.org/foundation/voting.html
>

pEpkey.asc (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version)

Michael Brohl-3
In reply to this post by Nicolas Malin-2
I now did

./gradlew cleanAll loadAll testIntegration

and my build is successful also. Weird but good for the release.

I'll vote again with this result if noone else has problems.

Thanks,

Michael


Am 20.02.20 um 16:22 schrieb Nicolas Malin:

> On 20/02/2020 16:05, Jacopo Cappellato wrote:
>> On Thu, Feb 20, 2020 at 3:36 PM Michael Brohl <[hidden email]>
>> wrote:
>>
>>> [...]
>>> Can someone confirm that this is not depending on my environment somehow?
>>>
>> Weird, tests all passed in my environment. I have just re-run them now and
>> it worked again. I am curious to get the feedback from others.
>>
>> Jacopo
>>
> Same here,
>
> Tests finished with successful from my environment (openjdk 1.8.0_242)
>
> Nicolas
>


smime.p7s (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version)

Jacopo Cappellato-3
In reply to this post by Nicolas Malin-2
On Thu, Feb 20, 2020 at 4:26 PM Nicolas Malin <[hidden email]>
wrote:

> Jacopo,
>
> During my check I saw that this archive contains the gradle wrapper.
> It's a forget or just me that not understand the finality of
> https://issues.apache.org/jira/browse/OFBIZ-10145
>
> Nicolas


This is a good catch Nicolas!
With all the back and forth and several comments in that ticket I don't
recall what was the final decision: should I simply remove the
gradle-wrapper.jar file from the release archive? I guess we should also
update our README file with the step to run the init-gradle-wrapper.sh
script: any committer/volunteer to perform this task in the trunk and in
our two release branches?
Once this is done I will prepare new files and start a new vote.

Thanks,

Jacopo
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version)

Jacopo Cappellato-3
Please review below the new section that I have added to the README
documents that will be part of the release, to document how to get the
Gradle wrapper; in my opinion we should remove the wrapper from the trunk
and from all the release branches and include these notes in all the README
files, but this is a discussion for another day, for now I will be focusing
on this release only.

Thanks

Jacopo


=======================================================
diff --git a/README.adoc b/README.adoc
index e606462428..18b8d0420f 100644
--- a/README.adoc
+++ b/README.adoc
@@ -69,6 +69,13 @@
https://medium.com/@javachampions/java-is-still-free-2-0-0-6b9aa8d6d244[To
know
 To quickly install and fire-up OFBiz, please follow the below instructions
from
 the command line at the OFBiz top level directory (folder).

+[[download-the-gradle-wrapper]]
+=== Download the Gradle wrapper:
+
+MS Windows: `init-gradle-wrapper`
+
+Unix-like OS: `./gradle/init-gradle-wrapper`
+
 [[prepare-ofbiz]]
 === Prepare OFBiz:

diff --git a/README.md b/README.md
index 33c394ff67..4dabb2f5c7 100644
--- a/README.md
+++ b/README.md
@@ -59,6 +59,14 @@ from the command line at the OFBiz top level directory
(folder)

 In case of problems visit our [Further reading section](#further-reading)

+### Download the Gradle wrapper:
+
+MS Windows:
+`init-gradle-wrapper.bat`
+
+Unix-like OS:
+`./gradle/init-gradle-wrapper`
+
 ### Prepare OFBiz:

 >_Note_: Depending on your Internet connection speed it might take a long
=======================================================

On Thu, Feb 20, 2020 at 4:57 PM Jacopo Cappellato <
[hidden email]> wrote:

> On Thu, Feb 20, 2020 at 4:26 PM Nicolas Malin <[hidden email]>
> wrote:
>
>> Jacopo,
>>
>> During my check I saw that this archive contains the gradle wrapper.
>> It's a forget or just me that not understand the finality of
>> https://issues.apache.org/jira/browse/OFBIZ-10145
>>
>> Nicolas
>
>
> This is a good catch Nicolas!
> With all the back and forth and several comments in that ticket I don't
> recall what was the final decision: should I simply remove the
> gradle-wrapper.jar file from the release archive? I guess we should also
> update our README file with the step to run the init-gradle-wrapper.sh
> script: any committer/volunteer to perform this task in the trunk and in
> our two release branches?
> Once this is done I will prepare new files and start a new vote.
>
> Thanks,
>
> Jacopo
>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version)

Jacopo Cappellato-3
In reply to this post by Jacopo Cappellato-3
This vote has been cancelled, I am going to start a new vote thread.

Thanks,

Jacopo


On Thu, Feb 20, 2020 at 11:51 AM Jacopo Cappellato <
[hidden email]> wrote:

> This is the vote thread to release "Apache OFBiz 17.12.01": this is the
> first release, containing the framework, applications and all the plugins
> from the 17.12 release branches.
>
> The release files can be downloaded from here:
> https://dist.apache.org/repos/dist/dev/ofbiz/
>
> and are:
> * apache-ofbiz-17.12.01.zip
> * KEYS: text file with keys
> * apache-ofbiz-17.12.01.zip.asc: the detached signature file
> * apache-ofbiz-17.12.01.zip.sha512: checksum file
>
> Please download and test the zip file and verify the signature and
> checksum (for instructions on testing the signatures see
> http://www.apache.org/info/verification.html).
>
> Vote:
>
> [ +1] release as Apache OFBiz 17.12.01
> [ -1] do not release
>
> This vote will be open for 4 days.
> For more details about this process please read
> http://www.apache.org/foundation/voting.html
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version)

Nicolas Malin-2
In reply to this post by Jacopo Cappellato-3
Hi Jacopo, sorry for the latency,

I took some time to control the README.md from the 16.11.07 and it
contains information to download the wrapper.

I think this came from decision to remove the wrapper only on release
and keep it on source code.

Your proposal is good to fix quickly the problem. I will synchronize the
README on branches and trunk.

Nicolas

On 21/02/2020 08:13, Jacopo Cappellato wrote:

> Please review below the new section that I have added to the README
> documents that will be part of the release, to document how to get the
> Gradle wrapper; in my opinion we should remove the wrapper from the trunk
> and from all the release branches and include these notes in all the README
> files, but this is a discussion for another day, for now I will be focusing
> on this release only.
>
> Thanks
>
> Jacopo
>
>
> =======================================================
> diff --git a/README.adoc b/README.adoc
> index e606462428..18b8d0420f 100644
> --- a/README.adoc
> +++ b/README.adoc
> @@ -69,6 +69,13 @@
> https://medium.com/@javachampions/java-is-still-free-2-0-0-6b9aa8d6d244[To
> know
>  To quickly install and fire-up OFBiz, please follow the below instructions
> from
>  the command line at the OFBiz top level directory (folder).
>
> +[[download-the-gradle-wrapper]]
> +=== Download the Gradle wrapper:
> +
> +MS Windows: `init-gradle-wrapper`
> +
> +Unix-like OS: `./gradle/init-gradle-wrapper`
> +
>  [[prepare-ofbiz]]
>  === Prepare OFBiz:
>
> diff --git a/README.md b/README.md
> index 33c394ff67..4dabb2f5c7 100644
> --- a/README.md
> +++ b/README.md
> @@ -59,6 +59,14 @@ from the command line at the OFBiz top level directory
> (folder)
>
>  In case of problems visit our [Further reading section](#further-reading)
>
> +### Download the Gradle wrapper:
> +
> +MS Windows:
> +`init-gradle-wrapper.bat`
> +
> +Unix-like OS:
> +`./gradle/init-gradle-wrapper`
> +
>  ### Prepare OFBiz:
>
>  >_Note_: Depending on your Internet connection speed it might take a long
> =======================================================
>
> On Thu, Feb 20, 2020 at 4:57 PM Jacopo Cappellato <
> [hidden email]> wrote:
>
>> On Thu, Feb 20, 2020 at 4:26 PM Nicolas Malin <[hidden email]>
>> wrote:
>>
>>> Jacopo,
>>>
>>> During my check I saw that this archive contains the gradle wrapper.
>>> It's a forget or just me that not understand the finality of
>>> https://issues.apache.org/jira/browse/OFBIZ-10145
>>>
>>> Nicolas
>>
>> This is a good catch Nicolas!
>> With all the back and forth and several comments in that ticket I don't
>> recall what was the final decision: should I simply remove the
>> gradle-wrapper.jar file from the release archive? I guess we should also
>> update our README file with the step to run the init-gradle-wrapper.sh
>> script: any committer/volunteer to perform this task in the trunk and in
>> our two release branches?
>> Once this is done I will prepare new files and start a new vote.
>>
>> Thanks,
>>
>> Jacopo
>>
>>
>>

pEpkey.asc (2K) Download Attachment