View Relations page errors out

[Atul Vani]

Didn't get a chance to look into it yet, but there is some bug due to  
recent changes.
https://demo-stable.ofbiz.apache.org:8443/webtools/control/ViewRelations?entityName=Product

--
Using Opera's revolutionary email client: http://www.opera.com/mail/

[Adrian Crum-3]

Thank you for reporting it. I will take care of it.

-Adrian

On 5/8/2013 12:55 PM, Atul Vani wrote:
> Didn't get a chance to look into it yet, but there is some bug due to
> recent changes.
> https://demo-stable.ofbiz.apache.org:8443/webtools/control/ViewRelations?entityName=Product 
>
>

[Adrian Crum-3]

Fixed in revision 1480248.

-Adrian

On 5/8/2013 12:59 PM, Adrian Crum wrote:

> Thank you for reporting it. I will take care of it.
>
> -Adrian
>
> On 5/8/2013 12:55 PM, Atul Vani wrote:
>> Didn't get a chance to look into it yet, but there is some bug due to
>> recent changes.
>> https://demo-stable.ofbiz.apache.org:8443/webtools/control/ViewRelations?entityName=Product 
>>
>>
>

[Atul Vani]

Thanks Adrian.

On Wed, 08 May 2013 17:57:38 +0530, Adrian Crum  
<[hidden email]> wrote:

> Fixed in revision 1480248.
>
> -Adrian
>
> On 5/8/2013 12:59 PM, Adrian Crum wrote:
>> Thank you for reporting it. I will take care of it.
>>
>> -Adrian
>>
>> On 5/8/2013 12:55 PM, Atul Vani wrote:
>>> Didn't get a chance to look into it yet, but there is some bug due to  
>>> recent changes.
>>> https://demo-stable.ofbiz.apache.org:8443/webtools/control/ViewRelations?entityName=Product
>>
>

--
Using Opera's revolutionary email client: http://www.opera.com/mail/

[olivier.heintz Neogia.org]

similar problem in ViewGeneric.groovy

---framework/webtools/webapp/webtools/WEB-INF/actions/entity/ViewGeneric.groovy (3890402ee3d1bfccb7b058d3fbfc9109ba5dfac9)
+++framework/webtools/webapp/webtools/WEB-INF/actions/entity/ViewGeneric.groovy
@@ -399,14 +399,14 @@
                      mapRelation.put("valueRelatedPk", valueRelated.getPrimaryKey().toString());
                  }
                  mapRelation.put("relatedFieldsList", relatedFieldsList);
                  mapRelation.put("relType", "one");
 
                  String findString = "entityName=" + relatedEntity.getEntityName();
-                for (int knum = 0; knum < relation.getKeyMapsSize(); knum++) {
-                    ModelKeyMap keyMap = relation.getKeyMap(knum);
+                for (int knum = 0; knum < relation.getKeyMaps().size(); knum++) {
+                    ModelKeyMap keyMap = relation.getKeyMaps().get(knum);
                      if (value.get(keyMap.getFieldName()) != null) {
                          findString += "&" + keyMap.getRelFieldName() + "=" + value.get(keyMap.getFieldName());
                      }
                  }
                  String encodeFindString = UtilFormatOut.encodeQuery(findString);
                  mapRelation.put("encodeRelatedEntityFindString", encodeFindString);
@@ -417,14 +417,14 @@
      } else if (relation.getType().equalsIgnoreCase("many")) {
          if (value != null) {
              if (hasAllView || security.hasEntityPermission(relatedEntity.getPlainTableName(), "_VIEW", session)) {
                  mapRelation.put("relType", "many");
 
                  String findString = "entityName=" + relatedEntity.getEntityName();
-                for (int knum = 0; knum < relation.getKeyMapsSize(); knum++) {
-                    ModelKeyMap keyMap = relation.getKeyMap(knum);
+                for (int knum = 0; knum < relation.getKeyMaps().size(); knum++) {
+                    ModelKeyMap keyMap = relation.getKeyMaps().get(knum);
                      if (value.get(keyMap.getFieldName()) != null) {
                          findString += "&" + keyMap.getRelFieldName() + "=" + value.get(keyMap.getFieldName());
                      }
                  }
                  String encodeFindString = UtilFormatOut.encodeQuery(findString);
                  mapRelation.put("encodeRelatedEntityFindString", encodeFindString);




Le 08/05/2013 14:27, Adrian Crum a écrit :

> Fixed in revision 1480248.
>
> -Adrian
>
> On 5/8/2013 12:59 PM, Adrian Crum wrote:
>> Thank you for reporting it. I will take care of it.
>>
>> -Adrian
>>
>> On 5/8/2013 12:55 PM, Atul Vani wrote:
>>> Didn't get a chance to look into it yet, but there is some bug due
>>> to recent changes.
>>> https://demo-stable.ofbiz.apache.org:8443/webtools/control/ViewRelations?entityName=Product 
>>>
>>>
>>
>
>

[Adrian Crum-3]

Fixed in revision 1480702.

-Adrian

On 5/9/2013 3:18 PM, olivier Heintz wrote:

> similar problem in ViewGeneric.groovy
>
> ---framework/webtools/webapp/webtools/WEB-INF/actions/entity/ViewGeneric.groovy
> (3890402ee3d1bfccb7b058d3fbfc9109ba5dfac9)
> +++framework/webtools/webapp/webtools/WEB-INF/actions/entity/ViewGeneric.groovy
>
> @@ -399,14 +399,14 @@
>                      mapRelation.put("valueRelatedPk",
> valueRelated.getPrimaryKey().toString());
>                  }
>                  mapRelation.put("relatedFieldsList", relatedFieldsList);
>                  mapRelation.put("relType", "one");
>
>                  String findString = "entityName=" +
> relatedEntity.getEntityName();
> -                for (int knum = 0; knum < relation.getKeyMapsSize();
> knum++) {
> -                    ModelKeyMap keyMap = relation.getKeyMap(knum);
> +                for (int knum = 0; knum <
> relation.getKeyMaps().size(); knum++) {
> +                    ModelKeyMap keyMap =
> relation.getKeyMaps().get(knum);
>                      if (value.get(keyMap.getFieldName()) != null) {
>                          findString += "&" + keyMap.getRelFieldName()
> + "=" + value.get(keyMap.getFieldName());
>                      }
>                  }
>                  String encodeFindString =
> UtilFormatOut.encodeQuery(findString);
>                  mapRelation.put("encodeRelatedEntityFindString",
> encodeFindString);
> @@ -417,14 +417,14 @@
>      } else if (relation.getType().equalsIgnoreCase("many")) {
>          if (value != null) {
>              if (hasAllView ||
> security.hasEntityPermission(relatedEntity.getPlainTableName(),
> "_VIEW", session)) {
>                  mapRelation.put("relType", "many");
>
>                  String findString = "entityName=" +
> relatedEntity.getEntityName();
> -                for (int knum = 0; knum < relation.getKeyMapsSize();
> knum++) {
> -                    ModelKeyMap keyMap = relation.getKeyMap(knum);
> +                for (int knum = 0; knum <
> relation.getKeyMaps().size(); knum++) {
> +                    ModelKeyMap keyMap =
> relation.getKeyMaps().get(knum);
>                      if (value.get(keyMap.getFieldName()) != null) {
>                          findString += "&" + keyMap.getRelFieldName()
> + "=" + value.get(keyMap.getFieldName());
>                      }
>                  }
>                  String encodeFindString =
> UtilFormatOut.encodeQuery(findString);
>                  mapRelation.put("encodeRelatedEntityFindString",
> encodeFindString);
>
>
>
>
> Le 08/05/2013 14:27, Adrian Crum a écrit :
>> Fixed in revision 1480248.
>>
>> -Adrian
>>
>> On 5/8/2013 12:59 PM, Adrian Crum wrote:
>>> Thank you for reporting it. I will take care of it.
>>>
>>> -Adrian
>>>
>>> On 5/8/2013 12:55 PM, Atul Vani wrote:
>>>> Didn't get a chance to look into it yet, but there is some bug due
>>>> to recent changes.
>>>> https://demo-stable.ofbiz.apache.org:8443/webtools/control/ViewRelations?entityName=Product 
>>>>
>>>>
>>>
>>
>>
>
>

[olivier.heintz Neogia.org]

Thank you Adrian

Le 09/05/2013 17:59, Adrian Crum a écrit :

> Fixed in revision 1480702.
>
> -Adrian
>
> On 5/9/2013 3:18 PM, olivier Heintz wrote:
>> similar problem in ViewGeneric.groovy
>>
>> ---framework/webtools/webapp/webtools/WEB-INF/actions/entity/ViewGeneric.groovy
>> (3890402ee3d1bfccb7b058d3fbfc9109ba5dfac9)
>> +++framework/webtools/webapp/webtools/WEB-INF/actions/entity/ViewGeneric.groovy
>>
>> @@ -399,14 +399,14 @@
>>                      mapRelation.put("valueRelatedPk",
>> valueRelated.getPrimaryKey().toString());
>>                  }
>>                  mapRelation.put("relatedFieldsList",
>> relatedFieldsList);
>>                  mapRelation.put("relType", "one");
>>
>>                  String findString = "entityName=" +
>> relatedEntity.getEntityName();
>> -                for (int knum = 0; knum < relation.getKeyMapsSize();
>> knum++) {
>> -                    ModelKeyMap keyMap = relation.getKeyMap(knum);
>> +                for (int knum = 0; knum <
>> relation.getKeyMaps().size(); knum++) {
>> +                    ModelKeyMap keyMap =
>> relation.getKeyMaps().get(knum);
>>                      if (value.get(keyMap.getFieldName()) != null) {
>>                          findString += "&" + keyMap.getRelFieldName()
>> + "=" + value.get(keyMap.getFieldName());
>>                      }
>>                  }
>>                  String encodeFindString =
>> UtilFormatOut.encodeQuery(findString);
>> mapRelation.put("encodeRelatedEntityFindString", encodeFindString);
>> @@ -417,14 +417,14 @@
>>      } else if (relation.getType().equalsIgnoreCase("many")) {
>>          if (value != null) {
>>              if (hasAllView ||
>> security.hasEntityPermission(relatedEntity.getPlainTableName(),
>> "_VIEW", session)) {
>>                  mapRelation.put("relType", "many");
>>
>>                  String findString = "entityName=" +
>> relatedEntity.getEntityName();
>> -                for (int knum = 0; knum < relation.getKeyMapsSize();
>> knum++) {
>> -                    ModelKeyMap keyMap = relation.getKeyMap(knum);
>> +                for (int knum = 0; knum <
>> relation.getKeyMaps().size(); knum++) {
>> +                    ModelKeyMap keyMap =
>> relation.getKeyMaps().get(knum);
>>                      if (value.get(keyMap.getFieldName()) != null) {
>>                          findString += "&" + keyMap.getRelFieldName()
>> + "=" + value.get(keyMap.getFieldName());
>>                      }
>>                  }
>>                  String encodeFindString =
>> UtilFormatOut.encodeQuery(findString);
>> mapRelation.put("encodeRelatedEntityFindString", encodeFindString);
>>
>>
>>
>>
>> Le 08/05/2013 14:27, Adrian Crum a écrit :
>>> Fixed in revision 1480248.
>>>
>>> -Adrian
>>>
>>> On 5/8/2013 12:59 PM, Adrian Crum wrote:
>>>> Thank you for reporting it. I will take care of it.
>>>>
>>>> -Adrian
>>>>
>>>> On 5/8/2013 12:55 PM, Atul Vani wrote:
>>>>> Didn't get a chance to look into it yet, but there is some bug due
>>>>> to recent changes.
>>>>> https://demo-stable.ofbiz.apache.org:8443/webtools/control/ViewRelations?entityName=Product 
>>>>>
>>>>>
>>>>
>>>
>>>
>>
>>
>
>