Webapp mount-point="/" problem in ofbiz trunk

[iwolf]

Hello,

I am facing a problem when trying a webapp with mount-point="/" with the current trunk.

running localhost:8080 --> ecommerce starts without problems. Clicking on a category in the category tree i get the following:

org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://ecommerce/widget/CatalogScreens.xml#newbreadcrumbs]: java.lang.StringIndexOutOfBoundsException: String index out of range: -1 (String index out of range: -1)

My settings:
in ecommerce webapp:
mount-point="/" - no further changes.

build - load-demo - start

I fails in:
trunk Rev:1581712
trunk Rev:13.04 Rev:1581394

It works with 12.04 Rev:1581396

I would like to port an existing ofbiz onlineshop from 12.04 to 13.03/trunk without showing "ecommerce" in the url.

As far as I tracked down the problem by now it is connected to "ofbizCatalogAltUrl".

Before I dig in deeper I would like to know if the support for mount-point="/" has fall by indention?

Thanks for any info.
Ingo

[iwolf]

Further findings:

The problem is that in

../applications/products/src/org/ofbiz/product/category/CatalogUrlFIlter.java

request.getContextPath() is ""

Therefore

            if (urlBuilder.charAt(urlBuilder.length() - 1) != '/') {
                urlBuilder.append("/");
            }

will not work. As I am quite new to ofbiz, could anyone tell me if this is something that could be configured (current mis-configuration) or should this be catched in code like:

           if(contextPath ==""){
            contextPath = "/";
            }

[Jacques Le Roux]

You might be interested by this comment https://issues.apache.org/jira/browse/OFBIZ-5312?focusedCommentId=13944254 (and the few last ones above)
The branch which support this change is https://svn.apache.org/repos/asf/ofbiz/branches/OFBIZ-5312-ofbiz-ecommerce-seo-2013-10-23 (it synced with
trunk every week)

You might prefer the moment where I will create an ecomseo component. Unfortunately I'm quite busy at the moment and I don't expect it in the next weeks

Jacques

Le 26/03/2014 17:51, iwolf a écrit :

> Further findings:
>
> The problem is that in
>
> ../applications/products/src/org/ofbiz/product/category/CatalogUrlFIlter.java
>
> request.getContextPath() is ""
>
> Therefore
>
>              if (urlBuilder.charAt(urlBuilder.length() - 1) != '/') {
>                  urlBuilder.append("/");
>              }
>
> will not work. As I am quite new to ofbiz, could anyone tell me if this is
> something that could be configured (current mis-configuration) or should
> this be catched in code like:
>
>             if(contextPath ==""){
>               contextPath = "/";
>              }
>
>
>
> --
> View this message in context: http://ofbiz.135035.n4.nabble.com/Webapp-mount-point-problem-in-ofbiz-trunk-tp4649827p4649853.html
> Sent from the OFBiz - User mailing list archive at Nabble.com.
>

--
Jacques Le Roux
400E Chemin de la Mouline
34560 Poussan
33+(0)4 67 51 19 38
33+(0)6 11 19 50 28

[iwolf]

Hi Jacques,

thanks for the info. The SEO-branch works fine for my needs. Just one question. I can't get the "allowedPaths" defined in web.xml working (SeoContextFilter).I would need them to get "robots.txt" and "sitemap.xml" working again. Do you have a hint where I can start looking.

[Jacques Le Roux]

Ha sorry, forgot to answer, did you get it working since?

Jacques

Le 16/05/2014 14:58, iwolf a écrit :

> Hi Jacques,
>
> thanks for the info. The SEO-branch works fine for my needs. Just one
> question. I can't get the "allowedPaths" defined in web.xml working
> (SeoContextFilter).I would need them to get "robots.txt" and "sitemap.xml"
> working again. Do you have a hint where I can start looking.
>
>
>
> --
> View this message in context: http://ofbiz.135035.n4.nabble.com/Webapp-mount-point-problem-in-ofbiz-trunk-tp4649827p4651026.html
> Sent from the OFBiz - User mailing list archive at Nabble.com.
>

--

[iwolf]

Hi, no not by now. I am still searching.

[iwolf]

Hi Jaques,

I compared the current seo-branche with the current trunk. When it comes to context-filter I find the following difference:

SeoContextFilter
     [java] requestInfo:
     [java] httpRequest.getServletPath():
--> which results in a 404

ContextFilter
     [java] requestInfo: /*
     [java] httpRequest.getServletPath(): /robots.txt

Do you have an idea where the empty httpRequest.getServletPath() may come from?

Thanks,
Ingo

[Jacques Le Roux]

Le 08/06/2014 14:46, iwolf a écrit :

> Hi Jaques,
>
> I compared the current seo-branche with the current trunk. When it comes to
> context-filter I find the following difference:
>
> SeoContextFilter
>       [java] requestInfo:
>       [java] httpRequest.getServletPath():
> --> which results in a 404
>
> ContextFilter
>       [java] requestInfo: /*
>       [java] httpRequest.getServletPath(): /robots.txt
>
> Do you have an idea where the empty httpRequest.getServletPath() may come
> from?
>
> Thanks,
> Ingo
>
>
>
>
> --
> View this message in context: http://ofbiz.135035.n4.nabble.com/Webapp-mount-point-problem-in-ofbiz-trunk-tp4649827p4651407.html
> Sent from the OFBiz - User mailing list archive at Nabble.com.
>

--

[Jacques Le Roux]

Oops, sorry pushed the wrong button.

No I have no ideas yet, but I will have a look, thanks for the input!

Jacques

Le 09/06/2014 14:41, Jacques Le Roux a écrit :

>
> Le 08/06/2014 14:46, iwolf a écrit :
>> Hi Jaques,
>>
>> I compared the current seo-branche with the current trunk. When it comes to
>> context-filter I find the following difference:
>>
>> SeoContextFilter
>>       [java] requestInfo:
>>       [java] httpRequest.getServletPath():
>> --> which results in a 404
>>
>> ContextFilter
>>       [java] requestInfo: /*
>>       [java] httpRequest.getServletPath(): /robots.txt
>>
>> Do you have an idea where the empty httpRequest.getServletPath() may come
>> from?
>>
>> Thanks,
>> Ingo
>>
>>
>>
>>
>> --
>> View this message in context: http://ofbiz.135035.n4.nabble.com/Webapp-mount-point-problem-in-ofbiz-trunk-tp4649827p4651407.html
>> Sent from the OFBiz - User mailing list archive at Nabble.com.
>>
>

[iwolf]

Hi Jacques,

as I am still working to find the problem it seems that I found another one.

When sending the confirmation mail, the inluded urls (link to product, continue shopping) are missing the host information. Tested in actual trunk version vs. actual seo version.

Ingo

[Jacques Le Roux]

Thanks Ingo,

To keep things focused, could you report this, and your remark before, in comments at https://issues.apache.org/jira/browse/OFBIZ-5312 ?

Thanks

Jacques

Le 11/06/2014 12:16, iwolf a écrit :

> Hi Jacques,
>
> as I am still working to find the problem it seems that I found another one.
>
> When sending the confirmation mail, the inluded urls (link to product,
> continue shopping) are missing the host information. Tested in actual trunk
> version vs. actual seo version.
>
> Ingo
>
>
>
> --
> View this message in context: http://ofbiz.135035.n4.nabble.com/Webapp-mount-point-problem-in-ofbiz-trunk-tp4649827p4651433.html
> Sent from the OFBiz - User mailing list archive at Nabble.com.
>

--