Why README.md AND README.adoc in R17?

[Jacques Le Roux]

Hi All,

Is there a reason why we have README.md AND README.adoc in R17?

@Jacopo: also the final READMEs in 17.12.01 is adapted to the gradlew download thing, should the R17 not be so?

Thanks

Jacques

[Jacopo Cappellato-3]

On Wed, Apr 1, 2020 at 10:18 AM Jacques Le Roux <
[hidden email]> wrote:

> Hi All,
>
> Is there a reason why we have README.md AND README.adoc in R17?
>

We should definitely remove the former.


>
> @Jacopo: also the final READMEs in 17.12.01 is adapted to the gradlew
> download thing, should the R17 not be so?
>

IMO we should update R17 as well as all the relevant branches (including
trunk) AND remove the wrapper binaries from all of them.

Jacopo



>
> Thanks
>
> Jacques
>
>

[Michael Brohl-3]

Just look at your backport commit
fad06400e26c9b557b90c88dda5914b89794347b and answer yourself ;-)

Michael

Am 01.04.20 um 10:17 schrieb Jacques Le Roux:

> Hi All,
>
> Is there a reason why we have README.md AND README.adoc in R17?
>
> @Jacopo: also the final READMEs in 17.12.01 is adapted to the gradlew
> download thing, should the R17 not be so?
>
> Thanks
>
> Jacques
>

[Jacques Le Roux]

Hi Michael,

Yes just like you at  https://s.apache.org/8wsgr. I have the excuse of age :)

More seriously how do you get there? I find nothing in our MLs:

https://ofbiz.markmail.org/search/?q=fad06400e26c9b557b90c88dda5914b89794347b

https://ofbiz.markmail.org/search/?q=fad06400

Thanks

Jacques

Le 01/04/2020 à 10:23, Michael Brohl a écrit :

> Just look at your backport commit fad06400e26c9b557b90c88dda5914b89794347b and answer yourself ;-)
>
> Michael
>
> Am 01.04.20 um 10:17 schrieb Jacques Le Roux:
>> Hi All,
>>
>> Is there a reason why we have README.md AND README.adoc in R17?
>>
>> @Jacopo: also the final READMEs in 17.12.01 is adapted to the gradlew download thing, should the R17 not be so?
>>
>> Thanks
>>
>> Jacques
>>
>

[Michael Brohl-3]

Ah, age, yes... not sure if I am not able to use this as an excuse more
often given my age ;,-)

Not sure if I understand your question? I simply had a look at the
history for README.adoc and saw that you did the backport.

Regards,

Michael


Am 01.04.20 um 10:33 schrieb Jacques Le Roux:

> Hi Michael,
>
> Yes just like you at  https://s.apache.org/8wsgr. I have the excuse of
> age :)
>
> More seriously how do you get there? I find nothing in our MLs:
>
> https://ofbiz.markmail.org/search/?q=fad06400e26c9b557b90c88dda5914b89794347b 
>
>
> https://ofbiz.markmail.org/search/?q=fad06400
>
> Thanks
>
> Jacques
>
> Le 01/04/2020 à 10:23, Michael Brohl a écrit :
>> Just look at your backport commit
>> fad06400e26c9b557b90c88dda5914b89794347b and answer yourself ;-)
>>
>> Michael
>>
>> Am 01.04.20 um 10:17 schrieb Jacques Le Roux:
>>> Hi All,
>>>
>>> Is there a reason why we have README.md AND README.adoc in R17?
>>>
>>> @Jacopo: also the final READMEs in 17.12.01 is adapted to the
>>> gradlew download thing, should the R17 not be so?
>>>
>>> Thanks
>>>
>>> Jacques
>>>
>>

[Jacques Le Roux]

Le 01/04/2020 à 10:21, Jacopo Cappellato a écrit :
>> @Jacopo: also the final READMEs in 17.12.01 is adapted to the gradlew
>> download thing, should the R17 not be so?
>>
> IMO we should update R17 as well as all the relevant branches (including
> trunk) AND remove the wrapper binaries from all of them.
>
> Jacopo

+1, though I don't see a need in trunk. I'd be easier when releasing but not for contributors. Would you take care of the rest (ie R17 and R18) ?

TIA

Jacques

[Jacques Le Roux]

Le 01/04/2020 à 11:26, Michael Brohl a écrit :

> Not sure if I understand your question? I simply had a look at the history for README.adoc and saw that you did the backport.

I wonder why you answered that. You were the last to commit, last mine was before README.adoc creation :p
https://github.com/apache/ofbiz-framework/commits/release17.12/README.md
https://github.com/apache/ofbiz-framework/commits/release17.12/README.adoc

More seriously again, something is wrong there: it should be available through its SHA in at least one of our MLs (notifications is expected),

I can think of situations that would be needed. We know the moto about MLs...
I hope what Swapnil did with INFRA-19945 & INFRA-20007 is enough and we don't miss anything.

And REALLY GitBox is not functional. Just try to do the same thing than above with GitHub in GitBox :/[1]

Jacques
[1] I for one get a lot of

    Forbidden

    You don't have permission to access this resource.

in GitBox, once Daniel (Gruno) told me it was "normal". So we are dependent on GitHub if we don't have a local clone at hand :/

>
> Regards,
>
> Michael
>
>
> Am 01.04.20 um 10:33 schrieb Jacques Le Roux:
>> Hi Michael,
>>
>> Yes just like you at  https://s.apache.org/8wsgr. I have the excuse of age :)
>>
>> More seriously how do you get there? I find nothing in our MLs:
>>
>> https://ofbiz.markmail.org/search/?q=fad06400e26c9b557b90c88dda5914b89794347b
>>
>> https://ofbiz.markmail.org/search/?q=fad06400
>>
>> Thanks
>>
>> Jacques
>>
>> Le 01/04/2020 à 10:23, Michael Brohl a écrit :
>>> Just look at your backport commit fad06400e26c9b557b90c88dda5914b89794347b and answer yourself ;-)
>>>
>>> Michael
>>>
>>> Am 01.04.20 um 10:17 schrieb Jacques Le Roux:
>>>> Hi All,
>>>>
>>>> Is there a reason why we have README.md AND README.adoc in R17?
>>>>
>>>> @Jacopo: also the final READMEs in 17.12.01 is adapted to the gradlew download thing, should the R17 not be so?
>>>>
>>>> Thanks
>>>>
>>>> Jacques
>>>>
>>>
>

[Jacques Le Roux]

Le 01/04/2020 à 14:08, Jacques Le Roux a écrit :

> Le 01/04/2020 à 10:21, Jacopo Cappellato a écrit :
>>> @Jacopo: also the final READMEs in 17.12.01 is adapted to the gradlew
>>> download thing, should the R17 not be so?
>>>
>> IMO we should update R17 as well as all the relevant branches (including
>> trunk) AND remove the wrapper binaries from all of them.
>>
>> Jacopo
>
> +1, though I don't see a need in trunk. I'd be easier when releasing but not for contributors. Would you take care of the rest (ie R17 and R18) ?
>
> TIA
>
> Jacques

Done