I have noticed that some "bsh:" scriptlets are not working properly; I
fixed few of them in the rev forwarded at the bottom of this email. The error I was getting in the log was: Error evaluating BSH scriptlet [ org.ofbiz.base.util.UtilDateTime.nowTimestamp()], inserting nothing; error was: Sourced file: inline evaluation of: `` org.ofbiz.base.util.UtilDateTime.nowTimestamp();'' : Attempt to resolve method: nowTimestamp() on undefined variable or class name: org.ofbiz.base.util.UtilDateTime : at Line: 1 : in file: inline evaluation of: `` org.ofbiz.base.util.UtilDateTime.nowTimestamp();'' : org .ofbiz .base .util .UtilDateTime .nowTimestamp ( ) Can this be related to the recent work done to add the "groovy:" scriptlets support? I don't think so, by the way. Jacopo Begin forwarded message: > From: [hidden email] > Date: April 9, 2009 11:54:37 AM GMT+05:30 > To: [hidden email] > Subject: svn commit: r763526 - in /ofbiz/trunk/applications: > accounting/script/org/ofbiz/accounting/ledger/ accounting/webapp/ > accounting/agreement/ product/webapp/catalog/product/ product/webapp/ > facility/facility/ > Reply-To: [hidden email] > > Author: jacopoc > Date: Thu Apr 9 06:24:36 2009 > New Revision: 763526 > > URL: http://svn.apache.org/viewvc?rev=763526&view=rev > Log: > Switched from bsh to groovy scriptlets; the bsh ones are throwing an > error. > > Modified: > ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ > ledger/AcctgTransServices.xml > ofbiz/trunk/applications/accounting/webapp/accounting/agreement/ > AgreementForms.xml > ofbiz/trunk/applications/product/webapp/catalog/product/ > ProductForms.xml > ofbiz/trunk/applications/product/webapp/facility/facility/ > FacilityForms.xml > > Modified: ofbiz/trunk/applications/accounting/script/org/ofbiz/ > accounting/ledger/AcctgTransServices.xml > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/AcctgTransServices.xml?rev=763526&r1=763525&r2=763526&view=diff > = > = > = > = > = > = > = > = > ====================================================================== > --- ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ > ledger/AcctgTransServices.xml (original) > +++ ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ > ledger/AcctgTransServices.xml Thu Apr 9 06:24:36 2009 > @@ -226,7 +226,7 @@ > <!-- check the scheduled posting date, but only if it's set > --> > <if-not-empty field="acctgTrans.scheduledPostingDate"> > <set field="scheduledPostingDate" from- > field="acctgTrans.scheduledPostingDate"/> > - <set field="beforeScheduled" value="${bsh: > org > .ofbiz > .base > .util.UtilDateTime.nowTimestamp().before(scheduledPostingDate)}"/> > + <set field="beforeScheduled" value="${groovy: > org > .ofbiz > .base > .util.UtilDateTime.nowTimestamp().before(scheduledPostingDate)}"/> > <if-compare field="beforeScheduled" operator="equals" > value="true" type="Boolean"> > <add-error><fail-message message="Not posting GL > Accounting Transaction with ID [${parameters.acctgTransId}] because > it's not scheduled to be posted yet. The scheduled posting date is > [${acctgTrans.scheduledPostingDate}]"/></add-error> > </if-compare> > > Modified: ofbiz/trunk/applications/accounting/webapp/accounting/ > agreement/AgreementForms.xml > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/webapp/accounting/agreement/AgreementForms.xml?rev=763526&r1=763525&r2=763526&view=diff > = > = > = > = > = > = > = > = > ====================================================================== > --- ofbiz/trunk/applications/accounting/webapp/accounting/agreement/ > AgreementForms.xml (original) > +++ ofbiz/trunk/applications/accounting/webapp/accounting/agreement/ > AgreementForms.xml Thu Apr 9 06:24:36 2009 > @@ -385,7 +385,7 @@ > <field name="partyId"><hidden value="${agreement.partyIdTo}"/ > ></field> > <field name="currencyUomId"><hidden value="$ > {agreementItem.currencyUomId}"/></field> > <field name="availableFromDate" use- > when="agreementProductAppl==null"> > - <!--<date-time default-value="${bsh: > org.ofbiz.base.util.UtilDateTime.nowTimestamp()}"/>--> > + <!--<date-time default-value="${groovy: > org.ofbiz.base.util.UtilDateTime.nowTimestamp()}"/>--> > <date-time default-value="${agreement.fromDate}"/> > </field> > <field name="availableFromDate" use- > when="agreementProductAppl!=null"> > > Modified: ofbiz/trunk/applications/product/webapp/catalog/product/ > ProductForms.xml > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/webapp/catalog/product/ProductForms.xml?rev=763526&r1=763525&r2=763526&view=diff > = > = > = > = > = > = > = > = > ====================================================================== > --- ofbiz/trunk/applications/product/webapp/catalog/product/ > ProductForms.xml (original) > +++ ofbiz/trunk/applications/product/webapp/catalog/product/ > ProductForms.xml Thu Apr 9 06:24:36 2009 > @@ -790,7 +790,7 @@ > </drop-down> > </field> > <field name="availableFromDate" use- > when="supplierProduct==null"> > - <date-time default-value="${bsh: > org.ofbiz.base.util.UtilDateTime.nowTimestamp()}"/> > + <date-time default-value="${groovy: > org.ofbiz.base.util.UtilDateTime.nowTimestamp()}"/> > </field> > <field name="availableFromDate" use-when="supplierProduct! > =null"> > <display/> > > Modified: ofbiz/trunk/applications/product/webapp/facility/facility/ > FacilityForms.xml > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/webapp/facility/facility/FacilityForms.xml?rev=763526&r1=763525&r2=763526&view=diff > = > = > = > = > = > = > = > = > ====================================================================== > --- ofbiz/trunk/applications/product/webapp/facility/facility/ > FacilityForms.xml (original) > +++ ofbiz/trunk/applications/product/webapp/facility/facility/ > FacilityForms.xml Thu Apr 9 06:24:36 2009 > @@ -410,7 +410,7 @@ > <field name="offsetQOHQty" title="$ > {uiLabelMap.ProductQtyOffsetQOHBelow}"><text/></field> > <field name="offsetATPQty" title="$ > {uiLabelMap.ProductQtyOffsetATPBelow}"><text/></field> > <field name="productsSoldThruTimestamp" title="$ > {uiLabelMap.ProductShowProductsSoldThruTimestamp}"> > - <date-time default-value="${bsh: > org.ofbiz.base.util.UtilDateTime.nowTimestamp()}"/> > + <date-time default-value="${groovy: > org.ofbiz.base.util.UtilDateTime.nowTimestamp()}"/> > </field> > <field name="VIEW_SIZE" entry-name="viewSize" title="$ > {uiLabelMap.ProductShowProductsPerPage}"><text/></field> > <field name="monthsInPastLimit" entry- > name="monthsInPastLimit"><text/></field> > > smime.p7s (3K) Download Attachment |
I did notice that when I was changing the groovy stuff to save an interpreted form of the script and was testing it. I haven't had a chance to track it down yet, and also I agree that changing to use groovy: is probably the best way to go anyway. Whatever the problem is, it seems to be caused by the classpath or something in the bsh interpreter... or something causing it to not find classes. -David On Apr 9, 2009, at 12:29 AM, Jacopo Cappellato wrote: > I have noticed that some "bsh:" scriptlets are not working properly; > I fixed few of them in the rev forwarded at the bottom of this email. > > The error I was getting in the log was: > > Error evaluating BSH scriptlet > [ org.ofbiz.base.util.UtilDateTime.nowTimestamp()], inserting > nothing; error was: Sourced file: inline evaluation of: `` > org.ofbiz.base.util.UtilDateTime.nowTimestamp();'' : Attempt to > resolve method: nowTimestamp() on undefined variable or class name: > org.ofbiz.base.util.UtilDateTime : at Line: 1 : in file: inline > evaluation of: `` > org.ofbiz.base.util.UtilDateTime.nowTimestamp();'' : > org .ofbiz .base .util .UtilDateTime .nowTimestamp ( ) > > Can this be related to the recent work done to add the "groovy:" > scriptlets support? I don't think so, by the way. > > Jacopo > > > > Begin forwarded message: > >> From: [hidden email] >> Date: April 9, 2009 11:54:37 AM GMT+05:30 >> To: [hidden email] >> Subject: svn commit: r763526 - in /ofbiz/trunk/applications: >> accounting/script/org/ofbiz/accounting/ledger/ accounting/webapp/ >> accounting/agreement/ product/webapp/catalog/product/ product/ >> webapp/facility/facility/ >> Reply-To: [hidden email] >> >> Author: jacopoc >> Date: Thu Apr 9 06:24:36 2009 >> New Revision: 763526 >> >> URL: http://svn.apache.org/viewvc?rev=763526&view=rev >> Log: >> Switched from bsh to groovy scriptlets; the bsh ones are throwing >> an error. >> >> Modified: >> ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ >> ledger/AcctgTransServices.xml >> ofbiz/trunk/applications/accounting/webapp/accounting/agreement/ >> AgreementForms.xml >> ofbiz/trunk/applications/product/webapp/catalog/product/ >> ProductForms.xml >> ofbiz/trunk/applications/product/webapp/facility/facility/ >> FacilityForms.xml >> >> Modified: ofbiz/trunk/applications/accounting/script/org/ofbiz/ >> accounting/ledger/AcctgTransServices.xml >> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/AcctgTransServices.xml?rev=763526&r1=763525&r2=763526&view=diff >> = >> = >> = >> = >> = >> = >> = >> = >> = >> ===================================================================== >> --- ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ >> ledger/AcctgTransServices.xml (original) >> +++ ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ >> ledger/AcctgTransServices.xml Thu Apr 9 06:24:36 2009 >> @@ -226,7 +226,7 @@ >> <!-- check the scheduled posting date, but only if it's set >> --> >> <if-not-empty field="acctgTrans.scheduledPostingDate"> >> <set field="scheduledPostingDate" from- >> field="acctgTrans.scheduledPostingDate"/> >> - <set field="beforeScheduled" value="${bsh: >> org >> .ofbiz >> .base >> .util.UtilDateTime.nowTimestamp().before(scheduledPostingDate)}"/> >> + <set field="beforeScheduled" value="${groovy: >> org >> .ofbiz >> .base >> .util.UtilDateTime.nowTimestamp().before(scheduledPostingDate)}"/> >> <if-compare field="beforeScheduled" operator="equals" >> value="true" type="Boolean"> >> <add-error><fail-message message="Not posting GL >> Accounting Transaction with ID [${parameters.acctgTransId}] because >> it's not scheduled to be posted yet. The scheduled posting date is >> [${acctgTrans.scheduledPostingDate}]"/></add-error> >> </if-compare> >> >> Modified: ofbiz/trunk/applications/accounting/webapp/accounting/ >> agreement/AgreementForms.xml >> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/webapp/accounting/agreement/AgreementForms.xml?rev=763526&r1=763525&r2=763526&view=diff >> = >> = >> = >> = >> = >> = >> = >> = >> = >> ===================================================================== >> --- ofbiz/trunk/applications/accounting/webapp/accounting/agreement/ >> AgreementForms.xml (original) >> +++ ofbiz/trunk/applications/accounting/webapp/accounting/agreement/ >> AgreementForms.xml Thu Apr 9 06:24:36 2009 >> @@ -385,7 +385,7 @@ >> <field name="partyId"><hidden value="${agreement.partyIdTo}"/ >> ></field> >> <field name="currencyUomId"><hidden value="$ >> {agreementItem.currencyUomId}"/></field> >> <field name="availableFromDate" use- >> when="agreementProductAppl==null"> >> - <!--<date-time default-value="${bsh: >> org.ofbiz.base.util.UtilDateTime.nowTimestamp()}"/>--> >> + <!--<date-time default-value="${groovy: >> org.ofbiz.base.util.UtilDateTime.nowTimestamp()}"/>--> >> <date-time default-value="${agreement.fromDate}"/> >> </field> >> <field name="availableFromDate" use- >> when="agreementProductAppl!=null"> >> >> Modified: ofbiz/trunk/applications/product/webapp/catalog/product/ >> ProductForms.xml >> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/webapp/catalog/product/ProductForms.xml?rev=763526&r1=763525&r2=763526&view=diff >> = >> = >> = >> = >> = >> = >> = >> = >> = >> ===================================================================== >> --- ofbiz/trunk/applications/product/webapp/catalog/product/ >> ProductForms.xml (original) >> +++ ofbiz/trunk/applications/product/webapp/catalog/product/ >> ProductForms.xml Thu Apr 9 06:24:36 2009 >> @@ -790,7 +790,7 @@ >> </drop-down> >> </field> >> <field name="availableFromDate" use- >> when="supplierProduct==null"> >> - <date-time default-value="${bsh: >> org.ofbiz.base.util.UtilDateTime.nowTimestamp()}"/> >> + <date-time default-value="${groovy: >> org.ofbiz.base.util.UtilDateTime.nowTimestamp()}"/> >> </field> >> <field name="availableFromDate" use-when="supplierProduct! >> =null"> >> <display/> >> >> Modified: ofbiz/trunk/applications/product/webapp/facility/facility/ >> FacilityForms.xml >> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/webapp/facility/facility/FacilityForms.xml?rev=763526&r1=763525&r2=763526&view=diff >> = >> = >> = >> = >> = >> = >> = >> = >> = >> ===================================================================== >> --- ofbiz/trunk/applications/product/webapp/facility/facility/ >> FacilityForms.xml (original) >> +++ ofbiz/trunk/applications/product/webapp/facility/facility/ >> FacilityForms.xml Thu Apr 9 06:24:36 2009 >> @@ -410,7 +410,7 @@ >> <field name="offsetQOHQty" title="$ >> {uiLabelMap.ProductQtyOffsetQOHBelow}"><text/></field> >> <field name="offsetATPQty" title="$ >> {uiLabelMap.ProductQtyOffsetATPBelow}"><text/></field> >> <field name="productsSoldThruTimestamp" title="$ >> {uiLabelMap.ProductShowProductsSoldThruTimestamp}"> >> - <date-time default-value="${bsh: >> org.ofbiz.base.util.UtilDateTime.nowTimestamp()}"/> >> + <date-time default-value="${groovy: >> org.ofbiz.base.util.UtilDateTime.nowTimestamp()}"/> >> </field> >> <field name="VIEW_SIZE" entry-name="viewSize" title="$ >> {uiLabelMap.ProductShowProductsPerPage}"><text/></field> >> <field name="monthsInPastLimit" entry- >> name="monthsInPastLimit"><text/></field> >> >> > |
In reply to this post by Jacopo Cappellato-4
Keep in mind that a lot of that ${bsh:} stuff isn't needed with UEL. If
it's a simple method call you can just use the method call without the bsh:. Also, check out the built-in UEL functions. There are some Timestamp functions in there. -Adrian Jacopo Cappellato wrote: > I have noticed that some "bsh:" scriptlets are not working properly; I > fixed few of them in the rev forwarded at the bottom of this email. > > The error I was getting in the log was: > > Error evaluating BSH scriptlet [ > org.ofbiz.base.util.UtilDateTime.nowTimestamp()], inserting nothing; > error was: Sourced file: inline evaluation of: `` > org.ofbiz.base.util.UtilDateTime.nowTimestamp();'' : Attempt to resolve > method: nowTimestamp() on undefined variable or class name: > org.ofbiz.base.util.UtilDateTime : at Line: 1 : in file: inline > evaluation of: `` org.ofbiz.base.util.UtilDateTime.nowTimestamp();'' : > org .ofbiz .base .util .UtilDateTime .nowTimestamp ( ) > > Can this be related to the recent work done to add the "groovy:" > scriptlets support? I don't think so, by the way. > > Jacopo > > > > Begin forwarded message: > >> From: [hidden email] >> Date: April 9, 2009 11:54:37 AM GMT+05:30 >> To: [hidden email] >> Subject: svn commit: r763526 - in /ofbiz/trunk/applications: >> accounting/script/org/ofbiz/accounting/ledger/ >> accounting/webapp/accounting/agreement/ >> product/webapp/catalog/product/ product/webapp/facility/facility/ >> Reply-To: [hidden email] >> >> Author: jacopoc >> Date: Thu Apr 9 06:24:36 2009 >> New Revision: 763526 >> >> URL: http://svn.apache.org/viewvc?rev=763526&view=rev >> Log: >> Switched from bsh to groovy scriptlets; the bsh ones are throwing an >> error. >> >> Modified: >> >> ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/AcctgTransServices.xml >> >> >> ofbiz/trunk/applications/accounting/webapp/accounting/agreement/AgreementForms.xml >> >> >> ofbiz/trunk/applications/product/webapp/catalog/product/ProductForms.xml >> >> ofbiz/trunk/applications/product/webapp/facility/facility/FacilityForms.xml >> >> >> Modified: >> ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/AcctgTransServices.xml >> >> URL: >> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/AcctgTransServices.xml?rev=763526&r1=763525&r2=763526&view=diff >> >> ============================================================================== >> >> --- >> ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/AcctgTransServices.xml >> (original) >> +++ >> ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/AcctgTransServices.xml >> Thu Apr 9 06:24:36 2009 >> @@ -226,7 +226,7 @@ >> <!-- check the scheduled posting date, but only if it's set --> >> <if-not-empty field="acctgTrans.scheduledPostingDate"> >> <set field="scheduledPostingDate" >> from-field="acctgTrans.scheduledPostingDate"/> >> - <set field="beforeScheduled" value="${bsh: >> org.ofbiz.base.util.UtilDateTime.nowTimestamp().before(scheduledPostingDate)}"/> >> >> + <set field="beforeScheduled" value="${groovy: >> org.ofbiz.base.util.UtilDateTime.nowTimestamp().before(scheduledPostingDate)}"/> >> >> <if-compare field="beforeScheduled" operator="equals" >> value="true" type="Boolean"> >> <add-error><fail-message message="Not posting GL >> Accounting Transaction with ID [${parameters.acctgTransId}] because >> it's not scheduled to be posted yet. The scheduled posting date is >> [${acctgTrans.scheduledPostingDate}]"/></add-error> >> </if-compare> >> >> Modified: >> ofbiz/trunk/applications/accounting/webapp/accounting/agreement/AgreementForms.xml >> >> URL: >> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/webapp/accounting/agreement/AgreementForms.xml?rev=763526&r1=763525&r2=763526&view=diff >> >> ============================================================================== >> >> --- >> ofbiz/trunk/applications/accounting/webapp/accounting/agreement/AgreementForms.xml >> (original) >> +++ >> ofbiz/trunk/applications/accounting/webapp/accounting/agreement/AgreementForms.xml >> Thu Apr 9 06:24:36 2009 >> @@ -385,7 +385,7 @@ >> <field name="partyId"><hidden >> value="${agreement.partyIdTo}"/></field> >> <field name="currencyUomId"><hidden >> value="${agreementItem.currencyUomId}"/></field> >> <field name="availableFromDate" >> use-when="agreementProductAppl==null"> >> - <!--<date-time default-value="${bsh: >> org.ofbiz.base.util.UtilDateTime.nowTimestamp()}"/>--> >> + <!--<date-time default-value="${groovy: >> org.ofbiz.base.util.UtilDateTime.nowTimestamp()}"/>--> >> <date-time default-value="${agreement.fromDate}"/> >> </field> >> <field name="availableFromDate" >> use-when="agreementProductAppl!=null"> >> >> Modified: >> ofbiz/trunk/applications/product/webapp/catalog/product/ProductForms.xml >> URL: >> http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/webapp/catalog/product/ProductForms.xml?rev=763526&r1=763525&r2=763526&view=diff >> >> ============================================================================== >> >> --- >> ofbiz/trunk/applications/product/webapp/catalog/product/ProductForms.xml >> (original) >> +++ >> ofbiz/trunk/applications/product/webapp/catalog/product/ProductForms.xml >> Thu Apr 9 06:24:36 2009 >> @@ -790,7 +790,7 @@ >> </drop-down> >> </field> >> <field name="availableFromDate" use-when="supplierProduct==null"> >> - <date-time default-value="${bsh: >> org.ofbiz.base.util.UtilDateTime.nowTimestamp()}"/> >> + <date-time default-value="${groovy: >> org.ofbiz.base.util.UtilDateTime.nowTimestamp()}"/> >> </field> >> <field name="availableFromDate" use-when="supplierProduct!=null"> >> <display/> >> >> Modified: >> ofbiz/trunk/applications/product/webapp/facility/facility/FacilityForms.xml >> >> URL: >> http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/webapp/facility/facility/FacilityForms.xml?rev=763526&r1=763525&r2=763526&view=diff >> >> ============================================================================== >> >> --- >> ofbiz/trunk/applications/product/webapp/facility/facility/FacilityForms.xml >> (original) >> +++ >> ofbiz/trunk/applications/product/webapp/facility/facility/FacilityForms.xml >> Thu Apr 9 06:24:36 2009 >> @@ -410,7 +410,7 @@ >> <field name="offsetQOHQty" >> title="${uiLabelMap.ProductQtyOffsetQOHBelow}"><text/></field> >> <field name="offsetATPQty" >> title="${uiLabelMap.ProductQtyOffsetATPBelow}"><text/></field> >> <field name="productsSoldThruTimestamp" >> title="${uiLabelMap.ProductShowProductsSoldThruTimestamp}"> >> - <date-time default-value="${bsh: >> org.ofbiz.base.util.UtilDateTime.nowTimestamp()}"/> >> + <date-time default-value="${groovy: >> org.ofbiz.base.util.UtilDateTime.nowTimestamp()}"/> >> </field> >> <field name="VIEW_SIZE" entry-name="viewSize" >> title="${uiLabelMap.ProductShowProductsPerPage}"><text/></field> >> <field name="monthsInPastLimit" >> entry-name="monthsInPastLimit"><text/></field> >> >> > |
Free forum by Nabble | Edit this page |