[jira] Created: (OFBIZ-2269) Move payment.properties to PaymentGatewayConfig entities

[Nicolas Malin (Jira)]

Move payment.properties to PaymentGatewayConfig entities
--------------------------------------------------------

                 Key: OFBIZ-2269
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2269
             Project: OFBiz
          Issue Type: New Feature
          Components: ALL COMPONENTS
    Affects Versions: SVN trunk
            Reporter: Marco Risaliti
            Assignee: Marco Risaliti
            Priority: Minor
             Fix For: SVN trunk




--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-2269:
----------------------------------

    Attachment: Payment Gateway Configuration.pdf

Payment Gateways Configuration screenshot

> Move payment.properties to PaymentGatewayConfig entities
> --------------------------------------------------------
>
>                 Key: OFBIZ-2269
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2269
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: Payment Gateway Configuration.pdf, Product Store Payments.pdf
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-2269:
----------------------------------

    Attachment: Product Store Payments.pdf

Product Store Payments screenshot.

> Move payment.properties to PaymentGatewayConfig entities
> --------------------------------------------------------
>
>                 Key: OFBIZ-2269
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2269
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: Payment Gateway Configuration.pdf, Product Store Payments.pdf
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-2269:
----------------------------------

    Attachment: PaymentGateways.patch

First patch to move payment.properties to PaymentGatewayConfig entity as discussed on the dev mailing list.

> Move payment.properties to PaymentGatewayConfig entities
> --------------------------------------------------------
>
>                 Key: OFBIZ-2269
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2269
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: Payment Gateway Configuration.pdf, PaymentGateways.patch, Product Store Payments.pdf
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695682#action_12695682 ]

David E. Jones commented on OFBIZ-2269:
---------------------------------------

Looks like a great start Marco.

One small note: service names should start with a lower-case letter, just like Java method names do.

> Move payment.properties to PaymentGatewayConfig entities
> --------------------------------------------------------
>
>                 Key: OFBIZ-2269
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2269
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: Payment Gateway Configuration.pdf, PaymentGateways.patch, Product Store Payments.pdf
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695686#action_12695686 ]

Jacopo Cappellato commented on OFBIZ-2269:
------------------------------------------

Looks great Marco.
One more feature we could add to this (but I am not saying you should do this as part of the effort) is to, instead of entering the name of the service in the "product store payment setup", enter the "customMethodId" and use the CustomMethod entity to store all the available services.
We could then have drop down boxes that shows all the available services for authorization, another one for the capture etc...

Jacopo

> Move payment.properties to PaymentGatewayConfig entities
> --------------------------------------------------------
>
>                 Key: OFBIZ-2269
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2269
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: Payment Gateway Configuration.pdf, PaymentGateways.patch, Product Store Payments.pdf
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695832#action_12695832 ]

Marco Risaliti commented on OFBIZ-2269:
---------------------------------------

Thanks David to take care of it, I will provide a new patch for changing the service names will start with a lower-case letter.

> Move payment.properties to PaymentGatewayConfig entities
> --------------------------------------------------------
>
>                 Key: OFBIZ-2269
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2269
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: Payment Gateway Configuration.pdf, PaymentGateways.patch, Product Store Payments.pdf
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695834#action_12695834 ]

Marco Risaliti commented on OFBIZ-2269:
---------------------------------------

Thanks a lot Jacopo for your suggestion on payment service of "product store payment setup".
What did you think about this  ?

<CustomMethodType customMethodTypeId="CC_AUTH" parentTypeId="" hasTable="N" description="Credit Card authorize methods"/>

<CustomMethod customMethodId="AUTH_TEST" customMethodTypeId="CC_AUTH" customMethodName="testCCCapture" description="Test authorize"/>
<CustomMethod customMethodId="AUTH_AIM" customMethodTypeId="CC_AUTH" customMethodName="AIMCCAuth" description="Authorize dot net authorize"/>
<CustomMethod customMethodId="AUTH_CLEARCOMMERCE" customMethodTypeId="CC_AUTH" customMethodName="clearCommerceCCAuth" description="Clear Commerce authorize"/>
<CustomMethod customMethodId="AUTH_PAYFLOW" customMethodTypeId="CC_AUTH" customMethodName="payflowCCProcessor" description="Payflow Pro authorize"/>
<CustomMethod customMethodId="AUTH_ALWAYSAPPROVE" customMethodTypeId="CC_AUTH" customMethodName="alwaysApproveCCProcessor" description="Always approve authorize"/>

in ProductStorePaymentSetting entity add the following relation:

<relation type="one" fk-name="PRDS_PS_CUS_MET" rel-entity-name="CustomMethod">
    <key-map field-name="paymentService" rel-field-name="customMethodId"/>
</relation>

in this case we have to change the datas into ProductStorePaymentSetting like here:

from
<ProductStorePaymentSetting productStoreId="9000" paymentMethodTypeId="CREDIT_CARD" paymentServiceTypeEnumId="PRDS_PAY_AUTH" paymentService="alwaysApproveCCProcessor"/>

to
<ProductStorePaymentSetting productStoreId="9000" paymentMethodTypeId="CREDIT_CARD" paymentServiceTypeEnumId="PRDS_PAY_AUTH" paymentService="AUTH_ALWAYSAPPROVE"/>

What did you think of it ?

Thanks
Marco

> Move payment.properties to PaymentGatewayConfig entities
> --------------------------------------------------------
>
>                 Key: OFBIZ-2269
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2269
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: Payment Gateway Configuration.pdf, PaymentGateways.patch, Product Store Payments.pdf
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695884#action_12695884 ]

David E. Jones commented on OFBIZ-2269:
---------------------------------------

In this case the "paymentService" field should be changed to reflect it's new meaning. The generic recommended (and mostly used) pattern (that is REALLY annoying when it is not used, but alas I have missed commenting on a few over the years) is when creating a field that points to a foreign key then use the name of the foreign field with a prefix.

In this case instead of "paymentService" use "paymentCustomMethodId".

Also, in the relation element use the prefix attribute to help clarify. In this case where the field is paymentCustomMethodId the prefix should be "Payment".

> Move payment.properties to PaymentGatewayConfig entities
> --------------------------------------------------------
>
>                 Key: OFBIZ-2269
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2269
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: Payment Gateway Configuration.pdf, PaymentGateways.patch, Product Store Payments.pdf
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695962#action_12695962 ]

Sam Hamilton commented on OFBIZ-2269:
-------------------------------------

I just want to check the following is possible with the new changes; I have two ecommerce stores for Company A and Company B the payment settings can be different per store?

> Move payment.properties to PaymentGatewayConfig entities
> --------------------------------------------------------
>
>                 Key: OFBIZ-2269
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2269
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: Payment Gateway Configuration.pdf, PaymentGateways.patch, Product Store Payments.pdf
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-2269:
----------------------------------

    Attachment: PaymentGateways2.patch

PaymentGateways2.patch contains the following fix:

- service names having now the first letter in lower-case.
- add the new field paymentCustomMethodId into ProductStorePaymentSetting entity.
- handle the new paymentCustomMethodId into the Payments Setting form.
- change the PaymentGatewayServices.java for getting the customMethodName from CustomMethod entity instead of use the old paymentService field.

Thanks
Marco

> Move payment.properties to PaymentGatewayConfig entities
> --------------------------------------------------------
>
>                 Key: OFBIZ-2269
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2269
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: Payment Gateway Configuration.pdf, PaymentGateways.patch, PaymentGateways2.patch, Product Store Payments.pdf
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696236#action_12696236 ]

Marco Risaliti commented on OFBIZ-2269:
---------------------------------------

Hi Sam,

when this task will be completed it could be possible different payment settings per store.

Thanks
Marco

> Move payment.properties to PaymentGatewayConfig entities
> --------------------------------------------------------
>
>                 Key: OFBIZ-2269
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2269
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: Payment Gateway Configuration.pdf, PaymentGateways.patch, PaymentGateways2.patch, Product Store Payments.pdf
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-2269:
----------------------------------

    Attachment:     (was: Product Store Payments.pdf)

> Move payment.properties to PaymentGatewayConfig entities
> --------------------------------------------------------
>
>                 Key: OFBIZ-2269
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2269
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-2269:
----------------------------------

    Attachment:     (was: PaymentGateways.patch)

> Move payment.properties to PaymentGatewayConfig entities
> --------------------------------------------------------
>
>                 Key: OFBIZ-2269
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2269
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-2269:
----------------------------------

    Attachment:     (was: PaymentGateways2.patch)

> Move payment.properties to PaymentGatewayConfig entities
> --------------------------------------------------------
>
>                 Key: OFBIZ-2269
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2269
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-2269:
----------------------------------

    Attachment:     (was: Payment Gateway Configuration.pdf)

> Move payment.properties to PaymentGatewayConfig entities
> --------------------------------------------------------
>
>                 Key: OFBIZ-2269
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2269
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-2269:
----------------------------------

    Attachment: Product Store Payment Setup.pdf
                Payment Gateway Configuration Types.pdf
                Payment Gateway Configuration.pdf

New screenshots.

> Move payment.properties to PaymentGatewayConfig entities
> --------------------------------------------------------
>
>                 Key: OFBIZ-2269
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2269
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: Payment Gateway Configuration Types.pdf, Payment Gateway Configuration.pdf, Product Store Payment Setup.pdf
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-2269:
----------------------------------

    Attachment: PaymentGatewayConfig.patch

A new patch for Payment Gateways Configuration.
It seems to me now it's completed the first step.
Please take a look at it before continue with changing PayFlow integration to support the new Payment Gateway Configuration.

Thanks
Marco

> Move payment.properties to PaymentGatewayConfig entities
> --------------------------------------------------------
>
>                 Key: OFBIZ-2269
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2269
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: Payment Gateway Configuration Types.pdf, Payment Gateway Configuration.pdf, PaymentGatewayConfig.patch, Product Store Payment Setup.pdf
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-2269:
----------------------------------

    Attachment: PaymentGatewayConfig2.patch

An updated patch to handle new logging features of Payflow Pro v4.

> Move payment.properties to PaymentGatewayConfig entities
> --------------------------------------------------------
>
>                 Key: OFBIZ-2269
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2269
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: Payment Gateway Configuration Types.pdf, Payment Gateway Configuration.pdf, PaymentGatewayConfig.patch, PaymentGatewayConfig2.patch, Product Store Payment Setup.pdf
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti closed OFBIZ-2269.
---------------------------------

    Resolution: Fixed

Fixed into rev. 763782.

> Move payment.properties to PaymentGatewayConfig entities
> --------------------------------------------------------
>
>                 Key: OFBIZ-2269
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2269
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: Payment Gateway Configuration Types.pdf, Payment Gateway Configuration.pdf, PaymentGatewayConfig.patch, PaymentGatewayConfig2.patch, Product Store Payment Setup.pdf
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.