[jira] [Commented] (OFBIZ-10413) Remove unused code in `CommonEvents::setFollowerPage`

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-10413) Remove unused code in `CommonEvents::setFollowerPage`

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-10413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16489112#comment-16489112 ]

Jacques Le Roux commented on OFBIZ-10413:
-----------------------------------------

Mathieu,

If I refer to the data model, in WebUserPreference visitId is used for:
<field name="visitId" type="id"><description>To be able to keep preferences for a non loggin in user for the current session</description></field>

> Remove unused code in `CommonEvents::setFollowerPage`
> -----------------------------------------------------
>
>                 Key: OFBIZ-10413
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10413
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Trunk
>            Reporter: Mathieu Lirzin
>            Priority: Minor
>         Attachments: OFBIZ-10413-Improve-setFollowerPage.patch
>
>
> `CommonEvents::setFollowerPage` contains two unused variable definition.  After basic search I found that this request handler is used only in `webapp/partymgr/controller.xml` however I was unable to understand its purpose, so I have added a comment to add some kind of docstring.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)