[
https://issues.apache.org/jira/browse/OFBIZ-10453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527436#comment-16527436 ]
Michael Brohl commented on OFBIZ-10453:
---------------------------------------
Didn't we just agreed upon a slower process and review from more committers when changing these core aspects of the framework?
Especially when you change the patch there is no chance for anyone to review before it gets committed :(
> Factorize code logic from ‘ConfigXMLReader’
> -------------------------------------------
>
> Key: OFBIZ-10453
> URL:
https://issues.apache.org/jira/browse/OFBIZ-10453> Project: OFBiz
> Issue Type: Improvement
> Components: base
> Reporter: Mathieu Lirzin
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10453_0001-Add-ConfigXMLReader.ControllerConfig-pushIncludes.patch, OFBIZ-10453_0002-Add-ConfigXMLReader.ControllerConfig-getIncludes.patch
>
>
> There is a lot of repetitive code in {{ConfigXMLReader}}. Using a functional interface as a parameter of a generic algorithm avoids those repetitions.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Locked
