[jira] [Commented] (OFBIZ-10453) Factorize code logic from ‘ConfigXMLReader’

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-10453) Factorize code logic from ‘ConfigXMLReader’

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-10453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527440#comment-16527440 ]

Jacques Le Roux commented on OFBIZ-10453:
-----------------------------------------

It's not a change just a refactorization. I thought it was simple enough to be committed. If we go this way for simple and small changes like here things will be quite slow :(

> Factorize code logic from ‘ConfigXMLReader’
> -------------------------------------------
>
>                 Key: OFBIZ-10453
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10453
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: base
>            Reporter: Mathieu Lirzin
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-10453_0001-Add-ConfigXMLReader.ControllerConfig-pushIncludes.patch, OFBIZ-10453_0002-Add-ConfigXMLReader.ControllerConfig-getIncludes.patch
>
>
> There is a lot of repetitive code in {{ConfigXMLReader}}.  Using a functional interface as a parameter of a generic algorithm avoids those repetitions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)