[
https://issues.apache.org/jira/browse/OFBIZ-10638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690913#comment-16690913 ]
Mathieu Lirzin commented on OFBIZ-10638:
----------------------------------------
Hello Taher,
Indeed it is critical code, so you are right by being cautious.
Both manual tests, unit tests, integration tests, and data loading work fine on my machine. I am not a Java concurrency expert, so I can only be *relatively* confident with patch 1.
What do you mean by investigating the variable state for the container loader?
> The ‘StartupLoader’ interface should be removed
> -----------------------------------------------
>
> Key: OFBIZ-10638
> URL:
https://issues.apache.org/jira/browse/OFBIZ-10638> Project: OFBiz
> Issue Type: Improvement
> Affects Versions: Trunk
> Reporter: Mathieu Lirzin
> Assignee: Taher Alkhateeb
> Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10638_0001-Remove-StartupLoader-interface.patch, OFBIZ-10638_0002-Remove-unnecessary-arguments-in-AdminServer.patch, OFBIZ-10638_0003-Refactor-StartupControlPanel.patch, OFBIZ-10638_0004-Refactor-ContainerLoader.patch
>
>
> OFBiz used to provide alternate Startup loaders. Nowadays only the container loaders is used. As suggested by Taher [on the dev mailing list|
https://lists.apache.org/thread.html/f99d6f661eb8197df8eac6d8ba7db3fa9b7fe2569a4a24ef2fef5cae@%3Cdev.ofbiz.apache.org%3E], the {{StartupLoader}} interface should be removed and startup code using it should be adapted.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Locked
