[jira] [Commented] (OFBIZ-10638) The ‘StartupLoader’ interface should be removed

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-10638) The ‘StartupLoader’ interface should be removed

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-10638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690914#comment-16690914 ]

Taher Alkhateeb commented on OFBIZ-10638:
-----------------------------------------

Well, the syncrhonized block around startup loaders is now converted to a single container loader. This means we removed the synchronization mechanism for the startup loaders yet we continued to launch all the containers as usual.

 

I think your code looks fine, but just to be on the safe side, can you confirm that all containers are launched (anything that implements container). Does that for example include the birt container if you add that plugin? No problems? You know, just some smoke tests to make sure we are okay

> The ‘StartupLoader’ interface should be removed
> -----------------------------------------------
>
>                 Key: OFBIZ-10638
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10638
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Trunk
>            Reporter: Mathieu Lirzin
>            Assignee: Taher Alkhateeb
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-10638_0001-Remove-StartupLoader-interface.patch, OFBIZ-10638_0002-Remove-unnecessary-arguments-in-AdminServer.patch, OFBIZ-10638_0003-Refactor-StartupControlPanel.patch, OFBIZ-10638_0004-Refactor-ContainerLoader.patch
>
>
> OFBiz used to provide alternate Startup loaders. Nowadays only the container loaders is used. As suggested by Taher [on the dev mailing list|https://lists.apache.org/thread.html/f99d6f661eb8197df8eac6d8ba7db3fa9b7fe2569a4a24ef2fef5cae@%3Cdev.ofbiz.apache.org%3E], the {{StartupLoader}} interface should be removed and startup code using it should be adapted.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)