[
https://issues.apache.org/jira/browse/OFBIZ-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503020 ]
Jacopo Cappellato commented on OFBIZ-2:
---------------------------------------
Adrian,
I've committed your last patch "utildatetime.patch" of 08/Jun/2007 in rev. 545695
However, I've noticed that the new methods (getDayStart etc...) are very similar to the old ones: wouldn't be better to change the old ones to call your new ones with a null TimeZone?
I've committed this patch because this is not a big deal since the duplicated logic is pretty small, but if you could prepare a new patch with this enhancements I'd be more than happy to commit it.
> Add Timezone versions of functions in UtilDateTime
> --------------------------------------------------
>
> Key: OFBIZ-2
> URL:
https://issues.apache.org/jira/browse/OFBIZ-2> Project: OFBiz
> Issue Type: New Feature
> Components: framework
> Affects Versions: SVN trunk
> Environment: All
> Reporter: Vinay Agarwal
> Attachments: 06-06-21 Timezone.patch, tz_basic.patch, tz_basic.patch, utildatetime.patch, utildatetime.patch, utildatetime.patch, utildatetime.patch, UtilDateTime.patch
>
>
> I am starting to work with timezones. The first thing I came across is UtilDateTime's functions completely ignore timezones. I plan to create timezone versions of functions like getDayStart that will take a timezone id string or a TimeZone. I would not use any deprecated functions but do not plan to change their use in existing functions. I would appreciate suggestions.
> Regards,
> Vinay Agarwal
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Locked
