[jira] [Commented] (OFBIZ-5297) Order Report Issue

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-5297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13749371#comment-13749371 ]

Taher Alkhateeb commented on OFBIZ-5297:
----------------------------------------

Hi Jacques and Parimal,

Please note that the patch I'm working on (I did not create a JIRA yet as I want more substantial material to patch) is quite different. I am working on infrastructure improvement including exporting shared functionality to a separate JS library and unified formatting.

A quick review of this patch shows that my work would probably veer off quite differently. For example, if you look at this snippet:

{code}
@@ -215,7 +215,7 @@
             <method name="open"><![CDATA[salesOrderItemStarSchemas = null;
 userLogin = null;
 try {
-    userLogin = delegator.findOne("UserLogin",UtilMisc.toMap("userLoginId","admin"), false);
+    userLogin = delegator.findByPrimaryKey("UserLogin",UtilMisc.toMap("userLoginId","admin"));
{code}

You will see that the fundamental problem of hard-coding userLoginId is still not resolved. In addition, my objective is to actually yank out all code for userLogin into a separate shared library. My work might actually also apply some changes to BirtWorker.java

With that being said, I will adjust my work on my patch based on this JIRA and try to merge with this patch to be able to upload what I originally had in mind, or perhaps I will wait until you finalize all issues with this JIRA and close it before I start to submit mine. What do you think?
               

> Order Report Issue
> ------------------
>
>                 Key: OFBIZ-5297
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5297
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: order
>    Affects Versions: Release Branch 11.04, SVN trunk
>            Reporter: Parimal Gain
>              Labels: Birt
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-5297-11.04.patch, OFBIZ-5297-Trunk.patch
>
>
> Reports under Order component has following issues -
> 1. Following reports are not showing any records due some issue
>    a. Last three month sales report.
>    b. Sales report.
>    c. Sales Order discount code report.
>    d. Product demand report.
> 2. Inconsistency in opening the pdf report - some reports are opening in new tab window but some are in the same window.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira