[
https://issues.apache.org/jira/browse/OFBIZ-6791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15110443#comment-15110443 ]
Jacques Le Roux commented on OFBIZ-6791:
----------------------------------------
Come on Hans, you really wants to upset me :-o ?
No I did not miss it, but it seems you missed my anwser.
I see your point, I though thought that, with my explanation, you would debug/fix that yourself since you committed in 1st place.
I already answered you (*see thread link in description*) that to create an opportunity you need a leadPartyId. Because OOTB in UI (same with services) to create an opportunity you must
# use the EditSalesOpportunity request which loads the EditSalesOpportunity screen itself using the OpportunityForms.xml#EditSalesOpportunity form.
# This form calls the createSalesOpportunity request when it's not an update.
# The createSalesOpportunity request calls the createSalesOpportunity service.
# The createSalesOpportunity service triggers the SECAs which launch the createSalesOpportunityLeadRole and/or createSalesOpportunityAccountRole services if leadPartyId and/or accountPartyId (ONLY IF) is/are not empty.
Since leadPartyId and/or accountPartyId are no mandatory in EditSalesOpportunity form, nor in createSalesOpportunity/updateSalesOpportunity services, that's why you have this SECA condition, else you would not be able to create/update an opportunity.
I hope I gave you enough details to fix the issue. Hint: it's the list which should be fixed, not the SECA (and even less only one of them but the 4 - create/update for lead and account - if you would have been consistent but still wrong)
You really have a skill to have others working for you, don't you? :D
I'm an OFBiz volunteer, but sometimes I wonder... And today I better understand Adrian's harsh reaction on dev ML one day, please refer to it...
> Various fixes related with sales opportunity
> --------------------------------------------
>
> Key: OFBIZ-6791
> URL:
https://issues.apache.org/jira/browse/OFBIZ-6791> Project: OFBiz
> Issue Type: Bug
> Components: marketing, order
> Affects Versions: Trunk
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: Upcoming Branch
>
>
> Hans directly committed
> * r1723007 "sales opportunity creation: required-field removed, disturbed the form submission, entityone no value field, error in the log"
> * and r1723248 "various fixes to the salesopportunity list and create functions"
> I wanted to backport them and create this Jira for releases notes. But before I checked the commits and found an issue, see
http://markmail.org/message/mspie3qdjcac2tci--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Locked
