[jira] [Commented] (OFBIZ-6810) Refactor components regarding groovy and freemarker file locations

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-6810) Refactor components regarding groovy and freemarker file locations

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-6810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15110587#comment-15110587 ]

Jacques Le Roux commented on OFBIZ-6810:
----------------------------------------

Jacopo's initial proposal was (slightly modified by me for component_name generalisation)
{noformat}
src/main/java/org/ofbiz/component_name/...
src/test/java/org/ofbiz/component_name/...
src/main/minilang/org/ofbiz/component_name/...
src/main/groovy/...
{noformat}

Adam's suggested a change to differentiate between pre-compiled vs parsed Groovy scripts and then Jacopo proposed
{noformat}
src/main/java/org/ofbiz/component_name/...
src/test/java/org/ofbiz/component_name/...
src/main/minilang/org/ofbiz/component_name/...
src/main/groovy/... (pre-compiled Groovy)
src/main/scripts/... (parsed Groovy scripts)
{noformat}

I personnaly wonder why we should carry the Java package name way for other languages. So I'd suggest
{noformat}
src/main/java/org/ofbiz/component_name/...
src/test/java/org/ofbiz/component_name/...
minilang/...
groovy/... (pre-compiled Groovy)
/groovyScripts/... (parsed Groovy scripts, groovyScripts rather that script because other script languages could be used in the future)
{noformat}

As Nicolas suggested we could differentiate under minilang, groovy and groovyScripts folders by using sub-folders like screen, event and service (better to separate those 2 last). We anyway need to keep the Java package name way for Java classes.

Sincerely I did not put much thoughts on this and I could have missed something... Notably how much changes this entails for the *"component://"* notation

> Refactor components regarding groovy and freemarker file locations
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-6810
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6810
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk, Release Branch 15.12
>            Reporter: Pierre Smits
>            Assignee: Nicolas Malin
>
> This is a placeholder issue to capture all tasks and related issues regarding the refactoring of the directory structure with respect to the location of .groovy and .ftl (freemarker templates) files.
> See related discussion: http://ofbiz.markmail.org/message/25dse4jke2fp64mx



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)