[
https://issues.apache.org/jira/browse/OFBIZ-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153140#comment-16153140 ]
Jacques Le Roux commented on OFBIZ-8341:
----------------------------------------
BTW there is a large usage of GeneralException in OrderServices.java. And the usage is not consistent. This is the kind of things we should thought about if we want to refactor a monster like that (6411 lines).
> Fix Default or Empty Catch block in Java and Groovy files
> ---------------------------------------------------------
>
> Key: OFBIZ-8341
> URL:
https://issues.apache.org/jira/browse/OFBIZ-8341> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
> Reporter: Harsh Vijaywargiya
> Assignee: Jacques Le Roux
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-8341- OrderReadHelper.patch
>
>
> In many Java and Groovy files we have auto generated catch blocks or empty catch blocks.
> To avoid such exception swallowing this should be improved to at least log the error and also return error in case of service.
> As of now I found following classes with such patterns -
> InventoryServices.java
> FreeMarkerWorker.java
> QRCodeEvents.java
> QRCodeServices.java
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
Locked
