[jira] [Updated] (OFBIZ-8341) Fix Default or Empty Catch block in Java and Groovy files

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-8341:
-----------------------------------
    Attachment: OFBIZ-8341- OrderReadHelper.patch

The OFBIZ-8341- OrderReadHelper.patch reverts r1807240 and rather throw exceptions
Thanks to [Scott's suggestion on dev ML|https://lists.apache.org/thread.html/c2de549eb9eed43315bc898eaa167dd90beed54738fb053ec6212719@%3Cdev.ofbiz.apache.org%3E], if we agree another type of replacement for swallowed exceptions

> Fix Default or Empty Catch block in Java and Groovy files
> ---------------------------------------------------------
>
>                 Key: OFBIZ-8341
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-8341
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>            Reporter: Harsh Vijaywargiya
>            Assignee: Jacques Le Roux
>             Fix For: Upcoming Release
>
>         Attachments: OFBIZ-8341- OrderReadHelper.patch
>
>
> In many Java and Groovy files we have auto generated catch blocks or empty catch blocks.
> To avoid such exception swallowing this should be improved to at least log the error and also return error in case of service.
> As of now I found following classes with such patterns -
> InventoryServices.java
> FreeMarkerWorker.java
> QRCodeEvents.java
> QRCodeServices.java

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)