[jira] [Commented] (OFBIZ-9833) Token Based Authentication

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16400971#comment-16400971 ]

Jacques Le Roux commented on OFBIZ-9833:
----------------------------------------

I agree to revert but I face 2 problems at the moment. One concerns only me but the other is more annoying. When I revert all the commits I made and reported above (resolving conflicts) I get a weird issue:
{code:java}
2018-03-15 18:57:37,883 |jsse-nio-8443-exec-4 |ModelService |E| [ModelService.validate] : {userLogin} : (IN) Required test error: org.apache.ofbiz.service.ServiceValidationException: Type che
ck failed for field [userLogin.request]; expected type is [javax.servlet.http.HttpServletRequest]; actual type is [org.apache.catalina.connector.RequestFacade]
2018-03-15 18:57:37,883 |jsse-nio-8443-exec-4 |ServiceDispatcher |E| Incoming context (in runSync : userLogin) does not match expected requirements
org.apache.ofbiz.service.ServiceValidationException: Type check failed for field [userLogin.request]; expected type is [javax.servlet.http.HttpServletRequest]; actual type is [org.apache.catalina.connector.Re
questFacade]
at org.apache.ofbiz.service.ModelService.validate(ModelService.java:745) ~[ofbiz.jar:?]
at org.apache.ofbiz.service.ModelService.validate(ModelService.java:597) ~[ofbiz.jar:?]
at org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:381) [ofbiz.jar:?]
at org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:228) [ofbiz.jar:?]
at org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88) [ofbiz.jar:?]
at org.apache.ofbiz.webapp.control.LoginWorker.login(LoginWorker.java:440) [ofbiz.jar:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_112]
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_112]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_112]
at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_112]
at org.apache.ofbiz.webapp.event.JavaEventHandler.invoke(JavaEventHandler.java:100) [ofbiz.jar:?]
at org.apache.ofbiz.webapp.event.JavaEventHandler.invoke(JavaEventHandler.java:80) [ofbiz.jar:?]
at org.apache.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:730) [ofbiz.jar:?]
at org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:454) [ofbiz.jar:?]
at org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:213) [ofbiz.jar:?]
at org.apache.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:87) [ofbiz.jar:?]
at javax.servlet.http.HttpServlet.service(HttpServlet.java:706) [javax.servlet-api-4.0.0.jar:4.0.0]
at javax.servlet.http.HttpServlet.service(HttpServlet.java:791) [javax.servlet-api-4.0.0.jar:4.0.0]
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231) [tomcat-catalina-8.5.24.jar:8.5.24]
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) [tomcat-catalina-8.5.24.jar:8.5.24]
at org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:196) [ofbiz.jar:?]
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) [tomcat-catalina-8.5.24.jar:8.5.24]
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) [tomcat-catalina-8.5.24.jar:8.5.24]
at org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:157) [ofbiz.jar:?]
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) [tomcat-catalina-8.5.24.jar:8.5.24]
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) [tomcat-catalina-8.5.24.jar:8.5.24]
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:198) [tomcat-catalina-8.5.24.jar:8.5.24]
at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96) [tomcat-catalina-8.5.24.jar:8.5.24]
at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:504) [tomcat-catalina-8.5.24.jar:8.5.24]
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:140) [tomcat-catalina-8.5.24.jar:8.5.24]
at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:81) [tomcat-catalina-8.5.24.jar:8.5.24]
at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:87) [tomcat-catalina-8.5.24.jar:8.5.24]
at org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:650) [tomcat-catalina-8.5.24.jar:8.5.24]
at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:342) [tomcat-catalina-8.5.24.jar:8.5.24]
at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:803) [tomcat-coyote-8.5.24.jar:8.5.24]
at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66) [tomcat-coyote-8.5.24.jar:8.5.24]
at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:790) [tomcat-coyote-8.5.24.jar:8.5.24]
at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1459) [tomcat-coyote-8.5.24.jar:8.5.24]
at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49) [tomcat-coyote-8.5.24.jar:8.5.24]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [?:1.8.0_112]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [?:1.8.0_112]
at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61) [tomcat-util-8.5.24.jar:8.5.24]
at java.lang.Thread.run(Thread.java:745) [?:1.8.0_112]
2018-03-15 18:57:37,886 |jsse-nio-8443-exec-4 |ServiceDispatcher |T| [[Sync service failed...- total:0.0,since last(Begin):0.0]] - 'catalog / userLogin'
{code}
Could you please apply the OFBIZ-9833-revert.patch and see if you get the same. It's seems related to my sole change in ContextFilter which is reverted in the patch. I tried a cleanAll to, at my surprise, no avail.

The other (only mine) issue is I began to work on another solution, before you asked to revert Jacopo. So it will be uneasy to me when I'll revert. Anyway that's my pb and we need 1st to understand what's happening with the revert patch, thanks.

> Token Based Authentication
> --------------------------
>
>                 Key: OFBIZ-9833
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9833
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Deepak Dixit
>            Assignee: Deepak Dixit
>            Priority: Major
>         Attachments: JSON Web Tokens.pdf, OFBIZ-9833-JWTManager.patch, OFBIZ-9833-external-server-test-example.patch, OFBIZ-9833-external-server-test-example.patch, OFBIZ-9833-external-server.patch, OFBIZ-9833-external-server.patch, OFBIZ-9833-external-server.patch, Token Based Authentication in Apache OfBiz.pdf, Token Based Authentication.pdf, rfc7519.pdf
>
>
> Here is dev list discussion for token based authentication work:
> http://markmail.org/message/vyskeh2wujqpkbwg

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)