[jira] [Commented] (OFBIZ-9846) Replace Inline js with External js in renderFormClose macro

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-9846) Replace Inline js with External js in renderFormClose macro

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16491681#comment-16491681 ]

Aditya Sharma commented on OFBIZ-9846:
--------------------------------------

Thanks Jacques :)

Actually, I just forgot to mention that the above code was already commented out so I kept it as it was instead of removing it. I found it quite absurd as for common-theme the above code is not commented and parameters are passed with data. 
{quote}-            <#--list parameterList as parameter>
-                 "${[parameter.name|http://parameter.name/]}": "${parameter.value}",
-             </#list-->
{quote}
[https://markmail.org/message/ameuyjq6ik776mkg

Apart from that, we can remove unused themes/rainbowstone/template/HtmlMenuMacroLibrary.ftl file. It may have been committed by mistake.

> Replace Inline js with External js in renderFormClose macro
> -----------------------------------------------------------
>
>                 Key: OFBIZ-9846
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9846
>             Project: OFBiz
>          Issue Type: Sub-task
>    Affects Versions: Trunk
>            Reporter: Aditya Sharma
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-9846.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)