[
https://issues.apache.org/jira/browse/OFBIZ-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16491641#comment-16491641 ]
Jacques Le Roux edited comment on OFBIZ-9846 at 5/27/18 7:09 AM:
-----------------------------------------------------------------
Thanks Aditya,
Great job, took me a moment to review :) Also because I had some still pending (unrelated) changes.
Your silghtly modifed patch is in trunk at revision: 1832307
I simply removed from rainbowstone HtmlMenuMacroLibrary.ftl
{code}
<#--<#if parameterList?has_content>-->
<#--<#list parameterList as parameter>-->
<#--<#local params += ",'${parameter.name}': '${parameter.value}'">-->
<#--</#list>-->
<#--</#if>-->
{code}
Not sure why you kept it, I guess it was forgotten after working on it, please check
was (Author: jacques.le.roux):
Thanks Aditya,
Great job, took me a moment to review :) Also because I had some still pending (unrelated) changes.
Your silghtly modifed patch is in trunk at revision: 1832307
I simply removed from rainbowstone HtmlMenuMacroLibrary.ftl
<#--<#if parameterList?has_content>-->
<#--<#list parameterList as parameter>-->
<#--<#local params += ",'${parameter.name}': '${parameter.value}'">-->
<#--</#list>-->
<#--</#if>-->
Not sure why you kept it, I guess it was forgotten after working on it, please check
> Replace Inline js with External js in renderFormClose macro
> -----------------------------------------------------------
>
> Key: OFBIZ-9846
> URL:
https://issues.apache.org/jira/browse/OFBIZ-9846> Project: OFBiz
> Issue Type: Sub-task
> Affects Versions: Trunk
> Reporter: Aditya Sharma
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-9846.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Locked
