OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-1009) Reorganization of PayPalEvents

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

25 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-1009) Reorganization of PayPalEvents

Reorganization of PayPalEvents
------------------------------

Key: OFBIZ-1009
URL: https://issues.apache.org/jira/browse/OFBIZ-1009
Project: OFBiz (The Open for Business Project)
Issue Type: Bug
Components: accounting
Affects Versions: SVN trunk, Release Branch 4.0
Environment: mac os x
Reporter: Marco Risaliti
Priority: Minor
Fix For: SVN trunk, Release Branch 4.0

I have reorganizated the PayPalEvents.java performing those tasks:
- removing unused variable to avoid compile warning
- removed hardcoded error messages to use uiLabels.properties
- correct the bug that does not create the payment for the order that was paid on PayPal
- removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties

This patch can be tested also on the front-end application on http://www.ofbiz.it

After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.

Thanks in advance
Marco Risaliti

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1009) Reorganization of PayPalEvents

[ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12497914 ]

David E. Jones commented on OFBIZ-1009:
---------------------------------------

Just a quick thought: these appear to be new features and improvements of the PayPal stuff rather than a bug fix, and probably shouldn't be included in the release branch.

> Reorganization of PayPalEvents
> ------------------------------
>
> Key: OFBIZ-1009
> URL: https://issues.apache.org/jira/browse/OFBIZ-1009
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk, Release Branch 4.0
> Environment: mac os x
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk, Release Branch 4.0
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1009) Reorganization of PayPalEvents

In reply to this post by Nicolas Malin (Jira)

> Reorganization of PayPalEvents
> ------------------------------
>
> Key: OFBIZ-1009
> URL: https://issues.apache.org/jira/browse/OFBIZ-1009
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk, Release Branch 4.0
> Environment: mac os x
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk, Release Branch 4.0
>
> Attachments: PayPal.patch
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

mrisaliti@libero.it

Re: [jira] Commented: (OFBIZ-1009) Reorganization of PayPalEvents

In reply to this post by Nicolas Malin (Jira)

Yes, mainly this patch is an improvement but the bug is if you use
PayPal then during the notification the payment/payment gateway
response and order payment preference will be not be created.
So if you consider this is not a bug you can apply it on to main trunk.

Thanks a lot
Marco

Il giorno 22/mag/07, alle ore 18:12, David E. Jones (JIRA) ha scritto:

>
> [ https://issues.apache.org/jira/browse/OFBIZ-1009?
> page=com.atlassian.jira.plugin.system.issuetabpanels:comment-
> tabpanel#action_12497914 ]
>
> David E. Jones commented on OFBIZ-1009:
> ---------------------------------------
>
> Just a quick thought: these appear to be new features and
> improvements of the PayPal stuff rather than a bug fix, and
> probably shouldn't be included in the release branch.
>
>> Reorganization of PayPalEvents
>> ------------------------------
>>
>> Key: OFBIZ-1009
>> URL: https://issues.apache.org/jira/browse/OFBIZ-1009
>> Project: OFBiz (The Open for Business Project)
>> Issue Type: Bug
>> Components: accounting
>> Affects Versions: SVN trunk, Release Branch 4.0
>> Environment: mac os x
>> Reporter: Marco Risaliti
>> Priority: Minor
>> Fix For: SVN trunk, Release Branch 4.0
>>
>>
>> I have reorganizated the PayPalEvents.java performing those tasks:
>> - removing unused variable to avoid compile warning
>> - removed hardcoded error messages to use uiLabels.properties
>> - correct the bug that does not create the payment for the order
>> that was paid on PayPal
>> - removed an hard-coded link to production PayPal (http://
>> www.paypal.com/cgi-bin/webscr) and retrieved from the
>> payment.properties
>> This patch can be tested also on the front-end application on
>> http://www.ofbiz.it
>> After review and commit this patch the issue OFBIZ-175 and
>> OFBIZ-247 can be closed.
>> Thanks in advance
>> Marco Risaliti
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1009) Reorganization of PayPalEvents

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato updated OFBIZ-1009:
-------------------------------------

Fix Version/s: (was: Release Branch 4.0)

> Reorganization of PayPalEvents
> ------------------------------
>
> Key: OFBIZ-1009
> URL: https://issues.apache.org/jira/browse/OFBIZ-1009
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk, Release Branch 4.0
> Environment: mac os x
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: PayPal.patch
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1009) Reorganization of PayPalEvents

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523617 ]

Marco Risaliti commented on OFBIZ-1009:
---------------------------------------

Can someone review and commit this patch in the trunk ?

Thanks in advance
Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1009) Reorganization of PayPalEvents

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534768 ]

Marco Risaliti commented on OFBIZ-1009:
---------------------------------------

Hi Jacques,

if you have the time also to review this patch it will be great.

Thanks in advance
Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1009) Reorganization of PayPalEvents

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534779 ]

Jacques Le Roux commented on OFBIZ-1009:
----------------------------------------

Hi Marco,

Yes I will soon. What David meant is that you have also changed some stuff not bug related. The best would have been to create a patch for bugs fixes and another one for other stuffes. Anyway, I will see if this really need to be in release when reviewing.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1009) Reorganization of PayPalEvents

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534802 ]

Marco Risaliti commented on OFBIZ-1009:
---------------------------------------

Hi Jacques,

if you want I can provide two different patches to solve the bug also into the release 4.0.
By the way I have seen that I have provide a wrong patch with no relative path to the ofbiz directory and so I will upload a new patch to solve this problem.

Thanks a lot
Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1009) Reorganization of PayPalEvents

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534813 ]

Jacques Le Roux commented on OFBIZ-1009:
----------------------------------------

Marco,

Yes of course, 2 patches would be better

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1009) Reorganization of PayPalEvents

In reply to this post by Nicolas Malin (Jira)

> Reorganization of PayPalEvents
> ------------------------------
>
> Key: OFBIZ-1009
> URL: https://issues.apache.org/jira/browse/OFBIZ-1009
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk, Release Branch 4.0
> Environment: mac os x
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1009) Reorganization of PayPalEvents

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-1009:
----------------------------------

Attachment: PayPal_bug.patch

Hi Jacques,

this is the patch that correct the bug in order payment preference creation and I have removed an hardcoded link to paypal production.
I think that this issue is currenctly present in release 4.0 but I have not tested in it.
I'm sure that with this patch the issue is solved in the trunk.

This are the steps to test the paypal:
- configure correctly the payment.properties to go to the paypal sandbox (https://www.sandbox.paypal.com/us/cgi-bin/webscr) and configure the return url to your public ip address of the current ofbiz running application.
- connect to paypal sandbox environment before open OFBiz and connect to PayPal Developer Central with your paypal buyer user
- checkout an order with paypal payment on the ecommerce application.
- ofbiz will redirect to paypal
- login to paypal with paypal buyer user
- press pay now and then return to merchant

Thanks
Marco

> Reorganization of PayPalEvents
> ------------------------------
>
> Key: OFBIZ-1009
> URL: https://issues.apache.org/jira/browse/OFBIZ-1009
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk, Release Branch 4.0
> Environment: mac os x
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: PayPal_bug.patch
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1009) Reorganization of PayPalEvents

In reply to this post by Nicolas Malin (Jira)

> Reorganization of PayPalEvents
> ------------------------------
>
> Key: OFBIZ-1009
> URL: https://issues.apache.org/jira/browse/OFBIZ-1009
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk, Release Branch 4.0
> Environment: mac os x
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: PayPal_bug.patch, PayPal_i18n.patch
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1009) Reorganization of PayPalEvents

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12535731 ]

Marco Risaliti commented on OFBIZ-1009:
---------------------------------------

Jacques,

remember to close the issue OFBIZ-175 and OFBIZ-247 if this issue will be closed because they are duplicate of the same issue.

Marco

> Reorganization of PayPalEvents
> ------------------------------
>
> Key: OFBIZ-1009
> URL: https://issues.apache.org/jira/browse/OFBIZ-1009
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk, Release Branch 4.0
> Environment: mac os x
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: PayPal_bug.patch, PayPal_i18n.patch
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1009) PayPalEvents does not create order payment preference

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-1009:
----------------------------------

Summary: PayPalEvents does not create order payment preference (was: Reorganization of PayPalEvents)

> PayPalEvents does not create order payment preference
> ------------------------------------------------------
>
> Key: OFBIZ-1009
> URL: https://issues.apache.org/jira/browse/OFBIZ-1009
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk, Release Branch 4.0
> Environment: mac os x
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: PayPal_bug.patch, PayPal_i18n.patch
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1009) PayPalEvents does not create order payment preference

In reply to this post by Nicolas Malin (Jira)

> PayPalEvents does not create order payment preference
> ------------------------------------------------------
>
> Key: OFBIZ-1009
> URL: https://issues.apache.org/jira/browse/OFBIZ-1009
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk, Release Branch 4.0
> Environment: mac os x
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: PayPal_bug.patch
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1009) PayPalEvents does not create order payment preference

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12535739 ]

Marco Risaliti commented on OFBIZ-1009:
---------------------------------------

Jacques,

I have move the improvements on PayPalEvents into the new issue OFBIZ-1351.

Marco

> PayPalEvents does not create order payment preference
> ------------------------------------------------------
>
> Key: OFBIZ-1009
> URL: https://issues.apache.org/jira/browse/OFBIZ-1009
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk, Release Branch 4.0
> Environment: mac os x
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: PayPal_bug.patch
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1009) PayPalEvents does not create order payment preference

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548894 ]

BJ Freeman commented on OFBIZ-1009:
-----------------------------------

not sure if this is an oversite
+#payment.paypal.confirm=http://www.paypal.com/cgi-bin/webscr
should be
+#payment.paypal.confirm=https://www.paypal.com/cgi-bin/webscr
https://www.paypal.com/IntegrationCenter/ic_ipn.html

> PayPalEvents does not create order payment preference
> ------------------------------------------------------
>
> Key: OFBIZ-1009
> URL: https://issues.apache.org/jira/browse/OFBIZ-1009
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk, Release Branch 4.0
> Environment: mac os x
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: PayPal_bug.patch
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Assigned: (OFBIZ-1009) PayPalEvents does not create order payment preference

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti reassigned OFBIZ-1009:
-------------------------------------

Assignee: Marco Risaliti

> PayPalEvents does not create order payment preference
> ------------------------------------------------------
>
> Key: OFBIZ-1009
> URL: https://issues.apache.org/jira/browse/OFBIZ-1009
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk, Release Branch 4.0
> Environment: mac os x
> Reporter: Marco Risaliti
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: PayPal_bug.patch
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1009) PayPalEvents does not create order payment preference

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-1009:
----------------------------------

Attachment: PayPal_bug2.patch

This is the new patch I have tested I will commit now in the trunk, I will leave this issue open because probably it has to be merged into the release 4 by at the moment I did not how to do it.

Thanks
Marco

> PayPalEvents does not create order payment preference
> ------------------------------------------------------
>
> Key: OFBIZ-1009
> URL: https://issues.apache.org/jira/browse/OFBIZ-1009
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk, Release Branch 4.0
> Environment: mac os x
> Reporter: Marco Risaliti
> Assignee: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: PayPal_bug.patch, PayPal_bug2.patch
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.