[jira] Created: (OFBIZ-1020) DatabaseUtil ofbiz startup scan fix

[Nicolas Malin (Jira)]

DatabaseUtil ofbiz startup scan fix
-----------------------------------

                 Key: OFBIZ-1020
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1020
             Project: OFBiz (The Open for Business Project)
          Issue Type: Improvement
          Components: framework
    Affects Versions: SVN trunk
         Environment: WinXP
            Reporter: Karl Eilebrecht
            Priority: Minor
             Fix For: SVN trunk
         Attachments: patch9653.patch

This issue is part of Key-Work Ofbiz Contribution Proposal.
http://docs.ofbiz.org/display/OFBIZ/Key-Work+Ofbiz+Contribution+Proposal

Based on Release: 540035
Includes:         -
Required:         -
Recommended:      -
Classes:          DatabaseUtil.java
Description:      Fixes Database scan to always perform all checks
                  independently of a single failure. Furthermore fixes
                  a problem with primary key analysis on some databases
                  due to not API-conforming call of getPrimaryKeys().

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Karl Eilebrecht updated OFBIZ-1020:
-----------------------------------

    Attachment: patch9653.patch

> DatabaseUtil ofbiz startup scan fix
> -----------------------------------
>
>                 Key: OFBIZ-1020
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1020
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: WinXP
>            Reporter: Karl Eilebrecht
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: patch9653.patch
>
>
> This issue is part of Key-Work Ofbiz Contribution Proposal.
> http://docs.ofbiz.org/display/OFBIZ/Key-Work+Ofbiz+Contribution+Proposal
> Based on Release: 540035
> Includes:         -
> Required:         -
> Recommended:      -
> Classes:          DatabaseUtil.java
> Description:      Fixes Database scan to always perform all checks
>                   independently of a single failure. Furthermore fixes
>                   a problem with primary key analysis on some databases
>                   due to not API-conforming call of getPrimaryKeys().

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1020:
-------------------------------

    Attachment: patch9653.patch

Attached patch updated to latest SVN. Removed unnecessary comments.

Karl - comments about what was changed and why can go in this Jira issue. After a change is committed, users can refer to the commit log, which will direct them to the Jira issue that preceded the commit.

> DatabaseUtil ofbiz startup scan fix
> -----------------------------------
>
>                 Key: OFBIZ-1020
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1020
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: WinXP
>            Reporter: Karl Eilebrecht
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: patch9653.patch, patch9653.patch
>
>
> This issue is part of Key-Work Ofbiz Contribution Proposal.
> http://docs.ofbiz.org/display/OFBIZ/Key-Work+Ofbiz+Contribution+Proposal
> Based on Release: 540035
> Includes:         -
> Required:         -
> Recommended:      -
> Classes:          DatabaseUtil.java
> Description:      Fixes Database scan to always perform all checks
>                   independently of a single failure. Furthermore fixes
>                   a problem with primary key analysis on some databases
>                   due to not API-conforming call of getPrimaryKeys().

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1020:
-------------------------------

    Issue Type: Bug  (was: Improvement)

I'm changing this issue to Bug because the patch provided fixes a known bug -

"fixes a problem with primary key analysis on some databases due to not API-conforming call of getPrimaryKeys()"

It would be better if the patch had been separated into two - improvement in one, bug fix in the other.

I have confirmed the bug fix works. Our database server (Advantage) throws exceptions at startup. The patch eliminates the exceptions.

> DatabaseUtil ofbiz startup scan fix
> -----------------------------------
>
>                 Key: OFBIZ-1020
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1020
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: WinXP
>            Reporter: Karl Eilebrecht
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: patch9653.patch, patch9653.patch
>
>
> This issue is part of Key-Work Ofbiz Contribution Proposal.
> http://docs.ofbiz.org/display/OFBIZ/Key-Work+Ofbiz+Contribution+Proposal
> Based on Release: 540035
> Includes:         -
> Required:         -
> Recommended:      -
> Classes:          DatabaseUtil.java
> Description:      Fixes Database scan to always perform all checks
>                   independently of a single failure. Furthermore fixes
>                   a problem with primary key analysis on some databases
>                   due to not API-conforming call of getPrimaryKeys().

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David E. Jones reassigned OFBIZ-1020:
-------------------------------------

    Assignee: David E. Jones

> DatabaseUtil ofbiz startup scan fix
> -----------------------------------
>
>                 Key: OFBIZ-1020
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1020
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: WinXP
>            Reporter: Karl Eilebrecht
>            Assignee: David E. Jones
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: patch9653.patch, patch9653.patch
>
>
> This issue is part of Key-Work Ofbiz Contribution Proposal.
> http://docs.ofbiz.org/display/OFBIZ/Key-Work+Ofbiz+Contribution+Proposal
> Based on Release: 540035
> Includes:         -
> Required:         -
> Recommended:      -
> Classes:          DatabaseUtil.java
> Description:      Fixes Database scan to always perform all checks
>                   independently of a single failure. Furthermore fixes
>                   a problem with primary key analysis on some databases
>                   due to not API-conforming call of getPrimaryKeys().

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David E. Jones closed OFBIZ-1020.
---------------------------------

    Resolution: Fixed

Thanks Karl and Adrian for your work on this. The changes for it are in SVN r579551. I made a few changes beyond the latest patch, as described in the commit notes:

"Applied patch from Karl Eilebrecht, cleaned up by Adrian Crum, to fix startup issues in SQL Server and other databases, including the latest version of Derby which I'll now put in here; after the patch I made a few changes to keep the stuff that tries to get data for all tables in one call as that tends to perform MUCH faster on certain databases, but now checks for errors and will try other methods as needed; right now this is only being done for primary key info, but the same pattern could be applied in other places if needed (and it may very well be); this should close Jira #OFBIZ-1020"

I also cleaned up some formatting and remove the serialized object IDs because I think the warnings in an IDE are less annoying than a stale version number for these objects, and humans tend to forget to update them.

> DatabaseUtil ofbiz startup scan fix
> -----------------------------------
>
>                 Key: OFBIZ-1020
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1020
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: WinXP
>            Reporter: Karl Eilebrecht
>            Assignee: David E. Jones
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: patch9653.patch, patch9653.patch
>
>
> This issue is part of Key-Work Ofbiz Contribution Proposal.
> http://docs.ofbiz.org/display/OFBIZ/Key-Work+Ofbiz+Contribution+Proposal
> Based on Release: 540035
> Includes:         -
> Required:         -
> Recommended:      -
> Classes:          DatabaseUtil.java
> Description:      Fixes Database scan to always perform all checks
>                   independently of a single failure. Furthermore fixes
>                   a problem with primary key analysis on some databases
>                   due to not API-conforming call of getPrimaryKeys().

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12530482 ]

Adrian Crum commented on OFBIZ-1020:
------------------------------------

Thanks David!  Rev 579551 fixes our databases exceptions.

> DatabaseUtil ofbiz startup scan fix
> -----------------------------------
>
>                 Key: OFBIZ-1020
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1020
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: WinXP
>            Reporter: Karl Eilebrecht
>            Assignee: David E. Jones
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: patch9653.patch, patch9653.patch
>
>
> This issue is part of Key-Work Ofbiz Contribution Proposal.
> http://docs.ofbiz.org/display/OFBIZ/Key-Work+Ofbiz+Contribution+Proposal
> Based on Release: 540035
> Includes:         -
> Required:         -
> Recommended:      -
> Classes:          DatabaseUtil.java
> Description:      Fixes Database scan to always perform all checks
>                   independently of a single failure. Furthermore fixes
>                   a problem with primary key analysis on some databases
>                   due to not API-conforming call of getPrimaryKeys().

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.