[jira] Created: (OFBIZ-1040) Submission of GeoData_IN.xml

[Nicolas Malin (Jira)]

Submission of GeoData_IN.xml
----------------------------

                 Key: OFBIZ-1040
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1040
             Project: OFBiz (The Open for Business Project)
          Issue Type: Improvement
            Reporter: Vikash Anand
            Priority: Minor


I am submitting GeoData_IN.xml

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikash Anand updated OFBIZ-1040:
--------------------------------

    Attachment: GeoData_IN.xml

First version of GeoData_IN.xml. Please let me know if i need to add something else.

> Submission of GeoData_IN.xml
> ----------------------------
>
>                 Key: OFBIZ-1040
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1040
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Vikash Anand
>            Priority: Minor
>         Attachments: GeoData_IN.xml
>
>
> I am submitting GeoData_IN.xml

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12499482 ]

Anil K Patel commented on OFBIZ-1040:
-------------------------------------

Looks good to me.
Anil

> Submission of GeoData_IN.xml
> ----------------------------
>
>                 Key: OFBIZ-1040
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1040
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Vikash Anand
>            Priority: Minor
>         Attachments: GeoData_IN.xml
>
>
> I am submitting GeoData_IN.xml

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato reassigned OFBIZ-1040:
----------------------------------------

    Assignee: Jacopo Cappellato

> Submission of GeoData_IN.xml
> ----------------------------
>
>                 Key: OFBIZ-1040
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1040
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Vikash Anand
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: GeoData_IN.xml
>
>
> I am submitting GeoData_IN.xml

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12502732 ]

Jacopo Cappellato commented on OFBIZ-1040:
------------------------------------------

I'm sorry but we cannot add this file as is now.
Apart from a few formatting issues (tabs instead of 4 spaces and 5-spaces formatting) some of the geo id conflicts with existing ones; for example:

geoId="MN"

To all: what is the best convention for geoId to avoid this kind of problems?

> Submission of GeoData_IN.xml
> ----------------------------
>
>                 Key: OFBIZ-1040
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1040
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Vikash Anand
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: GeoData_IN.xml
>
>
> I am submitting GeoData_IN.xml

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12502789 ]

Jacques Le Roux commented on OFBIZ-1040:
----------------------------------------

Hi Jacopo,

Is there a norm ? Else, we might prefix... (or suffix)

> Submission of GeoData_IN.xml
> ----------------------------
>
>                 Key: OFBIZ-1040
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1040
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Vikash Anand
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: GeoData_IN.xml
>
>
> I am submitting GeoData_IN.xml

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503357 ]

Jacopo Cappellato commented on OFBIZ-1040:
------------------------------------------

With reference to the comments in issue OFBIZ-582, please provide a modified file where all the geoId have a prefix of "IN-".
Also please verify if the "&" symbol, contained in at least one of the geo names, can cause problems to data import tools etc...

> Submission of GeoData_IN.xml
> ----------------------------
>
>                 Key: OFBIZ-1040
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1040
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Vikash Anand
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: GeoData_IN.xml
>
>
> I am submitting GeoData_IN.xml

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato closed OFBIZ-1040.
------------------------------------

    Resolution: Fixed

Vikash a modified version of your patch is in rev. 585403

> Submission of GeoData_IN.xml
> ----------------------------
>
>                 Key: OFBIZ-1040
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1040
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Vikash Anand
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: GeoData_IN.xml
>
>
> I am submitting GeoData_IN.xml

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.