[jira] Created: (OFBIZ-1041) various values in allowSolicitation variable break some screens
Locked
12
12
[jira] Commented: (OFBIZ-1041) various values in allowSolicitation variable break some screens
 
|
[ https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504438 ] Adrian Crum commented on OFBIZ-1041: ------------------------------------ It's a good idea to keep a sharp line drawn between the service layer and the presentation layer. This patch introduces UI elements into the service layer. Perhaps a better approach in the service layer is to simply check for "Y" - if it is anything else, default to "N". Also, a UI pattern I have been using lately is to have the current data select the correct list element, instead of displaying it twice. Example: <select name="allowSolicitation"> <#assign allowSolicitation = (mechMap.partyContactMech.allowSolicitation)?default("N")> <option value="Y"<#if allowSolitation == "Y"> selected="selected"</#if>>${uiLabelMap.CommonY}</option> <option value="N"<#if allowSolitation == "N"> selected="selected"</#if>>${uiLabelMap.CommonN}</option> </select> Not that this approach is any better, it's just different. > various values in allowSolicitation variable break some screens > ---------------------------------------------------------------- > > Key: OFBIZ-1041 > URL: https://issues.apache.org/jira/browse/OFBIZ-1041 > Project: OFBiz > Issue Type: Bug > Components: party > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Krzysztof Podejma > Assignee: Si Chen > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: allowSolicitation.patch > > > in contact forms field allowSolicitation is set to uiLabelMap.CommonY or uiLabelMap.CommonN. > it would be a good idea to force this value to Y or N because it is confusing if you use more than one language > additionaly different values break forms in other apps like crmsfa > please see my patch > Krzysztof Podejma -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
Drop-down current value styles (was Re: [jira] Commented: (OFBIZ-1041) various values in allowSolicitation variable break some screens)
|
|
Adrian Crum (JIRA) wrote: > Also, a UI pattern I have been using lately is to have the current data select the correct list element, instead of displaying it twice. Example: > > <select name="allowSolicitation"> > <#assign allowSolicitation = (mechMap.partyContactMech.allowSolicitation)?default("N")> > <option value="Y"<#if allowSolitation == "Y"> selected="selected"</#if>>${uiLabelMap.CommonY}</option> > <option value="N"<#if allowSolitation == "N"> selected="selected"</#if>>${uiLabelMap.CommonN}</option> > </select> > > Not that this approach is any better, it's just different. The main reason we have not used this approach in general is that it does not give as much information to the user. For simple applications it is fine and cleaner/smaller. For OFBiz we use the other pattern with the current values at the top and a separator that also default to the current value to err on the side of clarity and flexibility. The form widget supports both, BTW, and easily switches between them. The current value at the top has these benefits: 1. clarity: if another value is selected the user can still click on the drop-down and look at the top to see what the original value was 2. flexibility: if the current value is not part of the new options then we can't just select the one in the drop-down; this happens currently in various OFBiz screens, especially for status drop-downs that show the current status and all of the possible status transitions (usually there isn't a transition to go from one status back to itself) -David |
Re: Drop-down current value styles (was Re: [jira] Commented: (OFBIZ-1041) various values in allowSolicitation variable break some screens)
|
|
Very good points! Thank you for the insight.
David E Jones wrote: > > > Adrian Crum (JIRA) wrote: > >> Also, a UI pattern I have been using lately is to have the current >> data select the correct list element, instead of displaying it twice. >> Example: >> >> <select name="allowSolicitation"> >> <#assign allowSolicitation = >> (mechMap.partyContactMech.allowSolicitation)?default("N")> >> <option value="Y"<#if allowSolitation == "Y"> >> selected="selected"</#if>>${uiLabelMap.CommonY}</option> >> <option value="N"<#if allowSolitation == "N"> >> selected="selected"</#if>>${uiLabelMap.CommonN}</option> >> </select> >> >> Not that this approach is any better, it's just different. > > > The main reason we have not used this approach in general is that it > does not give as much information to the user. For simple applications > it is fine and cleaner/smaller. For OFBiz we use the other pattern with > the current values at the top and a separator that also default to the > current value to err on the side of clarity and flexibility. The form > widget supports both, BTW, and easily switches between them. > > The current value at the top has these benefits: > > 1. clarity: if another value is selected the user can still click on the > drop-down and look at the top to see what the original value was > > 2. flexibility: if the current value is not part of the new options then > we can't just select the one in the drop-down; this happens currently in > various OFBiz screens, especially for status drop-downs that show the > current status and all of the possible status transitions (usually there > isn't a transition to go from one status back to itself) > > -David > > |
[jira] Commented: (OFBIZ-1041) various values in allowSolicitation variable break some screens
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504447 ] Krzysztof Podejma commented on OFBIZ-1041: ------------------------------------------ Adrian, your proposal doesn't use current value so if user wants change only phone number, he has to set allowSolitation field too. If not, form will change Y to N. I think it is not user friendly and a little bit confusing. > various values in allowSolicitation variable break some screens > ---------------------------------------------------------------- > > Key: OFBIZ-1041 > URL: https://issues.apache.org/jira/browse/OFBIZ-1041 > Project: OFBiz > Issue Type: Bug > Components: party > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Krzysztof Podejma > Assignee: Si Chen > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: allowSolicitation.patch > > > in contact forms field allowSolicitation is set to uiLabelMap.CommonY or uiLabelMap.CommonN. > it would be a good idea to force this value to Y or N because it is confusing if you use more than one language > additionaly different values break forms in other apps like crmsfa > please see my patch > Krzysztof Podejma -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Issue Comment Edited: (OFBIZ-1041) various values in allowSolicitation variable break some screens
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504447 ] Krzysztof Podejma edited comment on OFBIZ-1041 at 6/13/07 2:50 PM: ------------------------------------------------------------------- Adrian, your proposal doesn't use current value so if user wants change only phone number, he has to set allowSolitation field too. If not, form will change Y to N. I think it is not user friendly and a little bit confusing. I think "Y","N","" is the right way "" - dont know was: Adrian, your proposal doesn't use current value so if user wants change only phone number, he has to set allowSolitation field too. If not, form will change Y to N. I think it is not user friendly and a little bit confusing. > various values in allowSolicitation variable break some screens > ---------------------------------------------------------------- > > Key: OFBIZ-1041 > URL: https://issues.apache.org/jira/browse/OFBIZ-1041 > Project: OFBiz > Issue Type: Bug > Components: party > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Krzysztof Podejma > Assignee: Si Chen > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: allowSolicitation.patch > > > in contact forms field allowSolicitation is set to uiLabelMap.CommonY or uiLabelMap.CommonN. > it would be a good idea to force this value to Y or N because it is confusing if you use more than one language > additionaly different values break forms in other apps like crmsfa > please see my patch > Krzysztof Podejma -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
Re: Drop-down current value styles (was Re: [jira] Commented: (OFBIZ-1041) various values in allowSolicitation variable break some screens)
Administrator
|
In reply to this post by Adrian Crum
Thanks for clarification David.
Jacques De : "Adrian Crum" <[hidden email]> > Very good points! Thank you for the insight. > > David E Jones wrote: > > > > > > Adrian Crum (JIRA) wrote: > > > >> Also, a UI pattern I have been using lately is to have the current > >> data select the correct list element, instead of displaying it twice. > >> Example: > >> > >> <select name="allowSolicitation"> > >> <#assign allowSolicitation = > >> (mechMap.partyContactMech.allowSolicitation)?default("N")> > >> <option value="Y"<#if allowSolitation == "Y"> > >> selected="selected"</#if>>${uiLabelMap.CommonY}</option> > >> <option value="N"<#if allowSolitation == "N"> > >> selected="selected"</#if>>${uiLabelMap.CommonN}</option> > >> </select> > >> > >> Not that this approach is any better, it's just different. > > > > > > The main reason we have not used this approach in general is that it > > does not give as much information to the user. For simple > > it is fine and cleaner/smaller. For OFBiz we use the other pattern with > > the current values at the top and a separator that also default to the > > current value to err on the side of clarity and flexibility. The form > > widget supports both, BTW, and easily switches between them. > > > > The current value at the top has these benefits: > > > > 1. clarity: if another value is selected the user can still click on the > > drop-down and look at the top to see what the original value was > > > > 2. flexibility: if the current value is not part of the new options then > > we can't just select the one in the drop-down; this happens currently in > > various OFBiz screens, especially for status drop-downs that show the > > current status and all of the possible status transitions (usually there > > isn't a transition to go from one status back to itself) > > > > -David > > > > |
[jira] Closed: (OFBIZ-1041) various values in allowSolicitation variable break some screens
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-1041. ---------------------------------- Resolution: Won't Fix Assignee: Jacques Le Roux (was: Si Chen) Si, I think this issue should be closed. Else please feel free to re-open > various values in allowSolicitation variable break some screens > ---------------------------------------------------------------- > > Key: OFBIZ-1041 > URL: https://issues.apache.org/jira/browse/OFBIZ-1041 > Project: OFBiz > Issue Type: Bug > Components: party > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Krzysztof Podejma > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: allowSolicitation.patch > > > in contact forms field allowSolicitation is set to uiLabelMap.CommonY or uiLabelMap.CommonN. > it would be a good idea to force this value to Y or N because it is confusing if you use more than one language > additionaly different values break forms in other apps like crmsfa > please see my patch > Krzysztof Podejma -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1041) various values in allowSolicitation variable break some screens
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512623 ] Krzysztof Podejma commented on OFBIZ-1041: ------------------------------------------ so it will not be fixed? > various values in allowSolicitation variable break some screens > ---------------------------------------------------------------- > > Key: OFBIZ-1041 > URL: https://issues.apache.org/jira/browse/OFBIZ-1041 > Project: OFBiz > Issue Type: Bug > Components: party > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Krzysztof Podejma > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: allowSolicitation.patch > > > in contact forms field allowSolicitation is set to uiLabelMap.CommonY or uiLabelMap.CommonN. > it would be a good idea to force this value to Y or N because it is confusing if you use more than one language > additionaly different values break forms in other apps like crmsfa > please see my patch > Krzysztof Podejma -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1041) various values in allowSolicitation variable break some screens
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512629 ] Adrian Crum commented on OFBIZ-1041: ------------------------------------ The problem still exists. From line 224 of applications/party/webapp/partymgr/party/editcontactmech.ftl: <select name="allowSolicitation"> <option>${(mechMap.partyContactMech.allowSolicitation)?if_exists}</option> <option></option><option>${uiLabelMap.CommonY}</option><option>${uiLabelMap.CommonN}</option> </select> If a user has selected a locale that doesn't use Y and N to represent Yes and No, then the data returned by this code will be invalid. The code should be something like: <select name="allowSolicitation"> <#if (mechMap.partyContactMech.allowSolicitation)?exists > <#if (mechMap.partyContactMech.allowSolicitation?default("") == "Y")><option value="Y">${uiLabelMap.CommonY}</option></#if> <#if (mechMap.partyContactMech.allowSolicitation?default("") == "N")><option value="N">${uiLabelMap.CommonN}</option></#if> </#if> <option></option><option value="Y">${uiLabelMap.CommonY}</option><option value="N">${uiLabelMap.CommonN}</option> </select> Maybe Krzysztof can prepare an updated patch. > various values in allowSolicitation variable break some screens > ---------------------------------------------------------------- > > Key: OFBIZ-1041 > URL: https://issues.apache.org/jira/browse/OFBIZ-1041 > Project: OFBiz > Issue Type: Bug > Components: party > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Krzysztof Podejma > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: allowSolicitation.patch > > > in contact forms field allowSolicitation is set to uiLabelMap.CommonY or uiLabelMap.CommonN. > it would be a good idea to force this value to Y or N because it is confusing if you use more than one language > additionaly different values break forms in other apps like crmsfa > please see my patch > Krzysztof Podejma -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Reopened: (OFBIZ-1041) various values in allowSolicitation variable break some screens
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-1041: ------------------------------------ Yes right sorry, open for a patch (we are close to it I guess ;o) > various values in allowSolicitation variable break some screens > ---------------------------------------------------------------- > > Key: OFBIZ-1041 > URL: https://issues.apache.org/jira/browse/OFBIZ-1041 > Project: OFBiz > Issue Type: Bug > Components: party > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Krzysztof Podejma > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: allowSolicitation.patch > > > in contact forms field allowSolicitation is set to uiLabelMap.CommonY or uiLabelMap.CommonN. > it would be a good idea to force this value to Y or N because it is confusing if you use more than one language > additionaly different values break forms in other apps like crmsfa > please see my patch > Krzysztof Podejma -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Closed: (OFBIZ-1041) various values in allowSolicitation variable break some screens
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-1041. ---------------------------------- Resolution: Fixed I finally commited a bunch of changes in trunk rev. 556172 and 556181 and in release4.0 rev. 556185 > various values in allowSolicitation variable break some screens > ---------------------------------------------------------------- > > Key: OFBIZ-1041 > URL: https://issues.apache.org/jira/browse/OFBIZ-1041 > Project: OFBiz > Issue Type: Bug > Components: party > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Krzysztof Podejma > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: allowSolicitation.patch > > > in contact forms field allowSolicitation is set to uiLabelMap.CommonY or uiLabelMap.CommonN. > it would be a good idea to force this value to Y or N because it is confusing if you use more than one language > additionaly different values break forms in other apps like crmsfa > please see my patch > Krzysztof Podejma -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1041) various values in allowSolicitation variable break some screens
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512719 ] Adrian Crum commented on OFBIZ-1041: ------------------------------------ Jacques, I reviewed your commits and they are still not quite right. Example: Go to the edit contact mech page: https://127.0.0.1:8443/partymgr/control/editcontactmech?partyId=DemoCustomer&contactMechId=9025 click on the Allow Solicitation drop down list and notice the choices. Then switch to the Russian locale (just below Romanian). Refresh the page and look at the drop down list's choices again. The current selection is Y and the other two are translated to Russian. I committed the correct code (for this page only) in rev 556290. Check it out. > various values in allowSolicitation variable break some screens > ---------------------------------------------------------------- > > Key: OFBIZ-1041 > URL: https://issues.apache.org/jira/browse/OFBIZ-1041 > Project: OFBiz > Issue Type: Bug > Components: party > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Krzysztof Podejma > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: allowSolicitation.patch > > > in contact forms field allowSolicitation is set to uiLabelMap.CommonY or uiLabelMap.CommonN. > it would be a good idea to force this value to Y or N because it is confusing if you use more than one language > additionaly different values break forms in other apps like crmsfa > please see my patch > Krzysztof Podejma -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1041) various values in allowSolicitation variable break some screens
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512737 ] Jacques Le Roux commented on OFBIZ-1041: ---------------------------------------- Adrian, Yes I know you are right, I laready read your comment above ;o). I did that late tonight yesterday to treat quickly all cases and I simplified to be sure to not warp everything. I will review my work. It's easier now that it's "standardized". Thanks > various values in allowSolicitation variable break some screens > ---------------------------------------------------------------- > > Key: OFBIZ-1041 > URL: https://issues.apache.org/jira/browse/OFBIZ-1041 > Project: OFBiz > Issue Type: Bug > Components: party > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Krzysztof Podejma > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: allowSolicitation.patch > > > in contact forms field allowSolicitation is set to uiLabelMap.CommonY or uiLabelMap.CommonN. > it would be a good idea to force this value to Y or N because it is confusing if you use more than one language > additionaly different values break forms in other apps like crmsfa > please see my patch > Krzysztof Podejma -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1041) various values in allowSolicitation variable break some screens
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512784 ] Jacques Le Roux commented on OFBIZ-1041: ---------------------------------------- It's finally done :o) When I did the changes I was a bit puzzled because I found some new operators (at least ! and ??, see http://freemarker.org/docs/dgui_template_exp.html#dgui_template_exp_missing_default) but no use ot them in OFBiz. So I was not sure if I it was a good practice to use them (it was late and I preferred to not take any risks). Something also that prevent me at 1st to do it is that the freemarker plugins in Eclipse (I use hudson.freemarker_ide_0.9.14) does not take care of them yet). But this operators look cool (who will prefer default?() against ! ;o) and finally thismorning I decided to begin to use them. So I used this scheme (whitout unneded <#if (allowSolicitation)?exists > block around) <#if (()!"" == "Y")><option value="test">${uiLabelMap.CommonY}</option></#if> <#if (()!"" == "N")><option value="N">${uiLabelMap.CommonN}</option></#if> This definitively closes the "various values in allowSolicitation variable break some screens" (https://issues.apache.org/jira/browse/OFBIZ-1041). I used the same simple scheme everywhere but where no data was reloaded (like apparently in EditCategoryProducts.ftl and EditProductPromoRules.ftl) In trunk rev. 556373 Release4.0 revision: 556376, manually merged from trunk revision 556373 for some files Conflicts resolved by hand : EditProductStorePaySetup.ftl applications/party/webapp/partymgr/party/editcontactmech.ftl genericaddress.ftl editShoppingList.ftl newcustomer.ftl > various values in allowSolicitation variable break some screens > ---------------------------------------------------------------- > > Key: OFBIZ-1041 > URL: https://issues.apache.org/jira/browse/OFBIZ-1041 > Project: OFBiz > Issue Type: Bug > Components: party > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Krzysztof Podejma > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: allowSolicitation.patch > > > in contact forms field allowSolicitation is set to uiLabelMap.CommonY or uiLabelMap.CommonN. > it would be a good idea to force this value to Y or N because it is confusing if you use more than one language > additionaly different values break forms in other apps like crmsfa > please see my patch > Krzysztof Podejma -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1041) various values in allowSolicitation variable break some screens
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512786 ] Jacques Le Roux commented on OFBIZ-1041: ---------------------------------------- Oops, some parenthesis were missing in rev. 556376 of course should not be <#if (()!"" == "Y")><option value="test">${uiLabelMap.CommonY}</option></#if> <#if (()!"" == "N")><option value="N">${uiLabelMap.CommonN}</option></#if> but <#if ((()!"") == "Y")><option value="test">${uiLabelMap.CommonY}</option></#if> <#if ((()!"") == "N")><option value="N">${uiLabelMap.CommonN}</option></#if> Not yet well familiarised with ! operator :o/ > various values in allowSolicitation variable break some screens > ---------------------------------------------------------------- > > Key: OFBIZ-1041 > URL: https://issues.apache.org/jira/browse/OFBIZ-1041 > Project: OFBiz > Issue Type: Bug > Components: party > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Krzysztof Podejma > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: allowSolicitation.patch > > > in contact forms field allowSolicitation is set to uiLabelMap.CommonY or uiLabelMap.CommonN. > it would be a good idea to force this value to Y or N because it is confusing if you use more than one language > additionaly different values break forms in other apps like crmsfa > please see my patch > Krzysztof Podejma -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1041) various values in allowSolicitation variable break some screens
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512787 ] Jacques Le Roux commented on OFBIZ-1041: ---------------------------------------- And it seemed to me a simple issue ;o) Finally(?) in trunk rev. 556379 release 556381 > various values in allowSolicitation variable break some screens > ---------------------------------------------------------------- > > Key: OFBIZ-1041 > URL: https://issues.apache.org/jira/browse/OFBIZ-1041 > Project: OFBiz > Issue Type: Bug > Components: party > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Krzysztof Podejma > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: allowSolicitation.patch > > > in contact forms field allowSolicitation is set to uiLabelMap.CommonY or uiLabelMap.CommonN. > it would be a good idea to force this value to Y or N because it is confusing if you use more than one language > additionaly different values break forms in other apps like crmsfa > please see my patch > Krzysztof Podejma -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1041) various values in allowSolicitation variable break some screens
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512788 ] Jacques Le Roux commented on OFBIZ-1041: ---------------------------------------- ? in Finally(?) above was premonition : Put test in place of Y. Definitively not my day, I should not work on sunday :o( OK in trunk rev. 556382 release 556383 > various values in allowSolicitation variable break some screens > ---------------------------------------------------------------- > > Key: OFBIZ-1041 > URL: https://issues.apache.org/jira/browse/OFBIZ-1041 > Project: OFBiz > Issue Type: Bug > Components: party > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Krzysztof Podejma > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: allowSolicitation.patch > > > in contact forms field allowSolicitation is set to uiLabelMap.CommonY or uiLabelMap.CommonN. > it would be a good idea to force this value to Y or N because it is confusing if you use more than one language > additionaly different values break forms in other apps like crmsfa > please see my patch > Krzysztof Podejma -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1041) various values in allowSolicitation variable break some screens
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512790 ] Krzysztof Podejma commented on OFBIZ-1041: ------------------------------------------ I had to leave on weekend. Is it done now, or needs test? > various values in allowSolicitation variable break some screens > ---------------------------------------------------------------- > > Key: OFBIZ-1041 > URL: https://issues.apache.org/jira/browse/OFBIZ-1041 > Project: OFBiz > Issue Type: Bug > Components: party > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Krzysztof Podejma > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: allowSolicitation.patch > > > in contact forms field allowSolicitation is set to uiLabelMap.CommonY or uiLabelMap.CommonN. > it would be a good idea to force this value to Y or N because it is confusing if you use more than one language > additionaly different values break forms in other apps like crmsfa > please see my patch > Krzysztof Podejma -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1041) various values in allowSolicitation variable break some screens
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512795 ] Jacques Le Roux commented on OFBIZ-1041: ---------------------------------------- It should be done, but of course more tests are always welcome... > various values in allowSolicitation variable break some screens > ---------------------------------------------------------------- > > Key: OFBIZ-1041 > URL: https://issues.apache.org/jira/browse/OFBIZ-1041 > Project: OFBiz > Issue Type: Bug > Components: party > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Krzysztof Podejma > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: allowSolicitation.patch > > > in contact forms field allowSolicitation is set to uiLabelMap.CommonY or uiLabelMap.CommonN. > it would be a good idea to force this value to Y or N because it is confusing if you use more than one language > additionaly different values break forms in other apps like crmsfa > please see my patch > Krzysztof Podejma -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |