[jira] Created: (OFBIZ-1041) various values in allowSolicitation variable break some screens
Locked
12
12
[jira] Created: (OFBIZ-1041) various values in allowSolicitation variable break some screens
 
|
various values in allowSolicitation variable break some screens
---------------------------------------------------------------- Key: OFBIZ-1041 URL: https://issues.apache.org/jira/browse/OFBIZ-1041 Project: OFBiz (The Open for Business Project) Issue Type: Bug Components: party Affects Versions: SVN trunk, Release Branch 4.0 Reporter: Krzysztof Podejma Priority: Minor Fix For: SVN trunk, Release Branch 4.0 Attachments: allowSolicitation.patch in contact forms field allowSolicitation is set to uiLabelMap.CommonY or uiLabelMap.CommonN. it would be a good idea to force this value to Y or N because it is confusing if you use more than one language additionaly different values break forms in other apps like crmsfa please see my patch Krzysztof Podejma -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-1041) various values in allowSolicitation variable break some screens
|
|
[ https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krzysztof Podejma updated OFBIZ-1041: ------------------------------------- Attachment: allowSolicitation.patch > various values in allowSolicitation variable break some screens > ---------------------------------------------------------------- > > Key: OFBIZ-1041 > URL: https://issues.apache.org/jira/browse/OFBIZ-1041 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: party > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Krzysztof Podejma > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: allowSolicitation.patch > > > in contact forms field allowSolicitation is set to uiLabelMap.CommonY or uiLabelMap.CommonN. > it would be a good idea to force this value to Y or N because it is confusing if you use more than one language > additionaly different values break forms in other apps like crmsfa > please see my patch > Krzysztof Podejma -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1041) various values in allowSolicitation variable break some screens
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504250 ] Si Chen commented on OFBIZ-1041: -------------------------------- I don't know about this one. For a Chinese user, for example, Y or N might not have any meaning. Could you give me an example of the problem you see with using CommonY/CommonN? > various values in allowSolicitation variable break some screens > ---------------------------------------------------------------- > > Key: OFBIZ-1041 > URL: https://issues.apache.org/jira/browse/OFBIZ-1041 > Project: OFBiz > Issue Type: Bug > Components: party > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Krzysztof Podejma > Assignee: Si Chen > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: allowSolicitation.patch > > > in contact forms field allowSolicitation is set to uiLabelMap.CommonY or uiLabelMap.CommonN. > it would be a good idea to force this value to Y or N because it is confusing if you use more than one language > additionaly different values break forms in other apps like crmsfa > please see my patch > Krzysztof Podejma -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Assigned: (OFBIZ-1041) various values in allowSolicitation variable break some screens
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Si Chen reassigned OFBIZ-1041: ------------------------------ Assignee: Si Chen > various values in allowSolicitation variable break some screens > ---------------------------------------------------------------- > > Key: OFBIZ-1041 > URL: https://issues.apache.org/jira/browse/OFBIZ-1041 > Project: OFBiz > Issue Type: Bug > Components: party > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Krzysztof Podejma > Assignee: Si Chen > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: allowSolicitation.patch > > > in contact forms field allowSolicitation is set to uiLabelMap.CommonY or uiLabelMap.CommonN. > it would be a good idea to force this value to Y or N because it is confusing if you use more than one language > additionaly different values break forms in other apps like crmsfa > please see my patch > Krzysztof Podejma -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1041) various values in allowSolicitation variable break some screens
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504267 ] Krzysztof Podejma commented on OFBIZ-1041: ------------------------------------------ i.e. in crmsfa in viewprofile.ftl you have <#if (partyContactMech.allowSolicitation?default("") == "Y")><#assign solicit = uiLabelMap.CommonYes></#if> <#if (partyContactMech.allowSolicitation?default("") == "N")><#assign solicit = uiLabelMap.CommonNo></#if> so if this field don't have values from (Y,N) nothing is displayed second example is marketing list with emails and choosing email address by this field having this field with set of values Y,N,"" is good for system to indicate whether it is exactly YES or NOT if you have multilingual employees that use russian (D,N) polish (T,N), english (Y,N) set of those values will be D,T,Y,N so system will not be able to indicate what is YES and what is NOT > various values in allowSolicitation variable break some screens > ---------------------------------------------------------------- > > Key: OFBIZ-1041 > URL: https://issues.apache.org/jira/browse/OFBIZ-1041 > Project: OFBiz > Issue Type: Bug > Components: party > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Krzysztof Podejma > Assignee: Si Chen > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: allowSolicitation.patch > > > in contact forms field allowSolicitation is set to uiLabelMap.CommonY or uiLabelMap.CommonN. > it would be a good idea to force this value to Y or N because it is confusing if you use more than one language > additionaly different values break forms in other apps like crmsfa > please see my patch > Krzysztof Podejma -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1041) various values in allowSolicitation variable break some screens
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504331 ] David E. Jones commented on OFBIZ-1041: --------------------------------------- I'm totally with Si on this one, and it's important as this sort of thing has been broken by i18n efforts in the past. You can show other things to the user, but the system should ALWAYS store Y or N, otherwise how are we going to write low level service, queries, etc, especially searching for things entered by users from different locales/languages? This is very important. > various values in allowSolicitation variable break some screens > ---------------------------------------------------------------- > > Key: OFBIZ-1041 > URL: https://issues.apache.org/jira/browse/OFBIZ-1041 > Project: OFBiz > Issue Type: Bug > Components: party > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Krzysztof Podejma > Assignee: Si Chen > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: allowSolicitation.patch > > > in contact forms field allowSolicitation is set to uiLabelMap.CommonY or uiLabelMap.CommonN. > it would be a good idea to force this value to Y or N because it is confusing if you use more than one language > additionaly different values break forms in other apps like crmsfa > please see my patch > Krzysztof Podejma -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1041) various values in allowSolicitation variable break some screens
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504346 ] Adrian Crum commented on OFBIZ-1041: ------------------------------------ Maybe something is getting lost in the translation. It seems to me that the attached patches ENFORCE David's point. For example, the line in applications/party/webapp/partymgr/party/editcontactmech.ftl - <option>${(mechMap.partyContactMech.allowSolicitation)?if_exists}</option> wouldn't make sense to someone who doesn't speak English because the raw data (Y/N) is being displayed. The patch fixes this by using the raw data (Y/N) to look up the correct UI label (CommonY/CommonN) - <#if (mechMap.partyContactMech.allowSolicitation)?exists > <option><#if (mechMap.partyContactMech.allowSolicitation?default("") == "Y")>${uiLabelMap.CommonY}</#if> <#if (mechMap.partyContactMech.allowSolicitation?default("") == "N")>${uiLabelMap.CommonN}</#if> </option> </#if> > various values in allowSolicitation variable break some screens > ---------------------------------------------------------------- > > Key: OFBIZ-1041 > URL: https://issues.apache.org/jira/browse/OFBIZ-1041 > Project: OFBiz > Issue Type: Bug > Components: party > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Krzysztof Podejma > Assignee: Si Chen > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: allowSolicitation.patch > > > in contact forms field allowSolicitation is set to uiLabelMap.CommonY or uiLabelMap.CommonN. > it would be a good idea to force this value to Y or N because it is confusing if you use more than one language > additionaly different values break forms in other apps like crmsfa > please see my patch > Krzysztof Podejma -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1041) various values in allowSolicitation variable break some screens
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504349 ] David E. Jones commented on OFBIZ-1041: --------------------------------------- Thanks Adrian, just after writing that while I was reading other email I wondered if I had read it backwards, and I think you're totally right that I did! Anyway, hopefully my point is clear. It's great to internationalize what the user sees, but not the system values. > various values in allowSolicitation variable break some screens > ---------------------------------------------------------------- > > Key: OFBIZ-1041 > URL: https://issues.apache.org/jira/browse/OFBIZ-1041 > Project: OFBiz > Issue Type: Bug > Components: party > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Krzysztof Podejma > Assignee: Si Chen > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: allowSolicitation.patch > > > in contact forms field allowSolicitation is set to uiLabelMap.CommonY or uiLabelMap.CommonN. > it would be a good idea to force this value to Y or N because it is confusing if you use more than one language > additionaly different values break forms in other apps like crmsfa > please see my patch > Krzysztof Podejma -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1041) various values in allowSolicitation variable break some screens
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504351 ] Krzysztof Podejma commented on OFBIZ-1041: ------------------------------------------ I think checking my patch will make you sure that we have the same point of view. > various values in allowSolicitation variable break some screens > ---------------------------------------------------------------- > > Key: OFBIZ-1041 > URL: https://issues.apache.org/jira/browse/OFBIZ-1041 > Project: OFBiz > Issue Type: Bug > Components: party > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Krzysztof Podejma > Assignee: Si Chen > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: allowSolicitation.patch > > > in contact forms field allowSolicitation is set to uiLabelMap.CommonY or uiLabelMap.CommonN. > it would be a good idea to force this value to Y or N because it is confusing if you use more than one language > additionaly different values break forms in other apps like crmsfa > please see my patch > Krzysztof Podejma -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1041) various values in allowSolicitation variable break some screens
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504366 ] Oleg Andreyev commented on OFBIZ-1041: -------------------------------------- Thanks Krzysztof for pointing this error out. Current code in editcontactmech.ftl is inadmissible. This is fragment of your patch <select name="allowSolicitation"> - <option>${(mechMap.partyContactMech.allowSolicitation)?if_exists}</option> + <#if (mechMap.partyContactMech.allowSolicitation)?exists > + <option><#if (mechMap.partyContactMech.allowSolicitation?default("") == "Y")>${uiLabelMap.CommonY}</#if> + <#if (mechMap.partyContactMech.allowSolicitation?default("") == "N")>${uiLabelMap.CommonN}</#if> + </option> + </#if> <option></option><option>${uiLabelMap.CommonY}</option><option>${uiLabelMap.CommonN}</option> </select> It's something wrong. I think the right way for ftl is: <select name="somename"> <option value="N">${uiLabelMap.CommonN}</option> <option value="Y">${uiLabelMap.CommonY}</option> </select> correspondingly for forms: <drop-down allow-empty="false"> <option key="Y" description="${uiLabelMap.CommonY}"/> <option key="N" description="${uiLabelMap.CommonN}"/> </drop-down> > various values in allowSolicitation variable break some screens > ---------------------------------------------------------------- > > Key: OFBIZ-1041 > URL: https://issues.apache.org/jira/browse/OFBIZ-1041 > Project: OFBiz > Issue Type: Bug > Components: party > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Krzysztof Podejma > Assignee: Si Chen > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: allowSolicitation.patch > > > in contact forms field allowSolicitation is set to uiLabelMap.CommonY or uiLabelMap.CommonN. > it would be a good idea to force this value to Y or N because it is confusing if you use more than one language > additionaly different values break forms in other apps like crmsfa > please see my patch > Krzysztof Podejma -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1041) various values in allowSolicitation variable break some screens
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504387 ] Krzysztof Podejma commented on OFBIZ-1041: ------------------------------------------ code : <select name="allowSolicitation"> <#if (mechMap.partyContactMech.allowSolicitation)?exists > <option><#if (mechMap.partyContactMech.allowSolicitation?default("") == "Y")>${uiLabelMap.CommonY}</#if> <#if (mechMap.partyContactMech.allowSolicitation?default("") == "N")>${uiLabelMap.CommonN}</#if> </option> </#if> <option></option><option>${uiLabelMap.CommonY}</option><option>${uiLabelMap.CommonN}</option> </select> is correct because we want to show current value of alllowSolicitation to user in his language. your way is not so right in this case because if user omit this field, it will be submited with N value. Even if value was Y > various values in allowSolicitation variable break some screens > ---------------------------------------------------------------- > > Key: OFBIZ-1041 > URL: https://issues.apache.org/jira/browse/OFBIZ-1041 > Project: OFBiz > Issue Type: Bug > Components: party > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Krzysztof Podejma > Assignee: Si Chen > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: allowSolicitation.patch > > > in contact forms field allowSolicitation is set to uiLabelMap.CommonY or uiLabelMap.CommonN. > it would be a good idea to force this value to Y or N because it is confusing if you use more than one language > additionaly different values break forms in other apps like crmsfa > please see my patch > Krzysztof Podejma -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1041) various values in allowSolicitation variable break some screens
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504394 ] David E. Jones commented on OFBIZ-1041: --------------------------------------- Okay, I was just looking at the code and it looks like this breaks the pattern I noted as very important in my comments. What this code does is internationalize what the user sees AND what is sent to the server. That will break things and is a big problem. What needs to happen whenever there is a i18n'ed label inside <option></option> the value attribute on the option element MUST be used. For example instead of: <option>${uiLabelMap.CommonY}</option> (BAD) you should use: <option value="Y">${uiLabelMap.CommonY}</option> (GOOD) > various values in allowSolicitation variable break some screens > ---------------------------------------------------------------- > > Key: OFBIZ-1041 > URL: https://issues.apache.org/jira/browse/OFBIZ-1041 > Project: OFBiz > Issue Type: Bug > Components: party > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Krzysztof Podejma > Assignee: Si Chen > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: allowSolicitation.patch > > > in contact forms field allowSolicitation is set to uiLabelMap.CommonY or uiLabelMap.CommonN. > it would be a good idea to force this value to Y or N because it is confusing if you use more than one language > additionaly different values break forms in other apps like crmsfa > please see my patch > Krzysztof Podejma -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1041) various values in allowSolicitation variable break some screens
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504398 ] Krzysztof Podejma commented on OFBIZ-1041: ------------------------------------------ in ofbiz trunk you have <select name="allowSolicitation"> <option>${(mechMap.partyContactMech.allowSolicitation)?if_exists}</option> <option></option><option>${uiLabelMap.CommonY}</option><option>${uiLabelMap.CommonN}</option> </select> and i fixed this to: <select name="allowSolicitation"> <#if (mechMap.partyContactMech.allowSolicitation)?exists > <option><#if (mechMap.partyContactMech.allowSolicitation?default("") == "Y")>${uiLabelMap.CommonY}</#if> <#if (mechMap.partyContactMech.allowSolicitation?default("") == "N")>${uiLabelMap.CommonN}</#if> </option> </#if> <option></option><option>${uiLabelMap.CommonY}</option><option>${uiLabelMap.CommonN}</option> </select> my patch is a simple fix, not refactoring > various values in allowSolicitation variable break some screens > ---------------------------------------------------------------- > > Key: OFBIZ-1041 > URL: https://issues.apache.org/jira/browse/OFBIZ-1041 > Project: OFBiz > Issue Type: Bug > Components: party > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Krzysztof Podejma > Assignee: Si Chen > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: allowSolicitation.patch > > > in contact forms field allowSolicitation is set to uiLabelMap.CommonY or uiLabelMap.CommonN. > it would be a good idea to force this value to Y or N because it is confusing if you use more than one language > additionaly different values break forms in other apps like crmsfa > please see my patch > Krzysztof Podejma -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1041) various values in allowSolicitation variable break some screens
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504400 ] David E. Jones commented on OFBIZ-1041: --------------------------------------- Yeah, but that will actually break things more. As soon as you submit the form in a different locale and try to look at it the "Y" and "N" won't match. > various values in allowSolicitation variable break some screens > ---------------------------------------------------------------- > > Key: OFBIZ-1041 > URL: https://issues.apache.org/jira/browse/OFBIZ-1041 > Project: OFBiz > Issue Type: Bug > Components: party > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Krzysztof Podejma > Assignee: Si Chen > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: allowSolicitation.patch > > > in contact forms field allowSolicitation is set to uiLabelMap.CommonY or uiLabelMap.CommonN. > it would be a good idea to force this value to Y or N because it is confusing if you use more than one language > additionaly different values break forms in other apps like crmsfa > please see my patch > Krzysztof Podejma -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1041) various values in allowSolicitation variable break some screens
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504405 ] Krzysztof Podejma commented on OFBIZ-1041: ------------------------------------------ maybe you haven't noticed. This patch adds <!-- allowSolicitation is forced to Y or N --> <property-to-field resource="CommonUiLabels" property="CommonY" field-name="commonY"/> <property-to-field resource="CommonUiLabels" property="CommonY" field-name="commonN"/> <if> <condition><if-compare field-name="newPartyContactMech.allowSolicitation" operator="equals" value="${commonY}"/></condition> <then> <set field="newPartyContactMech.allowSolicitation" value="Y" /> </then> <else-if> <condition><if-compare field-name="newPartyContactMech.allowSolicitation" operator="equals" value="${commonN}"/></condition> <then> <set field="newPartyContactMech.allowSolicitation" value="N" /> </then> </else-if> </if> to updatePartyContactMech to fix all other screen that want to pass invalid value > various values in allowSolicitation variable break some screens > ---------------------------------------------------------------- > > Key: OFBIZ-1041 > URL: https://issues.apache.org/jira/browse/OFBIZ-1041 > Project: OFBiz > Issue Type: Bug > Components: party > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Krzysztof Podejma > Assignee: Si Chen > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: allowSolicitation.patch > > > in contact forms field allowSolicitation is set to uiLabelMap.CommonY or uiLabelMap.CommonN. > it would be a good idea to force this value to Y or N because it is confusing if you use more than one language > additionaly different values break forms in other apps like crmsfa > please see my patch > Krzysztof Podejma -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1041) various values in allowSolicitation variable break some screens
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504408 ] David E. Jones commented on OFBIZ-1041: --------------------------------------- Okay, yeah. That's the exact point though. We don't want to internationalize the back-end and the values going into the database. We ONLY want to internationalize the front-end, ie ONLY the stuff the custom sees. > various values in allowSolicitation variable break some screens > ---------------------------------------------------------------- > > Key: OFBIZ-1041 > URL: https://issues.apache.org/jira/browse/OFBIZ-1041 > Project: OFBiz > Issue Type: Bug > Components: party > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Krzysztof Podejma > Assignee: Si Chen > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: allowSolicitation.patch > > > in contact forms field allowSolicitation is set to uiLabelMap.CommonY or uiLabelMap.CommonN. > it would be a good idea to force this value to Y or N because it is confusing if you use more than one language > additionaly different values break forms in other apps like crmsfa > please see my patch > Krzysztof Podejma -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1041) various values in allowSolicitation variable break some screens
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504419 ] Krzysztof Podejma commented on OFBIZ-1041: ------------------------------------------ this select could look like this <select name="allowSolicitation"> <#if (mechMap.partyContactMech.allowSolicitation)?exists > <#if (mechMap.partyContactMech.allowSolicitation?default("") == "Y")><option value="Y">${uiLabelMap.CommonY}</option></#if> <#if (mechMap.partyContactMech.allowSolicitation?default("") == "N")><option value="N">${uiLabelMap.CommonN}</option></#if> </#if> <option value=""></option><option value="Y">${uiLabelMap.CommonY}</option><option value="N">${uiLabelMap.CommonN}</option> </select> I'm not 100% sure that it'll work without fix in updatePartyContactMech I've submited above. as far as I remember there were problems with selects and values in options > various values in allowSolicitation variable break some screens > ---------------------------------------------------------------- > > Key: OFBIZ-1041 > URL: https://issues.apache.org/jira/browse/OFBIZ-1041 > Project: OFBiz > Issue Type: Bug > Components: party > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Krzysztof Podejma > Assignee: Si Chen > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: allowSolicitation.patch > > > in contact forms field allowSolicitation is set to uiLabelMap.CommonY or uiLabelMap.CommonN. > it would be a good idea to force this value to Y or N because it is confusing if you use more than one language > additionaly different values break forms in other apps like crmsfa > please see my patch > Krzysztof Podejma -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1041) various values in allowSolicitation variable break some screens
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504424 ] Jacques Le Roux commented on OFBIZ-1041: ---------------------------------------- David, Can you elaborate on this, please ? I understand that nothing else than "Y" and "N" should be stored in DB indicator fields. But I don't see why we should not internationalise the back-end (here, I assume that front-end is eCommerce or POS for instance, and back-end other applications components like order, party, etc. ) Thanks Jacques > various values in allowSolicitation variable break some screens > ---------------------------------------------------------------- > > Key: OFBIZ-1041 > URL: https://issues.apache.org/jira/browse/OFBIZ-1041 > Project: OFBiz > Issue Type: Bug > Components: party > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Krzysztof Podejma > Assignee: Si Chen > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: allowSolicitation.patch > > > in contact forms field allowSolicitation is set to uiLabelMap.CommonY or uiLabelMap.CommonN. > it would be a good idea to force this value to Y or N because it is confusing if you use more than one language > additionaly different values break forms in other apps like crmsfa > please see my patch > Krzysztof Podejma -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1041) various values in allowSolicitation variable break some screens
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504427 ] David E. Jones commented on OFBIZ-1041: --------------------------------------- Sorry, I didn't mean that literally in terms of "back-end" versus "front-end" applications. I meant that in terms of the back-end or supporting logic of an application as opposed to the front-end or user interface of an application. > various values in allowSolicitation variable break some screens > ---------------------------------------------------------------- > > Key: OFBIZ-1041 > URL: https://issues.apache.org/jira/browse/OFBIZ-1041 > Project: OFBiz > Issue Type: Bug > Components: party > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Krzysztof Podejma > Assignee: Si Chen > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: allowSolicitation.patch > > > in contact forms field allowSolicitation is set to uiLabelMap.CommonY or uiLabelMap.CommonN. > it would be a good idea to force this value to Y or N because it is confusing if you use more than one language > additionaly different values break forms in other apps like crmsfa > please see my patch > Krzysztof Podejma -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1041) various values in allowSolicitation variable break some screens
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504429 ] Scott Gray commented on OFBIZ-1041: ----------------------------------- Hi Jacques I think David means front end to be user interface and back end to be the server processing. > various values in allowSolicitation variable break some screens > ---------------------------------------------------------------- > > Key: OFBIZ-1041 > URL: https://issues.apache.org/jira/browse/OFBIZ-1041 > Project: OFBiz > Issue Type: Bug > Components: party > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Krzysztof Podejma > Assignee: Si Chen > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: allowSolicitation.patch > > > in contact forms field allowSolicitation is set to uiLabelMap.CommonY or uiLabelMap.CommonN. > it would be a good idea to force this value to Y or N because it is confusing if you use more than one language > additionaly different values break forms in other apps like crmsfa > please see my patch > Krzysztof Podejma -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |