[jira] Created: (OFBIZ-1060) createInvoiceForOrder ECA not being called

[Nicolas Malin (Jira)]

createInvoiceForOrder ECA not being called
------------------------------------------

                 Key: OFBIZ-1060
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1060
             Project: OFBiz (The Open for Business Project)
          Issue Type: Bug
          Components: accounting
            Reporter: Andrew Sykes
            Priority: Minor


From createInvoiceForOrderAllItems there's a direct call to createInvoiceForOrder, but the latter has an ECA on it, to capture the payment. The direct call won't trigger the ECAs.


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Sykes updated OFBIZ-1060:
--------------------------------

    Attachment: InvoiceServices.java.patch

> createInvoiceForOrder ECA not being called
> ------------------------------------------
>
>                 Key: OFBIZ-1060
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1060
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: accounting
>            Reporter: Andrew Sykes
>            Priority: Minor
>         Attachments: InvoiceServices.java.patch
>
>
> From createInvoiceForOrderAllItems there's a direct call to createInvoiceForOrder, but the latter has an ECA on it, to capture the payment. The direct call won't trigger the ECAs.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12501888 ]

Jacopo Cappellato commented on OFBIZ-1060:
------------------------------------------

I've reviewed the patch and I agree with Andrew.
Is there a reason for using a direct call instead of  a service call? Can I commit this change?

> createInvoiceForOrder ECA not being called
> ------------------------------------------
>
>                 Key: OFBIZ-1060
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1060
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>            Reporter: Andrew Sykes
>            Priority: Minor
>         Attachments: InvoiceServices.java.patch
>
>
> From createInvoiceForOrderAllItems there's a direct call to createInvoiceForOrder, but the latter has an ECA on it, to capture the payment. The direct call won't trigger the ECAs.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato reassigned OFBIZ-1060:
----------------------------------------

    Assignee: Jacopo Cappellato

> createInvoiceForOrder ECA not being called
> ------------------------------------------
>
>                 Key: OFBIZ-1060
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1060
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>            Reporter: Andrew Sykes
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: InvoiceServices.java.patch
>
>
> From createInvoiceForOrderAllItems there's a direct call to createInvoiceForOrder, but the latter has an ECA on it, to capture the payment. The direct call won't trigger the ECAs.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato closed OFBIZ-1060.
------------------------------------

    Resolution: Fixed

Andrew,

thanks: rev. 545410

> createInvoiceForOrder ECA not being called
> ------------------------------------------
>
>                 Key: OFBIZ-1060
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1060
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>            Reporter: Andrew Sykes
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: InvoiceServices.java.patch
>
>
> From createInvoiceForOrderAllItems there's a direct call to createInvoiceForOrder, but the latter has an ECA on it, to capture the payment. The direct call won't trigger the ECAs.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.