[jira] Created: (OFBIZ-109) InvoiceServices.updatePaymentApplicationDefBd

[Nicolas Malin (Jira)]

InvoiceServices.updatePaymentApplicationDefBd
---------------------------------------------

                 Key: OFBIZ-109
                 URL: http://issues.apache.org/jira/browse/OFBIZ-109
             Project: OFBiz (The Open for Business Project)
          Issue Type: Bug
          Components: accounting
            Reporter: Chris Howe


variable invoiceItemApplyAvailable is the difference between a big decimal without scale and a user inputed big decimal, which generally has a scale.  Therfore 8.1899999999999999787 - 8.19 is < 0 and the payment application will not be entered

around line 1861 (my copy is mocked up for a temporary thing, otherwise, I'd submit a patch)
reads
                    invoiceItemApplyAvailable = invoiceItem.getBigDecimal("amount").multiply(quantity).subtract(InvoiceWorker.getInvoiceItemAppliedBd(invoiceItem));


should read
                    invoiceItemApplyAvailable = invoiceItem.getBigDecimal("amount").multiply(quantity).setScale(decimals,rounding).subtract(InvoiceWorker.getInvoiceItemAppliedBd(invoiceItem));

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-109?page=all ]

Hans Bakker resolved OFBIZ-109.
-------------------------------

    Resolution: Fixed

implemented with : Committed revision 425325.

Chris, thank you for reporting this.

> InvoiceServices.updatePaymentApplicationDefBd
> ---------------------------------------------
>
>                 Key: OFBIZ-109
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-109
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: accounting
>            Reporter: Chris Howe
>
> variable invoiceItemApplyAvailable is the difference between a big decimal without scale and a user inputed big decimal, which generally has a scale.  Therfore 8.1899999999999999787 - 8.19 is < 0 and the payment application will not be entered
> around line 1861 (my copy is mocked up for a temporary thing, otherwise, I'd submit a patch)
> reads
>                     invoiceItemApplyAvailable = invoiceItem.getBigDecimal("amount").multiply(quantity).subtract(InvoiceWorker.getInvoiceItemAppliedBd(invoiceItem));
> should read
>                     invoiceItemApplyAvailable = invoiceItem.getBigDecimal("amount").multiply(quantity).setScale(decimals,rounding).subtract(InvoiceWorker.getInvoiceItemAppliedBd(invoiceItem));

... [show rest of quote]

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-109?page=all ]

Jacopo Cappellato closed OFBIZ-109.
-----------------------------------

> InvoiceServices.updatePaymentApplicationDefBd
> ---------------------------------------------
>
>                 Key: OFBIZ-109
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-109
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: accounting
>            Reporter: Chris Howe
>
> variable invoiceItemApplyAvailable is the difference between a big decimal without scale and a user inputed big decimal, which generally has a scale.  Therfore 8.1899999999999999787 - 8.19 is < 0 and the payment application will not be entered
> around line 1861 (my copy is mocked up for a temporary thing, otherwise, I'd submit a patch)
> reads
>                     invoiceItemApplyAvailable = invoiceItem.getBigDecimal("amount").multiply(quantity).subtract(InvoiceWorker.getInvoiceItemAppliedBd(invoiceItem));
> should read
>                     invoiceItemApplyAvailable = invoiceItem.getBigDecimal("amount").multiply(quantity).setScale(decimals,rounding).subtract(InvoiceWorker.getInvoiceItemAppliedBd(invoiceItem));

... [show rest of quote]

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira