OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-1096) Enhanced pager for Forms

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

46 messages Options

123

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1096) Enhanced pager for Forms

[ https://issues.apache.org/jira/browse/OFBIZ-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12508490 ]

Wickersheimer Jeremy commented on OFBIZ-1096:
---------------------------------------------

Adrian,

I checked the few changes you made, just one issue: you assign the class "disabled" on disabled buttons, this works for text buttons, but won't with images.

If for example i style nav-first with arrow-first.png, i would want to style the corresponding disabled button with arrow-first-disabled.png (which would be a grayed arrow pointing left).
So i will go back to adding "-disabled" to the base class.

About you other points:

1. Yes why not, in fact i would prefer removing all \n and keep the appendWhitespace at the end of the pager rendering.

2. Indeed.

3. Tricky, the combobox represent the current page, the "1 of X" indicates the records displayed, not the pages.
So IMO the current page should remain in the center.
Else i did not use uiLabels, but i guess i will add "Page" before the combobox, and "rows" after the "1 - X of Y", this will make thing clearer i think.

> Enhanced pager for Forms
> ------------------------
>
> Key: OFBIZ-1096
> URL: https://issues.apache.org/jira/browse/OFBIZ-1096
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Wickersheimer Jeremy
> Priority: Minor
> Attachments: form-dtd.patch, form-dtd_2.patch, HtmlFormRenderer-2.patch, HtmlFormRenderer.patch, maincss.patch, ModelForm-2.patch, ModelForm.patch, pager.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk version.
> PS: I would like to use this issue to have your comments on another pager issue. The current implementation doesn't support pages that display more than one list form for the obvious reason that the only the parameters VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to differentiate the form.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1096) Enhanced pager for Forms

In reply to this post by Nicolas Malin (Jira)

> Enhanced pager for Forms
> ------------------------
>
> Key: OFBIZ-1096
> URL: https://issues.apache.org/jira/browse/OFBIZ-1096
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Wickersheimer Jeremy
> Priority: Minor
> Attachments: form-dtd.patch, form-dtd_2.patch, HtmlFormRenderer-2.patch, HtmlFormRenderer.patch, maincss.patch, ModelForm-2.patch, ModelForm.patch, pager-2.patch, pager.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk version.
> PS: I would like to use this issue to have your comments on another pager issue. The current implementation doesn't support pages that display more than one list form for the obvious reason that the only the parameters VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to differentiate the form.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1096) Enhanced pager for Forms

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12508572 ]

Adrian Crum commented on OFBIZ-1096:
------------------------------------

Jeremy,

I still think the pagination elements make more sense with the select box last. I'd like to hear what others think.

> Enhanced pager for Forms
> ------------------------
>
> Key: OFBIZ-1096
> URL: https://issues.apache.org/jira/browse/OFBIZ-1096
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Wickersheimer Jeremy
> Priority: Minor
> Attachments: form-dtd.patch, form-dtd_2.patch, HtmlFormRenderer-2.patch, HtmlFormRenderer.patch, maincss.patch, ModelForm-2.patch, ModelForm.patch, pager-2.patch, pager.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk version.
> PS: I would like to use this issue to have your comments on another pager issue. The current implementation doesn't support pages that display more than one list form for the obvious reason that the only the parameters VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to differentiate the form.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1096) Enhanced pager for Forms

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12508576 ]

Adrian Crum commented on OFBIZ-1096:
------------------------------------

Maybe something was misunderstood in my point #2.

If you have this line in HtmlFormRenderer.java:

buffer.append("<div class=\"").append(modelForm.getPaginateStyle()).append("\">");

then you don't need lines like this:

buffer.append("<li class=\"").append(modelForm.getPaginateFirstStyle());

Instead, the contained elements can be styled specifically:

buffer.append("<li class=\"nav-first\"");

If someone wants to change the pagination style, they only need to specify the style for the outermost container (the <div> element) because the CSS classes they use will style the contained elements via descendent selectors (like I did in maincss.css). Doing so will eliminate all of the unnecessary form widget properties.

In other words, the only style the xml file, the model form, and the renderer needs to accomodate is the outermost paginate style.

> Enhanced pager for Forms
> ------------------------
>
> Key: OFBIZ-1096
> URL: https://issues.apache.org/jira/browse/OFBIZ-1096
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Wickersheimer Jeremy
> Priority: Minor
> Attachments: form-dtd.patch, form-dtd_2.patch, HtmlFormRenderer-2.patch, HtmlFormRenderer.patch, maincss.patch, ModelForm-2.patch, ModelForm.patch, pager-2.patch, pager.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk version.
> PS: I would like to use this issue to have your comments on another pager issue. The current implementation doesn't support pages that display more than one list form for the obvious reason that the only the parameters VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to differentiate the form.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1096) Enhanced pager for Forms

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12508725 ]

Wickersheimer Jeremy commented on OFBIZ-1096:
---------------------------------------------

Iknow what you mean.

I like to keep everything related in the same place, classes to style the Forms are in ModelForm, the rendering done in HtmlFormRenderer can then retrieve those classes consistently instead of mixing hard coding and ModeForm getters.

This is easier for maintainers i think. If later we add code that need those styles, we have only one place to look for them and one place to modify them.
If in the future someone want to change the default CSS of the pager elements i will be very easy. If in the future we decide that we need to add the custom styles in the XML, there will be very little to change in the ModelForm code, and no modifications to make anywhere else in the framework.

For the same reason, i kept the public getter instead of retrieving the constant directly .

> Enhanced pager for Forms
> ------------------------
>
> Key: OFBIZ-1096
> URL: https://issues.apache.org/jira/browse/OFBIZ-1096
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Wickersheimer Jeremy
> Priority: Minor
> Attachments: form-dtd.patch, form-dtd_2.patch, HtmlFormRenderer-2.patch, HtmlFormRenderer.patch, maincss.patch, ModelForm-2.patch, ModelForm.patch, pager-2.patch, pager.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk version.
> PS: I would like to use this issue to have your comments on another pager issue. The current implementation doesn't support pages that display more than one list form for the obvious reason that the only the parameters VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to differentiate the form.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1096) Enhanced pager for Forms

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wickersheimer Jeremy updated OFBIZ-1096:
----------------------------------------

Attachment: pager-3.patch

This patch also contains some modifications to have the pager display on top of the list.

This add a new method in ModelForm named preparePager().
This method is perform the computation needed for the pager also done in renderItemRows(). I tried to only extract the necessary code.

I did not remove the computation code from renderItemRows, so the work is done twice. That is because i only call preparePager for a list, and i did not want to break other things.

This patch is a draft to answer one comment on the possibility to have the pager on top, i would prefer to stick with pager-2.patch for now.
I will work on it further and suggest it as a different Improvement.

> Enhanced pager for Forms
> ------------------------
>
> Key: OFBIZ-1096
> URL: https://issues.apache.org/jira/browse/OFBIZ-1096
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Wickersheimer Jeremy
> Priority: Minor
> Attachments: form-dtd.patch, form-dtd_2.patch, HtmlFormRenderer-2.patch, HtmlFormRenderer.patch, maincss.patch, ModelForm-2.patch, ModelForm.patch, pager-2.patch, pager-3.patch, pager.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk version.
> PS: I would like to use this issue to have your comments on another pager issue. The current implementation doesn't support pages that display more than one list form for the obvious reason that the only the parameters VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to differentiate the form.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1096) Enhanced pager for Forms

In reply to this post by Nicolas Malin (Jira)

> Enhanced pager for Forms
> ------------------------
>
> Key: OFBIZ-1096
> URL: https://issues.apache.org/jira/browse/OFBIZ-1096
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Wickersheimer Jeremy
> Priority: Minor
> Attachments: form-dtd.patch, form-dtd_2.patch, HtmlFormRenderer-2.patch, HtmlFormRenderer.patch, maincss.patch, ModelForm-2.patch, ModelForm.patch, pager-2.patch, pager-2.patch, pager-3.patch, pager.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk version.
> PS: I would like to use this issue to have your comments on another pager issue. The current implementation doesn't support pages that display more than one list form for the obvious reason that the only the parameters VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to differentiate the form.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1096) Enhanced pager for Forms

In reply to this post by Nicolas Malin (Jira)

> Enhanced pager for Forms
> ------------------------
>
> Key: OFBIZ-1096
> URL: https://issues.apache.org/jira/browse/OFBIZ-1096
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Wickersheimer Jeremy
> Priority: Minor
> Attachments: pager-2.patch, pager-2.patch, pager-3.patch, pager.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk version.
> PS: I would like to use this issue to have your comments on another pager issue. The current implementation doesn't support pages that display more than one list form for the obvious reason that the only the parameters VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to differentiate the form.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1096) Enhanced pager for Forms

In reply to this post by Nicolas Malin (Jira)

> Enhanced pager for Forms
> ------------------------
>
> Key: OFBIZ-1096
> URL: https://issues.apache.org/jira/browse/OFBIZ-1096
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Wickersheimer Jeremy
> Priority: Minor
> Attachments: pager-2.patch, pager-2.patch, pager-3.patch, pager.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk version.
> PS: I would like to use this issue to have your comments on another pager issue. The current implementation doesn't support pages that display more than one list form for the obvious reason that the only the parameters VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to differentiate the form.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1096) Enhanced pager for Forms

In reply to this post by Nicolas Malin (Jira)

> Enhanced pager for Forms
> ------------------------
>
> Key: OFBIZ-1096
> URL: https://issues.apache.org/jira/browse/OFBIZ-1096
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Wickersheimer Jeremy
> Priority: Minor
> Attachments: pager-2.patch, pager-2.patch, pager-3.patch, pager.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk version.
> PS: I would like to use this issue to have your comments on another pager issue. The current implementation doesn't support pages that display more than one list form for the obvious reason that the only the parameters VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to differentiate the form.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1096) Enhanced pager for Forms

In reply to this post by Nicolas Malin (Jira)

> Enhanced pager for Forms
> ------------------------
>
> Key: OFBIZ-1096
> URL: https://issues.apache.org/jira/browse/OFBIZ-1096
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Wickersheimer Jeremy
> Priority: Minor
> Attachments: pager-2.patch, pager-2.patch, pager-3.patch, pager.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk version.
> PS: I would like to use this issue to have your comments on another pager issue. The current implementation doesn't support pages that display more than one list form for the obvious reason that the only the parameters VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to differentiate the form.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1096) Enhanced pager for Forms

In reply to this post by Nicolas Malin (Jira)

> Enhanced pager for Forms
> ------------------------
>
> Key: OFBIZ-1096
> URL: https://issues.apache.org/jira/browse/OFBIZ-1096
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Wickersheimer Jeremy
> Priority: Minor
> Attachments: pager-2.patch, pager-2.patch, pager-3.patch, pager.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk version.
> PS: I would like to use this issue to have your comments on another pager issue. The current implementation doesn't support pages that display more than one list form for the obvious reason that the only the parameters VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to differentiate the form.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1096) Enhanced pager for Forms

In reply to this post by Nicolas Malin (Jira)

> Enhanced pager for Forms
> ------------------------
>
> Key: OFBIZ-1096
> URL: https://issues.apache.org/jira/browse/OFBIZ-1096
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Wickersheimer Jeremy
> Priority: Minor
> Attachments: pager-2.patch, pager-2.patch, pager-3.patch, pager.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk version.
> PS: I would like to use this issue to have your comments on another pager issue. The current implementation doesn't support pages that display more than one list form for the obvious reason that the only the parameters VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to differentiate the form.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1096) Enhanced pager for Forms

In reply to this post by Nicolas Malin (Jira)

> Enhanced pager for Forms
> ------------------------
>
> Key: OFBIZ-1096
> URL: https://issues.apache.org/jira/browse/OFBIZ-1096
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Wickersheimer Jeremy
> Priority: Minor
> Attachments: pager-2.patch, pager-2.patch, pager-3.patch, pager.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk version.
> PS: I would like to use this issue to have your comments on another pager issue. The current implementation doesn't support pages that display more than one list form for the obvious reason that the only the parameters VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to differentiate the form.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1096) Enhanced pager for Forms

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12508774 ]

Jacques Le Roux commented on OFBIZ-1096:
----------------------------------------

Jeremy,

Actually it's easier for us (and also for you) if you keep alwas the same name for a file. Jira takes care of that. Jut reload with the same name and Jira will "grey" the old fine letting us know which files are the good ones.

Thanks for your work.

> Enhanced pager for Forms
> ------------------------
>
> Key: OFBIZ-1096
> URL: https://issues.apache.org/jira/browse/OFBIZ-1096
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Wickersheimer Jeremy
> Priority: Minor
> Attachments: pager-2.patch, pager-2.patch, pager-3.patch, pager.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk version.
> PS: I would like to use this issue to have your comments on another pager issue. The current implementation doesn't support pages that display more than one list form for the obvious reason that the only the parameters VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to differentiate the form.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1096) Enhanced pager for Forms

In reply to this post by Nicolas Malin (Jira)

> Enhanced pager for Forms
> ------------------------
>
> Key: OFBIZ-1096
> URL: https://issues.apache.org/jira/browse/OFBIZ-1096
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Wickersheimer Jeremy
> Priority: Minor
> Attachments: pager-2.patch, pager-2.patch, pager-3.patch, pager-3.patch, pager.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk version.
> PS: I would like to use this issue to have your comments on another pager issue. The current implementation doesn't support pages that display more than one list form for the obvious reason that the only the parameters VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to differentiate the form.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1096) Enhanced pager for Forms

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12509233 ]

Jacques Le Roux commented on OFBIZ-1096:
----------------------------------------

I did not review, nor event test these patch. So I have a suggestion that is maybe already covert. I suggest to allow users to be able to set the size of the VIEW_SIZE

> Enhanced pager for Forms
> ------------------------
>
> Key: OFBIZ-1096
> URL: https://issues.apache.org/jira/browse/OFBIZ-1096
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Wickersheimer Jeremy
> Priority: Minor
> Attachments: pager-2.patch, pager-2.patch, pager-3.patch, pager-3.patch, pager.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk version.
> PS: I would like to use this issue to have your comments on another pager issue. The current implementation doesn't support pages that display more than one list form for the obvious reason that the only the parameters VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to differentiate the form.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1096) Enhanced pager for Forms

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12509234 ]

Jacques Le Roux commented on OFBIZ-1096:
----------------------------------------

BTW which patch is actually to use : pager2 ? Do we need to delete the others to make things clearer ?

> Enhanced pager for Forms
> ------------------------
>
> Key: OFBIZ-1096
> URL: https://issues.apache.org/jira/browse/OFBIZ-1096
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Wickersheimer Jeremy
> Priority: Minor
> Attachments: pager-2.patch, pager-2.patch, pager-3.patch, pager-3.patch, pager.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk version.
> PS: I would like to use this issue to have your comments on another pager issue. The current implementation doesn't support pages that display more than one list form for the obvious reason that the only the parameters VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to differentiate the form.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1096) Enhanced pager for Forms

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12509261 ]

Wickersheimer Jeremy commented on OFBIZ-1096:
---------------------------------------------

Jacques,

No there is no way to set the view size yet, so it uses the one given
in the form definition of the hard coded default (which can be 50 or
100 if i remember well).
This could be done but it is much less useful for the user.

For which patch to take:
- pager-2 is the implementation of the new pager yes.
- pager-3 is a "beta" that adds the pager on top of the list too, but
i would like to discuss it in a separate thread. There is some code to
rewrite in ModelForm to make things better.

> Enhanced pager for Forms
> ------------------------
>
> Key: OFBIZ-1096
> URL: https://issues.apache.org/jira/browse/OFBIZ-1096
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Wickersheimer Jeremy
> Priority: Minor
> Attachments: pager-2.patch, pager-2.patch, pager-3.patch, pager-3.patch, pager.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk version.
> PS: I would like to use this issue to have your comments on another pager issue. The current implementation doesn't support pages that display more than one list form for the obvious reason that the only the parameters VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to differentiate the form.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1096) Enhanced pager for Forms

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12509263 ]

Jacques Le Roux commented on OFBIZ-1096:
----------------------------------------

Jeremy,

Will you mind opening a new Jira issue for pager-3 ? Then I will delete all the deprecated files in this issue to make the things clearer.

> Enhanced pager for Forms
> ------------------------
>
> Key: OFBIZ-1096
> URL: https://issues.apache.org/jira/browse/OFBIZ-1096
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Wickersheimer Jeremy
> Priority: Minor
> Attachments: pager-2.patch, pager-2.patch, pager-3.patch, pager-3.patch, pager.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk version.
> PS: I would like to use this issue to have your comments on another pager issue. The current implementation doesn't support pages that display more than one list form for the obvious reason that the only the parameters VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to differentiate the form.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

123