[jira] Created: (OFBIZ-1096) Enhanced pager for Forms

[Nicolas Malin (Jira)]

Enhanced pager for Forms
------------------------

                 Key: OFBIZ-1096
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1096
             Project: OFBiz
          Issue Type: Improvement
          Components: framework
    Affects Versions: SVN trunk
            Reporter: Wickersheimer Jeremy
            Priority: Minor


I am currently working on an enhanced pager. The change affects a few files in the framework but i tried to make it as small as possible.

The main enhancement is to add "First" and "Last" button in the pager as well as a javascript combobox to quickly jump to any page.
It is inspired by the Neogia implementation but rewritten to integrate with the existing pager.

I will attach the patches as i apply the changes to the latest SVN trunk version.

PS: I would like to use this issue to have your comments on another pager issue. The current implementation doesn't support pages that display more than one list form for the obvious reason that the only the parameters VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to differentiate the form.


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wickersheimer Jeremy updated OFBIZ-1096:
----------------------------------------

    Attachment: form-dtd.patch

This is the patch for : framework/widget/dtd/widget-form.xsd
It adds these attributes to the form:
- paginate-first-label
- paginate-last-label
- paginate-first-style
- paginate-last-style
- paginate-first-disabled-style
- paginate-previous-disabled-style
- paginate-next-disabled-style
- paginate-last-disabled-style

> Enhanced pager for Forms
> ------------------------
>
>                 Key: OFBIZ-1096
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1096
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Priority: Minor
>         Attachments: form-dtd.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk version.
> PS: I would like to use this issue to have your comments on another pager issue. The current implementation doesn't support pages that display more than one list form for the obvious reason that the only the parameters VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to differentiate the form.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wickersheimer Jeremy updated OFBIZ-1096:
----------------------------------------

    Attachment: ModelForm.patch

This patch is for : framework/widget/src/org/ofbiz/widget/form/ModelForm.java
This adds the necessary attributes, initialization code (in initForm) setters and getters for the added attributes in the XSD.

There is no real "new code" here, all additions were adapted from the existing code.

> Enhanced pager for Forms
> ------------------------
>
>                 Key: OFBIZ-1096
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1096
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Priority: Minor
>         Attachments: form-dtd.patch, ModelForm.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk version.
> PS: I would like to use this issue to have your comments on another pager issue. The current implementation doesn't support pages that display more than one list form for the obvious reason that the only the parameters VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to differentiate the form.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wickersheimer Jeremy updated OFBIZ-1096:
----------------------------------------

    Attachment: HtmlFormRenderer.patch

This is the patch for : framework/widget/src/org/ofbiz/widget/html/HtmlFormRenderer.java

This is a rewrite of the renderNextPrev method.

> Enhanced pager for Forms
> ------------------------
>
>                 Key: OFBIZ-1096
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1096
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Priority: Minor
>         Attachments: form-dtd.patch, HtmlFormRenderer.patch, ModelForm.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk version.
> PS: I would like to use this issue to have your comments on another pager issue. The current implementation doesn't support pages that display more than one list form for the obvious reason that the only the parameters VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to differentiate the form.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12507957 ]

Jacopo Cappellato commented on OFBIZ-1096:
------------------------------------------

Jeremy,

I've applied your patch (not yet really reviewed) and I like it; some minor issues:

1) minor formatting issues:

// this is not good
if (condition)
    action;
// this is good
if (condition) {
    action;
}

and also:
// this is not good
if (condition) {
    action;
}
else {
    action;
}
// this is good
if (condition) {
    action;
} else {
    action;
}

2) would it be possible to display the links at the top and at the bottom of the list? (right now they are displayed only at the bottom)

What do other think about this patch?

> Enhanced pager for Forms
> ------------------------
>
>                 Key: OFBIZ-1096
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1096
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Priority: Minor
>         Attachments: form-dtd.patch, HtmlFormRenderer.patch, ModelForm.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk version.
> PS: I would like to use this issue to have your comments on another pager issue. The current implementation doesn't support pages that display more than one list form for the obvious reason that the only the parameters VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to differentiate the form.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12507972 ]

David E. Jones commented on OFBIZ-1096:
---------------------------------------

In general I like this enhancement, and it finally gets some things into the form widget that we've had in the ecommerce category pagination for a long time.

As for the new attributes... there was some discussion a little while back about the fact that there are already too many attributes on the form element. It might be good to start putting all new style attributes in a new sub-element, as was discussed before. I tried looking around for the issue but after 15 minutes I'm out of time on this. I'm sure it's in there somewhere, maybe closed and that's why I couldn't find it in the searches I did.

Anyway, that's the main thing that should probably change so we don't get too much (more!) attribute bloat in the form element. The name of the sub-element was in that issue somewhere and we should probably just with that (unless it makes no sense, I don't remember as it was too long ago we discussed that). Something like "form-styles" or just "styles" would be good, and then "-style" can be removed from all of the attribute names.

> Enhanced pager for Forms
> ------------------------
>
>                 Key: OFBIZ-1096
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1096
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Priority: Minor
>         Attachments: form-dtd.patch, HtmlFormRenderer.patch, ModelForm.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk version.
> PS: I would like to use this issue to have your comments on another pager issue. The current implementation doesn't support pages that display more than one list form for the obvious reason that the only the parameters VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to differentiate the form.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12507975 ]

Jacques Le Roux commented on OFBIZ-1096:
----------------------------------------

David,

I guess the discussion you think about is http://www.nabble.com/-RFC--Form-Widget-Stylings-element-%7C%7C-attribute-tf3282030.html and the corresponding Jira issue is
https://issues.apache.org/jira/browse/OFBIZ-760

> Enhanced pager for Forms
> ------------------------
>
>                 Key: OFBIZ-1096
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1096
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Priority: Minor
>         Attachments: form-dtd.patch, HtmlFormRenderer.patch, ModelForm.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk version.
> PS: I would like to use this issue to have your comments on another pager issue. The current implementation doesn't support pages that display more than one list form for the obvious reason that the only the parameters VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to differentiate the form.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12507974 ]

Adrian Crum commented on OFBIZ-1096:
------------------------------------

The issue David is referring to is OFBIZ-762.

> Enhanced pager for Forms
> ------------------------
>
>                 Key: OFBIZ-1096
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1096
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Priority: Minor
>         Attachments: form-dtd.patch, HtmlFormRenderer.patch, ModelForm.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk version.
> PS: I would like to use this issue to have your comments on another pager issue. The current implementation doesn't support pages that display more than one list form for the obvious reason that the only the parameters VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to differentiate the form.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12507978 ]

Jacques Le Roux commented on OFBIZ-1096:
----------------------------------------

Ha yes, Adrian is right ! (did not see is comment before posting)

> Enhanced pager for Forms
> ------------------------
>
>                 Key: OFBIZ-1096
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1096
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Priority: Minor
>         Attachments: form-dtd.patch, HtmlFormRenderer.patch, ModelForm.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk version.
> PS: I would like to use this issue to have your comments on another pager issue. The current implementation doesn't support pages that display more than one list form for the obvious reason that the only the parameters VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to differentiate the form.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[pierre-29]

Thank you very much to create a patch for this into ofbiz. I should
create a patch fore this feature but i never had the time ...

Many thanks Jeremy

Pierre

Wickersheimer Jeremy (JIRA) wrote:

>      [ https://issues.apache.org/jira/browse/OFBIZ-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Wickersheimer Jeremy updated OFBIZ-1096:
> ----------------------------------------
>
>     Attachment: HtmlFormRenderer.patch
>
> This is the patch for : framework/widget/src/org/ofbiz/widget/html/HtmlFormRenderer.java
>
> This is a rewrite of the renderNextPrev method.
>
>  
>> Enhanced pager for Forms
>> ------------------------
>>
>>                 Key: OFBIZ-1096
>>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1096
>>             Project: OFBiz
>>          Issue Type: Improvement
>>          Components: framework
>>    Affects Versions: SVN trunk
>>            Reporter: Wickersheimer Jeremy
>>            Priority: Minor
>>         Attachments: form-dtd.patch, HtmlFormRenderer.patch, ModelForm.patch
>>
>>
>> I am currently working on an enhanced pager. The change affects a few files in the framework but i tried to make it as small as possible.
>> The main enhancement is to add "First" and "Last" button in the pager as well as a javascript combobox to quickly jump to any page.
>> It is inspired by the Neogia implementation but rewritten to integrate with the existing pager.
>> I will attach the patches as i apply the changes to the latest SVN trunk version.
>> PS: I would like to use this issue to have your comments on another pager issue. The current implementation doesn't support pages that display more than one list form for the obvious reason that the only the parameters VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to differentiate the form.
>>    
>
>  

--
Pierre Gaudin,
Ingénieur Etudes et Développement

NEREIDE
http://www.nereide.biz
33 (0)2 47 50 30 54

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12508031 ]

Wickersheimer Jeremy commented on OFBIZ-1096:
---------------------------------------------

Jacopo:

It is possible to display it on Top, i will work on it. In fact i already have the call to render the pager on top in my local version, but some elements necessary to the pager are computed when the list is rendered (such as listSize ...)
In Neogia they made the calculation in the pager rendering code which is imho not elegant.

About the attributes, i just added them to be consistent. And i also noticed that labels are hard coded in English, shouldn't we use uiLabels in the Form code ? I think that would remove any use for the label attributes.

For style attributes, i would not use them i think. If that were up to me i would probably prefer to hard code CSS classes in the pager rendering code and let people change their CSS. In my previous version i had these, in the patch only the classes for the the table cells remains in the code (needed to style the pager buttons with arrow images rather than text).

There is also the FTL issue, they won't share this piece of code ... in my local version i had a set of FTL macros that would perform the same result but i had to import code from Opentaps into the framework to support their custom tag for importing FTL files.
But since most of the FTLs comes along with a BSH i would still prefer to see them disappear :)

> Enhanced pager for Forms
> ------------------------
>
>                 Key: OFBIZ-1096
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1096
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Priority: Minor
>         Attachments: form-dtd.patch, HtmlFormRenderer.patch, ModelForm.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk version.
> PS: I would like to use this issue to have your comments on another pager issue. The current implementation doesn't support pages that display more than one list form for the obvious reason that the only the parameters VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to differentiate the form.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12508202 ]

Adrian Crum commented on OFBIZ-1096:
------------------------------------

Jeremy,

While you are working on the changes, keep in mind that the maincss.css style sheet has semantic css classes for previous and next links. They are near the end of the file. It would be nice if the widget code defaulted to these classes if no style has been specified in the widget XML file.

http://docs.ofbiz.org/display/OFBIZ/OFBiz+maincss.css+HTML+Element+Collection+Styles

> Enhanced pager for Forms
> ------------------------
>
>                 Key: OFBIZ-1096
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1096
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Priority: Minor
>         Attachments: form-dtd.patch, HtmlFormRenderer.patch, ModelForm.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk version.
> PS: I would like to use this issue to have your comments on another pager issue. The current implementation doesn't support pages that display more than one list form for the obvious reason that the only the parameters VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to differentiate the form.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12508209 ]

Wickersheimer Jeremy commented on OFBIZ-1096:
---------------------------------------------

Adrian:

You mean the nav-* classes. They are currently unused. But yes we
could use them, and we also need to duplicate them for
disabled-buttons. Or agree on something different like.

Basically the only specifications are that the 4 buttons can each have
a different icon, and two states : enabled or disabled.
The container of the pager (here the table) should also have its class.

But this is not really an important issue for me, i am more interested
in having the pager workin. For the HTML and CSS i would rather let a
commiter decide, I am perfectly fine with the text buttons :)

> Enhanced pager for Forms
> ------------------------
>
>                 Key: OFBIZ-1096
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1096
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Priority: Minor
>         Attachments: form-dtd.patch, HtmlFormRenderer.patch, ModelForm.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk version.
> PS: I would like to use this issue to have your comments on another pager issue. The current implementation doesn't support pages that display more than one list form for the obvious reason that the only the parameters VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to differentiate the form.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12508221 ]

Adrian Crum commented on OFBIZ-1096:
------------------------------------

Jeremy,

The nav classes are being used, but they don't do anything at this time. The idea is to style HTML elements using a set of pre-defined semantic classes so that - some time in the future - those HTML elements can be styled by updating the main style sheet.

I just took a quick look at your patch, but I haven't applied it. I noticed you are using table-based layout - we are trying to avoid that. It would be preferable to use an unordered list for your navigation links.

Check out the bottom of this page:

http://docs.ofbiz.org/display/OFBADMIN/Best+Practices+Guide

> Enhanced pager for Forms
> ------------------------
>
>                 Key: OFBIZ-1096
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1096
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Priority: Minor
>         Attachments: form-dtd.patch, HtmlFormRenderer.patch, ModelForm.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk version.
> PS: I would like to use this issue to have your comments on another pager issue. The current implementation doesn't support pages that display more than one list form for the obvious reason that the only the parameters VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to differentiate the form.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12508377 ]

Wickersheimer Jeremy commented on OFBIZ-1096:
---------------------------------------------

Ok i will rewrite the thing a bit with those changes:
- use nav-* CSS classes by default, i also remove the disabled style because i don't think we need 4 attributes for this. Instead i will use (normal style class) + "-disabled"
- use "nav-pager" as the default style for the pager container, and an attribute paginate-style for the user to override. This makes implementing a custom style for the pager easier because only this style will need to be changed.
- rewrite some if blocks to follow the coding format
- change the table structure for:
<div class="..">
  <ul>
    <li>..</li>
  </ul>
</div>
- patch for maincss.css so that the pager looks the same with the new HTML and classes.

> Enhanced pager for Forms
> ------------------------
>
>                 Key: OFBIZ-1096
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1096
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Priority: Minor
>         Attachments: form-dtd.patch, HtmlFormRenderer.patch, ModelForm.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk version.
> PS: I would like to use this issue to have your comments on another pager issue. The current implementation doesn't support pages that display more than one list form for the obvious reason that the only the parameters VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to differentiate the form.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wickersheimer Jeremy updated OFBIZ-1096:
----------------------------------------

    Attachment: maincss.patch

CSS patch

> Enhanced pager for Forms
> ------------------------
>
>                 Key: OFBIZ-1096
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1096
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Priority: Minor
>         Attachments: form-dtd.patch, HtmlFormRenderer.patch, maincss.patch, ModelForm.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk version.
> PS: I would like to use this issue to have your comments on another pager issue. The current implementation doesn't support pages that display more than one list form for the obvious reason that the only the parameters VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to differentiate the form.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wickersheimer Jeremy updated OFBIZ-1096:
----------------------------------------

    Attachment: HtmlFormRenderer-2.patch

New HtmlFormRendere patch.
Correct ed if blocks, and changed HTML.

> Enhanced pager for Forms
> ------------------------
>
>                 Key: OFBIZ-1096
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1096
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Priority: Minor
>         Attachments: form-dtd.patch, form-dtd_2.patch, HtmlFormRenderer-2.patch, HtmlFormRenderer.patch, maincss.patch, ModelForm-2.patch, ModelForm.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk version.
> PS: I would like to use this issue to have your comments on another pager issue. The current implementation doesn't support pages that display more than one list form for the obvious reason that the only the parameters VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to differentiate the form.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wickersheimer Jeremy updated OFBIZ-1096:
----------------------------------------

    Attachment: ModelForm-2.patch

New modelForm patch, to be used with the new form DTD

> Enhanced pager for Forms
> ------------------------
>
>                 Key: OFBIZ-1096
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1096
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Priority: Minor
>         Attachments: form-dtd.patch, form-dtd_2.patch, HtmlFormRenderer-2.patch, HtmlFormRenderer.patch, maincss.patch, ModelForm-2.patch, ModelForm.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk version.
> PS: I would like to use this issue to have your comments on another pager issue. The current implementation doesn't support pages that display more than one list form for the obvious reason that the only the parameters VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to differentiate the form.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wickersheimer Jeremy updated OFBIZ-1096:
----------------------------------------

    Attachment: form-dtd_2.patch

New form DTD (replace the previous patch)

> Enhanced pager for Forms
> ------------------------
>
>                 Key: OFBIZ-1096
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1096
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Priority: Minor
>         Attachments: form-dtd.patch, form-dtd_2.patch, HtmlFormRenderer-2.patch, HtmlFormRenderer.patch, maincss.patch, ModelForm-2.patch, ModelForm.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk version.
> PS: I would like to use this issue to have your comments on another pager issue. The current implementation doesn't support pages that display more than one list form for the obvious reason that the only the parameters VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to differentiate the form.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1096:
-------------------------------

    Attachment: pager.patch

Jeremy,

Your latest patches are much improved. Instead of going back and forth in Jira comments, I applied your patches to my local copy and made some corrections. They are in the pager.patch attachment.

A few things still need to be done:

1. HtmlFormRenderer.java - change the \n characters to appendWhitespace calls
2. ModelForm.java and the widget-form.xsd files - the nav-* properties really aren't needed. As long as you have the PaginateStyle available for the outermost container, anyone can style its contained elements.
3. It would be nice to have the select box appear last. That way, the other elements follow the established pattern:

Previous - 1 of x - Next - Page [select box]

Once those changes are made, then you will have an excellent contribution. I look forward to seeing it in the project.

> Enhanced pager for Forms
> ------------------------
>
>                 Key: OFBIZ-1096
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1096
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Priority: Minor
>         Attachments: form-dtd.patch, form-dtd_2.patch, HtmlFormRenderer-2.patch, HtmlFormRenderer.patch, maincss.patch, ModelForm-2.patch, ModelForm.patch, pager.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk version.
> PS: I would like to use this issue to have your comments on another pager issue. The current implementation doesn't support pages that display more than one list form for the obvious reason that the only the parameters VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to differentiate the form.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.