[jira] Created: (OFBIZ-1107) Item and Sale discounts are not shown in the Journal

[Nicolas Malin (Jira)]

Item and Sale discounts are not shown in the Journal
----------------------------------------------------

                 Key: OFBIZ-1107
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1107
             Project: OFBiz
          Issue Type: Improvement
          Components: pos
    Affects Versions: SVN trunk
            Reporter: Chris Lombardi
            Priority: Minor


Neither "item discounts" nor "sale discounts" are shown in the Journal panel.  The amounts are just taken out of the Grand Total.  I have the fix for this, I just have to clean up my code and check it in.



--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-1107:
--------------------------------------

    Assignee: Jacques Le Roux

> Item and Sale discounts are not shown in the Journal
> ----------------------------------------------------
>
>                 Key: OFBIZ-1107
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1107
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: pos
>    Affects Versions: SVN trunk
>            Reporter: Chris Lombardi
>            Assignee: Jacques Le Roux
>            Priority: Minor
>
> Neither "item discounts" nor "sale discounts" are shown in the Journal panel.  The amounts are just taken out of the Grand Total.  I have the fix for this, I just have to clean up my code and check it in.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12508593 ]

Jacques Le Roux commented on OFBIZ-1107:
----------------------------------------

Please before submitting a patch if you have not read this page http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices, please read it

Thanks

> Item and Sale discounts are not shown in the Journal
> ----------------------------------------------------
>
>                 Key: OFBIZ-1107
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1107
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: pos
>    Affects Versions: SVN trunk
>            Reporter: Chris Lombardi
>            Assignee: Jacques Le Roux
>            Priority: Minor
>
> Neither "item discounts" nor "sale discounts" are shown in the Journal panel.  The amounts are just taken out of the Grand Total.  I have the fix for this, I just have to clean up my code and check it in.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Lombardi updated OFBIZ-1107:
----------------------------------

    Attachment:     (was: SaleDiscount.diff)

> Item and Sale discounts are not shown in the Journal
> ----------------------------------------------------
>
>                 Key: OFBIZ-1107
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1107
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: pos
>    Affects Versions: SVN trunk
>            Reporter: Chris Lombardi
>            Assignee: Jacques Le Roux
>            Priority: Minor
>
> Neither "item discounts" nor "sale discounts" are shown in the Journal panel.  The amounts are just taken out of the Grand Total.  I have the fix for this, I just have to clean up my code and check it in.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Lombardi updated OFBIZ-1107:
----------------------------------

    Attachment: SaleDiscount.diff

Adds a line to the Journal to show "sale discounts".

> Item and Sale discounts are not shown in the Journal
> ----------------------------------------------------
>
>                 Key: OFBIZ-1107
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1107
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: pos
>    Affects Versions: SVN trunk
>            Reporter: Chris Lombardi
>            Assignee: Jacques Le Roux
>            Priority: Minor
>
> Neither "item discounts" nor "sale discounts" are shown in the Journal panel.  The amounts are just taken out of the Grand Total.  I have the fix for this, I just have to clean up my code and check it in.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Lombardi updated OFBIZ-1107:
----------------------------------

    Attachment: SaleDiscount.diff

Displays Sale Discounts in the Journal.

> Item and Sale discounts are not shown in the Journal
> ----------------------------------------------------
>
>                 Key: OFBIZ-1107
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1107
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: pos
>    Affects Versions: SVN trunk
>            Reporter: Chris Lombardi
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: SaleDiscount.diff
>
>
> Neither "item discounts" nor "sale discounts" are shown in the Journal panel.  The amounts are just taken out of the Grand Total.  I have the fix for this, I just have to clean up my code and check it in.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Lombardi updated OFBIZ-1107:
----------------------------------

    Comment: was deleted

> Item and Sale discounts are not shown in the Journal
> ----------------------------------------------------
>
>                 Key: OFBIZ-1107
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1107
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: pos
>    Affects Versions: SVN trunk
>            Reporter: Chris Lombardi
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: SaleDiscount.diff
>
>
> Neither "item discounts" nor "sale discounts" are shown in the Journal panel.  The amounts are just taken out of the Grand Total.  I have the fix for this, I just have to clean up my code and check it in.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12508630 ]

Chris Lombardi commented on OFBIZ-1107:
---------------------------------------

Item discounts were already included in the trunk.  My patch includes only an update to show the sale discount.

> Item and Sale discounts are not shown in the Journal
> ----------------------------------------------------
>
>                 Key: OFBIZ-1107
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1107
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: pos
>    Affects Versions: SVN trunk
>            Reporter: Chris Lombardi
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: SaleDiscount.diff
>
>
> Neither "item discounts" nor "sale discounts" are shown in the Journal panel.  The amounts are just taken out of the Grand Total.  I have the fix for this, I just have to clean up my code and check it in.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1107.
----------------------------------

       Resolution: Fixed
    Fix Version/s: Release Branch 4.0

Thanks Chris,

Your patch is in trunk rev.  551332  

I slightly changed to improve the information : not only "(adjustement)" for both sale and item discount but "(sale discount)" and "(item discount)"

So I put in other properties file the english tokens. People will just have to translate it...

For instance in french I put
    (ItemDiscount)=Remise sur l'article
    (SalesDiscount)=Remise sur la vente
Note that I did not use parenthesis as they are redundant here because of the sign in price

Also I got rid of the dash in column quantity for other lines that product (useless)

> Item and Sale discounts are not shown in the Journal
> ----------------------------------------------------
>
>                 Key: OFBIZ-1107
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1107
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: pos
>    Affects Versions: SVN trunk
>            Reporter: Chris Lombardi
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 4.0
>
>         Attachments: SaleDiscount.diff
>
>
> Neither "item discounts" nor "sale discounts" are shown in the Journal panel.  The amounts are just taken out of the Grand Total.  I have the fix for this, I just have to clean up my code and check it in.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reopened OFBIZ-1107:
------------------------------------

> Item and Sale discounts are not shown in the Journal
> ----------------------------------------------------
>
>                 Key: OFBIZ-1107
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1107
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: pos
>    Affects Versions: SVN trunk
>            Reporter: Chris Lombardi
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 4.0
>
>         Attachments: SaleDiscount.diff
>
>
> Neither "item discounts" nor "sale discounts" are shown in the Journal panel.  The amounts are just taken out of the Grand Total.  I have the fix for this, I just have to clean up my code and check it in.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1107.
----------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: Release Branch 4.0)
                   SVN trunk

Re-opened to re-close : of course wrong line (not in release don't worry :o)

> Item and Sale discounts are not shown in the Journal
> ----------------------------------------------------
>
>                 Key: OFBIZ-1107
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1107
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: pos
>    Affects Versions: SVN trunk
>            Reporter: Chris Lombardi
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: SaleDiscount.diff
>
>
> Neither "item discounts" nor "sale discounts" are shown in the Journal panel.  The amounts are just taken out of the Grand Total.  I have the fix for this, I just have to clean up my code and check it in.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12508672 ]

Chris Lombardi commented on OFBIZ-1107:
---------------------------------------

That works for me.  Thanks much! -C

> Item and Sale discounts are not shown in the Journal
> ----------------------------------------------------
>
>                 Key: OFBIZ-1107
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1107
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: pos
>    Affects Versions: SVN trunk
>            Reporter: Chris Lombardi
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: SaleDiscount.diff
>
>
> Neither "item discounts" nor "sale discounts" are shown in the Journal panel.  The amounts are just taken out of the Grand Total.  I have the fix for this, I just have to clean up my code and check it in.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.