[jira] Created: (OFBIZ-1132) Order item can't have not-integer quantity.

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-1132) Order item can't have not-integer quantity.

Nicolas Malin (Jira)
Order item can't have not-integer quantity.
-------------------------------------------

                 Key: OFBIZ-1132
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1132
             Project: OFBiz
          Issue Type: Bug
          Components: order
    Affects Versions: SVN trunk
            Reporter: Oleg Andreyev
            Priority: Minor
             Fix For: SVN trunk
         Attachments: ordercart.diff

Data model and quantity value type allows positive non-integer quantity of the products. But this possibility is blocked in some points of the ShoppingCart[Helper/Item/Events] code. Of course this case is seldom enough but it's possible. The patch corrects this problem.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1132) Order item can't have not-integer quantity.

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Andreyev updated OFBIZ-1132:
---------------------------------

    Attachment: ordercart.diff

> Order item can't have not-integer quantity.
> -------------------------------------------
>
>                 Key: OFBIZ-1132
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1132
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Oleg Andreyev
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ordercart.diff
>
>
> Data model and quantity value type allows positive non-integer quantity of the products. But this possibility is blocked in some points of the ShoppingCart[Helper/Item/Events] code. Of course this case is seldom enough but it's possible. The patch corrects this problem.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1132) Order item can't have not-integer quantity.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12511014 ]

David E. Jones commented on OFBIZ-1132:
---------------------------------------

There is some history behind this, and I think the current status is that it needs to be discussed.

The intent of the current stuff (only moderately well supported) is to have quantity ALWAYS be an integer (whole number) and if a decimal amount is needed then the "amount" field would be used.

Anyway, to get an idea of what's up I recommend reading though some mailing list history, and there are probably some relevant Jira issues too. Yeah, by this I mean researching the issue.

In short though, this should NOT be committed until it is discussed and a solution/approach generally agreed on.

If we do go with supporting decimal numbers for the quantity field we need to at least first have in place an indicator on the Product entity as to whether a decimal quantity is allowed for that Product or not, and that should default to false to be consistent with current behavior.

> Order item can't have not-integer quantity.
> -------------------------------------------
>
>                 Key: OFBIZ-1132
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1132
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Oleg Andreyev
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ordercart.diff
>
>
> Data model and quantity value type allows positive non-integer quantity of the products. But this possibility is blocked in some points of the ShoppingCart[Helper/Item/Events] code. Of course this case is seldom enough but it's possible. The patch corrects this problem.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-1132) Order item can't have not-integer quantity.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato closed OFBIZ-1132.
------------------------------------

    Resolution: Invalid

Yes,

we will need to support this with a different approach: probably supporting unit of measures for orders/inventory items etc... (and conversions) would be a possibility, as already discussed in the past.


> Order item can't have not-integer quantity.
> -------------------------------------------
>
>                 Key: OFBIZ-1132
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1132
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Oleg Andreyev
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ordercart.diff
>
>
> Data model and quantity value type allows positive non-integer quantity of the products. But this possibility is blocked in some points of the ShoppingCart[Helper/Item/Events] code. Of course this case is seldom enough but it's possible. The patch corrects this problem.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.