[jira] Created: (OFBIZ-1137) Replaced hard coded USD in currency dropdowns with defaultCurrencyUomId

[Nicolas Malin (Jira)]

Replaced hard coded USD in currency dropdowns with defaultCurrencyUomId
-----------------------------------------------------------------------

                 Key: OFBIZ-1137
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1137
             Project: OFBiz
          Issue Type: Improvement
    Affects Versions: SVN trunk, Release Branch 4.0
            Reporter: Bilgin Ibryam
            Priority: Trivial
             Fix For: SVN trunk, Release Branch 4.0
         Attachments: UomId.patch

I changed the currency.uom.id.default in general.properties but the default currency was still USD in lots of dropdowns. The reason is that it is hard coded in the dropdowns. So i replaced them with defaultCurrencyUomId and now it is better.
BTW whats the best way to order by the currency dropdown? I see that it is ordered by abbreviation, description, uomId...

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam updated OFBIZ-1137:
---------------------------------

    Attachment: UomId.patch

the patch

> Replaced hard coded USD in currency dropdowns with defaultCurrencyUomId
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-1137
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1137
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Bilgin Ibryam
>            Priority: Trivial
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: UomId.patch
>
>
> I changed the currency.uom.id.default in general.properties but the default currency was still USD in lots of dropdowns. The reason is that it is hard coded in the dropdowns. So i replaced them with defaultCurrencyUomId and now it is better.
> BTW whats the best way to order by the currency dropdown? I see that it is ordered by abbreviation, description, uomId...

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12511935 ]

Wickersheimer Jeremy commented on OFBIZ-1137:
---------------------------------------------

I think it should be consistently ordered by what is displayed in the dropdown. that should be abbreviation i think.

> Replaced hard coded USD in currency dropdowns with defaultCurrencyUomId
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-1137
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1137
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Bilgin Ibryam
>            Priority: Trivial
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: UomId.patch
>
>
> I changed the currency.uom.id.default in general.properties but the default currency was still USD in lots of dropdowns. The reason is that it is hard coded in the dropdowns. So i replaced them with defaultCurrencyUomId and now it is better.
> BTW whats the best way to order by the currency dropdown? I see that it is ordered by abbreviation, description, uomId...

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512097 ]

Guido Amarilla commented on OFBIZ-1137:
---------------------------------------

I like more this format:
[USD] American Dollar
and the list should be ordered by the abbreviation, so it is invariable between languages.
There should be consistency between currency uom id dropdowns in every application. Currently different formats are used.

> Replaced hard coded USD in currency dropdowns with defaultCurrencyUomId
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-1137
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1137
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Bilgin Ibryam
>            Priority: Trivial
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: UomId.patch
>
>
> I changed the currency.uom.id.default in general.properties but the default currency was still USD in lots of dropdowns. The reason is that it is hard coded in the dropdowns. So i replaced them with defaultCurrencyUomId and now it is better.
> BTW whats the best way to order by the currency dropdown? I see that it is ordered by abbreviation, description, uomId...

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512236 ]

Scott Gray commented on OFBIZ-1137:
-----------------------------------

I'm not a fan of that format because most browsers will let you use the keyboard to speed up selection but having the currency start with [ means it doesn't work very well.

> Replaced hard coded USD in currency dropdowns with defaultCurrencyUomId
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-1137
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1137
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Bilgin Ibryam
>            Priority: Trivial
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: UomId.patch
>
>
> I changed the currency.uom.id.default in general.properties but the default currency was still USD in lots of dropdowns. The reason is that it is hard coded in the dropdowns. So i replaced them with defaultCurrencyUomId and now it is better.
> BTW whats the best way to order by the currency dropdown? I see that it is ordered by abbreviation, description, uomId...

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512243 ]

Jacques Le Roux commented on OFBIZ-1137:
----------------------------------------

I agree with Scoot, why add [ ] ?

> Replaced hard coded USD in currency dropdowns with defaultCurrencyUomId
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-1137
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1137
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Bilgin Ibryam
>            Priority: Trivial
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: UomId.patch
>
>
> I changed the currency.uom.id.default in general.properties but the default currency was still USD in lots of dropdowns. The reason is that it is hard coded in the dropdowns. So i replaced them with defaultCurrencyUomId and now it is better.
> BTW whats the best way to order by the currency dropdown? I see that it is ordered by abbreviation, description, uomId...

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512246 ]

Jacques Le Roux commented on OFBIZ-1137:
----------------------------------------

Sorry, was Scott of course ;o)

> Replaced hard coded USD in currency dropdowns with defaultCurrencyUomId
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-1137
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1137
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Bilgin Ibryam
>            Priority: Trivial
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: UomId.patch
>
>
> I changed the currency.uom.id.default in general.properties but the default currency was still USD in lots of dropdowns. The reason is that it is hard coded in the dropdowns. So i replaced them with defaultCurrencyUomId and now it is better.
> BTW whats the best way to order by the currency dropdown? I see that it is ordered by abbreviation, description, uomId...

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512253 ]

Guido Amarilla commented on OFBIZ-1137:
---------------------------------------

What about
USD - American Dollar  or USD (American Dollar)
This way we can use speed selection and have a description of the currency.

> Replaced hard coded USD in currency dropdowns with defaultCurrencyUomId
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-1137
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1137
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Bilgin Ibryam
>            Priority: Trivial
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: UomId.patch
>
>
> I changed the currency.uom.id.default in general.properties but the default currency was still USD in lots of dropdowns. The reason is that it is hard coded in the dropdowns. So i replaced them with defaultCurrencyUomId and now it is better.
> BTW whats the best way to order by the currency dropdown? I see that it is ordered by abbreviation, description, uomId...

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512255 ]

Scott Gray commented on OFBIZ-1137:
-----------------------------------

The first one looks good to me

> Replaced hard coded USD in currency dropdowns with defaultCurrencyUomId
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-1137
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1137
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Bilgin Ibryam
>            Priority: Trivial
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: UomId.patch
>
>
> I changed the currency.uom.id.default in general.properties but the default currency was still USD in lots of dropdowns. The reason is that it is hard coded in the dropdowns. So i replaced them with defaultCurrencyUomId and now it is better.
> BTW whats the best way to order by the currency dropdown? I see that it is ordered by abbreviation, description, uomId...

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512256 ]

Jacques Le Roux commented on OFBIZ-1137:
----------------------------------------

Guido,

Yes, I prefer the 1st

> Replaced hard coded USD in currency dropdowns with defaultCurrencyUomId
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-1137
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1137
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Bilgin Ibryam
>            Priority: Trivial
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: UomId.patch
>
>
> I changed the currency.uom.id.default in general.properties but the default currency was still USD in lots of dropdowns. The reason is that it is hard coded in the dropdowns. So i replaced them with defaultCurrencyUomId and now it is better.
> BTW whats the best way to order by the currency dropdown? I see that it is ordered by abbreviation, description, uomId...

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512496 ]

Bilgin Ibryam commented on OFBIZ-1137:
--------------------------------------

Ok guys,
I will create a new issue for  the currency dropdown. So i will do all of them look like USD - American Dollar  and order by abbreviation.
Can someone commit and close this issue. This one was only for replacing hard coded USD.

> Replaced hard coded USD in currency dropdowns with defaultCurrencyUomId
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-1137
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1137
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Bilgin Ibryam
>            Priority: Trivial
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: UomId.patch
>
>
> I changed the currency.uom.id.default in general.properties but the default currency was still USD in lots of dropdowns. The reason is that it is hard coded in the dropdowns. So i replaced them with defaultCurrencyUomId and now it is better.
> BTW whats the best way to order by the currency dropdown? I see that it is ordered by abbreviation, description, uomId...

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1137.
----------------------------------

    Resolution: Fixed
      Assignee: Jacques Le Roux

Thanks Bilgin,

Your patch is in trunk rev. 556105.

I tried to merge the patch in release4.0 but I got a conflict in PartyForms.xml and after some struggle I surrendered

> Replaced hard coded USD in currency dropdowns with defaultCurrencyUomId
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-1137
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1137
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Bilgin Ibryam
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: UomId.patch
>
>
> I changed the currency.uom.id.default in general.properties but the default currency was still USD in lots of dropdowns. The reason is that it is hard coded in the dropdowns. So i replaced them with defaultCurrencyUomId and now it is better.
> BTW whats the best way to order by the currency dropdown? I see that it is ordered by abbreviation, description, uomId...

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.