error in view-size used for paginate = "false" form
---------------------------------------------------- Key: OFBIZ-1152 URL: https://issues.apache.org/jira/browse/OFBIZ-1152 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Gaudin Pierre Fix For: SVN trunk If paginate is set to false then wiev-size is never used. Only DEFAULT_PAGE_SIZE is used. 1/ in init() Modelform wiev-size is getting : setDefaultViewSize(formElement.getAttribute("view-size")); =>OK 2/ this value is set to defaultViewSize defaultViewSize = sz.intValue(); => OK 3/ in getListLimits() Modelform if paginate is false then DEFAULT_PAGE_SIZE is used and not defaultViewSize viewSize = DEFAULT_PAGE_SIZE; => KO -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[ https://issues.apache.org/jira/browse/OFBIZ-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gaudin Pierre updated OFBIZ-1152: --------------------------------- Attachment: defaultViewSize.patch here is the patch from revision 556832 > error in view-size used for paginate = "false" form > ---------------------------------------------------- > > Key: OFBIZ-1152 > URL: https://issues.apache.org/jira/browse/OFBIZ-1152 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Gaudin Pierre > Fix For: SVN trunk > > Attachments: defaultViewSize.patch > > > If paginate is set to false then wiev-size is never used. Only DEFAULT_PAGE_SIZE is used. > 1/ in init() Modelform wiev-size is getting : > setDefaultViewSize(formElement.getAttribute("view-size")); > =>OK > 2/ this value is set to defaultViewSize > defaultViewSize = sz.intValue(); > => OK > 3/ in getListLimits() Modelform if paginate is false then DEFAULT_PAGE_SIZE is used and not defaultViewSize > viewSize = DEFAULT_PAGE_SIZE; > => KO -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12513846 ] Gaudin Pierre commented on OFBIZ-1152: -------------------------------------- Hi all, Is there any body to have a look at this patch ? This is a very simple but important fix. Thanks Pierre > error in view-size used for paginate = "false" form > ---------------------------------------------------- > > Key: OFBIZ-1152 > URL: https://issues.apache.org/jira/browse/OFBIZ-1152 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Gaudin Pierre > Fix For: SVN trunk > > Attachments: defaultViewSize.patch > > > If paginate is set to false then wiev-size is never used. Only DEFAULT_PAGE_SIZE is used. > 1/ in init() Modelform wiev-size is getting : > setDefaultViewSize(formElement.getAttribute("view-size")); > =>OK > 2/ this value is set to defaultViewSize > defaultViewSize = sz.intValue(); > => OK > 3/ in getListLimits() Modelform if paginate is false then DEFAULT_PAGE_SIZE is used and not defaultViewSize > viewSize = DEFAULT_PAGE_SIZE; > => KO -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12513851 ] Scott Gray commented on OFBIZ-1152: ----------------------------------- Hi Gaudin Please be patient someone will look at it as soon as there is time, but rest assured we appreciate your help. Regards Scott > error in view-size used for paginate = "false" form > ---------------------------------------------------- > > Key: OFBIZ-1152 > URL: https://issues.apache.org/jira/browse/OFBIZ-1152 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Gaudin Pierre > Fix For: SVN trunk > > Attachments: defaultViewSize.patch > > > If paginate is set to false then wiev-size is never used. Only DEFAULT_PAGE_SIZE is used. > 1/ in init() Modelform wiev-size is getting : > setDefaultViewSize(formElement.getAttribute("view-size")); > =>OK > 2/ this value is set to defaultViewSize > defaultViewSize = sz.intValue(); > => OK > 3/ in getListLimits() Modelform if paginate is false then DEFAULT_PAGE_SIZE is used and not defaultViewSize > viewSize = DEFAULT_PAGE_SIZE; > => KO -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-1152: -------------------------------------- Assignee: Jacques Le Roux > error in view-size used for paginate = "false" form > ---------------------------------------------------- > > Key: OFBIZ-1152 > URL: https://issues.apache.org/jira/browse/OFBIZ-1152 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Gaudin Pierre > Assignee: Jacques Le Roux > Fix For: SVN trunk > > Attachments: defaultViewSize.patch > > > If paginate is set to false then wiev-size is never used. Only DEFAULT_PAGE_SIZE is used. > 1/ in init() Modelform wiev-size is getting : > setDefaultViewSize(formElement.getAttribute("view-size")); > =>OK > 2/ this value is set to defaultViewSize > defaultViewSize = sz.intValue(); > => OK > 3/ in getListLimits() Modelform if paginate is false then DEFAULT_PAGE_SIZE is used and not defaultViewSize > viewSize = DEFAULT_PAGE_SIZE; > => KO -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-1152. ---------------------------------- Resolution: Fixed Fix Version/s: Release Branch 4.0 Thanks Pierre, Your patch is in trunk rev. 557554, release4.0 : 557556 > error in view-size used for paginate = "false" form > ---------------------------------------------------- > > Key: OFBIZ-1152 > URL: https://issues.apache.org/jira/browse/OFBIZ-1152 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Gaudin Pierre > Assignee: Jacques Le Roux > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: defaultViewSize.patch > > > If paginate is set to false then wiev-size is never used. Only DEFAULT_PAGE_SIZE is used. > 1/ in init() Modelform wiev-size is getting : > setDefaultViewSize(formElement.getAttribute("view-size")); > =>OK > 2/ this value is set to defaultViewSize > defaultViewSize = sz.intValue(); > => OK > 3/ in getListLimits() Modelform if paginate is false then DEFAULT_PAGE_SIZE is used and not defaultViewSize > viewSize = DEFAULT_PAGE_SIZE; > => KO -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12513866 ] Gaudin Pierre commented on OFBIZ-1152: -------------------------------------- Many thanks Jacques ! Pierre > error in view-size used for paginate = "false" form > ---------------------------------------------------- > > Key: OFBIZ-1152 > URL: https://issues.apache.org/jira/browse/OFBIZ-1152 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Gaudin Pierre > Assignee: Jacques Le Roux > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: defaultViewSize.patch > > > If paginate is set to false then wiev-size is never used. Only DEFAULT_PAGE_SIZE is used. > 1/ in init() Modelform wiev-size is getting : > setDefaultViewSize(formElement.getAttribute("view-size")); > =>OK > 2/ this value is set to defaultViewSize > defaultViewSize = sz.intValue(); > => OK > 3/ in getListLimits() Modelform if paginate is false then DEFAULT_PAGE_SIZE is used and not defaultViewSize > viewSize = DEFAULT_PAGE_SIZE; > => KO -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12513867 ] David E. Jones commented on OFBIZ-1152: --------------------------------------- Is it just me, or did a few things make it in with this patch that are outside of what was described here, and possibly unrelated? > error in view-size used for paginate = "false" form > ---------------------------------------------------- > > Key: OFBIZ-1152 > URL: https://issues.apache.org/jira/browse/OFBIZ-1152 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Gaudin Pierre > Assignee: Jacques Le Roux > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: defaultViewSize.patch > > > If paginate is set to false then wiev-size is never used. Only DEFAULT_PAGE_SIZE is used. > 1/ in init() Modelform wiev-size is getting : > setDefaultViewSize(formElement.getAttribute("view-size")); > =>OK > 2/ this value is set to defaultViewSize > defaultViewSize = sz.intValue(); > => OK > 3/ in getListLimits() Modelform if paginate is false then DEFAULT_PAGE_SIZE is used and not defaultViewSize > viewSize = DEFAULT_PAGE_SIZE; > => KO -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12513875 ] Jacques Le Roux commented on OFBIZ-1152: ---------------------------------------- No David, you are right. There is something wrong with my commit not Pierre's patch. I suspect my new Eclipse 3.3 configuration. It should be only EOL and blanks. I will check. If only I had used Tortoise SVN after patching from command line as I do normally :(. > error in view-size used for paginate = "false" form > ---------------------------------------------------- > > Key: OFBIZ-1152 > URL: https://issues.apache.org/jira/browse/OFBIZ-1152 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Gaudin Pierre > Assignee: Jacques Le Roux > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: defaultViewSize.patch > > > If paginate is set to false then wiev-size is never used. Only DEFAULT_PAGE_SIZE is used. > 1/ in init() Modelform wiev-size is getting : > setDefaultViewSize(formElement.getAttribute("view-size")); > =>OK > 2/ this value is set to defaultViewSize > defaultViewSize = sz.intValue(); > => OK > 3/ in getListLimits() Modelform if paginate is false then DEFAULT_PAGE_SIZE is used and not defaultViewSize > viewSize = DEFAULT_PAGE_SIZE; > => KO -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12513877 ] Jacques Le Roux commented on OFBIZ-1152: ---------------------------------------- Mmm, I should have forgot another patch I was reviewing and get caught for any reason. I will revert to previous and reapply the patch correctly (in release too). Sorry for that folks, and thanks for your awareness David. > error in view-size used for paginate = "false" form > ---------------------------------------------------- > > Key: OFBIZ-1152 > URL: https://issues.apache.org/jira/browse/OFBIZ-1152 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Gaudin Pierre > Assignee: Jacques Le Roux > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: defaultViewSize.patch > > > If paginate is set to false then wiev-size is never used. Only DEFAULT_PAGE_SIZE is used. > 1/ in init() Modelform wiev-size is getting : > setDefaultViewSize(formElement.getAttribute("view-size")); > =>OK > 2/ this value is set to defaultViewSize > defaultViewSize = sz.intValue(); > => OK > 3/ in getListLimits() Modelform if paginate is false then DEFAULT_PAGE_SIZE is used and not defaultViewSize > viewSize = DEFAULT_PAGE_SIZE; > => KO -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
Free forum by Nabble | Edit this page |