[jira] Created: (OFBIZ-1156) Small bugs in ecommerce application
Locked
[jira] Created: (OFBIZ-1156) Small bugs in ecommerce application
 
|
Small bugs in ecommerce application
----------------------------------- Key: OFBIZ-1156 URL: https://issues.apache.org/jira/browse/OFBIZ-1156 Project: OFBiz Issue Type: Bug Components: ecommerce Affects Versions: Release Branch 4.0 Reporter: Bilgin Ibryam Priority: Minor Fix For: Release Branch 4.0 I found some small bugs in ecommerce and did a patch for them. 1. Added * for the required postal code field. 2. When creating order from quote, if you choose the offline payment method, the submit button is not working, because the form is not created... The applied patch fixes these problems. I got also one question: In ecommerce, if you go to view cart screen you see items in the cart. If there are promotion items, in front of the them there is "P link". It indicates that the item is a promotion, but why it is a link to the same screen? it just refresh the same screen... Here is its code: <a href="<@ofbizUrl>view/showcart</@ofbizUrl>" class="buttontext">P</a> Regards, Bilgin Ibryam -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-1156) Small bugs in ecommerce application
|
|
[ https://issues.apache.org/jira/browse/OFBIZ-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam updated OFBIZ-1156: --------------------------------- Attachment: ecommerce.patch the patch > Small bugs in ecommerce application > ----------------------------------- > > Key: OFBIZ-1156 > URL: https://issues.apache.org/jira/browse/OFBIZ-1156 > Project: OFBiz > Issue Type: Bug > Components: ecommerce > Affects Versions: Release Branch 4.0 > Reporter: Bilgin Ibryam > Priority: Minor > Fix For: Release Branch 4.0 > > Attachments: ecommerce.patch > > > I found some small bugs in ecommerce and did a patch for them. > 1. Added * for the required postal code field. > 2. When creating order from quote, if you choose the offline payment method, the submit button is not working, because the form is not created... > The applied patch fixes these problems. > I got also one question: > In ecommerce, if you go to view cart screen you see items in the cart. If there are promotion items, in front of the them there is "P link". It indicates that the item is a promotion, but why it is a link to the same screen? it just refresh the same screen... > Here is its code: > <a href="<@ofbizUrl>view/showcart</@ofbizUrl>" class="buttontext">P</a> > Regards, > Bilgin Ibryam -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-1156) Small bugs in ecommerce application
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam updated OFBIZ-1156: --------------------------------- Fix Version/s: SVN trunk Affects Version/s: SVN trunk > Small bugs in ecommerce application > ----------------------------------- > > Key: OFBIZ-1156 > URL: https://issues.apache.org/jira/browse/OFBIZ-1156 > Project: OFBiz > Issue Type: Bug > Components: ecommerce > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Bilgin Ibryam > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: ecommerce.patch > > > I found some small bugs in ecommerce and did a patch for them. > 1. Added * for the required postal code field. > 2. When creating order from quote, if you choose the offline payment method, the submit button is not working, because the form is not created... > The applied patch fixes these problems. > I got also one question: > In ecommerce, if you go to view cart screen you see items in the cart. If there are promotion items, in front of the them there is "P link". It indicates that the item is a promotion, but why it is a link to the same screen? it just refresh the same screen... > Here is its code: > <a href="<@ofbizUrl>view/showcart</@ofbizUrl>" class="buttontext">P</a> > Regards, > Bilgin Ibryam -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1156) Small bugs in ecommerce application
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12516249 ] Jacques Le Roux commented on OFBIZ-1156: ---------------------------------------- Bilgin, I applied your patch and quicky tested. It's really better but there are still some problems. . When you check "Billing address is the same as the shipping address" in the screen following the screen you fixed you get a blank page. . Wnen you click on "Continue" nothing happens Thanks for your work > Small bugs in ecommerce application > ----------------------------------- > > Key: OFBIZ-1156 > URL: https://issues.apache.org/jira/browse/OFBIZ-1156 > Project: OFBiz > Issue Type: Bug > Components: ecommerce > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Bilgin Ibryam > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: ecommerce.patch > > > I found some small bugs in ecommerce and did a patch for them. > 1. Added * for the required postal code field. > 2. When creating order from quote, if you choose the offline payment method, the submit button is not working, because the form is not created... > The applied patch fixes these problems. > I got also one question: > In ecommerce, if you go to view cart screen you see items in the cart. If there are promotion items, in front of the them there is "P link". It indicates that the item is a promotion, but why it is a link to the same screen? it just refresh the same screen... > Here is its code: > <a href="<@ofbizUrl>view/showcart</@ofbizUrl>" class="buttontext">P</a> > Regards, > Bilgin Ibryam -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1156) Small bugs in ecommerce application
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12516294 ] Bilgin Ibryam commented on OFBIZ-1156: -------------------------------------- Thanks for the commit Jacques. These days i will take a look at these problems too. Any idea about "P" link in the cart ? > Small bugs in ecommerce application > ----------------------------------- > > Key: OFBIZ-1156 > URL: https://issues.apache.org/jira/browse/OFBIZ-1156 > Project: OFBiz > Issue Type: Bug > Components: ecommerce > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Bilgin Ibryam > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: ecommerce.patch > > > I found some small bugs in ecommerce and did a patch for them. > 1. Added * for the required postal code field. > 2. When creating order from quote, if you choose the offline payment method, the submit button is not working, because the form is not created... > The applied patch fixes these problems. > I got also one question: > In ecommerce, if you go to view cart screen you see items in the cart. If there are promotion items, in front of the them there is "P link". It indicates that the item is a promotion, but why it is a link to the same screen? it just refresh the same screen... > Here is its code: > <a href="<@ofbizUrl>view/showcart</@ofbizUrl>" class="buttontext">P</a> > Regards, > Bilgin Ibryam -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Assigned: (OFBIZ-1156) Small bugs in ecommerce application
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-1156: -------------------------------------- Assignee: Jacques Le Roux > Small bugs in ecommerce application > ----------------------------------- > > Key: OFBIZ-1156 > URL: https://issues.apache.org/jira/browse/OFBIZ-1156 > Project: OFBiz > Issue Type: Bug > Components: ecommerce > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Bilgin Ibryam > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: ecommerce.patch > > > I found some small bugs in ecommerce and did a patch for them. > 1. Added * for the required postal code field. > 2. When creating order from quote, if you choose the offline payment method, the submit button is not working, because the form is not created... > The applied patch fixes these problems. > I got also one question: > In ecommerce, if you go to view cart screen you see items in the cart. If there are promotion items, in front of the them there is "P link". It indicates that the item is a promotion, but why it is a link to the same screen? it just refresh the same screen... > Here is its code: > <a href="<@ofbizUrl>view/showcart</@ofbizUrl>" class="buttontext">P</a> > Regards, > Bilgin Ibryam -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1156) Small bugs in ecommerce application
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519280 ] Jacques Le Roux commented on OFBIZ-1156: ---------------------------------------- Bilgin, I'm not sure what you mean by "commit" above (I did not commit your patch). I have no idea about the "P" link, somebody knows ? > Small bugs in ecommerce application > ----------------------------------- > > Key: OFBIZ-1156 > URL: https://issues.apache.org/jira/browse/OFBIZ-1156 > Project: OFBiz > Issue Type: Bug > Components: ecommerce > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Bilgin Ibryam > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: ecommerce.patch > > > I found some small bugs in ecommerce and did a patch for them. > 1. Added * for the required postal code field. > 2. When creating order from quote, if you choose the offline payment method, the submit button is not working, because the form is not created... > The applied patch fixes these problems. > I got also one question: > In ecommerce, if you go to view cart screen you see items in the cart. If there are promotion items, in front of the them there is "P link". It indicates that the item is a promotion, but why it is a link to the same screen? it just refresh the same screen... > Here is its code: > <a href="<@ofbizUrl>view/showcart</@ofbizUrl>" class="buttontext">P</a> > Regards, > Bilgin Ibryam -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1156) Small bugs in ecommerce application
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523382 ] Bilgin Ibryam commented on OFBIZ-1156: -------------------------------------- Finally i spent some time for this issue and here is what i found out: While creating order from quote, in payment Options screen is used paymentoptions.ftl and in payment Information screen is used paymentinformation.ftl But in some case these both screens are replaced from billsetting screen with billsetting.ftl And billsetting.ftl is combination of paymentoptions.ftl plus paymentinformation.ftl (plus some buggy code). I do not know is it intentional or not, using two different screens for the same purpose, but i replaced billsetting screen with payment Options screen. I think that this is the right solution. Jacques, can you try again my patch. This time it should fix all the bugs. BTW the billsetting view-map in ecommerce controller, the billsettings screen in OrderScreens.xml and its file (billsettings.bsh and billsettings.ftl) could be also deleted, they are not used anywhere else in the framework. But it is up to you... > Small bugs in ecommerce application > ----------------------------------- > > Key: OFBIZ-1156 > URL: https://issues.apache.org/jira/browse/OFBIZ-1156 > Project: OFBiz > Issue Type: Bug > Components: ecommerce > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Bilgin Ibryam > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: ecommerce.patch > > > I found some small bugs in ecommerce and did a patch for them. > 1. Added * for the required postal code field. > 2. When creating order from quote, if you choose the offline payment method, the submit button is not working, because the form is not created... > The applied patch fixes these problems. > I got also one question: > In ecommerce, if you go to view cart screen you see items in the cart. If there are promotion items, in front of the them there is "P link". It indicates that the item is a promotion, but why it is a link to the same screen? it just refresh the same screen... > Here is its code: > <a href="<@ofbizUrl>view/showcart</@ofbizUrl>" class="buttontext">P</a> > Regards, > Bilgin Ibryam -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-1156) Small bugs in ecommerce application
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam updated OFBIZ-1156: --------------------------------- Attachment: ecommerce.patch > Small bugs in ecommerce application > ----------------------------------- > > Key: OFBIZ-1156 > URL: https://issues.apache.org/jira/browse/OFBIZ-1156 > Project: OFBiz > Issue Type: Bug > Components: ecommerce > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Bilgin Ibryam > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: ecommerce.patch, ecommerce.patch > > > I found some small bugs in ecommerce and did a patch for them. > 1. Added * for the required postal code field. > 2. When creating order from quote, if you choose the offline payment method, the submit button is not working, because the form is not created... > The applied patch fixes these problems. > I got also one question: > In ecommerce, if you go to view cart screen you see items in the cart. If there are promotion items, in front of the them there is "P link". It indicates that the item is a promotion, but why it is a link to the same screen? it just refresh the same screen... > Here is its code: > <a href="<@ofbizUrl>view/showcart</@ofbizUrl>" class="buttontext">P</a> > Regards, > Bilgin Ibryam -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1156) Small bugs in ecommerce application
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524182 ] Bilgin Ibryam commented on OFBIZ-1156: -------------------------------------- OK. While checking out in ecommerce at " 3) How s pay? "screen I see some broken links: Single_Use_Credit_Card, Single_Use_Gift_Card, Single_Use_EFT_Account . And it looks like billesetting screen should be accessible from these 3 broken links. We should not delete this screen. This final patch should fix all the mentioned bugs. I hope so :) About the "P link" : it should be a link to the exact promotion, like "L link" is a link to the shopping list. But getting productPromoId from shopping cart item is not very easy and this "P" is link to the same page instead of promotion detail screen. > Small bugs in ecommerce application > ----------------------------------- > > Key: OFBIZ-1156 > URL: https://issues.apache.org/jira/browse/OFBIZ-1156 > Project: OFBiz > Issue Type: Bug > Components: ecommerce > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Bilgin Ibryam > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: ecommerce.patch, ecommerce.patch > > > I found some small bugs in ecommerce and did a patch for them. > 1. Added * for the required postal code field. > 2. When creating order from quote, if you choose the offline payment method, the submit button is not working, because the form is not created... > The applied patch fixes these problems. > I got also one question: > In ecommerce, if you go to view cart screen you see items in the cart. If there are promotion items, in front of the them there is "P link". It indicates that the item is a promotion, but why it is a link to the same screen? it just refresh the same screen... > Here is its code: > <a href="<@ofbizUrl>view/showcart</@ofbizUrl>" class="buttontext">P</a> > Regards, > Bilgin Ibryam -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-1156) Small bugs in ecommerce application
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam updated OFBIZ-1156: --------------------------------- Attachment: ecommerce.patch > Small bugs in ecommerce application > ----------------------------------- > > Key: OFBIZ-1156 > URL: https://issues.apache.org/jira/browse/OFBIZ-1156 > Project: OFBiz > Issue Type: Bug > Components: ecommerce > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Bilgin Ibryam > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: ecommerce.patch, ecommerce.patch, ecommerce.patch > > > I found some small bugs in ecommerce and did a patch for them. > 1. Added * for the required postal code field. > 2. When creating order from quote, if you choose the offline payment method, the submit button is not working, because the form is not created... > The applied patch fixes these problems. > I got also one question: > In ecommerce, if you go to view cart screen you see items in the cart. If there are promotion items, in front of the them there is "P link". It indicates that the item is a promotion, but why it is a link to the same screen? it just refresh the same screen... > Here is its code: > <a href="<@ofbizUrl>view/showcart</@ofbizUrl>" class="buttontext">P</a> > Regards, > Bilgin Ibryam -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1156) Small bugs in ecommerce application
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524470 ] Bilgin Ibryam commented on OFBIZ-1156: -------------------------------------- btw, this issue should be also fixed after applying the patch https://issues.apache.org/jira/browse/OFBIZ-866 > Small bugs in ecommerce application > ----------------------------------- > > Key: OFBIZ-1156 > URL: https://issues.apache.org/jira/browse/OFBIZ-1156 > Project: OFBiz > Issue Type: Bug > Components: ecommerce > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Bilgin Ibryam > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: ecommerce.patch, ecommerce.patch, ecommerce.patch > > > I found some small bugs in ecommerce and did a patch for them. > 1. Added * for the required postal code field. > 2. When creating order from quote, if you choose the offline payment method, the submit button is not working, because the form is not created... > The applied patch fixes these problems. > I got also one question: > In ecommerce, if you go to view cart screen you see items in the cart. If there are promotion items, in front of the them there is "P link". It indicates that the item is a promotion, but why it is a link to the same screen? it just refresh the same screen... > Here is its code: > <a href="<@ofbizUrl>view/showcart</@ofbizUrl>" class="buttontext">P</a> > Regards, > Bilgin Ibryam -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Closed: (OFBIZ-1156) Small bugs in ecommerce application
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-1156. ---------------------------------- Resolution: Fixed Thanks BIlgin, Your patch is in trunk rev. 572247 and release 572284 > Small bugs in ecommerce application > ----------------------------------- > > Key: OFBIZ-1156 > URL: https://issues.apache.org/jira/browse/OFBIZ-1156 > Project: OFBiz > Issue Type: Bug > Components: ecommerce > Affects Versions: SVN trunk, Release Branch 4.0 > Reporter: Bilgin Ibryam > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: ecommerce.patch, ecommerce.patch, ecommerce.patch > > > I found some small bugs in ecommerce and did a patch for them. > 1. Added * for the required postal code field. > 2. When creating order from quote, if you choose the offline payment method, the submit button is not working, because the form is not created... > The applied patch fixes these problems. > I got also one question: > In ecommerce, if you go to view cart screen you see items in the cart. If there are promotion items, in front of the them there is "P link". It indicates that the item is a promotion, but why it is a link to the same screen? it just refresh the same screen... > Here is its code: > <a href="<@ofbizUrl>view/showcart</@ofbizUrl>" class="buttontext">P</a> > Regards, > Bilgin Ibryam -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |