[jira] Created: (OFBIZ-1159) Integration with eBay (import of orders and export of auctions).

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515521 ]

Jacopo Cappellato commented on OFBIZ-1159:
------------------------------------------

David S.,

your patch is interesting and a good starting point to implement the update of existing contact mechs imported from eBay; however, after a quick review, there are two issues that you should resolve before committing your work to svn:

1) when you try to fetch existing contact mechs for a party, you use the following code:

GenericValue contactMech = EntityUtil.getFirst(delegator.findByAnd("PartyContactMechPurpose", UtilMisc.toMap("partyId", partyId, "contactMechPurposeTypeId","SHIPPING_LOCATION")));

unfortunately in this way you can also select an expired contact mech. Instead of using a findByAnd you should try to make a call to one of the methods of the ContactHelper class (or ContactMechWorker class) in the party component.

2) in the checkPartyAddress, checkPartyEmail etc... before running the update (that will expire the existing contact mech and create a new one, even if they are identical) you should compare field-to-field the two addresses/email....

Jacopo

> Integration with eBay (import of orders and export of auctions).
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-1159
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1159
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order, product
>            Reporter: Jacopo Cappellato
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: checkingForExistingParties.patch, importOrdersFromEbay10.patch, importOrdersFromEbay11.patch, importOrdersFromEbay13.patch, importOrdersFromEbay14.patch, importOrdersFromEbay15.patch, importOrdersFromEbay16.patch
>
>
> Integration with eBay (import of orders and export of auctions):
> development of a set of services and events, and some screens to manage import/export of data to/from eBay auctions API.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-1159:
----------------------------------

    Attachment: importOrdersFromEbay17.patch

This patch include new improvements about import of orders :
- Shipment method of eBay matched with the OFBiz ones.
- Now the xml document send and received from/to eBay are logged when debug verbose is on

and a lot of improvements on product export to eBay (listing creation) :
- Now is possible to choose the quantity, the starting price, the country/location where the object is located, the listing duration in days and the payment accepted from the buyer.
- In case of payment done via PayPal the PayPal e-mail of the seller is mandatory.
- At the moment the eBay category is not yet shown from eBay but there is an hard-coded value (feature not yet implemented).

Thanks in advance
Marco

> Integration with eBay (import of orders and export of auctions).
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-1159
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1159
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order, product
>            Reporter: Jacopo Cappellato
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: checkingForExistingParties.patch, importOrdersFromEbay10.patch, importOrdersFromEbay11.patch, importOrdersFromEbay13.patch, importOrdersFromEbay14.patch, importOrdersFromEbay15.patch, importOrdersFromEbay16.patch, importOrdersFromEbay17.patch
>
>
> Integration with eBay (import of orders and export of auctions):
> development of a set of services and events, and some screens to manage import/export of data to/from eBay auctions API.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515984 ]

Jacopo Cappellato commented on OFBIZ-1159:
------------------------------------------

Thanks Marco,

your patch is in rev. 560136

> Integration with eBay (import of orders and export of auctions).
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-1159
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1159
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order, product
>            Reporter: Jacopo Cappellato
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: checkingForExistingParties.patch, importOrdersFromEbay10.patch, importOrdersFromEbay11.patch, importOrdersFromEbay13.patch, importOrdersFromEbay14.patch, importOrdersFromEbay15.patch, importOrdersFromEbay16.patch, importOrdersFromEbay17.patch
>
>
> Integration with eBay (import of orders and export of auctions):
> development of a set of services and events, and some screens to manage import/export of data to/from eBay auctions API.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12516379 ]

David Shere commented on OFBIZ-1159:
------------------------------------

I'm still working on the changes you suggested, Jacopo.  I have postal address and email address done and I'm going to work on phone number.

> Integration with eBay (import of orders and export of auctions).
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-1159
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1159
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order, product
>            Reporter: Jacopo Cappellato
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: checkingForExistingParties.patch, importOrdersFromEbay10.patch, importOrdersFromEbay11.patch, importOrdersFromEbay13.patch, importOrdersFromEbay14.patch, importOrdersFromEbay15.patch, importOrdersFromEbay16.patch, importOrdersFromEbay17.patch
>
>
> Integration with eBay (import of orders and export of auctions):
> development of a set of services and events, and some screens to manage import/export of data to/from eBay auctions API.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Shere updated OFBIZ-1159:
-------------------------------

    Attachment: importOrdersFromEbay18.patch

This patch should address the suggestions you've made, Jacopo.  Let me know if it needs further work.

> Integration with eBay (import of orders and export of auctions).
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-1159
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1159
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order, product
>            Reporter: Jacopo Cappellato
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: checkingForExistingParties.patch, importOrdersFromEbay10.patch, importOrdersFromEbay11.patch, importOrdersFromEbay13.patch, importOrdersFromEbay14.patch, importOrdersFromEbay15.patch, importOrdersFromEbay16.patch, importOrdersFromEbay17.patch, importOrdersFromEbay18.patch
>
>
> Integration with eBay (import of orders and export of auctions):
> development of a set of services and events, and some screens to manage import/export of data to/from eBay auctions API.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12516922 ]

Jacopo Cappellato commented on OFBIZ-1159:
------------------------------------------

Thanks David,

your patch looks good; it is in rev. 561751

I'd say that now the main tasks for the eBay integration that would require more work are:

1) testing (test, test, test!!!)
2) creation of auctions from OFBiz: what we have implemented right now is pretty limited and it is more intended as a facility to help development... if anyone is willing to help we can better refine together what is needed here.

> Integration with eBay (import of orders and export of auctions).
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-1159
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1159
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order, product
>            Reporter: Jacopo Cappellato
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: checkingForExistingParties.patch, importOrdersFromEbay10.patch, importOrdersFromEbay11.patch, importOrdersFromEbay13.patch, importOrdersFromEbay14.patch, importOrdersFromEbay15.patch, importOrdersFromEbay16.patch, importOrdersFromEbay17.patch, importOrdersFromEbay18.patch
>
>
> Integration with eBay (import of orders and export of auctions):
> development of a set of services and events, and some screens to manage import/export of data to/from eBay auctions API.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-1159:
----------------------------------

    Attachment: importOrdersFromEbay19.patch

This patch is to retrieve the productId from the the title of the auction in case the sku is not present in the xml document.

Thanks
Marco

> Integration with eBay (import of orders and export of auctions).
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-1159
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1159
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order, product
>            Reporter: Jacopo Cappellato
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: checkingForExistingParties.patch, importOrdersFromEbay10.patch, importOrdersFromEbay11.patch, importOrdersFromEbay13.patch, importOrdersFromEbay14.patch, importOrdersFromEbay15.patch, importOrdersFromEbay16.patch, importOrdersFromEbay17.patch, importOrdersFromEbay18.patch, importOrdersFromEbay19.patch
>
>
> Integration with eBay (import of orders and export of auctions):
> development of a set of services and events, and some screens to manage import/export of data to/from eBay auctions API.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12517068 ]

Jacopo Cappellato commented on OFBIZ-1159:
------------------------------------------

thanks Marco,

rev. 561942

> Integration with eBay (import of orders and export of auctions).
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-1159
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1159
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order, product
>            Reporter: Jacopo Cappellato
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: checkingForExistingParties.patch, importOrdersFromEbay10.patch, importOrdersFromEbay11.patch, importOrdersFromEbay13.patch, importOrdersFromEbay14.patch, importOrdersFromEbay15.patch, importOrdersFromEbay16.patch, importOrdersFromEbay17.patch, importOrdersFromEbay18.patch, importOrdersFromEbay19.patch
>
>
> Integration with eBay (import of orders and export of auctions):
> development of a set of services and events, and some screens to manage import/export of data to/from eBay auctions API.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato closed OFBIZ-1159.
------------------------------------

    Resolution: Fixed

The main work is done now; specific issues and enhancements will be reported in new issues.

> Integration with eBay (import of orders and export of auctions).
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-1159
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1159
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order, product
>            Reporter: Jacopo Cappellato
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: checkingForExistingParties.patch, importOrdersFromEbay10.patch, importOrdersFromEbay11.patch, importOrdersFromEbay13.patch, importOrdersFromEbay14.patch, importOrdersFromEbay15.patch, importOrdersFromEbay16.patch, importOrdersFromEbay17.patch, importOrdersFromEbay18.patch, importOrdersFromEbay19.patch
>
>
> Integration with eBay (import of orders and export of auctions):
> development of a set of services and events, and some screens to manage import/export of data to/from eBay auctions API.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.