[jira] Created: (OFBIZ-1163) Bad UiLabel encoding causes bug in form widget

[Nicolas Malin (Jira)]

Bad UiLabel encoding causes bug in form widget
----------------------------------------------

                 Key: OFBIZ-1163
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1163
             Project: OFBiz
          Issue Type: Bug
          Components: framework
            Reporter: Valentina Sirkova
            Priority: Minor


Hi,

In CommonUiLabels.properties CommonEmptyHeader label is set to be white space but maybe its unicode equivalent should be used(CommonEmptyHeader=\u0020) as this particular label is not treated as white space.
 
For example if you view some fixed asset`s calendar (accounting/fixedassets/calendar)you would notice its columns are not displayed correctly. This is because the form listFixedAssetCalendar has fields whose titles are uiLabelMap.CommonEmptyHeader (which is supposed to be white space) but the method renderHeaderRow (ModelForm.java) does not generate headers for them because this condition from it evaluates to true wrongly:
if ("".equals(modelFormFieldTitle)) {
                    continue;
}

Valentina

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato closed OFBIZ-1163.
------------------------------------

    Resolution: Fixed

Thanks Valentina: I've used the unicode format in rev. 557911

> Bad UiLabel encoding causes bug in form widget
> ----------------------------------------------
>
>                 Key: OFBIZ-1163
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1163
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Valentina Sirkova
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>
> Hi,
> In CommonUiLabels.properties CommonEmptyHeader label is set to be white space but maybe its unicode equivalent should be used(CommonEmptyHeader=\u0020) as this particular label is not treated as white space.
>  
> For example if you view some fixed asset`s calendar (accounting/fixedassets/calendar)you would notice its columns are not displayed correctly. This is because the form listFixedAssetCalendar has fields whose titles are uiLabelMap.CommonEmptyHeader (which is supposed to be white space) but the method renderHeaderRow (ModelForm.java) does not generate headers for them because this condition from it evaluates to true wrongly:
> if ("".equals(modelFormFieldTitle)) {
>                     continue;
> }
> Valentina

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato reassigned OFBIZ-1163:
----------------------------------------

    Assignee: Jacopo Cappellato

> Bad UiLabel encoding causes bug in form widget
> ----------------------------------------------
>
>                 Key: OFBIZ-1163
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1163
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Valentina Sirkova
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>
> Hi,
> In CommonUiLabels.properties CommonEmptyHeader label is set to be white space but maybe its unicode equivalent should be used(CommonEmptyHeader=\u0020) as this particular label is not treated as white space.
>  
> For example if you view some fixed asset`s calendar (accounting/fixedassets/calendar)you would notice its columns are not displayed correctly. This is because the form listFixedAssetCalendar has fields whose titles are uiLabelMap.CommonEmptyHeader (which is supposed to be white space) but the method renderHeaderRow (ModelForm.java) does not generate headers for them because this condition from it evaluates to true wrongly:
> if ("".equals(modelFormFieldTitle)) {
>                     continue;
> }
> Valentina

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.