[jira] Created: (OFBIZ-1164) Improved Time Zone Support, Part 2

[Nicolas Malin (Jira)]

Improved Time Zone Support, Part 2
----------------------------------

                 Key: OFBIZ-1164
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1164
             Project: OFBiz
          Issue Type: Improvement
          Components: framework
            Reporter: Adrian Crum
            Priority: Minor


Modify framework code to support user-selected time zones.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1164:
-------------------------------

    Attachment: framework_tz.patch

framework_tz.patch contains a few modifications that demonstrate some of the work that needs to be done.

The attached patch enables the form widget to render date/time fields in the user's time zone.

More work needs to be done before this can be committed.

> Improved Time Zone Support, Part 2
> ----------------------------------
>
>                 Key: OFBIZ-1164
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1164
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: framework_tz.patch
>
>
> Modify framework code to support user-selected time zones.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514057 ]

Adrian Crum commented on OFBIZ-1164:
------------------------------------

I tried to insert the user-selected time zone support into the service engine, but I ended up chasing down a lot of bunny trails and I finally gave up.

This is where I could really use some help from the OFBiz gurus. Basically, the service engine needs to convert date/times correctly to/from Strings. The code in this patch can be copied into other areas of the project.

> Improved Time Zone Support, Part 2
> ----------------------------------
>
>                 Key: OFBIZ-1164
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1164
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: framework_tz.patch
>
>
> Modify framework code to support user-selected time zones.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1164:
-------------------------------

    Attachment: framework_tz.patch

Improved patch. I've made progress in the service engine. I still have one problem that I need help with though...

The following screen widget code still renders a Timestamp in the server's time zone:

<label text="${uiLabelMap.WorkEffortEstimatedStartDate}: " style="tableheadtext"/><label text="${workEffort.estimatedStartDate}" style="tabletext"/>

I modified FlexibleStringExpander to fix it, but it still isn't working. If anyone could take a look at it I would appreciate it!

I haven't tested service ECAs and entity ECAs.

> Improved Time Zone Support, Part 2
> ----------------------------------
>
>                 Key: OFBIZ-1164
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1164
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: framework_tz.patch, framework_tz.patch
>
>
> Modify framework code to support user-selected time zones.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1164:
-------------------------------

    Attachment: framework_tz.patch

Improved patch. Freemarker templates are now set up to use the user's time zone. Individual templates can override the user's time zone with the <#setting time_zone...> directive.

> Improved Time Zone Support, Part 2
> ----------------------------------
>
>                 Key: OFBIZ-1164
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1164
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: framework_tz.patch, framework_tz.patch, framework_tz.patch
>
>
> Modify framework code to support user-selected time zones.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1164:
-------------------------------

    Attachment: framework_tz.patch

Improved patch fixes a bug in the Freemarker template caching algorithm.

> Improved Time Zone Support, Part 2
> ----------------------------------
>
>                 Key: OFBIZ-1164
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1164
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: framework_tz.patch, framework_tz.patch, framework_tz.patch, framework_tz.patch
>
>
> Modify framework code to support user-selected time zones.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1164:
-------------------------------

    Attachment: framework_tz.patch

Updated patch includes improved FreeMarkerWorker.java file from OFBIZ-1170.

> Improved Time Zone Support, Part 2
> ----------------------------------
>
>                 Key: OFBIZ-1164
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1164
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: framework_tz.patch, framework_tz.patch, framework_tz.patch, framework_tz.patch, framework_tz.patch
>
>
> Modify framework code to support user-selected time zones.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12518968 ]

Jacques Le Roux commented on OFBIZ-1164:
----------------------------------------

I put a link to OFBIZ-1170, to remember about uncomment time zone support in FreeMarkerWorker.java :

/* uncomment code block when framework time zone support is implemented

> Improved Time Zone Support, Part 2
> ----------------------------------
>
>                 Key: OFBIZ-1164
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1164
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: framework_tz.patch, framework_tz.patch, framework_tz.patch, framework_tz.patch, framework_tz.patch
>
>
> Modify framework code to support user-selected time zones.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-1164:
--------------------------------------

    Assignee: Jacques Le Roux

> Improved Time Zone Support, Part 2
> ----------------------------------
>
>                 Key: OFBIZ-1164
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1164
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: framework_tz.patch, framework_tz.patch, framework_tz.patch, framework_tz.patch, framework_tz.patch
>
>
> Modify framework code to support user-selected time zones.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12518971 ]

Jacques Le Roux commented on OFBIZ-1164:
----------------------------------------

Adrian,

Do you think we are ready to test and hopefully commit this patch ?

> Improved Time Zone Support, Part 2
> ----------------------------------
>
>                 Key: OFBIZ-1164
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1164
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: framework_tz.patch, framework_tz.patch, framework_tz.patch, framework_tz.patch, framework_tz.patch
>
>
> Modify framework code to support user-selected time zones.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519024 ]

Adrian Crum commented on OFBIZ-1164:
------------------------------------

Jacques,

There is still work that needs to be done. See my comment above and the dev ml email I sent:

http://mail-archives.apache.org/mod_mbox/ofbiz-dev/200708.mbox/%3c46B0A897.3090301@...%3e

> Improved Time Zone Support, Part 2
> ----------------------------------
>
>                 Key: OFBIZ-1164
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1164
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: framework_tz.patch, framework_tz.patch, framework_tz.patch, framework_tz.patch, framework_tz.patch
>
>
> Modify framework code to support user-selected time zones.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1164:
-------------------------------

    Attachment: framework_tz.patch

Patch updated to latest svn.

> Improved Time Zone Support, Part 2
> ----------------------------------
>
>                 Key: OFBIZ-1164
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1164
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: framework_tz.patch, framework_tz.patch, framework_tz.patch, framework_tz.patch, framework_tz.patch, framework_tz.patch
>
>
> Modify framework code to support user-selected time zones.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519052 ]

Adrian Crum commented on OFBIZ-1164:
------------------------------------

Some more thoughts on committing this...

When it is committed, the majority of OFBiz will support user-selected time zones. I'm sure there will be bits and pieces of OFBiz that will still default to the server's time zone. I don't have any examples, but the potential is there if a particular code fragment attempts to do its own date/time conversions.

Originally, I had pictured developers applying this patch to their local copies and playing around with components that interest them. The areas that don't convert well could be fixed and contributed back as additional Jira issues (OFBIZ-1089 is an example). Once we're sure most of the exceptions have been caught, we could then commit this patch along with the patches in the additional Jira issues.

On the other hand, we could just commit this patch and let developers fix the exceptions as they come across them.

The popup calendar is a potential issue. The current implementation uses JavaScript - so the popup calendar will default to the user's time zone. That's fine for most cases. It gets confusing when the user sets OFBiz to use a time zone other than their own. Hopefully we'll have an updated popup calendar soon. Hey... where did Daniel Martinez go anyway? :p

> Improved Time Zone Support, Part 2
> ----------------------------------
>
>                 Key: OFBIZ-1164
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1164
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: framework_tz.patch, framework_tz.patch, framework_tz.patch, framework_tz.patch, framework_tz.patch, framework_tz.patch
>
>
> Modify framework code to support user-selected time zones.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519259 ]

Jacques Le Roux commented on OFBIZ-1164:
----------------------------------------

Thanks for the link Adrian,

I have reviewed and applied this patch without problems. I have tested it using OFBIZ-1089. So I will apply it right now and, as you suggested, let people fix problems they cross. Hopefully, Daniel Martinez is on holidays and will bring us back a new brand calendar :o)

> Improved Time Zone Support, Part 2
> ----------------------------------
>
>                 Key: OFBIZ-1164
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1164
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: framework_tz.patch, framework_tz.patch, framework_tz.patch, framework_tz.patch, framework_tz.patch, framework_tz.patch
>
>
> Modify framework code to support user-selected time zones.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1164.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk

Adrian,

Your patch is in trunk rev. 564957  

> Improved Time Zone Support, Part 2
> ----------------------------------
>
>                 Key: OFBIZ-1164
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1164
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: framework_tz.patch, framework_tz.patch, framework_tz.patch, framework_tz.patch, framework_tz.patch, framework_tz.patch
>
>
> Modify framework code to support user-selected time zones.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.