[jira] Created: (OFBIZ-1176) POS order status error

[Nicolas Malin (Jira)]

POS order status error
----------------------

                 Key: OFBIZ-1176
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1176
             Project: OFBiz
          Issue Type: Bug
          Components: pos
    Affects Versions: SVN trunk
            Reporter: Bilgin Ibryam
             Fix For: SVN trunk


Hi all,
this is a bug discuss here http://www.nabble.com/POS-order-status-change-error-tf4192871.html#a11923722
I tracked it down and found the reason for it.
When an sale is done on POS and paid with CASH,  the created entity OrderPaymentPreference->manualRefNum field in null. Then in CheckOuthelper.java:873 our OrderPaymentPreference is filtered and the order is not approved in CheckOuthelper.java:896 .Later it cannot be completed and we get ERROR :
> Could not change order status ; status is not a valid change.
I changed in POS the CASH payment method, so now it does like CHECK payment method and puts a "N/A" in manualRefNum field and everything works fine.
I am not sure that this the rightest way to fix it, because i am not sure whats the purpose of manualRefNum field in OrderPaymentPreference entity.
May be someone can tell me ? There are some comments in the code but does it mean that if manualRefNum field is null we are not approving the order automatically ?Why ? In which case it should be not null ?
       
        CheckOuthelper.java:873
        // check for online payment methods or in-hand payment types with verbal or external refs
        List exprs = UtilMisc.toList(new EntityExpr("manualRefNum", EntityOperator.NOT_EQUAL, null));

Regards,
Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam updated OFBIZ-1176:
---------------------------------

    Attachment: pos.patch

the patch

> POS order status error
> ----------------------
>
>                 Key: OFBIZ-1176
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1176
>             Project: OFBiz
>          Issue Type: Bug
>          Components: pos
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>             Fix For: SVN trunk
>
>         Attachments: pos.patch
>
>
> Hi all,
> this is a bug discuss here http://www.nabble.com/POS-order-status-change-error-tf4192871.html#a11923722
> I tracked it down and found the reason for it.
> When an sale is done on POS and paid with CASH,  the created entity OrderPaymentPreference->manualRefNum field in null. Then in CheckOuthelper.java:873 our OrderPaymentPreference is filtered and the order is not approved in CheckOuthelper.java:896 .Later it cannot be completed and we get ERROR :
> > Could not change order status ; status is not a valid change.
> I changed in POS the CASH payment method, so now it does like CHECK payment method and puts a "N/A" in manualRefNum field and everything works fine.
> I am not sure that this the rightest way to fix it, because i am not sure whats the purpose of manualRefNum field in OrderPaymentPreference entity.
> May be someone can tell me ? There are some comments in the code but does it mean that if manualRefNum field is null we are not approving the order automatically ?Why ? In which case it should be not null ?
>        
>         CheckOuthelper.java:873
>         // check for online payment methods or in-hand payment types with verbal or external refs
>         List exprs = UtilMisc.toList(new EntityExpr("manualRefNum", EntityOperator.NOT_EQUAL, null));
> Regards,
> Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-1176:
--------------------------------------

    Assignee: Jacques Le Roux

> POS order status error
> ----------------------
>
>                 Key: OFBIZ-1176
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1176
>             Project: OFBiz
>          Issue Type: Bug
>          Components: pos
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: pos.patch
>
>
> Hi all,
> this is a bug discuss here http://www.nabble.com/POS-order-status-change-error-tf4192871.html#a11923722
> I tracked it down and found the reason for it.
> When an sale is done on POS and paid with CASH,  the created entity OrderPaymentPreference->manualRefNum field in null. Then in CheckOuthelper.java:873 our OrderPaymentPreference is filtered and the order is not approved in CheckOuthelper.java:896 .Later it cannot be completed and we get ERROR :
> > Could not change order status ; status is not a valid change.
> I changed in POS the CASH payment method, so now it does like CHECK payment method and puts a "N/A" in manualRefNum field and everything works fine.
> I am not sure that this the rightest way to fix it, because i am not sure whats the purpose of manualRefNum field in OrderPaymentPreference entity.
> May be someone can tell me ? There are some comments in the code but does it mean that if manualRefNum field is null we are not approving the order automatically ?Why ? In which case it should be not null ?
>        
>         CheckOuthelper.java:873
>         // check for online payment methods or in-hand payment types with verbal or external refs
>         List exprs = UtilMisc.toList(new EntityExpr("manualRefNum", EntityOperator.NOT_EQUAL, null));
> Regards,
> Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1176.
----------------------------------

       Resolution: Fixed
    Fix Version/s: Release Branch 4.0

Thanks Bilgin,

Your patch is in trunk. rev. 562693, release4.0 rev. 562694

manualRefNum is used when an external payment (without service asociated) is set for a payment method type (from UI "Payments" in "Store"). Then the user is asked to enter manually a refNum. I can't see any reasons to add a refNum to a cash payment since there are alreday enough pointers to retrieve informations if needed (OrderId, PaymentId, InvoiveId, etc.) so "N/A" is just fine for now.

> POS order status error
> ----------------------
>
>                 Key: OFBIZ-1176
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1176
>             Project: OFBiz
>          Issue Type: Bug
>          Components: pos
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: pos.patch
>
>
> Hi all,
> this is a bug discuss here http://www.nabble.com/POS-order-status-change-error-tf4192871.html#a11923722
> I tracked it down and found the reason for it.
> When an sale is done on POS and paid with CASH,  the created entity OrderPaymentPreference->manualRefNum field in null. Then in CheckOuthelper.java:873 our OrderPaymentPreference is filtered and the order is not approved in CheckOuthelper.java:896 .Later it cannot be completed and we get ERROR :
> > Could not change order status ; status is not a valid change.
> I changed in POS the CASH payment method, so now it does like CHECK payment method and puts a "N/A" in manualRefNum field and everything works fine.
> I am not sure that this the rightest way to fix it, because i am not sure whats the purpose of manualRefNum field in OrderPaymentPreference entity.
> May be someone can tell me ? There are some comments in the code but does it mean that if manualRefNum field is null we are not approving the order automatically ?Why ? In which case it should be not null ?
>        
>         CheckOuthelper.java:873
>         // check for online payment methods or in-hand payment types with verbal or external refs
>         List exprs = UtilMisc.toList(new EntityExpr("manualRefNum", EntityOperator.NOT_EQUAL, null));
> Regards,
> Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.