[jira] Created: (OFBIZ-1180) Quote WorkEffort bug

[Nicolas Malin (Jira)]

Quote WorkEffort bug
--------------------

                 Key: OFBIZ-1180
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1180
             Project: OFBiz
          Issue Type: Bug
          Components: order
    Affects Versions: SVN trunk
            Reporter: Bilgin Ibryam
             Fix For: SVN trunk
         Attachments: quote_work_effort.patch

Adding WorkEfforts to quotes is broken. The reason is that the form "AddQuoteWorkEffort"  extends="EditWorkEffort".
So even its target="createQuoteWorkEffort" it uses  <alt-target target="createWorkEffort" use-when="workEffort==null"/> from the original form. I tried to use another alt-target but the form always use the original alt-target to createWorkEffort".  Any idea how to override this alt-target ?
For now i replaced  in the controller the request from createQuoteWorkEffort to createWorkEffort.
Another bug is in the ECA rule, the field name is misspelled. So right now everything works.

Regards,
Bilgin Ibyram

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam updated OFBIZ-1180:
---------------------------------

    Attachment: quote_work_effort.patch

the patch

> Quote WorkEffort bug
> --------------------
>
>                 Key: OFBIZ-1180
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1180
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>             Fix For: SVN trunk
>
>         Attachments: quote_work_effort.patch
>
>
> Adding WorkEfforts to quotes is broken. The reason is that the form "AddQuoteWorkEffort"  extends="EditWorkEffort".
> So even its target="createQuoteWorkEffort" it uses  <alt-target target="createWorkEffort" use-when="workEffort==null"/> from the original form. I tried to use another alt-target but the form always use the original alt-target to createWorkEffort".  Any idea how to override this alt-target ?
> For now i replaced  in the controller the request from createQuoteWorkEffort to createWorkEffort.
> Another bug is in the ECA rule, the field name is misspelled. So right now everything works.
> Regards,
> Bilgin Ibyram

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato reassigned OFBIZ-1180:
----------------------------------------

    Assignee: Jacopo Cappellato

> Quote WorkEffort bug
> --------------------
>
>                 Key: OFBIZ-1180
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1180
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Assignee: Jacopo Cappellato
>             Fix For: SVN trunk
>
>         Attachments: quote_work_effort.patch
>
>
> Adding WorkEfforts to quotes is broken. The reason is that the form "AddQuoteWorkEffort"  extends="EditWorkEffort".
> So even its target="createQuoteWorkEffort" it uses  <alt-target target="createWorkEffort" use-when="workEffort==null"/> from the original form. I tried to use another alt-target but the form always use the original alt-target to createWorkEffort".  Any idea how to override this alt-target ?
> For now i replaced  in the controller the request from createQuoteWorkEffort to createWorkEffort.
> Another bug is in the ECA rule, the field name is misspelled. So right now everything works.
> Regards,
> Bilgin Ibyram

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519318 ]

Jacques Le Roux commented on OFBIZ-1180:
----------------------------------------

Thanks Bilgin,

I agree that your patche fix the problem. I commited the seca part of your patch in trunk 565083 and release 565084

I'm currently working on a solution more general than the one you proposed but your patch might be applied temporarily if needed.

I want to add a target-type tag to the alt-target tag. But it's not as easy as I thought because alt-target is a list. I wonder also if I should have worked this on the other side of extends : keeping the target of the calling forms. I chose this way because it seemed more general to me.

> Quote WorkEffort bug
> --------------------
>
>                 Key: OFBIZ-1180
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1180
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Assignee: Jacopo Cappellato
>             Fix For: SVN trunk
>
>         Attachments: quote_work_effort.patch
>
>
> Adding WorkEfforts to quotes is broken. The reason is that the form "AddQuoteWorkEffort"  extends="EditWorkEffort".
> So even its target="createQuoteWorkEffort" it uses  <alt-target target="createWorkEffort" use-when="workEffort==null"/> from the original form. I tried to use another alt-target but the form always use the original alt-target to createWorkEffort".  Any idea how to override this alt-target ?
> For now i replaced  in the controller the request from createQuoteWorkEffort to createWorkEffort.
> Another bug is in the ECA rule, the field name is misspelled. So right now everything works.
> Regards,
> Bilgin Ibyram

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-1180:
--------------------------------------

    Assignee: Jacques Le Roux  (was: Jacopo Cappellato)

> Quote WorkEffort bug
> --------------------
>
>                 Key: OFBIZ-1180
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1180
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: quote_work_effort.patch
>
>
> Adding WorkEfforts to quotes is broken. The reason is that the form "AddQuoteWorkEffort"  extends="EditWorkEffort".
> So even its target="createQuoteWorkEffort" it uses  <alt-target target="createWorkEffort" use-when="workEffort==null"/> from the original form. I tried to use another alt-target but the form always use the original alt-target to createWorkEffort".  Any idea how to override this alt-target ?
> For now i replaced  in the controller the request from createQuoteWorkEffort to createWorkEffort.
> Another bug is in the ECA rule, the field name is misspelled. So right now everything works.
> Regards,
> Bilgin Ibyram

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524674 ]

Bilgin Ibryam commented on OFBIZ-1180:
--------------------------------------

Adding WorkEffort to Communications in party manager is also broken due to extending EditWorkEffort.
I just wanted to record it here.

> Quote WorkEffort bug
> --------------------
>
>                 Key: OFBIZ-1180
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1180
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: quote_work_effort.patch
>
>
> Adding WorkEfforts to quotes is broken. The reason is that the form "AddQuoteWorkEffort"  extends="EditWorkEffort".
> So even its target="createQuoteWorkEffort" it uses  <alt-target target="createWorkEffort" use-when="workEffort==null"/> from the original form. I tried to use another alt-target but the form always use the original alt-target to createWorkEffort".  Any idea how to override this alt-target ?
> For now i replaced  in the controller the request from createQuoteWorkEffort to createWorkEffort.
> Another bug is in the ECA rule, the field name is misspelled. So right now everything works.
> Regards,
> Bilgin Ibyram

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1180.
----------------------------------

    Resolution: Fixed

This is fixed in a more general way in trunk revision: 582338 . I close laready and I wait a bit before back porting to release4.0.

It does not solve the issue reported in comment https://issues.apache.org/jira/browse/OFBIZ-1180#action_12524674 "Adding WorkEffort to Communications in party manager is also broken due to extending EditWorkEffort." because then we get java.lang.IllegalArgumentException: Could not find screen with name [EditCommEventWorkEffort] in class resource [component://party/widget/partymgr/CommunicationScreens.xml]. But this is another problem : no EditCommEventWorkEffort screen is declared in CommunicationScreens.xml ! I create a new issue for that...

> Quote WorkEffort bug
> --------------------
>
>                 Key: OFBIZ-1180
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1180
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: quote_work_effort.patch
>
>
> Adding WorkEfforts to quotes is broken. The reason is that the form "AddQuoteWorkEffort"  extends="EditWorkEffort".
> So even its target="createQuoteWorkEffort" it uses  <alt-target target="createWorkEffort" use-when="workEffort==null"/> from the original form. I tried to use another alt-target but the form always use the original alt-target to createWorkEffort".  Any idea how to override this alt-target ?
> For now i replaced  in the controller the request from createQuoteWorkEffort to createWorkEffort.
> Another bug is in the ECA rule, the field name is misspelled. So right now everything works.
> Regards,
> Bilgin Ibyram

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12553951 ]

Jacques Le Roux commented on OFBIZ-1180:
----------------------------------------

I just tried to merge rev. 582338 in release4.0 but was unable to commit for unknown reason, I got this

D:\workspace\ofbizRelease4.0>echo off
version to merge :582338

D:\workspace\ofbizRelease4.0>svn merge -r 582337:582338 https://svn.apache.org/repos/asf/ofbiz/trunk
U    framework\widget\src\org\ofbiz\widget\form\ModelForm.java
U    framework\widget\src\org\ofbiz\widget\html\HtmlFormRenderer.java
U    framework\widget\dtd\widget-form.xsd

D:\workspace\ofbizRelease4.0>svn commit -m "Applied fix from trunk for revision: 582338"

I gived up after 2 tries...

> Quote WorkEffort bug
> --------------------
>
>                 Key: OFBIZ-1180
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1180
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: quote_work_effort.patch
>
>
> Adding WorkEfforts to quotes is broken. The reason is that the form "AddQuoteWorkEffort"  extends="EditWorkEffort".
> So even its target="createQuoteWorkEffort" it uses  <alt-target target="createWorkEffort" use-when="workEffort==null"/> from the original form. I tried to use another alt-target but the form always use the original alt-target to createWorkEffort".  Any idea how to override this alt-target ?
> For now i replaced  in the controller the request from createQuoteWorkEffort to createWorkEffort.
> Another bug is in the ECA rule, the field name is misspelled. So right now everything works.
> Regards,
> Bilgin Ibyram

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.