[jira] Created: (OFBIZ-1199) makeLoginUrl doesn't URL encode the strings

[Nicolas Malin (Jira)]

makeLoginUrl doesn't URL encode the strings
-------------------------------------------

                 Key: OFBIZ-1199
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1199
             Project: OFBiz
          Issue Type: Bug
          Components: framework
    Affects Versions: SVN trunk, Release Branch 4.0
            Reporter: Wickersheimer Jeremy
            Priority: Minor


The makeLoginUrl method in LoginWorker simply appends all parameters names and values to make an URL string, without using URLEncode.
This will make broken URLs when specials characters or Unicode characters are present.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wickersheimer Jeremy updated OFBIZ-1199:
----------------------------------------

    Attachment: ofbiz-1199.patch

> makeLoginUrl doesn't URL encode the strings
> -------------------------------------------
>
>                 Key: OFBIZ-1199
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1199
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Wickersheimer Jeremy
>            Priority: Minor
>         Attachments: ofbiz-1199.patch
>
>
> The makeLoginUrl method in LoginWorker simply appends all parameters names and values to make an URL string, without using URLEncode.
> This will make broken URLs when specials characters or Unicode characters are present.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545956 ]

Si Chen commented on OFBIZ-1199:
--------------------------------

If there are no objections I will be committing this patch.

> makeLoginUrl doesn't URL encode the strings
> -------------------------------------------
>
>                 Key: OFBIZ-1199
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1199
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Wickersheimer Jeremy
>            Assignee: Si Chen
>            Priority: Minor
>         Attachments: ofbiz-1199.patch
>
>
> The makeLoginUrl method in LoginWorker simply appends all parameters names and values to make an URL string, without using URLEncode.
> This will make broken URLs when specials characters or Unicode characters are present.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Si Chen reassigned OFBIZ-1199:
------------------------------

    Assignee: Si Chen

> makeLoginUrl doesn't URL encode the strings
> -------------------------------------------
>
>                 Key: OFBIZ-1199
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1199
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Wickersheimer Jeremy
>            Assignee: Si Chen
>            Priority: Minor
>         Attachments: ofbiz-1199.patch
>
>
> The makeLoginUrl method in LoginWorker simply appends all parameters names and values to make an URL string, without using URLEncode.
> This will make broken URLs when specials characters or Unicode characters are present.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12546013 ]

BJ Freeman commented on OFBIZ-1199:
-----------------------------------

si I would like to review it and then maybe add a request to a mod
this has to do with the bug of login in when there is a large amount of parameters when causes the login to fail.
would like to see if this patch will solve that  or more needs to be done.

> makeLoginUrl doesn't URL encode the strings
> -------------------------------------------
>
>                 Key: OFBIZ-1199
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1199
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Wickersheimer Jeremy
>            Assignee: Si Chen
>            Priority: Minor
>         Attachments: ofbiz-1199.patch
>
>
> The makeLoginUrl method in LoginWorker simply appends all parameters names and values to make an URL string, without using URLEncode.
> This will make broken URLs when specials characters or Unicode characters are present.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12547323 ]

Si Chen commented on OFBIZ-1199:
--------------------------------

Well, BJ, do you have any suggestions?

> makeLoginUrl doesn't URL encode the strings
> -------------------------------------------
>
>                 Key: OFBIZ-1199
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1199
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Wickersheimer Jeremy
>            Assignee: Si Chen
>            Priority: Minor
>         Attachments: ofbiz-1199.patch
>
>
> The makeLoginUrl method in LoginWorker simply appends all parameters names and values to make an URL string, without using URLEncode.
> This will make broken URLs when specials characters or Unicode characters are present.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12547382 ]

BJ Freeman commented on OFBIZ-1199:
-----------------------------------

guess my concerns would be best addressed in the orginal Jira
sorry to delay you.

> makeLoginUrl doesn't URL encode the strings
> -------------------------------------------
>
>                 Key: OFBIZ-1199
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1199
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Wickersheimer Jeremy
>            Assignee: Si Chen
>            Priority: Minor
>         Attachments: ofbiz-1199.patch
>
>
> The makeLoginUrl method in LoginWorker simply appends all parameters names and values to make an URL string, without using URLEncode.
> This will make broken URLs when specials characters or Unicode characters are present.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1199.
----------------------------------

       Resolution: Fixed
    Fix Version/s: Release Branch 4.0
                   SVN trunk
         Assignee: Jacques Le Roux  (was: Si Chen)

Thanks Jeremy,

Commited in trunk revision: 600278; release4.0 600279

> makeLoginUrl doesn't URL encode the strings
> -------------------------------------------
>
>                 Key: OFBIZ-1199
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1199
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Wickersheimer Jeremy
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: ofbiz-1199.patch
>
>
> The makeLoginUrl method in LoginWorker simply appends all parameters names and values to make an URL string, without using URLEncode.
> This will make broken URLs when specials characters or Unicode characters are present.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.